- 26 Mar, 2020 37 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a7510f0675df..b69c4e14c5e2 git log a7510f0675df..b69c4e14c5e2 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 cnorthrop@google.com Capture/Replay: Update CaptureReplay sample for compression 2020-03-25 cnorthrop@google.com Perf: Add a single Manhattan trace Created with: gclient setdep -r src/third_party/angle@b69c4e14c5e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I7524d3c01d111f0e6733a649c7b305087f3d0c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753476}
-
Theresa Wellington authored
Add a suite of tests verifying Android NMR1+ launcher shorcut behavior. BUG=632541 Change-Id: I4603610989fe145bbe410ad51c0900036bcb468d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121083 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753475}
-
Lei Zhang authored
Verify the PDF plugin can successfully report metrics. Currently, the plugin reports metrics using the PPAPI interface, but that will change in the future. Make sure metrics continue to work, and help prevent issues like https://crbug.com/1043019 from happening. Change-Id: I0306247a320040231b8f47a4981a45fcff689ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119204 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#753474}
-
dpapad authored
Bug: 1026426 Change-Id: I35b0fd47a1662d600779a904a18f99f163087c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119583 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#753473}
-
Daniel Hosseinian authored
crrev.com/752905 moved the definition of PrinterStatus out of cups_jobs.h, and named the new file with the assumption that it will only be built on ChromeOS. Given that CUPS IPP will be supported on macOS in the near future, this naming was not appropriate. Do the same thing with PrinterQueryResult. Bug: 226176 Change-Id: I54e99b63f40221a832ab95196c8c9c14ba7f2011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121081 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753472}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ba92999..e1d6f39d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d150dcc479b41f86d8eefd5f6e4450c96d09755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121277Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753471}
-
David Tseng authored
General strategy: - perform all actions (sm_.Call) - gather pending utterances - mix in Expect* calls between all Call actions (incrementally from the top) - keep the tests mostly simple (limit UI interactions) to prevent flakes - do use the async SpeechMonitor api which should be less flakey - deleted one test who's behavior is still in flux (empty panel menu behavior) Some tests were still failing but due to external factors. Comments left. Change-Id: I7689880dbeeac3b31fe22a8029fae5078d975f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119382 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#753470}
-
Noel Gordon authored
Block hover rules for inactive toolbar <cr-button>. Add focus rings to these toolbar <cr-button> only if the keyboard is active. And add TODO note about these rules applying in files-ng and not. Bug: 1062902, 992824 Change-Id: Ib4d670abc38aca455d03c4c01c1017bfec666937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120553Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753469}
-
Danan S authored
This refactor was motivated by revert 71f516df. Background: There was an ASAN error that occurred in certain test cases where the ParentPermissionDialog was deleted from beneath itself before it was able to set its dialog_closed_callback_ member, causing a use-after-free. The use-after-free was caused by the way this feature was originally implemented: 2 objects with distinct lifetimes separately managing the view and workflow of the ParentPermissionDialog. The 2 objects spanned sections of the codebase (ui and views) which have dependency restrictions that made it very challenging to coordinate the lifetime of objects across them. Furthermore, the flows in this code are full of asynchronous sections that necessitated an extra callback-based message passing interface between the 2 objects. This CL consolidates all the existing to a single object: ParentPermissionDialogView, thereby removing most of the aforementioned dependency and object lifetime management complexity. The API for creating the dialog remains in parent_permission_dialog.h, however it is now in a much simplified form, consisting of a simple control interface and Show() functions. Original change's description: > Revert "Changes to Webstore Private API to support child extension installation" > > This reverts commit 99ffda8e. > > Reason for revert: browser_tests failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37129 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18174 > > Original change's description: > > Changes to Webstore Private API to support child extension installation > > > > These changes are required in order to prompt a child user to get > > parent permission when they attempt to install an extension in the > > Chrome Webstore. > > > > This CL also enables the feature by default. > > > > Bug: 957832 > > Change-Id: I3a2011b418e31dd491fd35e37d976b492eef197b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079620 > > Commit-Queue: Dan S <danan@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#749436} > > TBR=karandeepb@chromium.org,danan@chromium.org > > Change-Id: If262ccd3dad279dc60e849f9780e340b18d7384c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 957832 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100891 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749726} Change-Id: Ia217f68502a6fe8719614b1322af74aeb02f3319 No-Presubmit: false No-Tree-Checks: false No-Try: false Bug: 957832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100548 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753468}
-
Maria Villarreal authored
Per guidance, this changes the color used in message_view to kColorId_UnfocusedBorderColor. Bug: 1056950 Change-Id: Ibe265a94c5552e01f7d5cbd330e42a940854f164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117291Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753467}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6f84edeb857..8351d2182b54 git log d6f84edeb857..8351d2182b54 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 crouleau@chromium.org [Catapult] Remove myself from OWNERS. Created with: gclient setdep -r src/third_party/catapult@8351d2182b54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1059913 Tbr: skyostil@google.com Change-Id: Ib8a956bcc35b324182c146e736ad3b6c6605ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753466}
-
Anatoliy Potapchuk authored
This part of Web kiosk launch was lacking test coverage. Now it does not. Also, we add window name to the created window so it does not fail on DCHECKS. Bug: 1046364 Change-Id: I569ad66061515bd18fef38e7e150a2c21be0ef3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116081Reviewed-by:
Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753465}
-
Zain Afzal authored
At the moment media-app receives a file list with only 1 item in it. This CL updates the launch code to send over all files in the current directory if the app was launched via the files app. This is part of a larger set of CLs to expose more directory methods and data to the guest frame. Bug: 996088 Change-Id: I485bbe143fcc953c8cd189ded30d0cf23f337fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108453Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#753464}
-
Gyuyoung Kim authored
This CL moves auto-height-column-with-border-and-padding.html test from css/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs and a ref test link. Bug: 1063749 Change-Id: I6751269ba56911615f236d57216e792b64410cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117555Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#753463}
-
Yoichi Osato authored
First, I broke the calculation by change initialization order: https://chromium-review.googlesource.com/c/chromium/src/+/1948393 That caused apparent memory improvement. Then another my CL fixed the order: https://chromium-review.googlesource.com/c/chromium/src/+/2099668 Now bots computes memory size appropriately as same as before. This CL adds a test so that no such false regression. Bug: 1062837 Change-Id: If76707cae97f0037664facd901bfea45241c66f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114479Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#753462}
-
Andrew Xu authored
Bug: 1058135 Change-Id: Id07d08176af1d0ca8641e651e19f0d0dc389045b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118225Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753461}
-
Jing Wang authored
Also fix some typo along the way. Bug: 1042084 Test: tested with Linux emulator Change-Id: I87b3d8afbdcfa1c87e8bd2a8b9521e50c55b7c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116160 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#753460}
-
Jesse Mohrland authored
If a user clicks into the omnibox and types before mouse-up, the characters typed before mouse-up can get deleted by subsequent chars due to the select-all behavior upon mouse-up. This detects the mouse-down state while typing and immediately executes select-all so existing characters are removed but none after mouse-down. Bug: 1063161 Change-Id: I3c31d19ce9a7efe129bf95729935634280ee6a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112758Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Jesse Mohrland <jessem@microsoft.com> Auto-Submit: Jesse Mohrland <jessem@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753459}
-
David Maunder authored
NonCriticalPersistedTabData. NonCriticalPersistedTabData is for metadata to build new features where the data needs to be persisted across restarts. However, the metadata is not pertinent to the running of the app as CriticalPersistedTabData (tab id, web contents etc.) is. Bug: 1048712 Change-Id: Ibcaa202322746d69065546fc3f7ea1d66b443ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036656Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#753458}
-
Gyuyoung Kim authored
This CL moves flex-column-relayout-assert.html test from css/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, a description of this test, and a title. Bug: 1063749 Change-Id: Ic68aa0b7f4b254ce10f178897a23f0b6171dd788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119460Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#753457}
-
Gabriel Charette authored
This is a prequisite for more additions to ScopedBlockingCall's internal namespace for the IO jank metric. It was getting too big and polluting the header. Extracting an _internal.h header is the common paradigm to work around this. R=fdoray@chromium.org, olivierli@google.com Bug: 1064645 Change-Id: I0b3c49222026d2d98db77eb6075efcf17d9f33e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102588 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753456}
-
Lei Zhang authored
Put the PDFExtensionTest cases that run JS into the PDFExtensionJSTest subclass. Put the service work JS tests into the PDFExtensionServiceWorkerJSTest subclass. Change-Id: Id9bee94508965218cb99c0cd44c75ebddaee638d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119202Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753455}
-
Simon Que authored
These are builders that were migrated from json to Chromium recipe configs, e.g. crrev.com/c/2071293, before Week 1b could be relanded. This group of builders is to migrate those builders separately: - ios-simulator-cr-recipe (inactive since Nov 2019) - ios-simulator-cronet - ios-webkit-tot - ios13-sdk-device Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I5bea944d63154048b5b5c951336f9d76befd2e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119892Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#753454}
-
danakj authored
The content/test/ dir depends on these but doesn't use them. R=nasko@chromium.org Bug: 866140 Change-Id: I9c42f1cfaf386cbbf41f74a69800cbd9bbb54e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118178 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#753453}
-
Reilly Grant authored
This reverts commit cc673fd0. Reason for revert: Unable to reproduce test flakiness. Original change's description: > Disable WebBluetoothTest.WebBluetoothAfterCrash > > See details in: > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYkJsdWV0b290aFRlc3QuV2ViQmx1ZXRvb3RoQWZ0ZXJDcmFzaAw > > TBR=reillyg@chromium.org > > Bug: 1022321 > Change-Id: I01fcb892eea350bc60a05fc8f5b1aab9088cffc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904191 > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Commit-Queue: Hongchan Choi <hongchan@chromium.org> > Auto-Submit: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713544} Bug: 1022321 Change-Id: I8bc50f7c4328cf4da82e6e4230a4a9b1fe1365cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121347Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753452}
-
dpapad authored
Bug: 1026426 Change-Id: I16c53dc810993f9cd1684ee735f5738a8aa91734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119795 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#753451}
-
Gabriel Charette authored
|task_is_worker_task| was hard to read as it identified what |task| would become but that variable doesn't exist when BeforeRunTask() is invoked. The answer from BeforeRunTask() is more accurately "should_run_tasks". R=etiennep@chromium.org Change-Id: I9c581c5d4b477dbe06d8c2ecab9f844f649674ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105958 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753450}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If098b90259f38cbe5abf87053e10fa1720779538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753449}
-
Mark Brand authored
Visibility of media/learning/common:interfaces will need to include new generated targets for the MojoLPM fuzzer. See https://chromium-review.googlesource.com/c/chromium/src/+/2115512. Since there shouldn't be anything other than generated targets under media/learning/mojo/public/mojom, adding a blanket whitelist. Change-Id: I64f2aca281fed37e4ecfdfcf901a73860e85c9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120413 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Mark Brand <markbrand@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#753448}
-
Dale Curtis authored
There are cases where we may get multiple canplaythrough events, we need to ensure that ones beyond the first don't trigger crashes. Bug: 1064635 Change-Id: I93ab49a5060e2dbbb39791e2e2193d47b6dd3959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119643 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753447}
-
Haiyang Pan authored
The test FeedNewTabPageTest#testFeedDisabledByPolicy keeps crashing since https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/860 Bug: 1064388 Change-Id: I9885ed704254197cc024857f41e8bd8930656b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121357 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753446}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c3eb703583e..34f71abca1a1 git log 4c3eb703583e..34f71abca1a1 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 ehmaldonado@google.com git-cache: Also bootstrap in the case that there are 0 pack files 2020-03-25 ehmaldonado@google.com depot_tools: Split gclient_smoketests. Created with: gclient setdep -r src/third_party/depot_tools@34f71abca1a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I148867c14f8012a22fa94f87618f38adb85766ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753445}
-
Tom Anderson authored
R=pkasting Bug: 1056950 Change-Id: Ibf068118a6f6b1710be4d291884f5c227206f460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121495 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753444}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bccb5f3b3896..71cb6fda55ac git log bccb5f3b3896..71cb6fda55ac --date=short --first-parent --format='%ad %ae %s' 2020-03-25 robertphillips@google.com Initialize all the SkYUVAIndex fields in the wacky_yuv_formats GM Created with: gclient setdep -r src/third_party/skia@71cb6fda55ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I5631e6aedec7de06ad76f5841d07abc8fc07ce66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753443}
-
Curtis McMullan authored
This commit disables resize for the virtual keyboard. BUG=1019990 Change-Id: Ifc602df0e41885518ac8f5e54fd1ea604e24c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120674Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#753442}
-
Becca Hughes authored
This adds the feed items to the WebUI. You can select a feed to show the content. BUG=1058187 Change-Id: I5051f77b68cb3da6710a547d50109cb95a7b890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118758 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753441}
-
Caleb Rouleau authored
It's best to have multiple owners in the event of OOO, so I have nominated John as an additional owner of load_library_perf_tests and Frank as an additional owner of media_perftests. Owners are responsible for understanding how these tests are important for the product. They do not need to understand how the tests are run or how the infrastructure works. I am leaving Google. TBR=johnchen@chromium.org Change-Id: Id217cf0364285f6d09a4e8eba25ea61789ab08fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121034Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#753440}
-
- 25 Mar, 2020 3 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/94584718d2c2..3ca8bc5a4a86 git log 94584718d2c2..3ca8bc5a4a86 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 kahinds@microsoft.com Ignore theme stylesheet application in high contrast mode 2020-03-25 brgoddar@microsoft.com Screencast: Add accessible text for the Screencast Nav Bar Controls Created with: gclient setdep -r src/third_party/devtools-frontend/src@3ca8bc5a4a86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378,chromium:1064733 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie89abcd2e3ccf5b94bc6e09e73ea3a427949c275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753439}
-
Jeff Yoon authored
This reverts commit f039e78b. Reason for revert: The wrong bot was migrated here. Original change's description: > [ios] ios-simulator-cronet tryjob src side Chromium config > > ios-simulator-cronet under chromium.fyi has already been migrated. > Missed migrating the trybot with it. > > Bug: 1055164,912681 > Change-Id: Ia58340308ba719dc6f39cf65ab40f73c4c89929b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120051 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753391} TBR=agable@chromium.org,jbudorick@chromium.org,jeffyoon@chromium.org Change-Id: I09d5cfeab541bbaf6f7d1b8382e273e5d621601b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055164, 912681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121420Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753438}
-
Haiyang Pan authored
The following tests starts failing consistently since the build https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/838 Bug: 1064367 Change-Id: Ibfae8da42da2cbdc44fb8e70ada0f50ee8cd3b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119386 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753437}
-