- 19 Nov, 2020 40 commits
-
-
Alan Cutter authored
This is a reland of d4e5f661 Re-fixed the Windows deps requirements. Also verified gn check locally on Linux cross compile target for Windows. https://chromium-review.googlesource.com/c/chromium/src/+/2546142/3/chrome/browser/win/conflicts/BUILD.gn Original change's description: > Reland "Extract browser_process.h/cc into own gn target" > > This is a reland of 86556051 > > The original CL missed a dep requirement in the Chrome branded > Windows build. This has been fixed: > https://chromium-review.googlesource.com/c/chromium/src/+/2543873/2/chrome/browser/win/conflicts/BUILD.gn > > Original change's description: > > Extract browser_process.h/cc into own gn target > > > > This CL pulls out browser_process.h and browser_process.cc into their > > own gn target so that other gn targets can depend on it without creating > > cyclic dependencies with //chrome/browser:browser. > > > > This is required for CL: > > https://chromium-review.googlesource.com/c/chromium/src/+/2528519 > > > > Bug: 1147410, 883570, 925153 > > Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Reviewed-by: Filip Gorski <fgorski@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Auto-Submit: Alan Cutter <alancutter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#828077} > > Bug: 1147410 > Bug: 883570 > Bug: 925153 > Change-Id: I18faaddc3850ceafb924bda6d8e197f886e79433 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543873 > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828442} Bug: 1147410 Bug: 883570 Bug: 925153 Change-Id: Ia8249933997b6f23f8c0ca63ab927bb70ce6849b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546142Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#829123}
-
Andrey Kosyakov authored
- disable sending of missed frames to frame observers added after we cancel frame in ExternalBeginFrameSourceMojo to avoid sending multiple frames, or sending frames at the time when the client does not intend. - force full frames (i.e. animation_only = false) till we have a first frame drawn. We used to do this on the client side, but this really belongs to the back-end (and maybe further down to the renderer). Bug: 1149042 Change-Id: Id1d79fbd4d6f355ebf6b9a441a5df772c7cf3b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538488Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#829122}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6e44bd85f3a3..0c019226a958 2020-11-19 dproy@chromium.org [tbmv2] Add a way to add alert groupings to histograms If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1150233 Tbr: nuskos@google.com Change-Id: I5b3f180d56a3cc409deaffb08e2ce4e611d940b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829121}
-
Alexandre Courbot authored
GetFrame() returns VideoFrames with a destruction observer than puts the frame back into the pool once the client is done with it. However, when a reconfiguration takes place, we are now working with a new set of frames, and we should not put the old ones back into the pool. Make sure this does not happen by invalidating the weak pointers the destruction observers has been posted with when switching to a new set of frames. BUG=b:161759267 BUG=b:165035340 BUG=b:172881995 TEST=CtsMediaTestCases android.media.cts.AdaptivePlaybackTest#testH264Adaptive passes on Trogdor TEST=GtsExoPlayerTestCases com.google.android.exoplayer.gts.DashTest passes on Trogdor Change-Id: Ia1a28fb64d5659eb1eedf0b96ad4bc344e67fdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548587 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829120}
-
Austin Tankiang authored
These broke due to https://crrev.com/c/1630010. Mark these links as rel="opener" to workaround this for now. Bug: 1149257 Change-Id: I4d21a03811fdef4bc7165ffdd172e004e6107d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547858Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#829119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f1bad64e. With Chromium commits locally applied on WPT: 0977dd12 "Move native paint worklet off thread" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I44898f3e29b2a182514a3404888e6e0675f9c58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548920Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829118}
-
Polina Bondarenko authored
Before starting ARC container or VM try to load a snapshot if available. ARC data snapshots are loaded only for MGS. If there is no snapshot or the process fails, start ARC session as usual. BUG=b:161221001 TEST=components_unittests TEST=unit_tests Change-Id: I7e222f9abd11b0471a40a475c73931886582bf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498488 Auto-Submit: Polina Bondarenko <pbond@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#829117}
-
Rebekah Potter authored
This reverts commit 18dac5f7. Reason for revert: Speculative revert. The IDs for these resources don't match what they should in the uprev failure described at https://bugs.chromium.org/p/chromium/issues/detail?id=1150466 It's likely this CL triggered the bot issue, but probably isn't the root cause (needs further investigation). Original change's description: > WebUI: Auto-generated grd file for chrome://usb-internals. > > Bug: 1132403 > Change-Id: Ie44b69c074794cbd10a08289e389e502e8e94ccc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539892 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828130} TBR=dpapad@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132403 Change-Id: I77d53bf592318c98e560b2f193cda0edd8dff0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548650 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#829116}
-
Polina Bondarenko authored
A new static library for components/arc/enterprise is needed to be able to call ArcDataSnapshotdManager from ArcSessionImpl. BUG=b:161221001 TEST=compile Change-Id: I8da4385cdc2d1bad74721a2c623631aa9894ff98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543063Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/458ab69a..8645ae9d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia676a2140e6016adfaf425d435ddcaf6a9e2463c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548885Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829114}
-
Luciano Pacheco authored
Add the optimize_webui() for the SharedWorker within Audio Player. Change Audio Player initialization to switch the SharedWorker script url based on the feature flag `AudioPlayerJsModules`. To be able to check the state of the feature flag refactored the initialization to: 1. Use the load_time_data.js because that's how we send the state of the flag from the C++ to the JS. 2. Delayed the initialization of MetadataModel to be after the load_time_data initialization because MetadataModel is what starts the SharedWorker. 3. Change the call site to MetadataModel which is in fetchMetadata_() to wait for MetadataModel initialization. No change in behavior, so the current tests cover this all. I've tested manually and run the integration tests with the flag on and off. Test: browser_tests --gtest_filter="AudioPlayer*:OpenAudioFiles*" Bug: 1133186 Change-Id: I62bd50a4ef17c0b799112727c0540fc5dc8f58d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546306 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#829113}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Iedb6f15e5aac26bdf6eb17d4017e6fe86f22f951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537252Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829112}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/021b77e7f0c7..3a578ae35233 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I76c533768329ce099645e9bc00b5ab9c532d183d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548466Reviewed-by:
-
Tal Pressman authored
Change-Id: I388d9ec4f1846485705c8aa8ddf6c33a9ab49c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547232 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829110}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/efe28dbf48ad..004bf3ee3fb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I08fe6d50430c346ba065af5c8c8d2f6775338446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548192Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829109}
-
Bartek Nowierski authored
No performance / memory / stability regression is observed. See comments #34 and #35 on crbug/1086388 Bug: 1086388, 1093838 Change-Id: I367b781a681b350883cde39b27ac505b3722bbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548702 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605689852-f178b38050a80e7ec32f221b3018d4e55c9e1dbc.profdata to chrome-win32-master-1605732977-09df8fbd862d08eaa283942ed13244c34d12f091.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I204e87e130f94b41917e4c757825b62770b249ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548407Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/438d44197a4f..ad797e966480 2020-11-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7c6e86706f606b867a9caeaffecda222256fb906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548802Reviewed-by:
-
Stefan Zager authored
This avoids over-invalidation when render throttling status changes. Rather than unconditionally invalidating the frame contents, with this CL we simply postpone propagating invalidation bits up to the parent document until the frame becomes unthrottled. Change-Id: Id510939429f40547a4e8a7e6df1c66a0f0869fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506298Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#829105}
-
Hitoshi Yoshida authored
This CL fixes several issues in building with using new IDL dictionary - Update some GN targets to be workable - Update generated files - Update include files and forward declarations - Wrap IDL enum with IDLEnumAsString() Bug: 839389 Change-Id: I89cc5e70d53502a8ee2e4ebaaf0d2659f7dac196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547223Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605711541-e80691ca139e898c0a60a52d6d7a9fcb07e313a9.profdata to chrome-win64-master-1605732977-d582403d24e72f4b574d0b095493057d717a9e6c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib30d2f4d892a481b9c71d4ef8a017bbbfaec654a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548604Reviewed-by:
-
Dominic Mazzoni authored
Timed out three times in a row: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/b8863245589403119392 Bug: 1150689 Tbr: austinct@chromium.org Change-Id: I2c03cd6376918d1d2ae37740c56e4e2a00c079aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548884Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829102}
-
Noel Gordon authored
Bug: 1102263 Change-Id: I0c526fa6c5dba0e6e7b7ccd0c4cd092f4a8b444c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548586Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#829101}
-
Yunke Zhou authored
Add testing utils so Oobe tast tests could use the methods here. This fixes the problem for oobe_smoke.go test where eula screen is not shown in non-branded build. Bug: 1145697 Change-Id: Id39a2b522699d96d43d5c849503b3221acac8008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527055 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829100}
-
Keishi Hattori authored
The following tests are timing out on Win7 Tests bot - virtual/plz-dedicated-worker/external/wpt/service-workers/service-worker/registration-updateviacache.https.html - virtual/plz-dedicated-worker/external/wpt/service-workers/service-worker/update-bytecheck-cors-import.https.html TBR=nhiroki Bug: 1150700 Change-Id: I582243fe4e91cb9ee46c90b430efe03f6f7c7c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547650Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829099}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8a58e38bfd26..8b76d37f9f9a 2020-11-19 jmadill@chromium.org Trace Tests: Run one step per frame. 2020-11-18 cclao@google.com Revert "Vulkan: Remove rotation related data from driver uniform" 2020-11-18 kainino@chromium.org Skip one more test on Apple DTK (ARM) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5726cf75f254f07d26511e19a120c9cdc055275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548317Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I81b77f364e2ec068bc00d0e103ff50bb54d44e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532483Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829097}
-
Tim Sergeant authored
This reverts commit 5243d913. Reason for revert: Chrome OS LKGM has been manually updated in crrev.com/c/2544964, bots using simplechrome should now have the fixed tast test. Original change's description: > Revert "Reland "CrOS: Add Files app to default shelf pins in second position"" > > This reverts commit 527ae681. > > Reason for revert: suspect causing chrome_all_tast_tests failure on chromeos-kevin-chrome > - ui.ShelfLaunchedApps > > First detected build: > https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/10864 > > Sample log: > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8863425670685038096/+/steps/chrome_all_tast_tests_on_ChromeOS/0/logs/Deterministic_failure:_ui.ShelfLaunchedApps__status_FAILURE_/0 > -- > Unexpected apps in the shelf. Expected only Chrome: [0x2f76930 0x2f76960] > -- > > Original change's description: > > Reland "CrOS: Add Files app to default shelf pins in second position" > > > > This is a reland of 5d6ecbfb > > > > The failing Tast test (ui.ShelfLaunchedApps) has been updated to > > ensure it continues passing after this CL is landed. > > > > This is the second of a chain of 3 CLs: > > > > 1. crrev.com/c/2538305: Allow Files app to be pinned by default in > > ui.ShelfLaunchedApps > > 2. crrev.com/c/2538857: Add Files app to default shelf pins in second > > position > > 3. crrev.com/c/2538307: Update ui.ShelfLaunchedApps to ensure Chrome and > > Files are always pinned > > > > Original change's description: > > > CrOS: Add Files app to default shelf pins in second position > > > > > > This adds the Files app to the spot after the Chrome icon, for new users > > > only. There's also some variations of the default pin layout controlled > > > by a Finch experiment, I've moved the Files app up in those layouts for > > > consistency. > > > > > > This change was requested for M88 and will be merged back. > > > > > > Bug: 1148519 > > > Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214 > > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > > > Auto-Submit: Tim Sergeant <tsergeant@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#827272} > > > > Bug: 1148519 > > Change-Id: I9186b43a651dea4c4de9e46f849d35da9cc6062c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538857 > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Tim Sergeant <tsergeant@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827981} > > TBR=xiyuan@chromium.org,tsergeant@chromium.org > > Change-Id: I36e3778d368973d250824541c422d68b1679babd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1148519 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543883 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#828095} CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=xiyuan@chromium.org,tasak@google.com,tsergeant@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148519 Change-Id: I113ab25e648699fb0a40c0e56e3205bb3cf00a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547646 Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#829096}
-
Jasmine Chen authored
Fixes the comments written in CameraHalDispatcherImpl::RegisterClient. Bug: b/173577612 Test: Build simplechrome Change-Id: I2ab5ec0ed36f54b8441befe9e218c8acac35aca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546392 Auto-Submit: Jasmine Chen <lnishan@google.com> Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829095}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d31db0b3751..021b77e7f0c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2ef36fb971fd0d85562dac853373321cad1e168f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548213Reviewed-by:
-
Xiang Ji authored
Also, did a one line fix for the client cloud enrollment test due to the 2016 test machine change. The latest CELab patch includes improved nested Win10 performance, and CrOS nested VM beta support. Validation: tryjob https://cr-buildbucket.appspot.com/build/8863238187133959552 Change-Id: I71f793b8d9c3485c9fb463465a917671b7119cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545876 Commit-Queue: Xiang Ji <jxiang@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829093}
-
David Tseng authored
See the Espeak-ng repo for Chrome here for required changes there: https://chromium.googlesource.com/chromiumos/third_party/espeak-ng/ Depends on https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2538938 (for try/catch while the cros sdk in telemetry is out of sync) and https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2538477 (for engine changes to adhere to the mojo changes here). Bug: 1146417, 1146418, 1146420 Test: fixes issues above Change-Id: I8057a881830e5b51671770fa654f742ecd3f47b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515786 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#829092}
-
Dominic Farolino authored
This reverts commit 2638a6e6. Reason for revert: We thought we had collected enough crash data, however crbug.com/1122182 was not actually fixed yet, so the minidumps did not actually contain the information we needed. agrieve@ has informed me that the issue should be fixed now, and we'll confirm whether or not that is the case by: 1.) Reverting this change 2.) Collecting minidumps 3.) Examining the minidumps to confirm that the debugging information exists Original change's description: > Revert "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly" > > This reverts commit b344652b. > Reason for revert: We have collected enough crashdumps now, and this is > causing crash metrics to be skewed as it's getting counted as a real > crash. > > Bug: 1132770 > Change-Id: Ia2e7a92bea2ebeca01c62ca9af73d3fe014685f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505985 > Auto-Submit: Mugdha Lakhani <nator@chromium.org> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822189} TBR=csharrison@chromium.org,nator@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR: charrison@chromium.org Bug: 1132770 Change-Id: I31ac96c2c5f4f0738fd2d8c4e60236b2bc0c35a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513109Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#829091}
-
Keishi Hattori authored
This reverts commit 3a6b8b82. Reason for revert: Speculative revert for DesksGestureHandlerTest.HorizontalScrolls and ReverseGestureHandlerTest.SwitchDesk failure on linux-chromeos-dbg crbug.com/1150701 Original change's description: > desks: Enable enhanced desk animations by default. > > Enabling also exposed a DCHECK where the throughput tracker was being > Stopped when it was not started. This was previously missed, because > manual testing was all done on a device, where DCHECKs were disabled. > > Bug: 1148923 > Test: none > Change-Id: I9c9236f04da072e0a63eb118db0969716a71ffdd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537131 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828916} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: I2db6cb1342dc0d20d0374d5da96dc9988dbfd5a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547855Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9bd9575f2f7794c432c9f1d10458632c808384bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548602Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5c2ea4d80c2b..438d44197a4f 2020-11-19 kahinds@microsoft.com [Loc] Migrate security to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28d666aa92a8811bc3cc65424fc8875bb68d651a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548410Reviewed-by:
-
Jeffrey Young authored
This is a reland of 6d681c88 AmbientController close all ui widgets in destructor. Prevents use-after-free in PhotoView destructor if Shell is destructed while Ambient mode is on. Original change's description: > ambient: support multiple displays > > Run ambient mode UI on each connected display. > RootWindowController construction handles adding ambient widgets > to new displays while ambient mode is running, and destructing them > on display removed. > > BUG=b:139953389 > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Ic57c33491098b66c7c0e90ef1f3d12c71f1fc303 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516968 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828329} Bug: b:139953389 Change-Id: I1a7acccb0325c2c65b3d9f57db3d4c4bde03dc63 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546971Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#829087}
-
Jeffrey Young authored
On shutdown, MetricsService may attempt to finalize logs and calls |ProvideCurrentSessionData|. |AmbientClient| may have been destructed by then. BUG=1150479 TEST=on about://flags, change a flag and restart ui Change-Id: I216b522ca1dd8c2c09a4f1350098b9c18620338c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547331Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#829086}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/021b77e7f0c7..3a578ae35233 2020-11-19 treehugger-gerrit@google.com Merge "Include FrameTimelineTest in TEST_MAPPING" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id1bdd172e774a837de59f987489149f03f682b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548505Reviewed-by:
-
Yann Dago authored
Bug: 1149989 Change-Id: I1f8857abde83ab07576a6a272d6918adbf712bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547444Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#829084}
-
