- 01 Nov, 2018 40 commits
-
-
James Hawkins authored
This method did nothing given that no event listener was registered for the auth attempt listener in the WebUI. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I4f46d553ee95538a468b05a434f609ab60c7ca52 Reviewed-on: https://chromium-review.googlesource.com/c/1312300Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#604625}
-
Kevin Bailey authored
In a RTL UI, we'd like the arrow keys to behave intuitively which means they must be reversed from in LTR mode. Also, it makes a slight behavior change: To handle the case of not being able to unfocus the button if the cursor is moved away from the end, we now unfocus the button as soon as the Omnibox is clicked (which makes sense in terms of moving the "focus".) Bug: 894788 Change-Id: I3323a5b2575bdbaad45853799044f21efa65ac63 Reviewed-on: https://chromium-review.googlesource.com/c/1280847 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#604624}
-
Tom McKee authored
Rename step_queueing_times_ to sliding_window_ to better clarity. Bug: 883487 Change-Id: I778db437b734a8e498efb69eb3aeff20aeb7cc47 Reviewed-on: https://chromium-review.googlesource.com/c/1299548 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604623}
-
Hazem Ashmawy authored
Add Finch Experiments info aka variations crash keys to Webview minidump. The keys are "variations" and "num-experiments". Bug: 758450 Change-Id: Ib3bc7b872c0ff88eb404595496a9084f1d123ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1305953 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#604622}
-
mark a. foltz authored
This patch removes the Presentation API from insecure contexts. The number of presentations started on insecure contexts is 0.0001% of page views on desktop and 0.0004 on Android. In addition it updates layout tests and WPT to use https: for presentation URLs. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion chromestatus.com feature entry: https://www.chromestatus.com/feature/5766218384408576 Bug: 733381 Change-Id: I9ae3025160b0e0bcf987fda0068a0e6bd92c24fd Reviewed-on: https://chromium-review.googlesource.com/c/1306336Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604621}
-
Mikhail Lopatkin authored
Prior to this CL removal of grit output file in BUILD.gn wasn't triggering a re-run of grit if all other files are up-to-date. This may cause a suprising output list verification failure later, during clean build. R=agrieve@chromium.org Change-Id: I881992c174d5d3a2433759e2622929c4e84b3845 Reviewed-on: https://chromium-review.googlesource.com/c/1310274Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#604620}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be837ac3bc79..fe45da4f047e git log be837ac3bc79..fe45da4f047e --date=short --no-merges --format='%ad %ae %s' 2018-11-01 philipel@webrtc.org Remove WebRTC-VP8-GfBoost field trial. 2018-11-01 srte@webrtc.org Makes send time information in feedback non-optional. Created with: gclient setdep -r src/third_party/webrtc@fe45da4f047e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2c942fdd256766b3f2d64dba8f980b275dd78626 Reviewed-on: https://chromium-review.googlesource.com/c/1312340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604619}
-
David Bienvenu authored
This is a reland of 03b56190 Original change's description: > Native window occlusion tracking for windows. > > This implements native window occlusion tracking on windows, under flag/experiment control. It uses WinEvent event hooks and EnumWindows to track and calculate occlusion. > > It is not yet hooked up to the code that treats occluded windows differently. > > Bug: 813093 > Change-Id: Ic9b473b8cad38e7b1653566f28917164bc92e21c > Reviewed-on: https://chromium-review.googlesource.com/c/1140752 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603619} Bug: 813093 Change-Id: I78fa7b04a7efc0c392100b852e1a1a5f04421132 Reviewed-on: https://chromium-review.googlesource.com/c/1308264 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4dda60c7111..fa7df23d8b0c git log e4dda60c7111..fa7df23d8b0c --date=short --no-merges --format='%ad %ae %s' 2018-11-01 mtklein@chromium.org more SkBlitter::Choose refactoring 2018-11-01 brianosman@google.com Remove unused GrCubicEffect 2018-11-01 herb@google.com Revert "Move from a functional to object based interface between Painter and SkDraw" 2018-11-01 caryclark@skia.org refactor bookmaker 2018-11-01 caryclark@skia.org simplify default bookmaker command line Created with: gclient setdep -r src/third_party/skia@fa7df23d8b0c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I1a97bf90b7224b87335d02b2cd90c48f0668fb82 Reviewed-on: https://chromium-review.googlesource.com/c/1312337Reviewed-by:
-
Theresa authored
Use a hairline border for Zine cards and sign in promo cards. In this v1, the Zine thumbnails sit on top of the hairline border. A future update will move the thumbnails inside the hairline border. BUG=872080 Change-Id: Ie416d2107c0e8b4e6d7a058f7026a5d2765664e8 Reviewed-on: https://chromium-review.googlesource.com/c/1311804 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604616}
-
Eric Aleshire authored
This was configured in my scheme when testing locally, so I forgot it even existed. Found when doing a full repro of the bot testing flow while trying to debug unrelated issues with ios-wpr-simulator. This line is very long as both of these flags should be part of "-c" so that iossim passes it properly. Is that fine? Bug: 892381 Change-Id: I5d7def3f138d10033914718429307b76a8d71d8a Reviewed-on: https://chromium-review.googlesource.com/c/1311809 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604615}
-
Ted Choc authored
BUG=898522 Change-Id: Id9ef47429b19582982480ff0dcd5af78ab21b99e Reviewed-on: https://chromium-review.googlesource.com/c/1311496 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#604614}
-
mrefaat authored
- Create TabUtil file that will contain methods that give tab information from a given webState but are not considered a tab state property. - Delete -title from tab.h/mm and create GetTabTitle function in TabUtil - Create Unit tests for GetTabTitle / Add SetTitle to TestWebState Bug: 898655, 898652 Change-Id: I9e30eb163d45f008e3a755cba7121526c41d5eee Reviewed-on: https://chromium-review.googlesource.com/c/1306782Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#604613}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/61791eae36b8..2960ec33667a $ git log 61791eae3..2960ec336 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 cwallez Add support for all of Chromium's CPU architectures. 2018-11-01 senorblanco D3D12 fix for register binding offsets. Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org BUG=870747 Change-Id: I6942e2e387f367be3aee7f707152375e6d6c0254 Reviewed-on: https://chromium-review.googlesource.com/c/1311932Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#604612}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5cb84f85868b..a6b8b8078371 git log 5cb84f85868b..a6b8b8078371 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 primiano@google.com Merge "Minor ui improvements" 2018-11-01 primiano@google.com Minor fixes to SQL controller and UI overview timeline Created with: gclient setdep -r src/third_party/perfetto@a6b8b8078371 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibbac7a5b813ef0d9b4faab5520b4beadd854b2b2 Reviewed-on: https://chromium-review.googlesource.com/c/1312334Reviewed-by:
-
manuk hovanesian authored
Revert "[Omnibox] Use GURL::possibly_invalid_spec instead of GURL::spec when sorting and deduping matches." This reverts commit 61d1146d. Reason for revert: per review comments, there may be a larger underlying reason as to why we we're generating invalid GURL's that should be addressed. Original change's description: > [Omnibox] Use GURL::possibly_invalid_spec instead of GURL::spec when sorting and deduping matches. > > Certain omnibox inputs, such as `http:www.` produce matches with invalid urls. Invoking GURL::spec on these invalid GURL's caused a DCHECK to evaluate false and crash the browser. The crash only affects debug builds as the DCHECK is inactive for non-debug builds. > > Bug: 898554 > Change-Id: I89a27f902b77bf6b221c321ab396787e9249a4e6 > Reviewed-on: https://chromium-review.googlesource.com/c/1308260 > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604012} TBR=krb@chromium.org,tommycli@chromium.org,manukh@chromium.org Change-Id: I3e2dddb8dd218bce805dc93d842f83b7366cf1bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898554 Reviewed-on: https://chromium-review.googlesource.com/c/1308603Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604610}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f2f7c2a92321..2256c2786cc8 git log f2f7c2a92321..2256c2786cc8 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Roll third_party/skia/ c994a93b3..91e260f4d (1 commit) Created with: gclient setdep -r src/third_party/pdfium@2256c2786cc8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I91ba830c004978c463dc26627d71fd4c54510af9 Reviewed-on: https://chromium-review.googlesource.com/c/1312335Reviewed-by:
-
Weidong Guo authored
Enable auto-hide shelf. Drag from bottom bezel to show home launcher and, meanwhile, use second finger to drag on home launcher, the launcher freezes. It happens because shelf is hidden when dragging with second finger which prevents the drag end event reaching home gesture handler. Changes: 1. Remove shelf visibility check for drag end event. 2. Avoid processing drag event when animation is running. Bug: 899554 Change-Id: I18262f813ab4acaab9266b7fba1c7790275d8fbc Reviewed-on: https://chromium-review.googlesource.com/c/1311840Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604608}
-
Anders Hartvoll Ruud authored
Due to how initial values of registered custom properties used to be handled, the style diff function for custom paint could not discover that the computed value for some property changed due to a new property registration. This meant that, if you used the property '--x' in your paint worklet (without applying '--x' on any element in the document), and _then_ registered the property '--x' (giving it an initial value), the worklet would not repaint even though the computed value of --x changed from "nothing" to the registered initial value. Now that initial values are returned from ::GetRegisteredVariable, simply compare those values when diffing for custom paint invalidation. Note that the second test in this CL is already passing before this CL, but I'm including it anyway since that case is also mentioned in the bug. R=ikilpatrick@chromium.org Bug: 657706 Change-Id: I2b7707d48d73693a70b100fe1121bd7f977b4db1 Reviewed-on: https://chromium-review.googlesource.com/c/1309788 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604607}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83a7a95315fa..f4ede5cbd079 Created with: gclient setdep -r src-internal@f4ede5cbd079 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3cc2e7330281c1321ddafbd8914c99aad4495e9c Reviewed-on: https://chromium-review.googlesource.com/c/1312339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604606}
-
Dmitry Gozman authored
We don't actually need these - we can use model observers instead. Bug: 882467 Change-Id: If847fcf4f2968430821de316e3b346a25a2a3592 Reviewed-on: https://chromium-review.googlesource.com/c/1311916 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#604605}
-
Koji Ishii authored
This patch adds size warning for NGPaintFragment. Currently, it is 128 bytes (208 bytes if DCHECK) on x64: * 104 bytes for its own fields. * 8 bytes for RefCounted<> (80 bytes if DCHECK). * 8 bytes for DisplayItemClient (16 bytes if DCHECK). * 8 bytes for ImageResourceObserver (a super class, even without any fields, adds 8 bytes minimum). Bug: 714962 Change-Id: I5fdd26e61f742e61bcf7c74393677dd61c587d91 Reviewed-on: https://chromium-review.googlesource.com/c/1312437Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#604604}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4115d82f09e2..cc9857f9b84d git log 4115d82f09e2..cc9857f9b84d --date=short --no-merges --format='%ad %ae %s' 2018-11-01 perezju@chromium.org [Telemetry] Increase timeout on CollectChromeTracingData 2018-11-01 eyaich@google.com Add support to telemetry for a StoryTest that is not TBM Created with: gclient setdep -r src/third_party/catapult@cc9857f9b84d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900920,chromium:714231 TBR=sullivan@chromium.org Change-Id: Ia6489b0e26405cb0ea98abaaa346a432e69bffb1 Reviewed-on: https://chromium-review.googlesource.com/c/1312336Reviewed-by:
-
Clemens Arbesser authored
[Autofill Assistant] Disabled autofill overlay during payment requests, because payment requests have their own overlay. Showing both overlays at the same time darkens the screen too much. However, the overlay color from autofill is different from that of the payment request. Even with this CL, there is a noticeable color change. We may want to adjust the color of our overlay to match that of the payment request. Bug: 806868 Change-Id: I63929cef745e4a573b90f567429ee996eb556b64 Reviewed-on: https://chromium-review.googlesource.com/c/1311922 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#604602}
-
Xianzhu Wang authored
This is a follow-up of crrev.com/c/1286894 which let a test fail if the test has some extra baselines. This CL let rebaseline-cl work for the failures by removing the extra baselines. Bug: 703899 Change-Id: Ib811cb1179af399406214ed78cb22520967915cb Reviewed-on: https://chromium-review.googlesource.com/c/1298124 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#604601}
-
Reza.Zakerinasab authored
This change fixes a memory allocation issue that apparently has caused a memory usage regression in video_VideoDecodeMemoryUsage Bug: 900455 Change-Id: Idc614a5c5171f3a12585ebd3c8384eddc5be7474 Reviewed-on: https://chromium-review.googlesource.com/c/1312627Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#604600}
-
Brian White authored
Bug: 900230 Change-Id: I37dd02c2a7e1b8ef586e101e036d6871c7361424 Reviewed-on: https://chromium-review.googlesource.com/c/1307935Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#604599}
-
Dmitry Gozman authored
We don't need some test runner methods anymore. We can also determine capabilities by type instead of passing them separately. Bug: 882467 Change-Id: I0dc07f4379141905d41968f969650f3d794fdee2 Reviewed-on: https://chromium-review.googlesource.com/c/1311839 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Mikhail Lopatkin authored
Without this the outputs list verification failure doesn't cause build to fail. R=agrieve@chromium.org Change-Id: I5c7416c3ff1681aab0f171ef3ee608aece130e8a Reviewed-on: https://chromium-review.googlesource.com/c/1309781Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb996dce7525..9e6f5134d1aa git log fb996dce7525..9e6f5134d1aa --date=short --no-merges --format='%ad %ae %s' 2018-11-01 dj2@everburning.com Reduce number of test targets (#2024) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9e6f5134d1aa The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I621e581b9ab2be759ec10ff6615e08c2a9badfa4 Reviewed-on: https://chromium-review.googlesource.com/c/1312626Reviewed-by:
-
François Beaufort authored
This CL is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1303364 Bug: 891427 Change-Id: Ie3075933134463107e43d2f452cc025405ba19c5 Reviewed-on: https://chromium-review.googlesource.com/c/1307394Reviewed-by:
-
Tommy Martino authored
The JellyBean implementation of the dropdown class doesn't show a divider between the ListView and the footer. This CL corrects that issue by wrapping the footer view in a simple new layout containing a divider, on Jellybean only. Bug: 900781 Change-Id: I37ed28c705dcfc4c0caa3aa9bde4dc122f29e9ca Reviewed-on: https://chromium-review.googlesource.com/c/1311938Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#604594}
-
Xianzhu Wang authored
In SPv1, background painting on the main graphics layer and on the scrolling contents layer are initiated by CompositedLayerMapping separately, so BlockPainter::Paint() just check the context to paint the background once on either the main graphics layer or the scrolling contents layer. In SPv2, for background painting BlockPainter::Paint() is called only once for each object in the background paint, so it needs to deal with the background on the main graphics layer and on the scrolling contents layer at the same time. Bug: 732611 Change-Id: I22300b82a585c3b96624524c37ed4bf6abafd9c8 Reviewed-on: https://chromium-review.googlesource.com/c/1303358 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604593}
-
Ehsan Chiniforooshan authored
We have TBMv2 versions of thread_times metrics, implemented in the Catapult repo in tracing/tracing/metrics/rendering. The legacy code for these metrics live in the Chromium repo in tools/perf/metrics/timeline.py. In order to not have a pause in the perf dashboard when we replace metrics defined in the Chromium repo with the ones defined in the Catapult repo, we plan to: 1- (this CL) modify the AddTBMv2RenderingMetrics function to behave when both metrics (with the same name) exist, 2- for all (groups of) thread times metrics: 2.1- rename the TBMv2 version, in the Catapult repo, to have the same name as the legacy metric, 2.2- delete the legacy metric, from the Chromium repo. 3- and, finally, delete the rendering measurement and rendering_util, and completely move to TBMv2. Bug: 890757 Change-Id: Iafb84d3ec0f732177005651e0b54b8dccb307c65 Reviewed-on: https://chromium-review.googlesource.com/c/1307838Reviewed-by:Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604592}
-
James Cook authored
This reverts commit 76f7d242. Reason for revert: Failing LockScreenNoteTakingTest.Launch on MSan bot, see crbug.com/899055 Original change's description: > Let ash provide window show state if client has SHOW_STATE_DEFAULT > > For lock screen app windows the window manager needs to specify the > initial show state of the window. Ensure the client (chrome) does not > overwrite the aura window show-state property in ash if the client > window has ui::SHOW_STATE_DEFAULT. > > Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash > > Bug: 899055 > Test: added to views_mus_unittests > > Change-Id: Ib7b6f9a060835ebf3e017737e4b98387a31831c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1303273 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604517} TBR=jamescook@chromium.org,tbarzic@chromium.org,sky@chromium.org,tsepez@chromium.org Change-Id: I809656b611b297daf7c1bacb5ec620a94ee3f235 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899055 Reviewed-on: https://chromium-review.googlesource.com/c/1312931Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604591}
-
Peter K. Lee authored
This code should have been removed as part of http://crrev/c/832942 Bug: 795802 Change-Id: I6d087c8f2cfc8c955db8ca757feded7379b7b6a6 Reviewed-on: https://chromium-review.googlesource.com/c/1312299Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#604590}
-
Jordan Demeulenaere authored
See b/118735405. Change-Id: Ia759ad8bab73d9479d832aa7dd187b51337773fc Reviewed-on: https://chromium-review.googlesource.com/c/1312479Reviewed-by:
-
Antonio Gomes authored
This is a reland of 947d8086 Compared to the reverted CL, this CL changes the way profiles are created, making use of the helper IdentityTestEnvironmentProfileAdaptor::CreateProfileForIdentityTestEnvironment, by overriding CreateBrowserContext. It is worth saying that the original memory failure was reproduced locally with the original CL and is now fixed. Original change's description: > [s13n] Convert c/b/ui/webui/settings/people_handler_unittest.cc to IdentityManager > > This CL converts the PeopleHandler unittests away from SignManager and > ProfileOAuth2TokenService, in favor of the new IdentityManager. > > Production code has been converted in [1]. This is a follow up steps. > > [1] https://crrev.com/c/1261637 > > BUG=890810 > > Change-Id: I405e46d2126180a2da61393bf32263ae43877b6b > Reviewed-on: https://chromium-review.googlesource.com/c/1311093 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#604377} Bug: 890810 Change-Id: I0aa039575603765bf4cec86cbb87bc86fd0b301f Reviewed-on: https://chromium-review.googlesource.com/c/1312909 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f0bf6da3705..83a7a95315fa Created with: gclient setdep -r src-internal@83a7a95315fa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7aa172f8eb70914040249f75335de8b1d4e9a98a Reviewed-on: https://chromium-review.googlesource.com/c/1312622Reviewed-by:
-
Evan Stade authored
Bug: 814675 Change-Id: I0eef36c50c2ec3b6dcc5566e553ed26f27379528 Reviewed-on: https://chromium-review.googlesource.com/c/1311657Reviewed-by:
-
