- 15 Jul, 2020 40 commits
-
-
Rohit Rao authored
The "automatic" user agent type is only available on iOS 13+. BUG=None Change-Id: I5746b05437856d29bd68d7229292d4ff006728a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297660Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788464}
-
David Van Cleve authored
The meta tag provides one way to set a document's referrer policy. We currently support tags that contain *lists* of policies, like <meta name=referrer content=policy,anotherpolicy> this is more permissive than the HTML spec (and WebKit and Gecko, which are in line with the spec). Meta tags with comma-separated lists of referrer policies show up at around 0.01% on the usage dashboard, which is above the "trivial to remove" threshold. This change adds a slightly more meaningful use counter examining the frequency with which these comma-separated-list policies have an effect: it maintains a counterfactual "what if we ignored all of these meta tags?" policy and, for window fetches that fall back to their initiating requests' referrer policies, check to see if recomputing the referrer using this counterfactual policy makes a difference. Bug: 1092930 Change-Id: Ic2a16f78288f3711a2fc43686c03bc9e727a5fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292830 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#788463}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2490b1ae774d..100707a33723 2020-07-14 swiftshader.regress@gmail.com Regres: Update test lists @ cd0af645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4ce4cd7587edf1b368864e946212783c567940b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788462}
-
Samuel Attard authored
Without this, debug builds fail comparing an int to an unsigned long. Bug: 1098899 Change-Id: Ica28ed3adf00c975b9ea5f7c2a42310a287fa7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298340Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#788461}
-
Lukasz Anforowicz authored
This CL removes an unnecessary std::move - it is unnecessary, because 1) |entry.break_token| is MulticolPartWalker::Entry::break_token which is a raw pointer (const NGBlockBreakToken*) 2) moves of built-in primitives types (including raw pointers) are just copies Bug: 1080832, 1066617 Change-Id: I7e6d1d44620732824962560c39bf7c90c3f65bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298336 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#788460}
-
Carlos IL authored
Implements on-form warning bubbles, and disables autofill for mixed content forms (forms on HTTPS sites that submit over HTTP). Pending work after this CL: -If we decide to do the same for password fields, a similar implementation for password manager. -The warning gets re-created with each typed character, we should not do this since it looks weird. -Login fields currently show the warning if there are no saved logins, this should be removed if we don't do this for login forms. Strings are not final and will likely be changed after UX review. Bug: 1093103 Change-Id: If77c59f652aac17c44bcdd0558b91fc6199025d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292868Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#788459}
-
My Nguyen authored
This is for feature bug 1097328. Enable this flag to see new language settings update for Chrome OS. Bug: 1104694 Change-Id: Ie62141f2b9b83b63c5fcf6f8fde2c8d21e754489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291825 Commit-Queue: My Nguyen <myy@chromium.org> Auto-Submit: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#788458}
-
Yan, Shaobo authored
This patch replaces the backed resource of imageBimap generated from video element to GPU resource. The old path has been used as fallback path. BUG=1098445 Change-Id: I346396a3a52bfe5034f9ef9580f875b1f5cb3177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277108Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#788457}
-
Fergus Dall authored
This test frequently times out, see e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38082 TBR=joelhockey@chromium.org Bug: 1092657 Change-Id: Idf0febbdef370abeb14063cd1fdededa19ea4562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298779Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#788456}
-
Callistus authored
Bug: b/157107063 Change-Id: Ie02e24afb175ef449b38fe319e0778def1472748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297029Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#788455}
-
Jun Kokatsu authored
This change renames Trusted Type policy in jstemplate to unsanitizedPolicy, so that Gerrit or some other tools can use or monitor this keyword as a way to add specific reviewers. Bug: 41905 Change-Id: I3e23607f0407ea986898b4f58f4eb206dcd56a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298291 Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#788454}
-
Bettina authored
Extensions* changes need to be increased as it has not been launched yet.The PasswordManager* histograms have to be updated as we use it for telemetry. Bug: 123 Change-Id: Ifa9e732fdd43fe9b267989ee764830c815d3faae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295756 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#788453}
-
chrome://internalschrome://chrome-urlsAlan Cutter authored
Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=455577&signed_aid=joCah5isK8_g9yc6pjF0rg==&inline=1 Bug: 1098638 Change-Id: I33ac3c4ff9089a9016532a08a7d9de6d9ec1cc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290475Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788452}
-
Hajime Hoshi authored
This reverts commit a8517b72. Reason for revert: Unit tests failure: crbug.com/1105711 Original change's description: > Remove DisableGPU flag in PluginPowerSaver browser test > > It's not clear why this should cause flakes, this will allow running > the tests on ChromeOS. > > Change-Id: Ife1867798873ca7233b2c2eb2ac56868c0fe2971 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290271 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788319} TBR=danakj@chromium.org,bokan@chromium.org,tommycli@chromium.org Change-Id: I38dc00b297fd723d45f55b2b9384c2f9c4ac57dd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298762Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788451}
-
David Benjamin authored
This was originally added in https://chromiumcodereview.appspot.com/21561003 for Channel ID. Channel ID no longer exists and this code is unused. Bug: 875053 Change-Id: I2fd1910909282bd753fd8a7f0ff32ecc2d808087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298343 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#788450}
-
Xinghui Lu authored
When enhanced protection is enabled: http://screen/xCztVbkOydH When enhanced protection is disabled: http://screen/mAX5c8wZoGV A managed view of this preference will be added in a future CL. Callback handling on the expand arrow click event will also be addressed in a future CL. Bug: 1097310 Change-Id: Ic5e657bdbcedcf361492215be48a109af33ff1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287275Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788449}
-
Dale Curtis authored
Addresses comments that were left during review after 94ab358b was merged. R=ccameron, wtc Bug: 960620, 1076568 Change-Id: Icfe931ddd25172f00966ae4730f3c90ffac6c9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298584 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788448}
-
Jeffrey Young authored
This is a reland of 3557d7dd Removes AssistantResponseProcessingV1 from AssistantBrowserTests Original change's description: > Assistant: ensure single generic error message > > Assistant processing v2 introduced a situation that allowed > multiple error messages to flush to the screen due to > AssistantInteractionControllerImpl::OnTtsStarted being > called multiple times. > > Add AssistantResponse::ContainsUiElement to check if duplicate > error elements already exist before adding more. > > Bug: b/158499400 > Change-Id: Ia90199ef8b733132fd5433ca47bb7905926b2f6e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258196 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#785935} Bug: b/158499400 Change-Id: I3c095dab6e42d55cec776ca32da172788c4dedde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288840 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#788447}
-
Maksim Ivanov authored
Add browsertests for the LoginScreenExtensionsLifetimeManager class that implements disabling/reenabling login-screen policy extensions when switching to/from user sessions. Also extend ExtensionForceInstallMixin to support setting policy via DeviceStateMixin. Bug: 1045740 Change-Id: I4ff3502cc571c396da74af76a7714d369a0b4f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276412Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#788446}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I73dff06fa768ad241a347f66e771173a8d99a74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298348Reviewed-by:
-
Liquan (Max) Gu authored
Context: Since ComponentPaymentRequestImpl owns PaymentRequestImpl, and PaymentRequestImpl have a weak reference to ComponentPaymentRequestImpl, ComponentPaymentRequestImpl can be GCed before PaymentRequestImpl (and caused the NullPointerException in the bug). Considering the fact that ComponentPaymentRequestImpl is the "component" part of PaymentRequestImpl, they should have the same lifespan. So this CL change the weak reference to direct reference. Before: PaymentRequestImpl had a weak reference to ComponentPaymentRequestImpl. After: PaymentRequestImpl have a direct reference to ComponentPaymentRequestImpl. Bug: 1104367 Change-Id: Id4199f6ea4c1ed73f8f37b8026662af694efe9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297689 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#788444}
-
Mohamed Heikal authored
Removes Chrome.apk (vs monochrome/trichrome/etc.) from the metrics collected by tools/binary_size/milestone_apk_sizes.py since it is no longer shipped. This cl also changes the heading for install size and compressed system image size to better match the column names in the milestone apk sizes sheet. Change-Id: Ia2521d6150835207b6fd6cda8136297e24866eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298196 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788443}
-
Orin Jaworski authored
This CL removes submatch fields from AutocompleteMatch and fixes most related logic. Tab switch and Pedal suggestions are not added to the suggestions list anymore since doing so would make them seem like full suggestions. Bug: 1102619 Change-Id: I44c8cbd29220fc520b3b7ebc28140888bd3b4cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293315Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788442}
-
Owen Rodley authored
Bug: 1094768,1105382 Change-Id: I4adef61ba684a97f729c02e2557736cbf6def33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297031 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#788441}
-
David Van Cleve authored
If this log line isn't needed in client builds, WDYT about changing it to a DVLOG? It's pretty noisy right now; for instance, see this example run from URLLoader tests: https://pastebin.com/7YBwscgP. Change-Id: Ica12950cf9149a3027148c532e29a32ff28798ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298639Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#788440}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie2a60ffa0cf28059baf01cbc8e54ea9c3635a549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298583Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594758783-89b5869eda45090ee3c154382bf0c8063de97283.profdata to chrome-mac-master-1594771186-d832f8303da18f87f12d9f2a0dd0e6f277bb9e8f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6a843c98a3c6ed97f8590ce5fabb3c18f131ea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298703Reviewed-by:
-
Dale Curtis authored
We may have some cards that are capable and some that are not yet ready to enable AV1 decoding, so this CL enables it by default but leaves the option for adding a gpu workaround to disable it. Bug: 1073252, 1092711 Change-Id: Id4327a382ec757dc70e07fbbf8207688e3a257d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298481 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#788437}
-
Natalie Chouinard authored
Add a couple basic render tests to the main settings screen for signed in and signed out views. This is a follow-up from https://crrev.com/c/2255221 to prevent similar regressions in future. Bug: 1097375 Change-Id: I506d3f7eb9b962549f66510d31c751815c45e448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258680Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#788436}
-
Yutaka Hirano authored
Bug: 693982 Change-Id: I9167ea0a097134cfd09decca1e4c0cf398a2a75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253601Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#788435}
-
James Hawkins authored
After the logic a few lines up, |account_id_| necessarily equals |account_id|. R=hansberry@chromium.org Bug: none Test: none Change-Id: I446aa1df5f5467d3a2c0e0ce5d560b33795b160a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293157Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#788434}
-
Scott Violet authored
This test uses API added in 84, so it needs to be marked as such. BUG=1079491 TEST=testSetUserAgentString Change-Id: I02757559f49359af080bc554c37b334351506dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298042 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#788433}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61e9eac61475..581586d36efb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: jianli@google.com Change-Id: If6b9464d1024bcd13d8382068749a26b106535a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298459Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788432}
-
dpapad authored
compress="gzip" is (as of r761031) the default behavior for HTML/CSS/JS/SVG files, and therefore there is no need to explicitly specify it. Bug: 1068407 Change-Id: I0f421e73c8e23f60be4365a4dc568743047b0110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290087Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#788431}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4e2d7cff8fc3..b31f5e717e2d 2020-07-14 enga@chromium.org Remove kMaxBindingsPerGroup limit 2020-07-14 rharrison@chromium.org Roll 5 dependencies 2020-07-14 kainino@chromium.org Skip clang-format on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ife8848650e2dff288483fc70552c2464deb41067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298519Reviewed-by:
-
Maksim Ivanov authored
The <cmath> header is needed for the log() function. Without this, the build fails in some configurations (e.g., when building inside Chrome OS SDK). Bug: none Change-Id: I425913a03173936a1949c022679852cc5242618d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297509Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#788429}
-
Matt Falkenhagen authored
Bug: 1092329 Change-Id: If310c9209d347315f531221fd8c46bc6227f70be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291185Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788428}
-
Shakti Sahu authored
This CL adds an additional flag that will act as a gateway for query tiles feature. Any current usage of query tiles will check for this feature as well. This is required for running country based experiments while not introducing crosstalk with other omnibox experiments. Finch CL : https://critique-ng.corp.google.com/cl/321059391/ Bug: 1105246 Change-Id: Ic89ed0c0be462709fe99b58b680bcbc15b5fe087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296287 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788427}
-
Xiyuan Xia authored
Crashes in https://crbug.com/1088432 and https://crbug.com/1099844 seems related to InkDrop and somehow an invalid LayerAnimationSequence gets in LayerAnimator's |animation_queue_|. Suspect it is caused by calling InkDropImpl::DestroyInkDropHighlight recursively when removing the layer. In such case, "highlight_->set_observer(nullptr)" could cause memory corruption since |highlight_| could be released. I don't have a repro but the recursive call could happen for InkDropImpl::DestroyInkDropRipple. This CL revises the two functions to prevent them being called from under Layer::Remove as speculative fix of the suspected memory corruption. Additionally, DestroyInkDropRipple() could trigger highlight to be created. This is unnecessary during destruction and sometime crashes, e.g. http://crash/34b439742c22c966 Bug: 1088432, 1099844 Change-Id: Ic5c032bce827a98ad5c564e4d67333743ea67189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293215 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#788426}
-
Frank Liberato authored
base::Optional used |&| in its placement new and operator->() implementations, which doesn't work as intended for types that provide overloads of operator&(). This CL replaces them with std::addressof. Bug: 1104378 Change-Id: I2301f435223ae45338c93469965b2b188a194ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293223 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788425}
-
