- 17 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9ae6d7f2ee9e..a9b199b05c1f 2020-08-17 cnorthrop@google.com Capture/Replay: Add ability to override entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Capture and play back first 1200 frames of COD. Change-Id: I18ca50a17cd334aff13c36e7a4ec171252768453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798549}
-
Thanh Nguyen authored
This CL: 1. Use vector icons for zero state file results. 2. Remove unnecessary pngs 3. Refactor file icon utils. Bug: 1067326 Change-Id: Ia64a505f4d40c7f8fcf981d7e6b976f7555de83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355351 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#798548}
-
Zhuoyu Qian authored
This patch rename UpdateShortcutInfosFromManifest() to UpdateShortcutsMenuItemInfosFromManifest(). And rename CreateShortcutInfos() to CreateShortcutsMenuItemInfos(). Bug: 1100751 Change-Id: Ibffe82bcac99676d6ca89f63df0588d776efae5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354126Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#798547}
-
Maggie Cai authored
Currently if we try to launch default arc app (e.g. play store) from intent picker when play store disabled, nothing will happen. This CL adapts the functionatliy to enable play store in this scenario. BUG = 1096903, 853604 Change-Id: Ib1efaba445d0dc957b2c425c61ffee164f838dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351350Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#798546}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7491e8b30f77..d882e93e416b 2020-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d315022be5b7 to 5e9b29fab92d (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I1e1b9d434b22416bf5def211319890efcf35faab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359682Reviewed-by:
-
Maksim Sisov authored
Trusty and Jessie have symbols unversioned. Thus, unversion the symbols in Linux sysroot the same way as was done for libdbus. Bug: 1116384 Change-Id: I2c16584de51141b53536c2a24f992913170a8f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352948Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798544}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e4e6433497c5..d2fe803ccc6a 2020-08-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c6cd6fe41d3025375e6c9a028d5500d04672b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359678Reviewed-by:
-
Peter Kasting authored
* Inline temps * Style guide bans "0.f" * Don't restate types * Better Time/TimeDelta unit usage * Simplify * Improve comments * Split separate DCHECK conditions * Use const/constexpr more * Eliminate unnecessary heap alloc Bug: none Change-Id: I4f7938318d436855f754ea262af268a0a95f414f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359007 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798542}
-
Yuki Yamada authored
It is not necessary to call Abandon() if the ExecutionContext is already destroyed. This is tested in PrerenderingTest.AbandonPrerender. Bug: 1115764, 1100257 Change-Id: I3f21953c03b2688d0b3760b05a9aabf1ee8ca781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355357 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798541}
-
Peter Kasting authored
* Inline temps * Range-based for * Split DCHECKs * Better units * Shorten code Bug: none Change-Id: I4f501c85c38f91efb3a6c94f2d3248f03cc808c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358998 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798540}
-
Nicholas Hollingum authored
Since crrev.com/c/1955818 all exo widgets (i.e. windows with a title bar, close buttons, etc) are defaulted to Arc++. This caused many crostini windows, which previously had no association, to be considered as Arc++ apps. This causes the Arc++ IME to steal events when there happens to be (or ever have been) an active input field in an arc++ app anywhere. We move the code that sets Arc++ windows to ClientControlledShellSurface, which Arc++ apps use. Bug: 1069388 Change-Id: If559a68315c2dcf175023f6601bdaf8bb6de46ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306499 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
-
Yoshisato Yanagisawa authored
Bug: 1105814 Change-Id: I78028c4e5f5bda13174090984675600270a011b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359026 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#798538}
-
Keith Lee authored
Applying comments in https://chromium-review.googlesource.com/c/chromium/src/+/2327773. Bug: 1108170 Change-Id: I3a528db4f4a7df288af0a5b02d758f5d9616f011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355657Reviewed-by:
-
Jing Wang authored
This is requested by UX in https://docs.google.com/document/d/1bZASllOcjDJdufpJdedUuM0cTQlIaoVO7K8AhXtWBrs/edit# Besides the announcement text change, now we will always announce the instruction about how to browse, accept and dismiss no matter if the annotation icon is displayed. So removed one inapplicable test. Test: Tested on DUT Bug: 1116298 Change-Id: I9fe24ea6ff50de5af4c24d4512dcf337f616b391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355530 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#798536}
-
Naoki Fukino authored
This is a follow-up of CL:2354115. As only one client listen to the click event of filter buttons, setting onclick property is sufficient and concise over addEventListener. Bug: none Change-Id: I13b5ad9c658c8489ec50a99754db422a79dc5551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359594Reviewed-by:
-
chrome://media-appTrent Apted authored
Currently user settings for default websites that may block these web features leak into system apps unless explicitly auto-granted. Bug: b/163088459 Change-Id: I22fb8bfcdd3a83c1a054c663bda0e54f89a6c238 Test: Open an image from ChromeOS Files app after setting chrome://settings/content/javascript to "Blocked" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358940 Commit-Queue: dstockwell <dstockwell@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Cr-Commit-Position: refs/heads/master@{#798534}
-
My Nguyen authored
Bug: 1113612 Change-Id: I831b447955cc147c80cb9dac9da4414933d787ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358716Reviewed-by:
-
My Nguyen authored
Spell check logic is from languages_page. It's currently disabled. Further logic for spellcheck languages will be added later. Spec: http://go/cros-lang-settings-ux slide 23. Current view: http://screen/36a08c58-4057-46d7-a6ef-7f43d370cbdc Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ic79458b605eda3fafc35f606f961e42b4ab23ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354118 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798532}
-
Prashant Nevase authored
There is no need to treat raster images differently. The element role added for images were used for deciding initial classification which is now moved to DarkModeFilter::AnalyzeShouldApplyToImage(), which should be called before calling ApplyToImageFlagsIfNeeded(). The functions added in Image class which were used for deciding element role for svg image container and gradient generated image are removed. Along with skipping filter to images drawn into larger rects, this patch adds logic for considering images for applying dark mode filter which have very smaller source rect. The analysis based on |src| and |dst| rects is extended for all kinds of images. With this rastered content from SVG images and gradient generated images undergo classification. Bug: 1094005 Change-Id: I6d24c770e2c703ddccfb70c00c0a5c9c51507498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352251Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#798531}
-
Naoki Fukino authored
Adding unit tests to evaluate the behavior of FileTypeFiltersController class, which was added with CL:2354115. Bug: 1114721 Test: Ran browser_tests --gtest_filter=*FileTypeFiltersController Change-Id: I9cc1cc8379fb35de909202d3043bda6d5304a024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359314Reviewed-by:
-
Xianzhu Wang authored
These were created in crrev.com/c/2146093 probably after we removed the mac10.10 bot for web tests and before we removed mac10.10 from blinkpy/web_tests scripts. TBR=szager@chromium.org Bug: 1107003 Change-Id: If64631c91dd341f580dad15e6deb72395c63c6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359366Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798529}
-
Ana SollanoKim authored
Previously, we had made the legends fragment in the following change https://chromium-review.googlesource.com/c/chromium/src/+/2090762. In this other change https://chromium-review.googlesource.com/c/chromium/src/+/2263353 we decided to not break borders for now. Because the legend is part of the fieldset border, we now want to treat the legend as monolithic. We still have logic for breaking the fieldset border, this will be addressed in a follow up change. Bug: 1097012 Change-Id: Iace252447063eb694c47fb9eea2a406ba2fe79d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353354 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#798528}
-
My Nguyen authored
Spec: http://go/cros-lang-settings-ux slide 23. Current view: http://screen/f9bbb539-b983-4ac7-aa9f-cb0886bd2f9f Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ic1ab01755fe86c28b89468aba54cc5dff010ced5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354113Reviewed-by:
-
tby authored
This is the first in a series of changes to how search providers are created and configured, with the aim of reducing the number of ranking and filtering steps between the providers and the UI. Eventually I'd like to repurpose the concept of a 'mixer group'. This change makes a small start by removing a feature of groups that we don't use anymore: multipliers on result scores. This CL also deletes some obsolete tests that don't take into account modern ranking. This coverage is mostly duplicated by search result ranker tests. Bug: 1028447 Change-Id: Ib6d27975ede3b9ee0a9d4b508d262ebff154670b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342533 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798526}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic2ce391f18c132cb7347d71461b190ed928b0711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359406Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798525}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic9b8e4cdb3a9d94af651f8e9663c042078ebcc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359237Reviewed-by:
-
Koji Ishii authored
This patch checks hyphenation alias first, before trying to open dictionaries. When the `lang` attribute is aliases, this change can reduce one IPC call. Bug: 1116540 Change-Id: I2ffe71a7f7c063238545320b538474e0e03307b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358714Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798523}
-
Fergus Dall authored
Mark compositing/layer-creation/overflow-scroll-overlap.html as failing on Mac This appears to have been broken by CL:2146093 which won't revert cleanly at this point. TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Bug: 1069546 Change-Id: I8a72c5e9e4e9d61df0365f4bb6b4158a6a11b9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359317Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798522}
-
danielng authored
Adding lxj to owners for pluginvm-show-camera-permissions and plugin-vm-show-microphone-permissions. Bug: 1106149 Change-Id: Ifcaf168fb48142632098f4ad3206878bc8240880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355359Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#798521}
-
Adam Rice authored
Always resolve tee's cancel promise after stream closes or errors. Applies https://github.com/whatwg/streams/pull/1039 to our implementation. BUG=1114014 Change-Id: Ic6d665bd928553ea3a292fe8221f0812d1c613e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358929Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#798520}
-
Mike Jackson authored
Update AppBannerManagerDesktop::OnWebAppInstalled to use the winning display mode when display_override is set. To test the change use: chrome --enable-features=WebAppManifestDisplayOverride Example websites: https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html (display == browser, display_override == [standard]) Explainer: https://github.com/WICG/display-override/blob/master/explainer.m Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Bug: 1109520 Change-Id: If0b589f0a19367f01501e2eb52aec16f4f2645cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354665Reviewed-by:
-
Justin Donnelly authored
This preserves the existing behavior where you can focus the omnibox and <text matching keyword><tab key> enters keyword mode. Bug: 1046523 Change-Id: I2e7d380cf31938e056b90b072df54e21e16ad348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346732 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798518}
-
Dominic Mazzoni authored
This looks better and better matches the mock. Bug: 1108114 Change-Id: I7f31c856bfe66b7d3fb4d4ae277ac633e8517295 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357855 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798517}
-
Peter Kasting authored
* Shorten code * Trivial naming/comment fixes * Use const more * Inline temps * Event::marking_time_in_bytes_per_second() is unused (and actually mis-named); remove * Use TimeDelta::InMicrosecondsF() to get a double Bug: none Change-Id: I324c6d82e04514e2a9105df05b5942eb2cfd9efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359006 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This CL adds kReadOnceStream enum value for fetch upload streaming instead of kChunkedDataPipe. kReadOnceStream means the data is non repeatable unlike kChunkedDataPipe. This is a preparation for "[fetch] Cache request stream body up to 64k bytes." (crrev.com/c/2269622) Bug: 1077174, 688906 Change-Id: I78c45777eb85751b20287bab6e55be0dd3502cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342525 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
David Maunder authored
We now do not allow Tab attributes to be acquired on an uninitialized Tab. We are finding tabs passed to getDomain() are uninitialized so we should handle this. Bug: 1116341 Change-Id: I69510196bf47b2b4939450905552a30ccb536d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358050 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798514}
-
Thanh Nguyen authored
This is a reland of dd116903 The original CL was reverted because mac-arm64-rel was failing. It works fine now. TBR=xiyuan@chromium.org,jiameng@chromium.org,tby@chromium.org,austinct@chromium.org Original change's description: > Using vector icons for launcher search provider > > Currently LauncherSearchProvider use png as the format for the result. > This CL changes the format to vector icons (.icon). > > Bug: 1067326 > Change-Id: I55fb11ed50906a5199bc28339de42d4903433b36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352290 > Reviewed-by: Austin Tankiang <austinct@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Reviewed-by: Tony Yeoman <tby@chromium.org> > Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798087} Bug: 1067326 Change-Id: I3558b2f0b023227d06893eda14b88fe3fe967b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358936Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
-
Sam McNally authored
When initialized incorrectly, some touchscreen controllers can report bogus values for their sizes. Chrome uses the touchscreen area in calculations; if that area overflows a signed 32-bit int, it check-fails. Thus, a misbehaving touchscreen can cause Chrome to crash-loop, rendering a device unusable. Mitigate this by warning about the bogus size and then ignoring the touchscreen input device. A non-functional touchscreen is better than an unusable device. BUG=b:162596241 Change-Id: I9291c176ed778f5ddb8a80d9ea75f17be7bd0554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353973Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798512}
-
Luciano Pacheco authored
The disabled state wasn't applied to disabled button because the selector was less specific. Fixed by adding a rule with "files-ng" to increase the specificity and using the semantic color. FIXED: 1116401 Change-Id: Ib3bb638d82b2bf488eca34894c86c63550ccb63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359590 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798511}
-
Naoki Fukino authored
When file-type filters in Recents is available, it provides equivalent functionality with media views and they become redundant. We can hide media views to save vertical space in directory tree in this situation. Bug: 1114721 Change-Id: Id4dd9660634560c71eb1a2a8e62879ad3b5206a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358937Reviewed-by:
-
