- 11 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35f78f4a4562..eddc7d0df5d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7fb7ffccc870a2717217fa856d9db4e24d88b825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842009}
-
Aya ElAttar authored
This is a reland of 57cebabc Original change's description: > DLP: Change DragDropDelegate::OnDragUpdated return type > > - Changed the return type of DragDropDelegate::OnDragUpdated > to return a struct of DragOperation and DataTransferEndpoint. > - The returned DataTransferEndpoint should be used in > DragDropController for allowing/disallowing dropping the > data according to the policy rules, See crrev.com/c/2595382. > > Bug: 1139886 > Change-Id: Ic80f2d55bf1df350d24778f01a43c8cba0ff67cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595411 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841675} TBR=sky@chromium.org,oshima@chromium.org Bug: 1139886 Change-Id: I547af7ff0dbd1dba47596e1cc47e743d8631c86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621300Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842008}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I3313c7091e8c775af08c8b997d36073a9631c30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621063Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842007}
-
Benjamin Beaudry authored
Once again, there was a nit we didn't detect in the first out-of-flow-multicol test we ever created and we duplicated it to all tests we created using the original one as a template. This CL fixes it. Change-Id: I7ad19fa9b3eda9205c1ad007b0bfbbe47d31d83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616972 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#842006}
-
Ramin Halavati authored
|Browser* GetOrCreateBrowser()| is renamed to |GetOrCreate|. |Browser::BrowserCreationStatus| is renamed to |Browser::CreationStatus| |Browser::GetBrowserCreationStatus()| is renamed to |Browser::GetCreationStatus()|. This CL does not change any behavior. Bug: 1162794 Change-Id: I14ce77c85153f746e1d1e70fcb66f5e83beb62ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617779Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#842005}
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/Cleared and OnUnconsentedPrimaryAccountChanged() are deprecated. So this cl changes these calls to OnPrimaryAccountChanged(). There is a behavior change introduced with this cl for AboutSigninInternals. Observers are now notified when the unconsented primary account changes as well as when sync account changes. Bug: 1158855 Change-Id: I2c7f2f70dd1b6e79f4b12033306fecc160329edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611276 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842004}
-
Elizabeth Popova authored
Add regexes for found on Russian websites names/labels. Bug: 1154727 Change-Id: I3eba2c09559ee8bb0ec42af488cd4c210fb0e155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599806Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#842003}
-
Benoit Lize authored
Some call sites in Chromium use (for instance) base::AlignedAlloc() with a small-enough alignment to be fulfilled by the normal allocator. For instance, with alignment = sizeof(void*), or 16 on 64 bit architectures. In these cases, we can use the regular allocator directly, which is faster, and can reduce memory fragmentation. Bug: 998048 Change-Id: Idca581c5db744f15fbb34cf3a80caf1f6d941546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615058 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842002}
-
Anatoliy Potapchuk authored
After crrev.com/c/2395298, the settings window opening would cause cause kiosk to crash. Previuosly, one of the lines was always returning false when checking SystemWebAppManager::IsEnabled, thus never exectuted. After the change, it was only executed in kiosk mode, which caused crashes. Bug: 1157279,1159274 Change-Id: I1456230547bb7d6e05a1c1515c3980000d88fa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593381Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#842001}
-
Alice Wang authored
This CL removes the unused method ProfileDataSource#getProfileDataMap in the ProfileDataSource interface and updates the interface comment as there is no requirement to invoke the interface on UI thread now. Bug: 1136452 Change-Id: Iadbc7021d3acc6b3405cc996428c73ddf6774787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620619Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842000}
-
Mihai Sardarescu authored
This CL fixes the order in which the notifications to update the primary account are being fired. The scenario that failed before this CL was the following (covered in test SigninManagerTest.UnconsentedPrimaryAccountUpdatedOnSyncConsentRevoked): 1. Account A and B are signed in with this order in the cookie jar. 2. Unconsented primary account: A 3. User enables sync with account B. B becomes the primary account 4. User revokes sync consent. 5. Unconsented primary account is reverted to B Before this CL, 2 notifications were sent with primary account changed in the wrong order: 1. { previous_state: { primary_account: gaia_id_for_me2_gmail.com, consent_level:NotRequired } current_state: { primary_account: gaia_id_for_me_gmail.com, consent_level:NotRequired } } 2. { previous_state: { primary_account: gaia_id_for_me2_gmail.com, consent_level:Sync }, current_state: { primary_account: gaia_id_for_me2_gmail.com, consent_level:NotRequired } } This CL fixes this order, and ensures that notification 2 above is correctly sent before notification 1. The change in the CL is fairly complex as it also updates the SigninManager to observe OnPrimaryAccountChanged notifications which is required as OnUnconsentedPrimaryAccountSet is deprecated. Bug: 1163126 Change-Id: I047014ce9bc569040d44121d90670d375f8fba62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613971 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:Monica Basta <msalama@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53f842487859..7e543a256b4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harrisonsean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harrisonsean@google.com Change-Id: Ice64dc5ab4775adf58b4d648ec1b46d7917d936e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620481Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841998}
-
Rohit Agarwal authored
ToolbarDataProviderTest is a batch tests which keeps the ChromeTabbedActivity alive in between the tests. These tests also included CCT tests which launched CustomTabActivity on top of the existing ChromeTabbedActivity. In test environment, launching multiple Activities often results in Android killing the background process and all the Activities encapsulating it. This CL, therefore decouples the CCT tests from ToolbarDataProviderTest and move it to CustomTabActivityIncognitoTest. Bug: 1154445 Change-Id: If7a69773fb441d17439401fe2881a11d7a1c5eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621058Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841997}
-
Anton Bikineev authored
Bug: 11297512 Change-Id: If7e4e3dc494c36649fcc538bc858ffd7638f626b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565686 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add JS module for //ui/file_manager/file_manager/foreground/js/ui/table: - table.js - table_column.js - table_column_model.js - table_header.js - table_list.js - table_splitter.js NOTE: TableColumn.width property changed to be inline instead of Object.defineProperty() because the old cr.defineProperty() allowed to overwrite only the getter however using Object.defineProperty() doesn't allow it. Bug: 1133186,1134497 Change-Id: I0e3aea36240674ef055ebb75865f7d229bd3da84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619104 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841995}
-
Wei Lee authored
This reverts commit 94464131. Reason for revert: b/176770937 Original change's description: > [CCA] Only use CameraDialog for intents under clamshell mode > > For tablet mode, we should better use the regular way to launch CCA, > which means opening CCA in a Browser, rather than using CameraDialog so > that the size of the CCA can be fullscreen as well. > > Bug: b/175322338, b/175326967, b/174891007 > Test: tast run [DUT] camera.CCAUIIntent* > Change-Id: I39cecffb36e4d104253d74ffd9e44c6740a648b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596282 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838170} TBR=sky@chromium.org,shik@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/175322338 Bug: b/175326967 Bug: b/174891007 Change-Id: If6ffd5e3903b7e10174e05651ada687292289db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620823Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841994}
-
Fredrik Söderqvist authored
Bug: 1162628 Change-Id: I5fae5bd6c0b6d9cfb80f2b65778dfaa6f13291bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620562 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#841993}
-
Maya Lekova authored
This CL updates the expiry date and owners list of V8.TurboFanOptimizeNonConcurrentTotalTime to match the rest of the V8.TurboFan* group. Bug: chromium:1149511 Change-Id: I8ade45123a24a7afac7b90982b0635eea1f61418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606359Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#841992}
-
Frédéric Wang authored
In [1] a test was added to to verify trustworthiness of custom schemes. However, the ones using IsOriginPotentiallyTrustworthy fails because non-opaque origin must be a "standard scheme" i.e. follow [2]. This CL adjusts the tests to actually use a "standard scheme", which is closer the intent to test chrome-extension URLs. It also removes corresponding test from SecurityOriginTest, as it does work well with url utils [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2593629 [2] https://tools.ietf.org/html/rfc3986#section-3 [3] crbug.com/1163060 Bug: 1153336, 1163060 Change-Id: I3e7f1d91558a97b1722a742d89c514b984b56ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595424Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#841991}
-
Aya Elgendy authored
Fix a typo in the pin dialog error message which read "1 attempts left" instead of "1 attempt left" when the user has attempted incorrect pins and there's only 1 attempt remaining. This CL is the second attempt to solve the issue after being reverted in commit 7672be058caa26d14678f8b0d4a06de56c155309 due to an issue in the error message format of the SAML login. The first attempt only handled the normal login while this one handles both the SAML login and the normal login. Bug: 1060695 Change-Id: Ieac135c90ef6e20cf53bd26d2ab87cf0147c21a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599814 Commit-Queue: Aya Nader Elgendy <ayag@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841990}
-
Kim-Anh Tran authored
V8 change will remove sending along data urls with Runtime.CallFrame, Runtime.ExceptionDetails, and Console.ConsoleMessage. Bug: chromium:1132260 Change-Id: I2c0ca7deea0f6384ffcbeee62fb230aa9b61c4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621532 Auto-Submit: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c46f2cb69a6..4e3706155af8 2021-01-11 jacktfranklin@chromium.org Fix flakey data-grid-controller interaction tests on Mac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f9c448f4c789840f274da7807fac1d24348a4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620480Reviewed-by:
-
Roman Aleksandrov authored
Bug: 1151292 Change-Id: I318dcff8ec10a721844856ff089e59ef68f8a09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601484Reviewed-by:
-
Michael Lippautz authored
Bug: 1056170 Change-Id: If0f380fccf14c13a212f3101ad311f22d85f38a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616231 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Removes the following retain cycle: self-> animator-> animations block -> self Bug: N/A Change-Id: I614f6d81f328eed8e0707f87fa2a9065d00089ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617863 Auto-Submit: Javier Flores <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#841985}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35f78f4a4562..eddc7d0df5d 2021-01-11 primiano@google.com Merge "Minor changes to IPC layer in preparation for Win port." 2021-01-11 primiano@google.com Merge "Exclude platform_unittest.cc from chromium builds" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. Bug: b/174454879 Change-Id: I3742be0d1dcb50e4c76433cbfe3efdb60063f477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621057 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#841984}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b90eef09f60..ac05066a00a9 2021-01-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 28ecef43 to 29d2d6a2 (82 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I6ac969799e206c402a99874160f93d35cae736a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621044Reviewed-by:
-
Jeff Yoon authored
Coverage instrumentation adds symbols in a different order to what's expected. We don't need to check symbol order for coverage instrumentation, so we'll skip it for now. Bug: 1163903 Change-Id: I074365d0f8a85c513e0988e4452931903005cc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620000 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841982}
-
Benoit Lize authored
With PartitionAlloc-Everywhere, there are two partitions: one for malloc(), and one for posix_memalign() (and equivalent). mallinfo() reports data for both partitions together. However there is a suspicion that having two separate partitions may increase GPU process memory footprint. To break these down, separate the aligned partition data from the regular one. On Linux, this shows that browser and renderer processes don't have a lot of aligned memory, but the GPU process does. For instance, with a single CNN.com tab open, there is a ~50/50 split between the regular and aligned partitions, and the aligned partition uses a lot of address space as well, respectively 128MiB allocated, and 179MiB mapped. Note: this may change sizes for some malloc() metrics with detailed dumps. Bug: 998048 Change-Id: I29dd7a93515ef25736ea830ddf663e85b9e122a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617848 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#841981}
-
Alice Wang authored
This CL breaks the circular dependency chain between SigninUtils and SigninActivity by moving the method .launchActivityIfAllowed() from SigninUtils to SigninActivityLauncherImpl. Bug: 1163470 Change-Id: I99a98142d8a5b604b0ebf847449754f55952d03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612858 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3a0405597374..1670c5184b9e 2021-01-11 stha09@googlemail.com IWYU: add missing include for size_t If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I73e7b7be0bb5333d929abc689916c2832303c0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620466Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I8e50aadb524f698ea259995d6ff90a90918e7dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618678 Auto-Submit: Javier Flores <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8b83eaf..cd58c190 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I969e583e6fd9d2afee4c49ac8f70563f216c9947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620887Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841977}
-
arthursonzogni authored
Apply CheckedObserverAdapter::IsMarkedForRemoval() advise: ``` If |weak_ptr_| was invalidated then this attempt to iterate over the pointer is a UAF. Tip: If it's unclear where the `delete` occurred, try adding CHECK(!IsInObserverList()) to the ~CheckedObserver() (destructor) override. However, note that this is not always a bug: a destroyed observer can exist in an ObserverList so long as nothing iterates over the ObserverList before the list itself is destroyed. ``` I have absolutely no clue what is causing bug 1153966. All the observation are wrapped inside base::Scoped{Observation, Observer}, so this shouldn't happen in theory. However there are proof it happens in practice: https://crash.corp.google.com/browse?q=ReportID%3D%27e5305cdcd95db0cb Bug:1153966 Change-Id: I067ccdd4d0b34737ba54b31a6fb5b6b1a9d2e0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615346 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841976}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610333688-2ac90a21c191bd1ea4698597daab8949225692c9.profdata to chrome-win32-master-1610338418-0a30eb701be1732e98bc8c78e37a5b6340c67f55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2da0a88ba93da59bf56763f86941623b2b7ddbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621039Reviewed-by:
-
Wei Lee authored
After https://crrev.com/c/2602969, |OnDeviceClosed()| might be triggered from different threads. But in |OnDeviceClosed()|, it will access |camera_app_devices_| and might introduce race condition. Therefore, to fix it, we can post the task to make sure that |OnDeviceClosed()| will be called on the same thread. And since now we will not call |OnDeviceClosed()| directly and the mojo error handler of a receiver set might be triggered more than once, we should also handle it properly. Bug: b/177191321 Test: Consecutively passes CCAUISettings.swa for 20 times Change-Id: I93e546a98c410017f17071c97336bfe40dcc7b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619247 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#841974}
-
David Roger authored
This CL fixes a crash happening after creating a signed in profile when the policy is set. This CL also adds browser tests checking that the signin profile is appropriately marked and unmarked ephemeral, and correctly destroyed at startup if required. Fixed: 1164314 Change-Id: I078fbc127d42267261b305149aff10e71ac53b59 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617926 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841973}
-
Alice Wang authored
This CL removes the redundant callback argument used in ForcedSigninProcessor. Bug: 1045525 Change-Id: I980e972cca487eed4f0669ffa44d9b44da33ef6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620259Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 29d2d6a2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I0c802a57f9296950b98fe752c9df4a06368ac8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619683Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841971}
-
dpapad authored
Bug: 1028829 Change-Id: Ib72761c7cafa6ec574fafebaf39d4c38e23a31c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616970 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841970}
-
