GitLab

BUG=353233
TEST=fast/dom/shadow/ol-with-distribution-recalc-crash.html

Review URL: https://codereview.chromium.org/204343002

git-svn-id: svn://svn.chromium.org/blink/trunk@169615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes the code more readable as it makes it clear we are only traversing
children. This is also a bit more efficient as nextSiblingChildren() tries to
traverse the ancestors siblings when done with the current siblings.

R=esprehn, adamk

Review URL: https://codereview.chromium.org/196823006

git-svn-id: svn://svn.chromium.org/blink/trunk@169614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This refactors simplifies dependency resolution, and makes it easier to
extend.

Specifically:
* Move file handling into idl_reader
* Move actual definition and interface merging to methods on IdlDefinitions
  and IdlInterface (in idl_definitions)

This also clarifies exactly what's going on specially:
* we tack on some extended attributes to members
* we merge implemented interfaces to the main one

Other changes:
* use next() instead of looping over a one-element list
* remove useless exceptions (specific exception classes are only useful
  if we catch them, otherwise it's no better than a string)

This is to support a separate CL:
Bindings: inherit enums and callbacks from partial interface files.
https://codereview.chromium.org/203193015/

TBR=haraken
BUG=345137

Review URL: https://codereview.chromium.org/205873003

git-svn-id: svn://svn.chromium.org/blink/trunk@169613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes the fast/css/css2-system-fonts.html explicit about the
font styles expected on each platform instead of just Mac.
It also converts the test to be text only as the style information is
now displayed in text format.

This change is in preparation for a refactor of system font handling.

BUG=353932

Review URL: https://codereview.chromium.org/204113007

git-svn-id: svn://svn.chromium.org/blink/trunk@169612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes the promise resolution logic of FontFaceSet#load()
to match the spec [1], in the following ways:

1. Rejects the promise with SyntaxError if the font argument fails to
   parse.
2. Otherwise, the promise should be resolved in the same way as
   Promise.all() called with all of the results of FontFace#load() of
   the matching font faces, i.e.
2.1. Resolves the promise with an array of the matching font faces when
     all the fonts are loaded, or
2.2. Rejects the promise with the rejection value of the first failed
     font face.

The new ScriptPromiseResolver Vector overloads need NoInline version of
v8Array, since existing v8Array() uses toV8 inside and hence requires
generated headers (see crbug.com/321569 for details of a similar issue).

[1] http://dev.w3.org/csswg/css-font-loading/#font-face-set-load

TEST=fast/css/fontfaceset-load.html
BUG=53213

Review URL: https://codereview.chromium.org/196383035

git-svn-id: svn://svn.chromium.org/blink/trunk@169611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This separates the decisions about caching StyleSheetContents for <style> elements
from those related to <link> elements. This makes the code clearer as there are
fewer conditions that could cause uncacheability (for example, the StyleSheetContents
for <style> elements could never be for an @import rule).

And since the <style> cache is per-StyleEngine (and thus per-Document), the
<style> case can now safely cache stylesheets that include @media rules.
This speeds up the included performance test from ~90ms on my Z620 to ~50ms,
and improves the biggest block of chromestatus.com load performance by ~20%.

This patch also cleans up StyleSheetContents a bit, collapsing the maybeCacheable()
method into isCacheable() and making appropriate accessors const.

BUG=342507

Review URL: https://codereview.chromium.org/196133034

git-svn-id: svn://svn.chromium.org/blink/trunk@169610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of keeping a separate hash map we should just store this
information in the ElementRareData. This simplifies the implementation and
in practice will likely reduce memory usage since almost all custom elements
we've seen so far touch something that ends up making them use rare data like
childNodes, attributes, tabIndex, classList or dataset.

Review URL: https://codereview.chromium.org/177063004

git-svn-id: svn://svn.chromium.org/blink/trunk@169609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds test expectation fix.

BUG=

Review URL: https://codereview.chromium.org/204983002

git-svn-id: svn://svn.chromium.org/blink/trunk@169608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a bug where resources in element.animate() calls were
not being fetched. This resulted in StylePendingImages leaking out of
the style resolving stage and into rendering which causes a crash.

This patch fixes the bug by ensuring StylePendingImages introduced in
applyAnimatedProperties() will be resolved as non-pending StyleImages
through an additional call to loadPendingResources().
This patch also modifies AnimatableImage to be a wrapper of CSSValues
instead of StyleImages in order to follow the same resource caching
logic as typical CSS image values.
This patch also updates EffectInput::convert() to pass the document's
StyleSheetContents to MutableStylePropertySet::setProperty() so that
relative URLs are correctly resolved to absolute URLs.

This is a reland of https://codereview.chromium.org/196573030/ with
AnimatableImage::create() rewritten to not require an ASSERT.

BUG=353385

Review URL: https://codereview.chromium.org/196943029

git-svn-id: svn://svn.chromium.org/blink/trunk@169607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because setCanBeDragged(true) is never called, all the rest of the
dragging code becomes unreachable. The feature as such looks useful, but
it would require fixing and above all testing to interact well with text
track rendering.

BUG=341813
TEST=LayoutTests/media/ still passes, i.e. there were none!

Review URL: https://codereview.chromium.org/196533020

git-svn-id: svn://svn.chromium.org/blink/trunk@169606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implement support for computing and populating the GlyphOverflow
structure for the harfbuzz code path. The current implementation is a
straight copy of the current Mac implementation with minor
modifications to use the corresponding harfbuzz APIs.

R=dglazkov@chromium.org,behdad@chromium.org
BUG=354165
TEST=fast/text/international/repaint-glyph-bounds.html

Review URL: https://codereview.chromium.org/205553003

git-svn-id: svn://svn.chromium.org/blink/trunk@169605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Harfbuzz-ng 0.9.27 introduced a HAVE_ICU_BUILTIN define which makes the
hb_buffer_set_unicode_funcs call redundant. Also call
hb_buffer_clear_content instead of hb_buffer_reset which is faster now
that we no longer explicitly set the unicode functions.

BUG=354117
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/197213032

git-svn-id: svn://svn.chromium.org/blink/trunk@169604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=304341

Review URL: https://codereview.chromium.org/204673007

git-svn-id: svn://svn.chromium.org/blink/trunk@169603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Getting/setting these properties can depend on FrameLoaderClient, which
will be null if the frame containing the DOMWindow has already been
detached.

BUG=349956,352048

Review URL: https://codereview.chromium.org/203493005

git-svn-id: svn://svn.chromium.org/blink/trunk@169602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This further simplifies EventTarget bindings generation.

The goal (for now) is to only have a special case for the
{{hidden_dependency_action}}; everything else should be pretty easy
to eliminate (except maybe the ListenerFindOnly case).

The main change in this CL is making the argument handling regular.
(Also correctly handles EventListener as a callback interface.)

This also breaks up the big custom generation into smaller pieces,
so each piece can be eliminated separately.

Followup to:
Simplify EventTarget bindings generation
https://codereview.chromium.org/201603002/

R=haraken
BUG=345503

Review URL: https://codereview.chromium.org/203143002

git-svn-id: svn://svn.chromium.org/blink/trunk@169601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Rewrite platform headers in public/web/ to public/platform/... (https://codereview.chromium.org/189703002/)

Reason for revert:
Broke Windows, Mac, and ChromeOS build.


Original issue's description:
> Rewrite platform headers in public/web/ to public/platform/...
> 
> Includes of this style are more consistent with the rest of the project and
> easier to verify with DEPS. For consistency, includes in public/web/ of other
> headers in public/web/ are rewritten to list the public/web/ portion as well.
> 
> BUG=350097
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169597

TBR=abarth@chromium.org,jamesr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=350097

Review URL: https://codereview.chromium.org/205153006

git-svn-id: svn://svn.chromium.org/blink/trunk@169600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Made tests start failing

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html,inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html

Original issue's description:
> Remove WebInspector.HeapSnapshotArraySlice
> 
> Uin32Array already has subarray method that returns a new view for the same array buffer.
> 
> BUG=None
> R=alph@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169554

TBR=alph@chromium.org,loislo@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/205953002

git-svn-id: svn://svn.chromium.org/blink/trunk@169599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Includes of this style are more consistent with the rest of the project and
easier to verify with DEPS. For consistency, includes in public/web/ of other
headers in public/web/ are rewritten to list the public/web/ portion as well.

BUG=350097

Review URL: https://codereview.chromium.org/189703002

git-svn-id: svn://svn.chromium.org/blink/trunk@169597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Theres no reason to synchronously recalc style whenever you change the
media attribute of a <style>.

Review URL: https://codereview.chromium.org/205463002

git-svn-id: svn://svn.chromium.org/blink/trunk@169596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

StyleSheetContents cache works independent of document's active(),
because StyleElement::process() always invokes StyleEngine::createSheet().

So removeSheetFromCache should also remove 'this' from the cache independent of document's active().

BUG=353894
TEST=fast/dom/move-style-element-to-inactive-document-crash.html

Review URL: https://codereview.chromium.org/204423002

git-svn-id: svn://svn.chromium.org/blink/trunk@169595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=347902

Review URL: https://codereview.chromium.org/201083003

git-svn-id: svn://svn.chromium.org/blink/trunk@169594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS Regions code has been removed in r167275 so these performance tests
do not work anymore.

Review URL: https://codereview.chromium.org/205323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It appears that this never worked correctly. To implement,
I extracted the code we use to set initial value for document and
started using it when applying initial font-family value.

BUG=354110
R=eseidel,eae

Review URL: https://codereview.chromium.org/197213034

git-svn-id: svn://svn.chromium.org/blink/trunk@169592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use it in WebSocket.

BUG=339373
R=tyoshino, abarth

Review URL: https://codereview.chromium.org/201593002

git-svn-id: svn://svn.chromium.org/blink/trunk@169591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add isHTMLPlugInElement() helpers for consistency with other HTML elements.
Those helpers rely on the isPluginElement() virtual function to check if
an Element is an HTMLPlugInElement.

R=tkent, adamk
BUG=346095

Review URL: https://codereview.chromium.org/202153005

git-svn-id: svn://svn.chromium.org/blink/trunk@169589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderBlock::percentHeightDescendants() is used to schedule layout of
descencents of a block when the logical height of the block changes.
It should contain descendants having percent height whose real height
calculation depends on the height of the block.

Previously
- the set doesn't contain direct children;
- skipped containing blocks for percent height calculation unnecessarily
  have the set.

Let the set contain all necessary objects. This doesn't fix any
functional breakage for now, but later layout optimization may depend
on the correct behavior of the function.

BUG=327815
TEST=WebFrameTest.RenderBlockPercentHeightDescendants

Review URL: https://codereview.chromium.org/201153008

git-svn-id: svn://svn.chromium.org/blink/trunk@169588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169576

BUG=353934
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/205393003

git-svn-id: svn://svn.chromium.org/blink/trunk@169587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We actually never use it in a meaningful way.

R=eae,eseidel
BUG=

Review URL: https://codereview.chromium.org/195893047

git-svn-id: svn://svn.chromium.org/blink/trunk@169586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since r168759 we use bilinear filtering for animated images. There
are complaints about the drop in image quality. However we don't want to
spend a lot of CPU cycles doing high quality animations for upscaling.
This change is a compromise for animated images: we do a cheaper
mipmapping for downscaling and bilinear for upscaling. There is a
noticable quality improvement.

This change implements InterpolationMedium for GraphicsContext. It used
to be equivalent to InterpolationLow and is now a higher quality option.
All GraphicsContext::drawSomething() methods have |useLowQualityScale|
removed. This gives a much cleaner code.

I also discovered/fixed a couple small issues with interpolation levels:
* It is apparent now that InterpolationDefault means InterpolationHigh
  on desktop and InterpolationLow on Android.
* Default for canvas elements used to InterpolationMedium but it
  really meant InterpolationLow.
* There is a bug for rendering images in canvas that InterpolationNone
  should be used but it has been InterpolationLow all along. I didn't
  fix in this change but added a FIXME.

The new interpolation level does not affect non-animated images. There
is no need to rebaseline any pixel test. I added a test GIF file that
loops two identical frames. This is used to test the image quality.

BUG=353251

Review URL: https://codereview.chromium.org/201513003

git-svn-id: svn://svn.chromium.org/blink/trunk@169585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This changes GraphicsLayerPaintInfo::offsetFromSquashingCLM
from an IntSize to a LayoutSize and changes
SquashingState::offsetFromAbsoluteForSquashingCLM from an
IntPoint to a LayoutPoint. This also adds a
subpixelAccumulation field to GraphicsLayerPaintInfo; this
gets computed at the same time as
GraphicsLayerPaintInfo::offsetFromRenderer.

BUG=327387

Review URL: https://codereview.chromium.org/143283011

git-svn-id: svn://svn.chromium.org/blink/trunk@169584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The BasicShape ellipse and circle functions now report a syntax error
if the "at" keyword is not followed by a position.

The existing parsing tests have been updated to include this case.

Ported over from http://trac.webkit.org/changeset/165835

BUG=353774

Review URL: https://codereview.chromium.org/203413006

git-svn-id: svn://svn.chromium.org/blink/trunk@169583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Most of the code there was no-ops.

R=eae,eseidel
BUG=

Review URL: https://codereview.chromium.org/204963002

git-svn-id: svn://svn.chromium.org/blink/trunk@169582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=346399
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/203743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch ensures the compositing layers are up-to-date
when calling elementLayerTreeAsText and layerTreeAsText
from tests. Before, elementLayerTreeAsText had a
DisableCompositingQueryAsserts which this patch removes.
layerTreeAsText previously updated updateCompositingLayers
but that was not sufficient; this patch adds a tighter
assert and calls updateLayoutAndStyleForPainting to fully
update.

BUG=

Review URL: https://codereview.chromium.org/202523004

git-svn-id: svn://svn.chromium.org/blink/trunk@169579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
The essential part of the change is in HTMLImportsController.cpp.
Anything else is to make it work with redirect.

The problem here is that allowCredentials flag is held both
by ResourceLoaderOptions and ResourceRequest and these two
can go out-of-sync. This change tries to make them in sync.

Such a state duplication should be resolved eventually, but
that is another story.

BUG=348671
TEST=import-cors-credentials.html
R=dglazkov@chromium.org, japhet@chromium.org, abarth

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169496

Review URL: https://codereview.chromium.org/196043002

git-svn-id: svn://svn.chromium.org/blink/trunk@169578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change tells the HTML parser know that lifecycle callbacks,
that is triggered through Microtask checkpoint, can create resources that
blocks scripts.

It also streamlines the unblock notification from Document to the parser
into didLoadAllScriptBlockingResources(). Now both didRemoveAllPendingStylesheets()
and didLoadAllImports() checks resource readiness and invokes the unified notification.

TEST=custom-element-style-block.html
BUG=346408
R=dglazkov@chromium.org, dominicc@chromium.org

Review URL: https://codereview.chromium.org/202813002

git-svn-id: svn://svn.chromium.org/blink/trunk@169577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The repainting in this test is correct in all cases, but due to timing
issues the actual repaint rects are not consistent from run to run or
across platforms.

Therefore, remove any text output for repaint rects and leave this as
just a pixel test.

BUG=353934,345027

Review URL: https://codereview.chromium.org/204873002

git-svn-id: svn://svn.chromium.org/blink/trunk@169576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test is testing some paint-dependent behavior (see issue 353827)
and should behave identically whether or not testRunner.display() is
called.  However, without the testRunner.display() calling into paint,
it misses some invalidations that need to be there for correctness.

BUG=345027,353827

Review URL: https://codereview.chromium.org/197883025

git-svn-id: svn://svn.chromium.org/blink/trunk@169575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch cleans up InspectorStyleSheet after the InspectorStyleSheet
and InspectorStyleSheetForInlineStyle implementations were separated.
It does the following changes:
- remove InspectorStyleSheet.checkPageStyleSheet as it is never used
- inline InspectorStyleSheet.ruleIndexByRule
- inline method InspectorStyleSheet.ruleIdByStyle into InspectorStyleSheet.styleId
- introduce single implementation for lineEndings in InspectorStyleSheetBase
- eliminate method InspectorStyleSheetBase.reparsestyleSheet

BUG=341506

Review URL: https://codereview.chromium.org/203633003

git-svn-id: svn://svn.chromium.org/blink/trunk@169574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch unlocks the text autosizing multipliers when
the document has finished parsing. This is necessary
to avoid weird effects when layout changes significantly
during page load. Resetting multipliers allows for a fresh
autosizing pass to take into account the whole document.

In particular this patch fixes issues with overlines on
http://forum.xda-developers.com and partially addresses
inconsistent font size on www.drudgereport.com
(see referenced bugs for details).

BUG=346786,131566

Review URL: https://codereview.chromium.org/189113014

git-svn-id: svn://svn.chromium.org/blink/trunk@169572 bbb929c8-8fbe-4397-9dbb-9b2b20218538