- 24 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/55783c1d0403..a4ec0ef8e1b3 git log 55783c1d0403..a4ec0ef8e1b3 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 fmayer@google.com Merge "Read ModuleSymbols from trace." Created with: gclient setdep -r src/third_party/perfetto@a4ec0ef8e1b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I626b8e9029bb34335bdc5e0f3344c1a804bdd40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699291}
-
Javier Fernandez authored
This is a reland of a445d168.. The original patch has been reverted due to a performance regression, described in bug #1002700. Additionally, this patch solves some cases not covered by the original patch, specifically when using 'non-auto' values for the grid item's min-width property. It also provides additional regressions tests. Finally, the performance regression is solved by checking out whether the grid item needs layout before considering to clear the Override size. Original change's description: > [css-grid] Clear the override width for computing percent margins > > When calculating the min-content contribution of a grid item of an auto > sized grid track we must consider the grid item's margin. When the grid > item's area is indefinite, a percent margin is resolved to zero. > However, when performing a relayout, the percent margin may be solved > against the previously computed grid area, since the grid item has > already an OverrideContainingBlockLogicalWidth value. > > In order to re-compute the percent margin properly, we need to clear > the previously override value. It's important be careful of not > clearing the override value set during intrinsic size, since we need > it for the actual layout phase. Hence, we only reset the 'override' > value when we are executing a definite strategy. > > Bug: 834643 > Change-Id: Ib936b26bee1da76afbdc886eb775746e13d40988 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782840 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694849} Bug: 834643, 942811 Change-Id: Id6fdf52fab471ebefecb2c087c086faf0e3f5dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796323 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#699290}
-
Mikhail Khokhlov authored
This formatter takes serialized histograms from test artifacts, adds diagnostics to them and saves to a file. Ad-hoc values are not supported yet. Bug: 981349 Change-Id: Iab6cbf40d4e3ddc118603a4eaa38dc58a9ae8163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796670 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#699289}
-
Rika Fujimaki authored
Replace ScriptState* with Isolate* We replace SharedPersistent with WorldSafeV8Reference to remove persistent, and to ensure v8::Local<v8::Value> is world safe. (ref. V8Value()) We also replace ScriptState* with Isolate* because ScriptValue doesn't depend on context any more. Bug: 1000152, 998994 Change-Id: If232d1da9579cf73157e400bf0c40950b2f3a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787672 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#699288}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider. Bug: 955171, 978694, 936482 Change-Id: Iac89ba3a94f06af9ae87887d72bafc998bc0a768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816462 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699287}
-
Hans Wennborg authored
After the Python 3 conversion, there is now an extra space in the output. This shows the problem: >>> print "a\n", "b" a b >>> from __future__ import print_function >>> print("a\n", "b") a b Fix it by specifying sep="". TBR=thakis Bug: 1007195 Change-Id: I20fea51951d552fcffee4704bd515c54bb84ef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821598Reviewed-by:Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#699286}
-
Peter Marshall authored
Remove the toggled title from ToolbarSettingToggle which is not used by any caller. Remove optGroup from ToolbarSettingComboBox which is not used by any caller. Change-Id: I1a2849d090b458ba807bf7aa6d59f06b66b24821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817886 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699285}
-
Bo Liu authored
Loading "file://" on higher versions of android will simply hang instead of finish in an error, thus causing the test to fail. Presumably on higher versions with dynamic permissions, browser is waiting for user consent which is probably not implemented in content shell or tests. Change it to link to itself instead, which is guaranteed to work. Bug: 990854 Change-Id: I6501deb0899a4c99f4a917e5ee1fd6ae144cdff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817100 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699284}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media_router.mojom.MediaStatusObserver interface, and adapt unit tests. Bug: 955171 Change-Id: I264e9bf9df22cb7ffe6418a4513b4260b39ee7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813506 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
-
Richard Townsend authored
Bug: 1006732 Change-Id: If244b1ee9915b148d64ed62497a04736b191e0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819500 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
-
Miyoung Shin authored
This change converts ContactsManager mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I9fbce895d342faa2de8d9be6fa66d8198820f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815925Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#699281}
-
Morten Stenshorne authored
Reverting the fragment builder to an earlier state simply isn't supported. We used to remove line boxes from the fragment builder after having laid out too many lines. But this doesn't necessarily revert the builder to the exact state that it had prior to adding those lines. Case in point is when we discover and add out-of-flow positioned descendants among the lines that later on get deleted (see the test). We don't delete the out-of-flow descendants, so we'd end up with two identical fragments for the out-of-flow positioned box, one in the fragmentainer that it should occur, and also one in the preceding fragmentainer, where we laid out too many lines and then deleted them. We sometimes need to lay out more lines than we can fit in a fragmentainer, to figure out where to break in order to honor the widows requirement. The new approach is to do a full relayout of the container and stop at the correct line. This CL introduces a new type NGEarlyBreak, which is currently a glorified int, but it will soon be extended to also support 'avoid' values for the break-before and break-after properties. Bug: 829028 Change-Id: I2d1bc5d51dc43360cbff17401d39d65613dea4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819249Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#699280}
-
Gauthier Ambard authored
From my tests, it seems that the file:// URL can only access files that are stored in the app folder. For now the only folder we have is emptied every time the app is launched, so storing the URL in the history don't make sense as the user won't be able to revisit them. Bug: 1003234 Change-Id: I7b5795009b0f5ddb2fb68f4eb4df476ddfe89b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803148 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699279}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d625bfe6e8a..3c049a34714d git log 6d625bfe6e8a..3c049a34714d --date=short --no-merges --format='%ad %ae %s' 2019-09-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 605c2e3c0ea7..3a762d54f649 (15 commits) Created with: gclient setdep -r src/third_party/angle@3c049a34714d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: Ifa483c3fe9b40c3d10a00e8503349295a0a02efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819795Reviewed-by:
-
Nazerke authored
This CL is moving crash_loop_detection_util* files from ios/chrome/browser/ to ios/chrome/browser/crash_report/. Bug: 973040 Change-Id: Ie741c0bc71a0b05b58d9807750479a11eb9f6889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813310 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#699277}
-
Jan Krcal authored
This CL adds metric recording for bookmark guid migration also in the encrypted data branch. This makes the code symmetric and thus easier to refactor in follow-up CLs. The metric got introduced recently so it is okay to change it without renaming (given that custom passphrase users will influence it very little). Bug: 1007199 Change-Id: Iecb6276cbe3681b57f39d40ffdf7f27ad4839f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818485 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#699276}
-
Mugdha Lakhani authored
and add a unit test to verify the same for when Google Play Services is up to date on the device, vs. when it's not. Change-Id: I36e7df61e4549af57b3fc275356878ed826dd7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819245 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#699275}
-
Hans Wennborg authored
TBR=thakis Bug: 1007195 Change-Id: I8280152158f63cfa2e3ad550eca726036b578506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820801Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca2ef4313b40..dc1ab03f429d Created with: gclient setdep -r src-internal@dc1ab03f429d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibcf12a2664e7582cd888c3bf0e60620792516254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820957Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699273}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/53ffaae2b80a..8de7737d65f3 git log 53ffaae2b80a..8de7737d65f3 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 vapier@chromium.org licensing: improve handling of utf-8 content Created with: gclient setdep -r src/third_party/chromite@8de7737d65f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iffe312de6419f2036ae5cf9691a4e075b74afacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820958Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts PhishingModelSetterRequest to new Mojo types using PendingReceiver. Bug: 955171 Change-Id: If10ec71ba4773c208fd02f4ba2ff58347551ff3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816478 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#699271}
-
David Jean authored
Measure browser and render generated page load running time through UMA. Bug: 996682 Change-Id: Ie6f6445ace8ea77285d819434ec8a0d541f9411b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760799 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699270}
-
arthursonzogni authored
Add: Navigation.IsSameSiteInstance.MainFrame Navigation.IsSameSiteInstance.SubFrame Modify: Navigation.IsSameBrowsingInstance Refactor the function RecordReadyToCommitNavigation(). --- This will help understanding the effects of the experiment: ProactivelySwapBrowingInstance. The histograms previously introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/1776050 needs to be broken down by frame type. Either main frame or subframe. That's why the histogram Navigation.IsSameSiteInstance has been broken down. Navigation.IsSameBrowingInstance was recorded on every navigations, even on subframe navigations where is was guaranteed to be same-BrowsingInstance. After this CL, it is recorded only on main frame navigations. Here, the histogram is simply modified instead of being replaced. The histogram is new (78.0.3905.0 Canary) and I don't expect any other teams to have used it yet. Bug: 977562 Change-Id: I346e66628202903a1eaf98175d5baac1bfdfe445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810526 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This change converts HidService mojom interface client in blink to use BrowserInterfaceBroker, and add BrowserInterfaceBrokerForTesting for unit tests in RenderFrameHostImpl. Bug: 936482 Change-Id: I8c744fde2cb03288d2546bf84d57f4ed4ff391ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816481Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media_router.mojom.MediaRouteProvider interface, and adapt unit tests. Bug: 955171 Change-Id: If4f84d7fe3bb48e49301667bbec1853a243a40e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813322 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Hiroki Nakagawa authored
WebServiceWorkerContextClient::WorkerContextFailedToStartOnInitiatorThread() is no longer necessary. Off-the-main-thread service worker script fetch removed the path where service worker startup fails before starting a service worker thread. Bug: 1005650 Change-Id: I090c97a020ec19ef95a3e402a0d7382407b3607b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820917Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699266}
-
Mikel Astiz authored
If the cryptographer initialized but has pending keys, the whole content of the Directory will be reencrypted when pending keys gets resolved. Hence, let's simplify the logic and store the data unencrypted meanwhile. Avoiding special-treatment for this case unblocks redesigning a simpler cryptographer API. Bug: 967417 Change-Id: Ib3894bb454dbe2a0d877e7c06e5186f59806d3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819250Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#699265}
-
Nick Harper authored
Change-Id: Ie1aca62f670229dfc6749547d2306908044dca97 Bug: 994899, b/141000720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820021 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#699264}
-
Chih-Yu Huang authored
Originally V4L2SVD tried to decode new buffers after any error occurs, i.e. at |kError| state. In this CL, we only handle the decoder request at |kDecode| state. BUG=b:140842667 TEST=run video_decode_accelerator_tests on Kevin Change-Id: Ib785b5d1e51a1489ce1340b03e2b10c2d1b45a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818011Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699263}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c096654fa7c6..867ab81687fc git log c096654fa7c6..867ab81687fc --date=short --no-merges --format='%ad %ae %s' 2019-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a905cbcdc21b..6d625bfe6e8a (3 commits) 2019-09-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 82de2e61..a76152f4 (372 commits) 2019-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1f89f58faeb8..e3a5983705da (1 commits) Created with: gclient setdep -r src/third_party/skia@867ab81687fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: If8425a2f3e1a54fe34eef0c4085c4923626da3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819856Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts PhishingDetectorPtr and PhishingDetectorRequest to new Mojo types using Remote, PendingRemote, PendingReceiver, Receiver, and ReceiverSet. Bug: 955171 Change-Id: I394157125a31492bbef3d93b6e86f434b45c5408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816241Reviewed-by:
-
Mihai Sardarescu authored
A regression was introduced in CL https://chromium-review.googlesource.com/c/chromium/src/+/1645229 when the list of accounts stored in pref |kSigninLastAccounts| was not correctly updated when the application enters foregound. This CL restores the old behaviour and stores the accounts seen in Chrome each time the application enters foreground. It also ensures that the have accounts changed state is not updated when the identity list changes while the application is in foreground. Bug: 1006717 Change-Id: Idc80947180b08bd7fa1e6ba7b72067604848ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819247 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#699260}
-
Ivana Zuzic authored
This reverts commit 6c35d28d. Reason for revert: If there's multiple credentials in the password list and one is edited, the rest of the credentials disappear and only the one that was edited stays in the list. That shouldn't be happening and needs to be corrected before landing this CL. Original change's description: > [PWD Editing Android] Save changes through PasswordEditingDelegateProvider > > PasswordEntryEditor saves changes for a credential record when the > Save button is clicked through PasswordEditingDelegateProvider. > > Bug: 377410 > Change-Id: I200e4702945212b847488835a04fad3e5581b139 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807308 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Ivana Zuzic <izuzic@google.com> > Cr-Commit-Position: refs/heads/master@{#698945} TBR=fhorschig@chromium.org,izuzic@google.com Change-Id: I5ce2e43b226ed47b49dfc069e0e9100b8598567b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 377410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820997Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#699259}
-
Colin Blundell authored
We are in the process of clarifying the use cases and usage model of FakeProfileOAuth2TokenService within the IdentityManager test infrastructure. This CL eliminates the FakePO2TS constructor that takes in a ProfileOAuth2TokenServiceDelegate, leaving only the one that internally creates a FakePO2TSDelegate. It turns out that there is no longer any usage of the constructor being eliminated here. Bug: 982751 Change-Id: If3dec3754887a62ef9564e50b64f0d8192907723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819313Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bc646eee208f..f2690a15b706 git log bc646eee208f..f2690a15b706 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 nisse@webrtc.org Delete unused method SendSideBandwidthEstimation::UpdateReceiverBlock Created with: gclient setdep -r src/third_party/webrtc@f2690a15b706 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ied91b810c918099eb544df3668376fd8c11509be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819794Reviewed-by:
-
David Roger authored
Until this CL, the Dice migration was blocked on the token migration. Now, if there are still pre-dice tokens when the dice migration happens, they are deleted. It has been more than a year since tokens are being migrated. There are still a few token services which were not migrated (most likely because they are corrupted or the encryption key has been lost). Bug: 1006669 Change-Id: Id4bf3e28c8386095ec98cc12cddbacb243f4f77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819310Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699256}
-
Vadym Doroshenko authored
This metric shows whether all password field values in a submitted password form came from JavaScript. This metric is useful for estimation ration of submissions that were facilitated by extensions. Change-Id: Id10152b9fc0f0402e6406fe4a578d21b065b552a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814017Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media_router.mojom.MediaRouter interface, and adapt unit tests. TBR=benwells@chromium.org Bug: 955171 Change-Id: I5290d977ce94e2be5efb00c8b5dd89bf74230b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813340 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome::mojom::ProfileImportObserver interface. Bug: 955171 Change-Id: I4a3bc9ed524a0962d1f87913f2dbeb27175bf425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816562Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds support for fading out text of LabelButton using AnimatingLayoutManager. Concretely, when ShrinkDownThenClearText() gets called, the button reports a new desired size without it's label. The AnimatingLayoutManager can then resize the button using an animation to its newly desired size while the label is still (partially) visible. Once the animation is finished, the button clears its label. This CL directly makes use of this functionality for ToolbarButton. Bug: 1002160 Change-Id: Id2569d4c58497ccb3198ca70a01cc2d7eb270a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810977 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699252}
-
