- 18 Aug, 2012 26 commits
-
-
xiyuan@chromium.org authored
- Pulse app list button while LauncherModel has STATUS_LOADING; - Remove LauncherItemStatus::STATUS_IS_PENDING etc since it is no longer needed; - ChromeLauncherController sets LauncherModel::STATUS_LOADING on starting and watch for sync finish and pending extension install. It sets LauncherModel::STATUS_NORMAL when sync is finished and there is no pending extension install from sync, or when a maximum 60 seconds timeout since turning on loading status; BUG=129236 TEST=Verify sync animation after OOBE. Review URL: https://chromiumcodereview.appspot.com/10829268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152221 0039d316-1c4b-4281-b951-d872f2087c98
-
markusheintz@chromium.org authored
BUG=140450 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152220 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This make GDataContactsService report failure after getting more than two 5xx errors while downloading a particular contact's photo. I'm doing this so we don't keep pounding away indefinitely if the server is having trouble. BUG=128805 TEST=none Review URL: https://chromiumcodereview.appspot.com/10829398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152219 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
No real changes, just adds a DCHECK() and unit test for a minimum alignment that callers can count on from Map(). Map() is already returning addresses which are aligned to the platform page size. Necessary for a media use case in which a wrapped shared memory object is passed around and is expected to have a certain alignment. BUG=none TEST=unittests, try bots. Review URL: https://chromiumcodereview.appspot.com/10827400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152218 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
Several tests were renamed from ExperimentsHelperTest.* to VariationsHelperTest.*. This updates unit_tests_disabled accordingly, and should fix the android_test try bot. Review URL: https://chromiumcodereview.appspot.com/10860021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152217 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=142729 Review URL: https://chromiumcodereview.appspot.com/10824339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152216 0039d316-1c4b-4281-b951-d872f2087c98
-
https://chromiumcodereview.appspot.com/10824257tedchoc@chromium.org authored
Android does not have URLBlacklist as it does not support ENABLE_CONFIGURATION_POLICY TEST=build unit_tests BUG= Review URL: https://chromiumcodereview.appspot.com/10834380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152215 0039d316-1c4b-4281-b951-d872f2087c98
-
clintstaley@chromium.org authored
UI snapshot: http://imgur.com/js4nc Review URL: https://chromiumcodereview.appspot.com/10820031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152214 0039d316-1c4b-4281-b951-d872f2087c98
-
rdsmith@chromium.org authored
This CL is a re-land of http://codereview.chromium.org/10799005, which was reverted due to test flakiness. BUG=123998 R=benjhayden@chromium.org TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10836293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152213 0039d316-1c4b-4281-b951-d872f2087c98
-
stevet@chromium.org authored
BUG=None TEST=No user-visible changes. Review URL: https://chromiumcodereview.appspot.com/10832371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152212 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Original CL: http://codereview.chromium.org/10829131/ BUG=142669 Review URL: https://chromiumcodereview.appspot.com/10831380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152211 0039d316-1c4b-4281-b951-d872f2087c98
-
palmer@chromium.org authored
BUG=142956 TEST=Create an X.509 certificate with a CN field that contains JavaScript. When you get the SSL error screen, check that the HTML + JavaScript is escape instead of being treated as HTML and/or script. Review URL: https://chromiumcodereview.appspot.com/10827364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152210 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Even having it in trunk breaks gtalk. Restored old flag for turning on browserless panels temporarily. BUG=143506 TEST=ensured browserless panels off by default Review URL: https://chromiumcodereview.appspot.com/10831383 TBR=jennb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10836325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152209 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
BUG=None Review URL: https://chromiumcodereview.appspot.com/10832378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152208 0039d316-1c4b-4281-b951-d872f2087c98
-
dfalcantara@chromium.org authored
There were some disconnects in the pipeline that prevented the user agent override string from being saved and restored from the temporary tab structions in sessions/, but couldn't be tested on Android because the pathways weren't being exercised in the same way. This CL finishes hooking it up for ChromeOS (and presumably the other platforms). BUG=140600 Review URL: https://chromiumcodereview.appspot.com/10827168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152207 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
the culprit is innerHtml assignment. Instead, treat the text as text and create spans with createElement. BUG=142964 Review URL: https://chromiumcodereview.appspot.com/10837295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152206 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152205 0039d316-1c4b-4281-b951-d872f2087c98
-
aruslan@chromium.org authored
Enable the PromoResourceService tests on Android testbots and make sure they don't fail due to incorrectly set time on the testbot devices. BUG=139642 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10837074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152204 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
TBR=epoger@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10825356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152203 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Added support for dumping pixel results, and signalling the server that we're ready. BUG=111316 TEST=none Review URL: https://chromiumcodereview.appspot.com/10824351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152202 0039d316-1c4b-4281-b951-d872f2087c98
-
jennb@chromium.org authored
Even having it in trunk breaks gtalk. Restored old flag for turning on browserless panels temporarily. BUG=143506 TEST=ensured browserless panels off by default Review URL: https://chromiumcodereview.appspot.com/10831383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152201 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=125846 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152200 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152198 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
Intended for the beta channel. BUG=143505 TEST=none TBR=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10857064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152197 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10825426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152196 0039d316-1c4b-4281-b951-d872f2087c98
-
karen@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152195 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Aug, 2012 14 commits
-
-
pkotwicz@chromium.org authored
Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory> instead of std::vector<unsigned char> Bug=138553 Test=Compiles R=michaelbai TBR=sky Review URL: https://chromiumcodereview.appspot.com/10831341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152193 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
BUG=143440 Review URL: https://chromiumcodereview.appspot.com/10857066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152192 0039d316-1c4b-4281-b951-d872f2087c98
-
alexeypa@chromium.org authored
In order to call SendSAS() successfully the calling process's binary has to: - be signed. - be installed under %ProgramFiles% or %SystemRoot%\system32. - specify uiAccess='true' in the manifest. - run under SYSTEM or the currently logged-on user. All of those requirements are met now, so SendSAS() can be called directly. BUG=135217 Review URL: https://chromiumcodereview.appspot.com/10836224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152191 0039d316-1c4b-4281-b951-d872f2087c98
-
jennb@chromium.org authored
Need to get window.open() working for browserless panels before baking in canary/dev. BUG=143506 TEST=None Review URL: https://chromiumcodereview.appspot.com/10829402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152190 0039d316-1c4b-4281-b951-d872f2087c98
-
jennyz@chromium.org authored
BUG=142716 Review URL: https://chromiumcodereview.appspot.com/10827388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152189 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Also suppress two warnings in third_party targets. gyp changes reviewed by willchan in http://codereview.chromium.org/10832369/ BUG=141532,138571 TBR=hans,willchan Review URL: https://chromiumcodereview.appspot.com/10827405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152187 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
beginSmoothScroll tries to do a simple animation for a given length in seconds, specified as a double. To do a half-second animation, it did base::TimeDelta::FromSeconds(0.5). base::TimeDelta::FromSeconds takes an in64, so this silently converts to FromSeconds(0) causing the smooth scroll to do exactly one step and stop. Review URL: https://chromiumcodereview.appspot.com/10825407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152186 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
Submitting http://codereview.chromium.org/10823397 for chrisphan. Also removed DOS line endings that seem to have been unintentionally introduced in a previous CL. BUG=143010 Review URL: https://chromiumcodereview.appspot.com/10832381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152184 0039d316-1c4b-4281-b951-d872f2087c98
-
sreeram@chromium.org authored
See bug link. The test flakiness is because of being randomly selected into a suggest field trial that causes the Google-returned suggestion to be ranked above the what-you-typed entry. This CL attempts to disable the suggest field trial by forcing a specific group (which at the moment doesn't have any experimental behaviour). BUG=143308 R=mpearson@chromium.org,nirnimesh@chromium.org TEST=This test should no longer flake on the bots. If it does, then it's likely that group #10 has been selected into a field trial. The fix would be to disable the suggest field trials properly (as mentioned in the TODO). Review URL: https://chromiumcodereview.appspot.com/10860022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152183 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
Also remote tabs that crept into the remoting.gyp file. Review URL: https://chromiumcodereview.appspot.com/10829327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152182 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
It just makes debugging difficult BUG=111316 TEST=none Review URL: https://chromiumcodereview.appspot.com/10857057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152181 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
You can now drag tabs in and out of windows in linux_aura builds. This patch has a lot of moving parts and caveats though. Moving parts in the patch: - Added system location to aura::Events. - Forwarding move events from RootWindowHostLinux to the TabDragController through an observer. - MessagePumpAuraX11 now can block waiting for a window to be mapped. If we don't do this, we can't perform a grab on the new window. - The drag offset is threaded from TabDragController through the WindowMoveController interface. (There's no other non-racey way of getting this data locally from X.) - RootWindowHostLinux now has working Show()/Hide(). TODOs: - After releasing a new window, the window looks focused, but isn't. You have to click on it for it to receive input focus. BUG=133059 TEST=none Review URL: https://chromiumcodereview.appspot.com/10828133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152180 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Adds missing parameter to FactoryGetFieldTrial() and changes group id values to not use kConstant naming convention since their values are dynamic. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10824353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152179 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=None Test=None TBR=sadrul Review URL: https://chromiumcodereview.appspot.com/10857060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152178 0039d316-1c4b-4281-b951-d872f2087c98
-