- 08 Sep, 2020 40 commits
-
-
Tarun Bansal authored
Change-Id: I3dace6defe908221b2f0783d8bc1cca6a4a6ffd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391286Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805030}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6f29c57c715c..c107c7e93630 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaa5ad35519b3988b316663b05c906fd448ec3791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805029}
-
Ian Struiksma authored
Add trybot config for "Win10 Tests x64 1909". Need to test rebaselining before promoting the win version Bug: 990885,1125612 Change-Id: Id722ed9a8a841dabce21cd5694186a6cbe0fc281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397660Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#805028}
-
Sunny Sachanandani authored
SkiaRenderer is strict about ensuring that the resource format passed in to the display compositor via TransferableResource, which is used to create the GrSurfaceProxy, matches the underlying SharedImageBacking's format which is the GrSurfaceBackend. In the context of DrawingBuffer this means that for low latency mode, the ExternalCanvasResource must have the same format as the shared image or swap chain. One problematic case is RGBA8 vs BGRA8 because the default CanvasColorParams() used when creating the resource uses the platform specific default for Skia, which is based on endianness, to determine the format passed to the display compositor. To solve this problem, this CL adds the shared image resource format to ColorBuffer, and makes it the source of truth for all places that need the format in DrawingBuffer. In particular, the CanvasColorParams is constructed to match the underlying resource format instead of relying on the defaults. Bug: 1122638 Change-Id: I8c4e93d7f08566e695a3948505f98541d55b7216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391410 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805027}
-
Xianzhu Wang authored
We don't support non-composited backdrop-filter. This CL allows a foreignObject with backdrop-filter to be composited with CompositeSVG. Not ready to support backdrop-filter for all SVG elements yet because for now backdrop-filter requires a PaintLayer. Bug: 1125307 Change-Id: I85a0dddab250d0695a6d91ba80ee4c64c45ee934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396655Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805026}
-
Zhaoliang Ma authored
As mentioned, this CL set the default bitrate based on image size instead of setting a fixed value. Bug: None Change-Id: I694f71f5fef64165ef15f4f8d07012485297e2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389261 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#805025}
-
Andrey Kosyakov authored
... previously broken by https://chromium-review.googlesource.com/c/chromium/src/+/2377666 Bug: 1008939 Change-Id: I5d01b09e757328c3a40836d2633e5e0526a3d8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399118Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805024}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7f6cd0ad669b..9dd5f6257f3e 2020-09-08 pasko@chromium.org device_utils: Update permission denylist with QUERY_ALL_PACKAGES If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1117184 Tbr: rmhasan@google.com Change-Id: I725ac4e4afd54311503e418c1d13f9e9b4f66bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398813Reviewed-by:
-
Christopher Cameron authored
Prior to crrev.com/804584, the code to select AVCaptureVideoDataOutput's pixel format looked like it might select PIXEL_FORMAT_MJPEG (aka dmb1 aka kCMVideoCodecType_JPEG_OpenDML), but it actually would always select PIXEL_FORMAT_YUY2 (aka yuv2 aka kCMPixelFormat_422YpCbCr8). And it turns out that PIXEL_FORMAT_MJPEG doesn't work. So let's make sure we don't select it. There remains a hunch that MJPEG will be the most efficient capture format, and we should evaluate doing the decode and conversion ourselves. Bug: 1124884 Change-Id: I04473b117c05ccadbdd3226badac20656d6241a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399238Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#805022}
-
Kyle Milka authored
Prompt the user to grant storage permission when saving a screenshot. http://screen/Avbsig9wehami4s.png Bug: 1093368 Change-Id: I56e959def91f3ada843ef810bea8a2daebf259c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378584 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805021}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e8358a4dead..9d7944292456 2020-09-08 fmayer@google.com Merge "Add package name to list of example processes." 2020-09-08 fmayer@google.com Merge "Clarify that heap_profile needs ADB." 2020-09-08 treehugger-gerrit@google.com Merge "metrics: Expose available metrics in a builtin table" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I33d7e012eac1d352c9eebde7e62045792935c4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399061Reviewed-by:
-
Ana SollanoKim authored
Added two web tests: 1. Small legend large border: At this time, the legend is treated as monolithic and the borders are not breaking as well. As a result, the border goes past the fragmentation line in the first and last columns. 2. Large legend small border: Similarly, the legend goes past the fragmentation line in the first column. The fieldset breaks when it reaches the fragmentation line in the second column. Deleted the update of the border block start value as it's no longer useful to calculate new offsets in the fieldset. This change in the code does not affect the two new web tests. Bug: 829028 Change-Id: I1746c9da67372f4a42ab7ab8c4184460814f486d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391217 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805019}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0ee2b2ab51b..76c7a195fd79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chcunningham@google.com,zmin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: chcunningham@google.com,zmin@google.com Change-Id: Idf71274c5c99611e122c2d3fe70f492fdfe71cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398812Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805018}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 43 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-07. TBR=chromium-metrics-reviews@google.com Change-Id: Iabaf998e91898cddc494e2b0861c9d397e37672b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399039Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#805017}
-
Reilly Grant authored
This change adds checks to the platform-specific implementations of Read() and Write() to make sure that the file descriptor is valid before. This makes the assumptions validated by later DCHECK correct. This cannot be done in the platform-independent layer because test code depends on being able to call some SerialIoHandler methods without an actual file descriptor. Bug: 1121836 Change-Id: If182404cf10a2f3b445b9c80b75fed5df6b5ab4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393001Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805016}
-
Ahmed Fakhry authored
BUG=1116137 TEST=Manual Change-Id: Ifdf59fb05064b8902a3d8562f8523c2b186c6b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393014 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#805015}
-
Aaron Leventhal authored
Bug: 1125186 Change-Id: Ia64dae63a0cd53003187597aaf59a3e64c94fba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398951Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805014}
-
Matt Menke authored
https://chromium-review.googlesource.com/c/chromium/src/+/2392995 removed URLRequestJobManager, its only remaining consumer. BUG: 354158 Change-Id: Iaed0be3b2f2b05957b68045bb0e623a3c1abeba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392996 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805013}
-
Eugene But authored
This is a follow up to crrev.com/c/2376723 which adds various memory usage metrics. According to Apple, apps get terminated by the OS if memory usage in background goes above 50 MBs. This CL adds a new metric to track memory usage when app got backgrounded to learn more about memory usage patterns. Bug: 1122181 Change-Id: If3a5f4ebb4dcc172607b2126e84b75e018d3ac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387080Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#805012}
-
Xida Chen authored
This CL changes a local variable in animation.cc to use base::Optional<double> so that it removes a usage of blink::NullValue. Bug: 791086 Change-Id: Ie82180b853efefb5e0f409c8c17d855c69bd9c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393072Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805011}
-
Kyle Horimoto authored
PhoneHub will be utilizing BleScanner to understand when a device is in proximity before attempting a connection via Nearby Connections. Thus, the BleScanner class must support multiple observers (one for the existing use case used by Instant Tethering and Smart Lock), and one for the Phone Hub case). BleScanner previously had a Delegate pattern which allowed only one listener for when BLE scans were picked up, so this CL converts this code to an Observer pattern which supports the new use case. For now, BleConnectionManagerImpl is still the only observer; a future CL will add an additional one. Bug: 1106937 Change-Id: I0dd3cea3d0f050d8caeb82784ed6193821ff657d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393258 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805010}
-
Elly Fong-Jones authored
Replaced with use of setters everywhere in the codebase and removed. A followup CL will remove overrides of GetWindowIcon, then have ShouldShowWindowIcon be implied by whether a non-null icon is set and remove calls to SetShowIcon. Bug: 1075649 Change-Id: I39a905bb0a06b591fd35413359f31fccdceeeaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392937 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805009}
-
Owen Min authored
The AutoplayMutedNotificationTest#testUnmutedPlaybackTakesAudioFocus is flaky on Marshmallow, disable the test. Bug: 1122185 TBR: mlamouri@chromium.org Change-Id: I171e567262296c221c1521d1154b1d87448a3fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399003Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805008}
-
Yuheng Huang authored
This is a reland of d4c213d3 Original change's description: > Remove INVALIDATE_TYPE_LOAD and INVALIDATE_TYPE_TAB on WebContentsImpl::LoadStateChanged() > > Since WebContentsImpl::DidStartLoading/DidStopLoading is already sending > NotifyNavigationStateChanged(INVALIDATE_TYPE_LOAD) by way of > LoadingStateChanged, it's no longer necessary to send this out in > WebContentsImpl::LoadStateChanged. This change can reduce the number > of call of TabStripModelObserver.TabChangedAt with TabChangeType.kAll > a lot to increase performance throughout the browser > > Bug: 1112496 > Change-Id: I96d8942d7e1ebd5ffc8b3f3389497936f62848c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357960 > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798852} Bug: 1112496 Change-Id: I19b697d515cb56088a5dde836d51c7d5cf3c54b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393155Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805007}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6f29c57c715c..6b0afc48ae3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibbb9977e68f2de024cd77dcbfa9a95218e632bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398887Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9218ba277ab5..72d35030231e 2020-09-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I028fb26d8c6e5f962475845d69f27d3df5a4bf67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398816Reviewed-by:
-
Mirko Bonadei authored
Bug: None Change-Id: Icce93899dc2772432ee4df0671191998cf273ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390742Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#805004}
-
Andrew Xu authored
Currently the multipaste menu item is notified of the selection update by Button::StateChanged(). However, when the mouse moves from one delete button to another one, the button state of the main button where the mouse exists does not change: it keeps NORMAL since the delete button is hovered. As a result, in this case the menu item who loses the selection fails to hide its delete button. This CL utilizes the property change callback to update the delete button's visibility depending on the selection state. Bug: 1112888 Change-Id: Idc711f95da53157cf37e8ccd5034be08e324a3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388712Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805003}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7e3252b4439a..4b505928d537 2020-09-08 tvanderlippe@chromium.org Update CodeMirror to 5.57.0 2020-09-08 jacktfranklin@chromium.org Update lit-html to 1.3.0 2020-09-08 tvanderlippe@chromium.org Remove skip_rollup 2020-09-08 tvanderlippe@chromium.org [globals] self.UI.shortcutRegistry 2020-09-08 tvanderlippe@chromium.org [globals] self.Persistence.persistence 2020-09-08 tvanderlippe@chromium.org [globals] self.UI.shortcutsScreen 2020-09-08 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewController.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320,chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I702da061a1b0097adc3a18c4b2017b9f1f8df050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398807Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 177 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-07. TBR=chromium-metrics-reviews@google.com Change-Id: I314b173a2f32f881cb12d3968823b60a5d50e276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399040Reviewed-by:
-
Owen Min authored
The FullscreenControllerInteractiveTest. TestTabDoesntExitMouseLockOnSubFrameNavigation is flaky on win10_chromium_x64_rel_ng. Disable the test. Bug: 1124492 TBR: thakis@chromium.org Change-Id: I0cf69bbbcaf8305111ee2f4d25301677335e6582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399005Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Xing Liu authored
If the the date picker or time picker are dismissed without negative button clicked. The dialog flow is leaked that any following downloads will not show dialogs due to DownloadLocationDialogResult.DUPLICATE_DIALOG. Bug: 1125066 Change-Id: I1fc54941fdd8486e3346b0f3dca670bf5f5316ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394717Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804999}
-
Yusuf Sengul authored
Bug: 1124834 Change-Id: I659d866ed4e697bc189edd35789b2179c6d913ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392774Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#804998}
-
Adithya Srinivasan authored
Fix was landed in https://crrev.com/c/2159599. Bug: 1069487 Change-Id: I88088ea07b76014e2cdb8c01ca0385f39470de10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388480 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#804997}
-
Daniel Hosseinian authored
Make the method friendlier to other callers. Change-Id: Ied53accfacf02ac7d3f59d45b31cdc7fd2c34709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393519Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#804996}
-
sczs authored
Previously there were some cases where there was no parentVC on dealloc, which caused the KVO observing from not being removed in some cases. This CL adds a BOOL for tracking to make sure the KVO observing stops on dealloc if needed. Bug: 1108794, 1085419, 1122031 Change-Id: Ifdfe268658fe90386f3ceb6c202d208bd431ef62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398398Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#804995}
-
Elaine Chien authored
Bug: 1044687 Change-Id: Iaa6e84f3d71382a0f783ddabcdb1383203f473e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391900Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#804994}
-
Mohamed Amir Yosef authored
Bug: 852356 Change-Id: I360bb3e3e1c91c42f4e12d724508fc2614ae9624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398679 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804993}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkChooseMobileTest* Change-Id: I4111a4cb0f13daf67ea51145b8f186a2b8b7ea02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392018Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#804992}
-
Nicholas Hollingum authored
Sine ScrollEvent is a subclass of MouseEvent we also need to check it here. I forgot to do this in the previous CL. Bug: 957455 Change-Id: I40f2a65d51dde010c593712105e4d4d6ee2eb1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397175 Auto-Submit: Nic Hollingum <hollingum@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804991}
-
