- 25 Mar, 2020 40 commits
-
-
Dave Tapuska authored
The changes were landed in the devtools repo but the tests were not re-enabled. BUG=1030746 Change-Id: If7d5184ae6bb1a21ce6241d1391e0b0c981b96e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120742Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753257}
-
Mark Cogan authored
This CL removes use of TabModelList from the metrics services manager client. Since this was the only use case for TabModelList's IsOffTheRecordSessionActive(), that logic is just reproduced in a static method for this class, using BrowserList. Bug: 1050142 Change-Id: I52090af91a3088cfe8e216c6c0d60f94ec292ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120412 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753256}
-
Robert Ma authored
Despite the claim, https://crrev.com/c/1603203 did not handle SIGTERM or SIGINT correctly; the script would still hang. Ultimately, `multiprocessing.Pool.map` is a blocking call during which the manager process cannot handle signals. This CL: 1. Reverts the failed workaround in executive.py added by https://crrev.com/c/1603203. 2. Switches from Pool.map to Pool.imap_unordered, which has two benefits: a) we can stream the results as we process files; b) the manager is unblocked every time a result is available so it can handle pending signals. imap_unordered is not added to the Executive class because of its limited use as of now. Change-Id: Ifd4c097875b62432a32e4e82c630f388e3e49ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117160 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753255}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2ffbc3f6d5d3..218c5d61fbba git log 2ffbc3f6d5d3..218c5d61fbba --date=short --first-parent --format='%ad %ae %s' 2020-03-25 changhaohan@chromium.org add aria-label for styles section 2020-03-25 szuend@chromium.org [issues] Show affected network requests in issues 2020-03-25 leese@chromium.org Reland "Deduplicate tabs with same URL" 2020-03-25 szuend@chromium.org [network] Add filter for the path attribute of a cookie 2020-03-25 tvanderlippe@chromium.org Add documentation for GN-Typescript integration 2020-03-25 tvanderlippe@chromium.org Add test that verifies dependencies rebuild dependents 2020-03-25 tvanderlippe@chromium.org Check recompilation works when files change Created with: gclient setdep -r src/third_party/devtools-frontend/src@218c5d61fbba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1064287,chromium:1064472,chromium:670180 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I999c60238537c5f0178ef4624efa6c492a41b5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120525Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753254}
-
Mike West authored
Following up on https://chromium-review.googlesource.com/c/chromium/src/+/2095548, which set the //content-side flag. This should be a no-op if things are wired up correctly. Bug: 739170 Change-Id: I91f977ab6bd472c3e8f1fdcae48a0dfbb4a070a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120416Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#753253}
-
Ioana Pandele authored
When the toggle is tapped, its state is communicated to the PasswordAccessoryController. The handling of the state change will be implemented in a separate CL. Android-only. Bug: 1044930 Change-Id: I8f3377593fa7b5f381d8d1f30ef437730a0b1787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117753Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#753252}
-
John Budorick authored
This isn't a great long-term solution, but in the short term, the links should work. Bug: 1034648 Change-Id: I3cca51467d681138fa2c3bb7375af350e9c9a127 Tbr: agable@chromium.org,gbeaty@chromium.org,efoo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120952Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753251}
-
Behdad Bakhshinategh authored
This reverts commit 20dddaa6. Reason for revert: crbug.com/1064605 Original change's description: > Added MissedDeadlineFrame category to Compositor Latency > > When a frame is started being tracked in controller the deadline is > recorded in compositor_frame_reporter and after presentation of the frame > it's compared to the presentation timestamp, and if it missed the > deadline is reported under CompositorLatency.MissedDeadlineFrame as well as > the super-set of CompositorLatency. > > Bug: chromium:1058909 > Change-Id: I39a624b3b0e11d764af26f92b5d849605a94ec0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096791 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752939} TBR=sadrul@chromium.org,schenney@chromium.org,behdadb@chromium.org Change-Id: If542b8f9b3a556e0ae6302387f5fb9f7696b2840 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1058909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120954Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753250}
-
Sorin Jianu authored
Some future work for the COM server requires accessing the ComServer instance, and there is no way to get to it starting from the objects instantiated by COM factories as a response to an RPC call. Bug: 1064498 Change-Id: I45923bf70cd922cb30a766fabea9bee87f524ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119213 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#753249}
-
Maksim Ivanov authored
Add a bunch of unit tests for the <security-token-pin> Polymer element. Bug: 1033936 Change-Id: I9b9545815c45c46074137604d71e0ddb72a2a081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116194Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#753248}
-
Dave Tapuska authored
Apply recommended changes for Mac platforms. BUG=591099,654477,638621,626703 Change-Id: I2c09ed17b0c82f239c14217af1bd16ffecc1b456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120737Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753247}
-
Patrick Monette authored
This fixes the compilation when building with "-fno-ms-extensions" Since the underlying storage in VARIANT is a "long", it makes sense to make the main constructor of ScopedVariant take an integer of this type. But even after this change, since there still many callsites using a "int" variable, that version is still needed to avoid the ambiguity between the "double" and "long" constructors. Finally, I've added an explicit version for VT_BOOL, because the above changes were causing additional compilation errors. Bug: 1061948 Change-Id: Ib6b22b2c01976dc4e6cbcf641e8a4ed3986c84a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110452 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#753246}
-
Vasilii Sukhanov authored
Currently it doesn't process DELETE, DELETE, ADD sequence which can happen in password generation scenario. Bug: 1063360 Change-Id: I6221ca87f5ab473328266d9a93112eec2c1dc981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120575Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753245}
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: Ic7d6191907067a216db444bdf8358749b40259f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120792Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#753244}
-
Vladimir Levin authored
This patch adds the ability for us to keep auto elements unlocked when the subtree has focus. The activation flag is replaced by an array of flags, and a function uses those flags to determine whether we should lock or unlock. This also adds a bunch of tests for focus(). Note that the place the focus/display lock updates happen needs to before the scroll, and NotifyFocusedElementChanged is too late in the pipeline for this. Change-Id: I251dcca44275322d4ba71b7de6f8fb83eb1fe81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112956 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753243}
-
manuk authored
Change-Id: I92a9d623740fefb12e98922ffb072158a664d571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118759 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753242}
-
Liviu Tinta authored
https://chromium-review.googlesource.com/c/chromium/src/+/2116169 reverted the failing test. Cleaning up the Failing test from TestExpectations. Bug: 1063163 Change-Id: I22725e2eb9f66978aa79dcbae5204b4ad7ba2127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118678Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753241}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fce26aa1391b..516de8ff4c7f git log fce26aa1391b..516de8ff4c7f --date=short --first-parent --format='%ad %ae %s' 2020-03-25 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-25 morg@google.com Add kukui and atlas to vmpi hwtest boards 2020-03-25 sanikak@chromium.org auto_updater_transfer: support new payload staging location 2020-03-25 richardfung@google.com Remove betty-qt-arc 2020-03-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-24 lamontjones@chromium.org config: mark monroe-release non-critical. 2020-03-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-24 victorhsieh@chromium.org NYC cleanup: setup_adb Created with: gclient setdep -r src/third_party/chromite@516de8ff4c7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ieeec179c21c6dcdff02b94b86c378f5ad28a7010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753240}
-
Friedrich Horschig authored
Since Android WebView still relies on DidEndEditTextField events, https://crrev.com/c/2087331 had to be reverted (see issue 1056527). Since these events are (time-wise) unpredictable, there are two ways to interrupt closing the updating/updated dialog: 1) Prevent the event from bubbling up from the render depending on OS. 2) Keep the popup "pinned" until next meaningful interaction. This CL implements 2) since 1) adds avoidable fragmentation. Meaningful interactions are: * accepting a suggestion * explicitly dismissing the dropdown (e.g. Esc, click outside field) * interactions that hide the dialog (scroll, navigation, etc.) All these interaction have one thing in common: they ultimately hide the dropdown *and* destroy it. Therefore, removing the line that resets |pinned_until_update_| covers all cases without side-effects. TBR=vasilii@chromium.org TBR Reason: API change for autofill client. Bug: 1043963 Change-Id: If6dffd86c02637b135b3a05812bbc4ea4c12a64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116052 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753239}
-
Xiaohan Wang authored
Also fix MediaFoundationProtectionManager to check the result of ScopedHString::ResolveCoreWinRTStringDelayload(). Change-Id: Ic9e37cfe3a7a53fd38332002d2396345ea1f78cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119373 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753238}
-
arthursonzogni authored
With NavigationMojoResponse, the NavigationURLLoaderImpl is waiting for both the response_head and the response_body before unbinding the URLLoader/URLLoaderClient Without NavigationMojoResponse, it was happening after receiving the response_head. Code to support both depending on the flag was unpleasant to read, but necessary. Now that NavigationMojoResponse is fully landed, it can be simplified. Bug: 1017710 Change-Id: Ic69b2c03072e60162c72927c0a6d8e56071d99b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120473Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#753237}
-
Liviu Tinta authored
2 out of the 4 tests in https://chromium-review.googlesource.com/c/chromium/src/+/2096112 failed the WebKit Linux Leak build. This is an attempt to land the two tests that were passing. Bug: 810882 Change-Id: I8c385de2b316c223d02f799b8524d56c00458474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118680Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753236}
-
Thomas Lukaszewicz authored
This change moves color definitions for the tab groups out of /components and into /chrome. This change means that each platform that wishes to use tab groups will have to define their own color mappings to the TabGroupColorId enum. Color should not be defined in /components. Change is intended to align color id definitions of the tab groups such that they allow for an easy transition into the Color Pipeline way of doing color. This CL is intended to match the existing functionality as closely as possible. Follow up CLs will address use of global theme accessors used in the menu models, fix color semantics and clean up tab group code. Bug: 1056916 Change-Id: I29d97c1b4101ed0d80d822f6c2c2d9db9856c81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115937Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753235}
-
Nate Chapin authored
Bug: 1063628 Test: fast/dom/HTMLScriptElement/reparent-to-new-document-integrity-report-crash.html Change-Id: If68846a2a95fd8e144a19b49d4efb6823b08f1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118696Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#753234}
-
Maksim Sisov authored
I accidentally left some lines of code that looked up for the WAYLAND_DISPLAY in a parent weston proc. This is incorrect and results in tests running in a wrong display if there are more than one Wayland compositor running (for example, running tests with the script on a local machine that has already had a Wayland session). Bug: 1029241 Change-Id: I9855b41d50790805850471176d2abf4802fb7990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111671Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#753233}
-
Thomas Lukaszewicz authored
Bug: 460513 Change-Id: Id4a48b7a270305953ca38e1e626f644306a861d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117324Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753232}
-
Friedrich Horschig authored
An alt="" tag on images hide them from screen readers. Since the banner on the leak check results page carries no additional information, it can and should be skipped. Bug: 1047726 Change-Id: I64299104ab86db6510fb4fcd199cf6d9f5c5c4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120578Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753231}
-
Nicolas Ouellet-Payeur authored
Include credentials in the HTTP request to download the XML. This allows the server to perform e.g. Kerberos or NTLM authentication. TESTED=Hosted sitelist.xml on an IIS server with NTLM auth. Before patch: rules don't get applied. After patch: rules get applied. Also checked chrome://net-export logs to make sure the `WWW-Authenticate' and `Authorization' headers are present. Bug: 1025946, 1063457 Change-Id: Ibbc86ea3feca17b1c918493698df906656c2f904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118230 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#753230}
-
Etienne Pierre-doray authored
This will allow us to see |from_path| and |to_path| when ::ReplaceFile is called. ::ReplaceFile is suspected to cause shutdown hangs in crbug.com/1054164. Bug: 1054164 Change-Id: I6296c9fb191f12c60b1398bde3eb31bc4ae44502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115694 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753229}
-
Justin Cohen authored
6835b8e29db1 Roll buildtools/ afc5b798c..4164a3056 (9 commits) 9a31d3f8e981 Print thread state after failure to suspend 4e2a190ad6e6 [ios] Bring up first draft thread and memory snapshot 296501351816 Prepare crashpad mig stuff for -Wunreachable-code in chromium_code af2be80bdb8a android: configure a native test suite b75c5783735e linux: disable arguments test on old kernels 311a5a2fdd5b Fix chromium build Change-Id: I031f48b23b71e68eb306918240dffe3851591184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119550 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753228}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1b20c41dcbfb..d19513f3ffbb git log 1b20c41dcbfb..d19513f3ffbb --date=short --first-parent --format='%ad %ae %s' 2020-03-25 titovartem@google.com Move calculation of target_encode_bitrate to DefaultVideoQualityAnalyzer 2020-03-25 sprang@webrtc.org Fixes temporal rate allocation issues. 2020-03-25 thakis@chromium.org webrtc: Suppress a -Wunreachable-code warning on Android. Created with: gclient setdep -r src/third_party/webrtc@d19513f3ffbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:346399 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I42d17e4608f938a52a142005732ea17cd3a78f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753227}
-
Tim van der Lippe authored
For DevTools [1] we advice contributors to symlink their repository into Chromium/src/. However, when locally running the `md_browser`, any files under `third_party/devtools-frontend/src/` don't show up, as the realpath would resolve the symlink after which `md_browser` aborts the request as it detects that the top-level directory is different. Instead of using realpath (which resolves symlinks and normalizes the path) we should be using normpath, which only does the latter. [1]: https://chromium.googlesource.com/devtools/devtools-frontend/+/refs/heads/master/README.md R=dpranke@chromium.org Change-Id: I8b64cfc3a51caf1f5d70b1fcb1bed80f95dd587e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120577 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#753226}
-
Patrick Monette authored
The PerformanceManagerTabHelper reflects WebContents and their frame trees into the PerformanceManager graph. This CL gives the graph visibility for the WebContents created by PendingAppInstallTask. Bug: 1046881 Change-Id: I20ab2faa3d30d7501808236a1395fb8b4d47b867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093033 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#753225}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5ccc09e06b6..4de93855b203 Created with: gclient setdep -r src-internal@4de93855b203 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I46ceb0693290d5800dc42b2ee341e8b0679658a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753224}
-
Vidhan authored
const vector<autofill::Suggestion> to std::vector<autofill::Suggestion> Bug: 1045401 Change-Id: I4ccd55d0156a6daaee859f9d48187e6d2bb75386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093600 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753223}
-
Pete Williamson authored
The experiment name needs to match finch instead of matching the name of the flag we use in chromium. Bug: 1045246 Change-Id: Ie64379eb275d3a0c51c9d3237d9e12602003cc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117914 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#753222}
-
Rohit Rao authored
Most of the files in this directory had no //content dependencies. Those that did were left in place. TBR=sky@chromium.org BUG=1061431 Change-Id: Ib0378541b92c20dded184a186c12ff22cbbb128a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102636 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753221}
-
Mugdha Lakhani authored
We were checking that the url of the installed PWA is a prefix of its scope. However, the url we have available from the PermissionContext is only the requesting origin, and hence this check fails if the scope is longer than the origin. This CL reverses the check to verify that the url is a prefix of the scope. A unit test has also been updated to test for this case. Bug: 1062177 Change-Id: Ic81f9b5b10fcb378cc3d65dadee947f53e8755b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107599 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753220}
-
Paul Lewis authored
Bug: 1063051 Change-Id: I1df569551de2b81a0c7ee4824d0410fe7cda5d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107994 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753219}
-
Michael van Ouwerkerk authored
Replace "shared" with "copied". Bug: 1064568 Change-Id: Ie11be1037089e574eae6783fead2790b30a63cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119536Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753218}
-