- 31 Jul, 2020 40 commits
-
-
Vasiliy Telezhnikov authored
For WebView the render target is provided by hwui (except when we use intermediate FBO to support stenil) and we don't know whether it supports alpha or not. So we assume always RGBA format Change-Id: Icbc3464961147a172e767d1ebdc8f7b9944479ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329918Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#793578}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibaccc59ec49ff64fa97b861ffe2d9d294cda3608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332539Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793577}
-
Saurabh Nijhara authored
As per current behaviour, unmanaged users are neither logged out of the session nor shown any update required notifications. But some admins might want to enable these for unmanaged users too. Hence, the new requirement is to add a boolean flag to enable the admins to control this behaviour for unmanaged users on their enterprise enrolled devices. This device policy is only applicable to ChromeOS. This CL adds this support to the policy. If the flag is unset or set to false, there is no change in the behaviour. If it is set to true, unmanaged sessions receive update required notifications and force log out, whenever applicable as per policy. Bug: 1109543 Change-Id: I90f75dfb9bb425b0d598104b807ce6ba65768b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319606Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#793576}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596167865-32b4d770ba98a451b62d0d6d996f9d383e4ffbb8.profdata to chrome-win32-master-1596171509-d368534e2598d7e86852dfa3435d6200fa4b1623.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I63ef9f8aedca0e06481151fafe91bcd1fc072742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332393Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793575}
-
Mikhail Khokhlov authored
This reverts commit 9b369b62. Reason for revert: The underlying issue has been fixed, the flakiness should disappear now. Original change's description: > [Sheriff]: Disable flaky TracingControllerTest.ProcessesPresentInTrace. > > BUG=1107612 > TBR=primiano@chromium.org > > Change-Id: Iea8a925f79b364bb7d603061c4e4e50fc0f62fed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308913 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790205} TBR=primiano@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1107612 Change-Id: I2738878a6f61443a42be0e07e746c2916f720d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317798Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#793574}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eca19c68df38..06f2818574c9 2020-07-31 aerotwist@chromium.org Use event to trigger Network Panel reveal & filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icb7e50aae6ea54b3685bfd07402eba9a275cf41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793573}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee8c246be71e..7d627545cbb4 2020-07-31 deadbeef@webrtc.org Revert "Pass NetworkMonitorFactory through PeerConnectionFactory." 2020-07-31 philipp.hancke@googlemail.com frame encryptor: remove note about not being production ready If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I40d86db2af89abf6946b784b708a609d9177abc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793572}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8ef67b87b41..08057456d373 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1103833 Tbr: koerber@google.com Change-Id: Ic63bc661fec9b5b0bf08750c53c1592578d48ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c3794dd52778..2ebb6ba9000e 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fd60950e59a3 to cbd5bee81dc6 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Test: Test: Test: Compile NBA2K20 MEC with MSVCTest: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: Ic1dced6e0090b6ca388b0cedc16f51d127a2c88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793570}
-
Titouan Rigoudy authored
As discussed over email, this will make it easier to thread through HttpCacheTransaction. It also makes it easier to mock out the endpoint for testing in crrev.com/c/2260423. Bug: chromium:986744 Change-Id: I749d795afc0b6e50b7095391dac27becf968cd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299234 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#793569}
-
Himanshu Jaju authored
- Move Type to a new mojo file to avoid cyclic dependendency - Add dependency from ShareTarget to mojom and vice versa Bug: 1085068 Change-Id: I0e358270afda02758c303967ee6b6f5b4fbce8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330025 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793568}
-
Peng Huang authored
This is a reland of 0b825660 Original change's description: > ExternalVkImageBacking: reuse more VkSemaphores. > > This CL change SharedImageRepresentationSkia::BeginScoped*Access()'s > definition to not pass semaphores's ownership to caller. So the caller > will not release any semaphores, so shared image backings can reuse or > release them. > > Bug: 1004772 > Change-Id: Idfbcf61571a56be6acc8c80ee838ff0e119ba8bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323562 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793261} Bug: 1004772 Change-Id: I2e3d41a29f2f3f45daf0d37cd09df2884a1b9189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331293 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#793567}
-
rbpotter authored
Adding a skeleton sidebar element with bookmarks/thumbnails icon buttons and placeholder divs for the two views. Bug: 1110756 Change-Id: I34b452bcc21a331c2eec88c15e794922b3124344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324558Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#793566}
-
My Nguyen authored
Need to make this method const for its use in another const method in RenderWidgetHostViewAura in https://crrev.com/c/2326556 Bug: 1109074 Change-Id: Ic5c6b49bd75b402233fb1ff1d98cca044cd6b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332081Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793565}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c07c0c93..ba362087 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib60707b6e6dba4279f601a5ca6c0e314e5734b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332496Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793564}
-
Monica Basta authored
This CL adds depth to the history.state. Depth is used to determine whether to navigate back or to navigate to the main route 'ProfilePickerMainView'. Bug: 1063856 Change-Id: Iacf322426f842377833cf3245f761d35662698b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312836Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#793563}
-
Richard Knoll authored
When a settings or snooze button handler of the MessageView deletes |this| synchronously, we can't access any local fields anymore. This CL fixes that by getting a weak ptr to check if |this| is still valid after calling the MessageView. Bug: None Change-Id: I8153a4c56fe5b5c91eafd5f9d1cdbcbc3f58857a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328858Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793562}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596153340-6d725ede4117dca447ca41731e1643697c638085.profdata to chrome-win64-master-1596174933-c71437d8a30297882573ea069b38258c9e90f721.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I405bc141cd9527d87fd24d24ffadb4a5269fc0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793561}
-
Miyoung Shin authored
This is a reland of f7d812d9. Reason for revert: org.chromium.android_webview.test.VisualStateTest#testVisualStateCallbackWhenContainerViewDetached__multiprocess_mode was flaky Fix : Fire the swap callback in QueueReportTimeSwapPromise::DidActivate if synchronous compositing is enabled on Android WebView. Original change's description: > Convert FrameMsg_VisualStateRequest to mojo > > This CL converts FrameMsg_VisualStateRequest to FrameWidget Mojo message > and FrameHostMsg_VisualStateResponse to the return callback of > FrameWidget mojo message. > > The legacy IPC message sent a single IPC with the multiple sub IPC > messages in reply, but this CL invokes each mojo message's callback > queued in the queue when the frame swap has occurred. > > This CL also includes to > - add WidgetCompositorHost interface bound on the compositor thread. > - move the implementation of |visual_state_callbacks_| from > RenderFrameHost to RenderWidgetHost. > - introduce WidgetSwapQueue queuing |id| having the same source > frame number to invoke the callbacks. > > Bug: 1071588 > Change-Id: If8c4db40be397921d19ca6a9a9287760879f3ff1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178480 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789884} Bug: 1071588 Change-Id: If7bfaa21277da199632e5c6ec748b54cea7eef58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309317Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#793560}
-
Rouslan Solomakhin authored
Before this patch, Chrome would attempt to download a payment method manifest from https://play.google.com/billing, which is a reserved URL for pointing to the invoking Trusted Web Activity and should not be dereferenced. This patch prevents downloads of any manifests for an Android payment app whose default payment method identifier is an app store payment method identifier. After this patch, Chrome does not attempt to download a payment method manifest from https://play.google.com/billing. Bug: 1099683 Change-Id: I3799d0486a7404ea0095b0c59a3d2467efd5b09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329404 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#793559}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/747a820a7d69..c3794dd52778 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 08a3cc4cfbaa to aa5bd7657e6c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Icf2ee536d0a3960c123dc37a38b5c48a95762806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793558}
-
chrome://tracingSami Kyostila authored
Use scoped_refptr instead of shared_ptr. Bug: b/158460807 Change-Id: I99a98247bb74b7a1e1743a9f0609185ab2929663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329538 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#793557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0579e73f. With Chromium commits locally applied on WPT: 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I3da788724b11df2b60f249d611d1084451b65f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331858Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793556}
-
Sami Kyostila authored
Fix a crash when running multiple Perfetto integration tests in the same process. We need to avoid hanging on to task runners from previous task environments between test runs. Bug: 1110847 Change-Id: I26b0274c5cddb37a88292cfa6ad474f17148a402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329893 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793555}
-
Lingqi Chi authored
Non-test code outside "services/network" should not depend on this directory directly. This CL cleans up all such disallowed dependencies from DEPS files in chrome/browser/extensions. But since there is no workaround to replace some private implementations with public ones, this CL also special cases them by adding them to specific_include_rules lists. Tbr: karandeepb@chromium.org Bug: 1049894 Change-Id: I6d47f656ef75c6bf3e907bc4dadc64932d6c2c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322427 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#793554}
-
Alan Cutter authored
Change-Id: If0429ea349a174d4520c59ccf9dc5091707fd6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895016 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#793553}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596160292-be7478816f9ea1c3a3e60ecafceb33fda007c691.profdata to chrome-win32-master-1596167865-32b4d770ba98a451b62d0d6d996f9d383e4ffbb8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I21aa4c1a68477eec5d46ee29ff437024919d0972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793552}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f70087925046..eca19c68df38 2020-07-31 alexrudenko@chromium.org Fix a typo in _normalizePositionData 2020-07-31 changhaohan@chromium.org Add e2e test Computed pane property traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106251,chromium:1106681 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8a3bf9883d0efbbf58f5d375d1c1ada0c7a2fa65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793551}
-
Maxim Kolosovskiy authored
This CL adds a new credential layout corresponding to a compromised credential for a website where the password can be changed via a script. This new layout replaces the "Change password" button with 2 buttons: one for automatic change and one for manual. UI mock: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8e7b42d005_0_45 This CL - introduces |hasScript| field in |CompromisedCredential| - introduces new |PasswordCheckProperties.ItemType| - COMPROMISED_CREDENTIAL_WITH_SCRIPT - adds layout for the credentials of the new item type (the new layout contains additional button) - adds strings for the new button's caption and its explanation - tests whether the new layout is inflated. TODOs: - add methods to CredentialsEventHandler to handle clicks on buttons - propagate the data about whether a given domain has script or not. Bug: 1086114, 1092444 Change-Id: I9aae4772e4e529d5510bf0ecb0db3d7127f62b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326570 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793550}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19a1943b27a0..cbd5bee81dc6 2020-07-31 lehoangq@gmail.com Disable shader's pre-rotation code on Metal & non-Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I3a99f163886e88463a7706fc60c539f58af61f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793549}
-
Monica Basta authored
Change-Id: I05d7202c2fbc7f4a3822d9a57926994c4bc11412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329894Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#793548}
-
Robbie Gibson authored
The new async APIs don't get the actual clipboard content when checking if the clipboard contains a url/image. This prevents them from triggering the new iOS 14 pasteboard access notification at bad times. Bug: 1110845 Change-Id: I8aa3989dae03999a319dc937f23432cff1f9ad81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325173Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#793547}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596088294-d7afac6507733c270f9eabdc2010773cc2ccd03c.profdata to chrome-mac-master-1596174933-7cf492c3635c483cb828a9ec34bd05bd116669be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I66c1c31e616f35c077425afa88bfad89494f4ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793546}
-
Egor Pasko authored
The comment was describing an aspect of lesser importance. The most important part is that the cache gets cleared by the caller as soon as it finds that CachedMetadataHandler returns nullptr from GetCachedMetadata(). Bug: None Change-Id: I465b9605f3845ae8bab2870d516bdc93c770d6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329536Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#793545}
-
Miriam Polzer authored
Add a policy called ChannelDowngradeBehavior to control whether to powerwash and rollback or wait for new updates on channel downgrade. This policy will be used in Chrome (for UI) and Chrome OS (update engine). Bug: 1110808 Change-Id: I71b91670f2e2fe0f077587a6b8c4b3e80d2e8dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324623 Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#793544}
-
Hiroki Nakagawa authored
The prefetch can happen before the referrer policy is known, so this CL makes the predictor use a conservertive one (no-referrer) by default. Bug: 1107318 Change-Id: If8c27090d5530edd457c83c23a059a76b90ad446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331599Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#793543}
-
Jiewei Qian authored
Users shouldn't be able to specify permissions for WebUIs. This CL treats WebUI URL as invalid web addresses, and prevents users from adding with add-site-dialog. Bug: 1108216 Change-Id: I4ceace41eba753a49642f67d2ad04325a9b4108e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315900Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#793542}
-
Darwin Huang authored
No need to keep dead code :P No functionality changes intended. Bug: 1111591 Change-Id: I8288b9585071ba99f6834c8d8b3309228933237e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331637 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#793541}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8869a24e77e..747a820a7d69 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 03cf7c3eaeaf to fada50119020 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I0a7c240fadc776235be26b2842fb8bfcdb549436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331287Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793540}
-
Ryan Hansberry authored
Rename to reflect the name of the superclass and the behavior of this test object. Bug: b:154849033, b:158848873 Change-Id: I50afc1508f7d1a6401e01b7102ef753339656aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317004 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#793539}
-