- 15 Jun, 2018 40 commits
-
-
Maksim Sisov authored
In particular, there is now a PlatformWindowInitProperties structure, which brings initial properties to ozone windows. It can be initialized (in the future, when other code is in place) with a desired window type, bounds and parenting model, which is very important for Wayland's xdg_popup windows (used for menu windows, for example). Bug: 578890 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr Change-Id: I573912d462d698b19b1bb09cf687971965e951e0 Reviewed-on: https://chromium-review.googlesource.com/1068746 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#567601}
-
Jose Dapena Paz authored
GCC fails to implicitely move an T to a base::Optional<T> in return. So this causes a build error. Explicitely std::move(). In this case the issue happened in AuthenticatorGetAssertionResponse. ../../device/fido/authenticator_get_assertion_response.cc: In static member function ‘static base::Optional<device::AuthenticatorGetAssertionResponse> device::AuthenticatorGetAssertionResponse::CreateFromU2fSignResponse(base::span<const unsigned char, 32ul>, base::span<const unsigned char>, base::span<const unsigned char>)’: ../../device/fido/authenticator_get_assertion_response.cc:48:10: error: could not convert ‘response’ from ‘device::AuthenticatorGetAssertionResponse’ to ‘base::Optional<device::AuthenticatorGetAssertionResponse>’ return response; ^~~~~~~~ Bug: 819294 Change-Id: I6410e3d4b10a9e50cae06f5a0b3dfe75d61d8b5d Reviewed-on: https://chromium-review.googlesource.com/1101684 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567600}
-
Tatsuhisa Yamaguchi authored
Bug: 845805 Change-Id: Ia9783b8499ed61e29a7257ba25f414a7db216dc8 Reviewed-on: https://chromium-review.googlesource.com/1100727Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567599}
-
Tetsui Ohkubo authored
In UnifiedSystemTray, notification list should have Clear All button at the bottom of the list. UX spec: http://shortn/_SbJoaT9xpn Screenshot: http://screen/xdFEFjJTs5x TEST=manual BUG=851830 Change-Id: Ia08f4c773d6b155c53e3b189cc9cca743e12150d Reviewed-on: https://chromium-review.googlesource.com/1096808Reviewed-by:
-
Chris Dziemborowicz authored
Bug: 853046 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4843a076212a21ed49bdabe4ec8bc88bda5f94e5 Reviewed-on: https://chromium-review.googlesource.com/1102027Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Chris Dziemborowicz <chrisdz@google.com> Cr-Commit-Position: refs/heads/master@{#567597}
-
Yoshifumi Inoue authored
This patch makes |AXLayoutObject::NextOnLine()| and |PreviousOnLine()| to work with LayoutNG with exporting |NextSiblingOf()| and |PreviousSiblingOf()| via |NGPaintFragmentTraversal|. This patch also introduces |back()| and |front()| in |NGPaintFragment::FrameRange| for ease of getting the last fragment in range and following STL container convention as other functions in |NGInlineFragmentTraversal|. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I51771896882e797ca58f0a88d5513f28bccf3e97 Bug: 591099 Reviewed-on: https://chromium-review.googlesource.com/1096915 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567596}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b520f6298c3e..67c2514bf571 git log b520f6298c3e..67c2514bf571 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 jdoerrie@chromium.org Telemetry: Disable testPlayWaitForEnded On Mac Created with: gclient setdep -r src/third_party/catapult@67c2514bf571 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852495 TBR=sullivan@chromium.org Change-Id: Ifc95d7a8bf8b94c216fee96d8666b1ab47dbf069 Reviewed-on: https://chromium-review.googlesource.com/1101730Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567595}
-
edchin authored
Previously, the section header in recent tabs in tab grid was a little low, and content would scroll up behind the section header. This CL fixes that by adjusting the content inset behavior so that the section header is flush up against the top toolbar. Bug: 852721 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1ab1f2f926b41cc7c874fc8b2250163b90bc4615 Reviewed-on: https://chromium-review.googlesource.com/1102194Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567594}
-
Vadym Doroshenko authored
Bug: 831123 Change-Id: I9ce6a2d781a7ac718043664f33420b782e5a3d9b Reviewed-on: https://chromium-review.googlesource.com/1101035 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567593}
-
Henrik Boström authored
Updated all tests to use promise_tests(), async/await and added cleanup logic for pc.close() in tests that did not already have that. Replaced broken test: 'addTrack with existing sender with null track, same kind, and sendrecv direction should create new sender' With: 'addTrack with existing sender that has not been used to send should reuse the sender', 'addTrack with existing sender that has been used to send should create new sender' Per-spec[1], if a sender has not been used to send (currentDirection never having had the value 'sendrecv' or 'sendonly') it may be reused, so the original test was incorrect. The new tests make sure that in the original scenario the sender IS reused, and in the case where the sender has been used a new sender is created instead of reusing, even if the original sender is no longer sending. In Unified Plan[2], all tests PASS. [1] Step 7 of https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addtrack [2] Work-in-Progress CL https://chromium-review.googlesource.com/c/chromium/src/+/1025771 Bug: 777617 Change-Id: I2b07bc03d84add30999e0e017bf008fbc9e9f89a Reviewed-on: https://chromium-review.googlesource.com/1100828 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#567592}
-
Yoichi Osato authored
This patch implements painting spelling/grammar markers by sharing logic from InlineTextBoxPainter. This patch fixes: - paint/markers/marker-early-break-bug.html Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4ebb3c788c614fde25c5fc28d461b089edb57fa9 Reviewed-on: https://chromium-review.googlesource.com/1100669 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Marc Treib authored
TBR=mastiz Bug: 850980 Change-Id: I34f162e61a6bbcab7eb702132c6a55cedfae927b Reviewed-on: https://chromium-review.googlesource.com/1101696Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567590}
-
Juan Antonio Navarro Perez authored
Story started failing with Chrome crash in the range: http://test-results.appspot.com/revision_range?start=566931&end=567000 TBR=nednguyen@google.com NOTRY=true Bug: 852840 Change-Id: I3e4ea10335259a2958eedc06fc1f7648b0ea2d5d Reviewed-on: https://chromium-review.googlesource.com/1102320Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#567589}
-
Olivier Robin authored
The NOTIMPLEMENTED is reached at startup. Implement the method. Bug: 852369 Change-Id: I843f7cd7e168a0b4317e030e3f48349ef3cd025c Reviewed-on: https://chromium-review.googlesource.com/1098965Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567588}
-
Hajime Hoshi authored
Before merging MediaElementEventQueue into EventQueueImpl, we need to eliminate code to set the target for an event. This is part of this work. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: Ic3b19ff2af19d931356ff72800797b36506f5ff0 Reviewed-on: https://chromium-review.googlesource.com/1102233 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567587}
-
Alex Clarke authored
As gab@ pointed out we don't really need the memory barrier here. Bug: 852344 Change-Id: Iadff34dd8d571cdcc4323ce6dd0f1e757f4a0fd1 Reviewed-on: https://chromium-review.googlesource.com/1099163 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567586}
-
Chinyue Chen authored
CastAudioJson encapsulates the path to tuning config and system config. The commit also makes CastAudioJson as its own build target so that it can be used by other components. Bug: internal b/109845931 Test: Tested on Joplin Change-Id: I6aef283b94f9ff48c9cadb15db6fbdb73756fbf1 Reviewed-on: https://chromium-review.googlesource.com/1095117 Commit-Queue: Chinyue Chen <chinyue@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#567585}
-
Marc Treib authored
It was only used in a single test, and only to verify a precondition, not an actual test expecation. Bug: 839834 Change-Id: I1d27c55b1178f765e89a8c4223533bed8ba24933 Reviewed-on: https://chromium-review.googlesource.com/1101210Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567584}
-
Marc Treib authored
- Remove HasSyncingEngine: It just checked "engine_ != nullptr", don't need a method for that (and most places already checked the member variable directly anyway). - Make IsSyncAllowedByPlatform private. - Move is_first_time_sync_configure_ to where it makes more sense. - Simplify a DCHECK - less negation. - Remove an unnecessary WeakPtr. - Merge InitializeEngine into StartUpSlowEngineComponents, its only call site. Bug: 839834 Change-Id: I2bd5a4829a2d7ade3a9acbdfe5c19f7c4f425968 Reviewed-on: https://chromium-review.googlesource.com/1101207Reviewed-by:
-
Tove Petersson authored
Bug: 832054 Change-Id: Id8292443a67fc85f708138dd790abea76384a24d Reviewed-on: https://chromium-review.googlesource.com/1039446 Commit-Queue: Tove Petersson <tovep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#567582}
-
Kent Tamura authored
Remove web_thread.h #include from thread_state.h. thread_state.h is used in 6000+ compilation units, and this CL reduces its estimated expanded size from 1,284KB to 937KB. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If0971d1b069e4bab55a1c1b51fe31514fa32c7c1 Reviewed-on: https://chromium-review.googlesource.com/1102223Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Implements step 8.1. of https://heycam.github.io/webidl/#create-an-interface-prototype-object Bug: 811029 Change-Id: I0feb1c16cf12585db8847c82d4efa342701bebcb Reviewed-on: https://chromium-review.googlesource.com/1098914 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#567580}
-
Oskar Sundbom authored
If the current playback position of a WebMediaPlayerMS is large enough, it is foreseeable that it could be returned as infinity() when converted from a TimeDelta. According to [1] (see the final example), a stream of unknown duration that ends should have its duration updated to reflect the actual stream length. Thus, it seems reasonable to expect that an infinite stream's playback position never indicates that it has ended. [1] https://html.spec.whatwg.org/multipage/media.html#offsets-into-the-media-resource Bug: b/67327907 Change-Id: Iadb87a6ed3183930da3384a0fa35506f7dc69bd2 Reviewed-on: https://chromium-review.googlesource.com/1076130Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567579}
-
Aleks Totic authored
Bug: 849751 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8c203eb45b980539b22dc5838f4546ed200323de Reviewed-on: https://chromium-review.googlesource.com/1101826 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
To clarify that it is for single Signed Exchange. Bug: 803774 Change-Id: I9890e8a2d717e539f9b03848d04df60e875a0b1a Reviewed-on: https://chromium-review.googlesource.com/1101611Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567577}
-
Ramin Halavati authored
Disabling flaky test on Windows: LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden Bug: 853118 Change-Id: I1cff832a48bdad86239fba26bd12d830c20c55f3 TBR: battre@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1101688Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#567576}
-
Yuichiro Hanada authored
//ui/keyboard is available only on Chrome OS. The code using the module is guarded by the correct conditions, so it has not caused any build error so far. Bug: 847109 Test: trybot Change-Id: I551d78e02d0b17b6d7cf6075e87189173d79844f Reviewed-on: https://chromium-review.googlesource.com/1098575Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567575}
-
Christian Dullweber authored
Currently BrowsingDataRemoverBrowserTests tests deletion for all time. A few data types are deleted incorrectly when deleting a time range. To catch this in the future, the tests are parameterized to run for "All time" and for "Last Hour" Bug: 843995 Change-Id: Ib7185423ba002ed3f2efc3398e9c0583f3134d98 Reviewed-on: https://chromium-review.googlesource.com/1100880 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567574}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fce7bc9e0825..d683d7ced42d git log fce7bc9e0825..d683d7ced42d --date=short --no-merges --format='%ad %ae %s' 2018-06-15 mmoss@chromium.org Revert "gclient: Don't allow None URLs (except in .gclient files)" Created with: gclient setdep -r src/third_party/depot_tools@d683d7ced42d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:839925,chromium:853093 TBR=agable@chromium.org Change-Id: Ic2fcedc6339d00e687ff31a3992d237406a95d4a Reviewed-on: https://chromium-review.googlesource.com/1101728Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567573}
-
Renee Wright authored
- Adds row to c/b/r/settings/device_page/storage for Crostini storage. - Fixes method ordering in device_storage_handler. Bug: 822499 Change-Id: Ibc0d01c287bf49af639f98803257c05aa66a0d1d Reviewed-on: https://chromium-review.googlesource.com/1077912 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#567572}
-
Mike West authored
This patch removes the `cause` member from `Sec-Metadata` headers generated for non-navigation requests. Spec: https://mikewest.github.io/sec-metadata/#cause-member Bug: 843478 Change-Id: I1cc35909ecdccd7ac0f4ab440be899acf67a0181 Reviewed-on: https://chromium-review.googlesource.com/1100820Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#567571}
-
Ryo Hashimoto authored
Add appfuse.mojom and implement the interface as ArcAppfuseBridge. Add ArcAppfuseBridge to the ARC bridge. Initialize appfuse D-Bus client. BUG=b:72017414 TEST=build Change-Id: I065a4d4ebef28119ca35530369a923fee6910288 Reviewed-on: https://chromium-review.googlesource.com/1098873 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567570}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdae28ee591a..3df694fe1174 git log cdae28ee591a..3df694fe1174 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@3df694fe1174 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I1d66a3d9e9419b009e460b9aa9a0b0dfe58c26a7 Reviewed-on: https://chromium-review.googlesource.com/1101729Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567569}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9491e5ebed98..06a2262078b2 git log 9491e5ebed98..06a2262078b2 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 xinghua.cao@intel.com ES31: Use indices to access image variables in built-in image functions Created with: gclient setdep -r src/third_party/angle@06a2262078b2 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9826484ef0d88ebac54df7b3eadaa6c7382790ff Reviewed-on: https://chromium-review.googlesource.com/1101727Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567568}
-
Michael Lippautz authored
This reverts commit 6a6e785e. Reason for revert: Fix in http://crrev.com/567561 Bug: 852980 Original change's description: > Telemetry: Disable loading.desktop/Kenh14 on Linux and Mac > > Disable due to failings on linux-perf, Mojo Linux Perf, and > mac-10_13_laptop_high_end-perf. > > See bug for sample builds. > > Bug: 852980 > Change-Id: Ifa31ba1b34d561afc12c545a8e01e1581b4b2e68 > Reviewed-on: https://chromium-review.googlesource.com/1101836 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Chong Zhang <chongz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567498} TBR=kouhei@chromium.org,chongz@chromium.org Change-Id: I9bc4911f021bd8b2164a19cf146e0e673cd70a92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852980 Reviewed-on: https://chromium-review.googlesource.com/1102058 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567567}
-
Tetsui Ohkubo authored
This CL replaces UI strings of Night Light and Rotation Lock buttons in UnifiedSystemTray. TEST=manual BUG=813499 Change-Id: Ibd191ef921e2e4041a83891c4fb4124110655f7d Reviewed-on: https://chromium-review.googlesource.com/1102221Reviewed-by:
-
Gang Wu authored
https://codereview.chromium.org/2504963002 update track impression from 2/3 of a card rather than 1/3 of a card, so related UMA need to update as well. Bug: 852813 Change-Id: I82105afe429816034f18212005fd2a97c5bdb42a Reviewed-on: https://chromium-review.googlesource.com/1100940Reviewed-by:
-
Yoichi Osato authored
This is a follow-up for a review comment at: ([LayoutNG] Paint composition document marker) https://chromium-review.googlesource.com/c/chromium/src/+/1090601/13/third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc#115 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8aaf6f08e917f1e5efe62a7cc856b2bbfff3fec1 Reviewed-on: https://chromium-review.googlesource.com/1100720 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
This CL adds a new method, EnableIme(). ArcInputMethodManagerService observes changes of the list of the active input methods and enables/disables IMEs in container side if any ARC IME is enabled/disabled. This CL also introduces new category of input method id, ArcImeId. It starts with '_arc_ime_' and used for distinguish Arc IMEs from other extension-based IMEs. Bug: 845079 Test: Unit tests are added. Change-Id: I94c673c96e4157d8c9f18896606144f91438b7dc Reviewed-on: https://chromium-review.googlesource.com/1098869 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567563}
-
Tetsui Ohkubo authored
Preivously, notifier settings was accessible from Notification Center. In UnifiedSystemTray, System Tray and Notification Center are merged, and notifier settings is accessible as a detailed view of Do not disturb feature pod item. Screenshot: http://screen/f2PaXeD71LQ TEST=manual BUG=835733 Change-Id: Ia6302647ebb837c4f8b494a150509273f0d56161 Reviewed-on: https://chromium-review.googlesource.com/1100719Reviewed-by:
-
