- 21 Sep, 2020 40 commits
-
-
Morten Stenshorne authored
Everything that takes place after child layout should be done in FinishLayout(), if possible, to save stack space. Bug: 930637 Change-Id: If5bb65184e17f0d5ad2a59fe690ac32832f351eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421454Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#809051}
-
Abigail Klein authored
rect of multiline elements. When a user opens a context menu via a keyboard shortcut, EventHandler::ShowNonLocatedContextMenu is called, which finds the center coordinate of the target element and opens a context menu there. When the target element is a multiline link, the center of that element's bounding box is often not on the link itself, which is a strange visual experience. This CL makes ShowNonLocatedContextMenu take the center coordinate of the first outline rect of the element. The outline rect is elsewhere used to show the focus highlight of multiline links. This ensures that the context menu is anchored to the link text itself. AX-Relnotes: Context menus opened on multiline links are visually anchored to the link text. Bug: 1121180 Change-Id: If6c3877e8abed9016a2d204e777142f27ca5e27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412906Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#809050}
-
Stepan Khapugin authored
Moves the ownership of the main browser state to the app state. Bug: 1045659 Change-Id: I37eea450d29d12c5fa31cdbf4a447667dc039a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414310 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#809049}
-
Eric Lawrence authored
Over the years, the features controlled by some switches were removed but the switches were left behind. Remove the unused switches. Bug: 1130298 Change-Id: I95a9ab169dec8bc26253171d0633d9b5c611b675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420709Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809048}
-
Brian Norris authored
Update a few owners while we're at it. Bug: 1089037 Change-Id: I9406fc37ae76b914c3eb012c5dc56b43db39c608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422341Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#809047}
-
Irina Fedorova authored
This CL updates passwords check for weakness for long passwords. It runs the zxcvbn-cpp library check for the first 40 characters of the password. Bug: 1119752 Change-Id: I0884e4bc3c32b7e7b44de2a02064e975a2e1d696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421516 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#809046}
-
Meilin Wang authored
This CL adds the Bluetooth disabled UI which will pop up when the Phone Hub feature is not available because Bluetooth is turned off on this device. Remaining work includes implementing button click handlers. Sreenshot: https://screenshot.googleplex.com/65m7heuR4rJrK4e.png BUG=1106937,1126208 Change-Id: I884d0ef250ceb5d283c69c555726abd0b0d80a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417542 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809045}
-
minch authored
- Remove all the DeprecatedGet*LayerColor functions. - Remove AshColorMode and |color_mode_|. Bug: 1107056 Change-Id: I999ca330613b3c7032322401cbece23d4cb398f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419919 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#809044}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600678560-d63b2733d2f4bab7a63bfddb4918170486fde26a.profdata to chrome-win64-master-1600689096-6bb040ccfec21a14348d3421fe3415a00ad5226f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I494eb8ed6b6b485c659edf6c39a1c8667fb522be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809043}
-
Thiabaud Engelbrecht authored
Bug: 1109209 Change-Id: Ia3e00e13bb8877f84f9e3193ca286927cda94b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382676 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809042}
-
Natalie Chouinard authored
The ICU case folded full font name for the regular weight Google Sans font is "google sans regular". Bug: 1130057 Change-Id: I4e0f8eccaf1dfd66ebb2d55cdae8557dda232ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419147Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809041}
-
Sebastien Marchand authored
This switches the Linux official build from AFDO to PGO. This yield some 3-4% performance gains on Speedometer and help unifying our desktop build configurations, PGO is already used on Win and Mac. The PGO profiles for Linux are generated by a continuous bot and are rolled in Chrome once or twice per day (AFDO is based on the Android profiles). This increases binary size by ~3-4%. Bug: 1111437 Change-Id: I565eb336fa5ad9480e99808ed49246634255b82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404620 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#809040}
-
Trevor Perrier authored
This CL fixes a crash caused by SplitCompat.installActivity being called before ChromeBaseAppCompatACtivity.applyOverrideConfiguration. The crash occurs because installActivity ends up calling getAssets, which can not be called before applyOverrideConfiguration. Bug: 1128698 Change-Id: If9e8e6d4bfa29a3fc18ea7509379ee78a2ec1a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422185 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#809039}
-
John Palmer authored
Change-Id: Ife1502a2d92a9f9ce9743e6fae95419bfd956a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384451 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809038}
-
Chris Lu authored
This will make sure the fullscreen promo is not shown for os version 14.0.0. Bug: 1130120 Change-Id: I17c4bc87453583d81b6220f3a072fac5def5ff58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419912Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#809037}
-
Daniel Nicoara authored
Do not launch passthrough on Chromecast before enabling it on ChromeOS since Chromecast uses the same graphics stack as ChromeOS. Bug: 1097320 Test: None Change-Id: Ibd77d09957925960f9a2243ae965b6836d9a8b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421630Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#809036}
-
Yu Han authored
Prior to this CL, progress and range have an alpha channel applied to their borders. And the select element isn't styled correctly for dark mode. This CL fixes progress and range element by avoiding the application of the alpha channel in dark mode. In addition, it styles the multi-select element with colors specified in the dark mode design. Bug: 1107289,1107287, 1111932 Change-Id: Ia55fabd46ad0f1ff4aa5de90cf88d2480b301962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368084Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809035}
-
Patrick Monette authored
The goal of this CL is to collect crashes from a DCHECK-enabled build. It is meant to be reverted within days of being committed and it will not affect other builds. Bug: 1086944, 1088353 Change-Id: Ie6fde9428793f1ae1f18af804e2390292dea76b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417292 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8614e4925896..44dff4f2012d 2020-09-21 johnstiles@google.com Optimize early-return detection. 2020-09-21 ethannicholas@google.com Fixed a bug with SkSL ternaries in binary files 2020-09-21 adlai@google.com Migrate skottie to GrDirectContext 2020-09-21 nifong@google.com include freetype in wasm build, see cl/332073924 for complete change 2020-09-21 johnstiles@google.com Remove duplicate copy of ensureScopedBlocks. 2020-09-21 adlai@google.com Remove SkCanvas::getGrContext & GrRecordingContext::backdoor 2020-09-21 bsalomon@google.com Separate YUVATextures, YUVATexturesCopy, and YUVAPixmaps in wacky GMs. 2020-09-21 kjlubick@google.com [canvaskit] Fix Debug build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I0bbe373dd4486fc4fb2b9f8a1b26b7675b95c162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422306Reviewed-by:
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/ebc8e4d9fb94..f90ada0d08e9 $ git log ebc8e4d9f..f90ada0d0 --date=short --no-merges --format='%ad %ae %s' 2020-09-20 janne-vlc tests: avoid using sed in header test 2020-09-20 martin meson: Set msvc like warning options for clang-cl 2020-09-18 martin meson: Use gas-preprocessor as generator, for targets that need it 2020-09-20 janne-vlc build: increase minimal meson to 0.49 2020-09-13 gramner x86: Add misc mc asm tweaks 2020-09-15 wtc Ban op->idc that may drop all layer-specific OBUs 2020-09-06 gramner cli: Add support for Unicode and long paths on Windows 10 2020-08-28 martin arm32: mc: NEON implementation of put/prep 8tap/bilin for 16 bpc 2020-09-03 martin arm64: mc: Apply tuning from w4/w8 case to w2 case in 16 bpc 8tap_hv 2020-09-03 martin arm: mc: Avoid an unnecessary mov in 8tap_hv w2 2020-09-01 martin arm32: mc: Load 8tap filter coefficients with alignment where possible 2020-09-01 martin arm32: mc: Use narrower vext.8 in 8tap_w4_h 2020-08-29 martin arm64: mc: Use more descriptive element specifiers for loads/stores in 16 bpc put_neon 2020-09-01 gramner cli: Use proper integer math in Y4M PAR calculations 2020-08-20 rzumer Output render size to Y4M 2020-08-27 martin arm32: mc: NEON implementation of avg/mask/w_avg for 16 bpc 2020-08-28 martin cli: Print the decoding fps even if the file lacks a nominal framerate 2020-08-22 janne-vlc tests: test stand alone API header compilation 2020-08-22 janne-vlc dav1d/headers.h: add missing stdint.h include 2020-08-22 janne-vlc contributing: document the allowed internal use of anonymous structs/unions 2020-08-21 janne-vlc bump soname for API changes 2020-08-21 janne-vlc API: move reserved space in Dav1dSettings to the end 2020-07-21 janne-vlc API: remove anonymous struct and union from Dav1dWarpedMotionParams 2020-07-09 janne-vlc CI: compare x86inc.asm with upstream 2020-07-10 janne-vlc x86inc.asm: remove private_prefix define and config.asm include 2020-07-09 janne-vlc x86inc.asm: use standalone x86inc.asm as upstream 2020-06-24 gramner x86inc.asm: Properly sort instructions in alphabetical order 2020-08-07 martin checkasm: Add ifdefs around the readtime check 2020-08-06 martin checkasm: Enforce declare_func to be outside of check_func 2020-08-06 jamrial obu: remove a few unnecessary calls to memset() 2020-07-17 jamrial obu: reduce scope of some variables 2020-08-05 martin checkasm: Use mach_absolute_time() as timer on darwin on ARM 2020-08-05 martin checkasm: msac: Fix signal handler recovery in msac_decode_bool* 2020-08-05 martin checkasm: Explicitly test whether the readtime() function works 2020-06-26 victorien x86: Add {put/prep}_{8tap/bilin} SSSE3 asm (64-bit) 2020-06-30 victorien x86: Minor changes to MC scaled AVX2 asm 2020-07-14 gramner x86: Add cdef_filter SSE optimizations 2020-07-20 epirat07 dav1dplay: Fix type mismatch warning 2020-07-13 code README: Update roadmap 2020-07-11 gramner Add enum entries for the maximum valid metadata values 2020-07-13 code Update README.md 2020-07-10 thakis Hide const symbols names too when building for mac/arm64 Created with: roll-dep src/third_party/dav1d/libdav1d TBR=wtc Bug: 1130138 Change-Id: I170af4e38c41278df942de6a8c22f0d4a589b760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422127Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#809032}
-
Trevor Perrier authored
This CL adds DetailedLanguageListPreference and removes any code associated with the language decouple from LanguageListPreference. The flag for using DetailedLanguageListPrefereces is moved to LanguageSettings. No UI changes are made in this CL. Future CLs will make significant changes to the DetailedLanguageListPreference page based on the Language settings redesign mocks. Bug: 1127531 Change-Id: I99bd9c51498000d249aea7aef13fb4aa49c97b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406721Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#809031}
-
Haiyang Pan authored
This test is flaky in a similar pattern as those in crrev.com/c/2419651 Bug: 1077552, 1127110 Change-Id: I0520cdb0ce3b611f130e2e2ada7009e70b2e0e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421834 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#809030}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600667868-753d2e8ebb132428b671d1eab55299188459911c.profdata to chrome-mac-master-1600711078-3749581e3468596138c3e122333d23faab2aaf5f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7de59f876d81b8680686383e35275c972b08ff3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422545Reviewed-by:
-
Shrek Shao authored
TBR=zmo@chromium.org Bug: 1130440, 1130470, 1130438, 1130411 Change-Id: Ia0c0d2b8248826ba4e79ff7f78003ff3315b550b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422460Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#809028}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe878dedd5ad..6aadd31a5f98 2020-09-21 srisser@google.com Implement VK_KHR_image_format_list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I584b62af9bdf923f23d3331cabf5b12e3b218cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422303Reviewed-by:
-
Jeroen Dhollander authored
This component handles all communication with the Bloom servers. Bug: b/165356952 Test: chromeos_components_unittests "Bloom*.*" Change-Id: Ib32a70a466d9024c62ab01d892c9eb381b19afad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375994 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#809026}
-
Peter Boström authored
Removes last use of view_to_field_ directly, which permits rewriting it as field_to_view_ and removing the FieldToView method. Bug: 1106422 Change-Id: Ia827aba9e48487dad30b0f24a66d39ab0ab349bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416724Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809025}
-
Satsuki Ueno authored
Updates the host:port parsing logic in chromedriver so that the debuggerAddress option can accept ipv6 addresses. This change does not support ipv6 addresses containing a zone id as the underlying url libraries will not parse them. Bug: 1112509 Change-Id: I2adb13b5788fc88a5ce4c415f680e2e3f93d6c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412811Reviewed-by:
Shengfa Lin <shengfa@google.com> Commit-Queue: Satsuki Ueno <satsukiu@google.com> Cr-Commit-Position: refs/heads/master@{#809024}
-
Wei Lee authored
Design Doc: go/cros-camera:dd:cca-default-saved-folder Bug: 1127587 Test: Take a photo and Camera folder is created and the photo is saved there. Change-Id: I2701ee5ed82df3df3a0ff2e65ad33f6e6145c3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407732 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#809023}
-
David Black authored
Holding space items should open on double click and single tap. Bug: 1129694 Change-Id: I844d1e5e5635ad3c7d1daf60126211b07c373e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416766 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809022}
-
Xing Liu authored
This CL adds a Android bookmark type for reading list, so we can distinguish reading list bookmarks in UI and fork calls into reading list backend. Bug: 1128074 Change-Id: I8ceb198bcca68c794d7a044210a73b97679fce07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415589Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
We've theorized that the App menu could be shown before the PWA check finishes and this is an effort to track if that happens in the real world. Although the end result (of such a race) is pretty benign (you get the behavior Stable is exhibiting today: the string 'Add to homescreen' would be shown instead of 'Install app'), we'd still like to know how common this is in the real world to see if we should address it. Bug: 1128364 Change-Id: Ifa5c670811a2d4dd823757a94cd9eb8486e47ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406166 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#809020}
-
John Williams authored
Bug: 1107164, b/161612881 Change-Id: Idf86fa429de43b5da554d57bd1e8d1cbd186835b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378772 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
-
Toby Huang authored
This CL adds four miscellaneous tips to commit_checklist.md. Firstly, use CL hashtags to group related CLs together. Secondly, don't use chrome/OWNERS as a blanket stamp to land your CL if your CL makes significant changes to subsystems. Thirdly, this CL adds a link to instructions for building various targets. Fourthly, this CL adds a tip about auto-submit. Bug: None Change-Id: Iaa3c51b8e2b4a49947061762f3a080a858f41fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369619 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809018}
-
Curt Clemens authored
This delegate provides access to the NearbySharingService from //ash. It will be used to implement a pod button in the system tray that toggles high visibility mode. Bug: 154866703 Test: unit_tests Change-Id: Icc6b84b6af0ba350d01a0a92e844f4dd2249600f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405439 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#809017}
-
Javier Fernández García-Boente authored
The new trailing space logic refactoring, landed in r806928 and relanded again in 807457, assigned the current offset as the non-hangable-run-end when this is not applicable. The root cause of this issue is that this offset must not exceed the item s range-end, so that we clamp it to this range-end value. However, since in some cases we use the original offset as the the non-hangable-run-end, we may lead to a situation where the offset used exceed the item's range end. This is precisely the DCHECK violation described in the issue 1130288. Since r808007 we have decided to use optional values for the non-hangable-run-end, but we didn't update the implementation of the PreviousBreakOpportunities and NextBreakOpportunities functions accordingly. Bug: 1130288 Change-Id: If5e5fb380320ca54f7a6d17d1c2bd020a643e12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421728Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#809016}
-
Jérôme Lebel authored
Updating expiration date for: + Signin.AccountReconcilorState.OnGaiaResponse + MobileSignInPromo.SettingsManager.ImpressionsTilSigninButtons + MobileSignInPromo.SettingsManager.ImpressionsTilXButton + MobileSignInPromo.SettingsManager.ImpressionsTilDismiss + MobileSignInPromo.BookmarkManager.ImpressionsTilXButton + MobileSignInPromo.BookmarkManager.ImpressionsTilDismiss + MobileSignInPromo.BookmarkManager.ImpressionsTilSigninButtons + FirstRun.Sentinel.CreatedFileError + FirstRun.Sentinel.Created Choosing the same expiration date than other sign-in metrics. Fixed: 1125775, 1125709, 1125708, 1125673 Change-Id: Ibdcd6023e3de10efc4f060d02cd07842699a2eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421652 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#809015}
-
Daniel Nicoara authored
ANGLE increases the OTA size on devices with constrainted space. Since Chromecast hasn't transitioned to passthrough command decoder yet, don't depend on ANGLE for now. Bug: 1097320 Bug: b/159166071 Test: Compiled Change-Id: I86a966af39e652564754d0680a9366c159b63b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422180Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#809014}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I18dc846e68a95e397446a17d5aa303286372923f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421763Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#809013}
-
Mohamed Amir Yosef authored
We need to invalidate the layout, in case the Header view is changed after the bubble has been created. This is also aligned with SetFootnoteView(). Bug: 1115936 Change-Id: I66896d7beeda5e2996ee9c72fad0bdbf99a268a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421517 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#809012}
-
