- 27 May, 2020 40 commits
-
-
Yuki Shiino authored
Bug: 839389 Change-Id: I6588232fe0a6e6d33a245fae9edf2598db34f950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215660Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772164}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590551922-893b4e02197be5d53e80dcc9648783993fdfcda3.profdata to chrome-mac-master-1590566295-92309f25158961ce5d340e659f77e189eb24879f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3e5a5db88312f2a7d7c253bb1f9a13446ae935dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217463Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772163}
-
Rijubrata Bhaumik authored
base/run_loop.h is only used in the test files, so use specific_include_rules in the DEPS accordingly. + some nits Bug: 897297 Change-Id: Ied0079aa6369c6b458e725a07458050ba8761588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214894Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#772162}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ia765946ac1c13882ce813c1769c1320a22f688eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217455Reviewed-by:
-
Sebastien Lalancette authored
When going from compact width to regular width, we swap the toolbar buttons. This allows us to add/remove buttons based on the screen constraints. Before iOS 13.5, setting the "items" property of a UIToolbar worked fine. However, in 13.5, this made the last button (Done button) to become non-responsive when going from compact width to regular width. Somehow, using the setItems:animated API fixes the issue. Tested on simulators: iPhone 13.5 and 12.4 iPAD 13.5 and 12.4 Bug: 1082723 Change-Id: Icde5b6760038560f9f8601af1afc328a4e2e4aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216285 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#772160}
-
Rune Lillesveen authored
There is no need for the extra call after ApplyAnimatedStandardProperties now that we trigger loading at the end of StyleForElement and PseudoStyleForElement. Also, we only need to have the extra loading for MatchedPropertiesCache case if when we actually add the ComputedStyle to the cache. Change-Id: I943c24f42f8ec945b901cdbf7572361dc68e280b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216076Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#772159}
-
Hiroki Nakagawa authored
This function declaration was added by the following CL, but wasn't implemented: https://codereview.chromium.org/1951853004 Bug: n/a Change-Id: I73657333974bca8255c40db94825660f1c6af949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215151 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772158}
-
Yan, Shaobo authored
In CopyImageBitmapToTexture, it has high risk that user provided a gpu texture that has different color format with ImageBitmap backed texture/buffer. This patch leverage skia to do color conversion in CPU uploading path. Change-Id: Ie033f1e222f01cb02d455c54bac83fdfd7526c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199933 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#772157}
-
Jan Wilken Dörrie authored
This reverts commit b7d9656d. Reason for revert: Tests are flaky on several builders, see https://crbug.com/1086794 Original change's description: > [Media History] Do not record background or muted watchtime > > Adds a fix so that Media History does not record > background or muted watchtime since they are not > useful to us (we only want foreground unmuted). > > BUG=1086511 > > Change-Id: I175c20ad88c136f291b72ae021b3cc22729bc5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216375 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771995} TBR=dalecurtis@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: Ie59c985576436a2443448b4141cc51fd09f75176 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086511, 1086794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215828Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772156}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfd24879a942..eaf51ab50b85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069072 Tbr: tasak@google.com Change-Id: I12fa3985bd11a108bd948889159377d4e5053a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217325Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772155}
-
Jan Wilken Dörrie authored
Revert "[Sheriff] Disable MediaHistoryBrowserTest.DoNotRecordWatchtime_Background/0 and DoNotRecordWatchtime_Muted/0 flaky on 6 builders." This reverts commit 33fe2fc7. Reason for revert: Will revert original CL, rather than disabling on more platforms. Original change's description: > [Sheriff] Disable MediaHistoryBrowserTest.DoNotRecordWatchtime_Background/0 and DoNotRecordWatchtime_Muted/0 flaky on 6 builders. > > The builders are linux-chromeos-dbg, Mac ASan 64 Tests (1), Linux ChromiumOS MSan Tests, > Win7 Tests (dbg)(1), Linux Tests (dbg)(1), and Linux CFI. > > Bug: 1086794 > Change-Id: If0b9d37b3d4662880916f26b8acfc5612200e075 > Tbr: beccahughes@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216098 > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#772101} TBR=tasak@google.com Change-Id: Ieecb200736154d52763f397548bad284eae6eceb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217552Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/79dcb2a5abbd..9e718f962f87 2020-05-26 bclayton@google.com Update SPIR-V Tools to 55af3902f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia7aca27e9fc8c9d084ae744ae9697dbbc54047ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217323Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit de6734f7. Reason for revert: Likely culprit for https://crbug.com/1086863. Original change's description: > vma_wrapper: create VmaAllocator for vulkan 1.1.0 > > For vulkan 1.1.0, VmaAllocator will use dedicated memory > allocation for some big vulkan memory request, and free > it when the allocation is released. Without this change, > the VmaAllocator will allocate memory from self managed > memory blocks for all vulkan memory request. And the > memory may not be released when the allocation is > released. VmaAllocator may keep the memory for later > usage. It could be the reason for the memory regression > in fuchsia. > > Bug: fuchsia:52463 > Change-Id: I7b905435d31b927b2344724f8a2e1738e0544410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215414 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771927} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: I2bc3a572ff9e95b4dcb3cdd8bf7a9f6bb5969c0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: fuchsia:52463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216254Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6a029fc9d84e..55c85f66d2fd 2020-05-27 hao.x.li@intel.com Query API: Extensions 2020-05-27 xinghua.cao@intel.com Check FP16 support on vulkan backend 2020-05-27 jiajie.hu@intel.com Set a default value for dawn_glm_dir like other GN build overrides If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I10c75bd1e7f98df9b252e2f9c020afadd8fa06ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217329Reviewed-by:
-
Scott Little authored
The load-first-K-images-eagerly optimization (https://crbug.com/996963), which causes Automatic LazyLoad to avoid deferring the first K images encountered by the parser, should default to zero. This way, the default behavior will match the previous behavior without this optimization, and it'll be easier to experiment with other values as needed. Bug: 1086726 Change-Id: I806008bba93fee471a596f67842f5db1b3f0e0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216805 Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#772150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c1a260a6cc9..1ba864348bde 2020-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 79dcb2a5abbd to 9e718f962f87 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I5bc6f8749a35b2a39abe1548790942433bdea12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217328Reviewed-by:
-
Bo Majewski authored
Adds .opus as a know extension for OGG files. Browser would return *.opus files as recent audio files, but file manager would not set the correct icon on them. Bug: 1067093 Change-Id: Ie14f06245004f96e6e86ba61353d0a3d7b584d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215389 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772148}
-
My Nguyen authored
Update pref values in the toggle in smart_inputs setting page to enable/disable assist personal info. Bug: 1067108 Change-Id: I1595e2ae84dcc76d0819921f886ead9c019df965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213656 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772147}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: Ic3150aaa466e7e114c6ad2f0d3e489453395be30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196131Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#772146}
-
dpapad authored
This fixes a runtime error thrown, when the search algorithm would force-render the password check subpage even when the PasswordCheck feature is not enabled. Fixed: 1086649 Change-Id: I82ed400713c85fa8c1a7fdd167a7219cebc5e731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216536Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b9e90b03da08..ea2ee251f623 2020-05-27 szuend@chromium.org Revert "Port IssuesModel to TypeScript" 2020-05-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-05-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-26 brgoddar@microsoft.com Automatic Symlinked workflow 2020-05-26 brgoddar@microsoft.com Memory: Disable failing snapshot test 2020-05-26 joselea@microsoft.com Devtools: Fix ally bug in Sources panel 2020-05-26 Rob.Paveza@microsoft.com ARIA submenus violation: Submenus should indicate they're submenus 2020-05-26 tvanderlippe@chromium.org Typecheck sdk/ChildTargetManager.js with TypeScript 2020-05-26 vidorteg@microsoft.com Fixing console placeholder in properties panel (Elements tab) 2020-05-26 tvanderlippe@chromium.org Disable webaudio test 2020-05-26 michael.liao@microsoft.com [Dom Storage]: Handle undefined storage case 2020-05-26 janscheffler@chromium.org Enable TypeScript in ScreenCaptureModel 2020-05-26 wolfi@chromium.org Port IssuesModel to TypeScript 2020-05-26 wolfi@chromium.org Port Resource.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320,chromium:1066813,chromium:1079233,chromium:1081686,chromium:1084631,chromium:1086519,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4e74c9ae87ef0a0cb4f7ef9c494f4a71fa3af11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217327Reviewed-by:
-
Nicholas Verne authored
Some interfaces on multi-interface USB devices should be blocked from sharing with guests. The mechanism for this is a mask parameter sent to PermissionBroker for use when it opens the raw USB fd for the guest to use. The mask is a "drop privileges" mask that can only be used to narrow the privileges given to the fd. Change-Id: Ia37726384666a1b24e336d1e8b4ec66117b94384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196885 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#772143}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91637164. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I0e45944d791aa03e9dc7973223f8fcae5cbb930b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216740Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772142}
-
Dominic Farolino authored
R=kinuko@chromium.org Bug: 1086227 Change-Id: I32ba539f0c765f7c2248638738662a05081a675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212966 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Also add a crash key for the link variation, to see if there is a pattern to crashes, should they be seen in the field. Bug: 1085899 Change-Id: I7b94f41d5661d31bf0fc11e9478092471db0e8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213880 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This is a reland of d95d2248 Original change's description: > Query Tiles : Integration test > > This CL adds end-to-end Integration tests for query tiles. The network > layer is substituted by a embedded test server that serves a fake > server response. Added omnibox javatests that use this mechanism to > test the full flow. > > Bug: 1083807 > Change-Id: Ida65dd9e093ce2311def892158c6bbe4de1fe3c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206153 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770512} Bug: 1083807 Change-Id: I7f65bfb79006201bdaa545c0aba8dd7cf2b4a243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210654Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772139}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a03bec408ff6..4ad5d5733e00 2020-05-27 dberris@chromium.org auto-triage: Respect monorail_project_id If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086639 Tbr: eseckler@google.com Change-Id: I5b2772549ef14d0ff8ff322b4c464d3e0b317cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217322Reviewed-by:
-
Matt Falkenhagen authored
Add more information about the process/threading model of network service and how it starts. Change-Id: I0669d6d4cb96eddff494f7c08ac7db575a628cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215523 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Darren Shen authored
IMEBridge is only ever initialized for Chrome OS [1], so all usages of IMEBridge::Get() will return nullptr for other platforms. Mark those functions as Chrome OS only, and (re)move any usages that appear in other platforms. A followup patch will move IMEBridge to ui/base/ime/chromeos. [1] https://source.chromium.org/search?q=IMEBridge::Initialize&sq=&ss=chromium%2Fchromium%2Fsrc&originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 1083803 Change-Id: Ic9cb463a918ef990dfff5ef29e311b3fbfb664b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212198Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3f479f3da7f8..5c1a260a6cc9 2020-05-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9f39a47c to 5749e77b (422 revisions) 2020-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7ff01bb15d40 to 5b4c627389a6 (15 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1079475,chromium:1084458,chromium:1084580 Tbr: westont@google.com Change-Id: I76dbece4eac08cd9b8a1abe6538d057550ee87f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217321Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=yusukes@chromium.org Bug: 1026641 Change-Id: I80631256980fa0f28c273c2bd8f9531e68628791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217204 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#772134}
-
Hugo Benichi authored
This patch removes the code populating the IP configuration data of mojo NetworkConfiguration objects from Chromium's ONC properties. The IP configuration data is now derived only from shill properties, which allows to eliminate a lot of redundant code in ArcNetHostImpl, and removes a blocker for eventually migrating the net.mojom RPC channel from Chromium to platform2. BUG=b:145960788 BUG=b:143258259 TEST=Flashed chrome, tested various connectivity setup with multiple networks, including L2TP connections and Chrome 3p VPN connections. Change-Id: I3999f085040c1906adbfcfb490eb0c7fcbc5ae3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215797 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
-
Kent Tamura authored
If a line contains ruby text and it overflows line-height, - If it overflows upwards, adjust block offset of the line in NGInlineLayoutAlgorithm - If it overflows downwards, pass the overflow amount via NGLayoutResult, and NGBlockLayoutAlgorithm::ComputeInflowPosition() refers to it. We don't consume spaces under the previous line and spaces over the next line yet. Bug: 1069817 Change-Id: Idd78eae27c916ac9d4b5de528f73acbaaa26a285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210192 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772132}
-
Guido Urdaneta authored
Fixed: 1084128,1075631 Change-Id: I70a29dc9bd5b3a5fe9c6d1981d1a14e805417ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216072Reviewed-by:
-
Hitoshi Yoshida authored
WebSocketStreamOptions.signal is a non-nullable dictionary member. This CL fixes the way to check if it is missing; makes to call hasSignal() instead of checking a nullptr. This is a preparation for the new code generator, with which the original code would crash. Bug: 839389 Change-Id: I5d43009f4998b00bc4705a912148382fbf2902a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214739 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772130}
-
Ian Kilpatrick authored
The old code was also looking at sticky positioned offsets, but it looks like position: sticky is generally broken with split inlines so couldn't trigger a reliable bug. Change-Id: I82bf9c0b5cdbfb316ca095e7acb574737c63678d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215367 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Gang Wu authored
Add thumbnail for clipboard image suggestion behind the flag. Bug: 1055925 Change-Id: I8cbf77725cc11fc0853ba801766e9b61acb5c048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204083 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772128}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iaf8ee33c59a6edb0d6d3974e3cec972d8bd9cf96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212104Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=ksakamoto@chromium.org Bug: 1026641 Change-Id: I7f14fa5fdc132e2d0760a7013147e69af3e5275f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217206 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772126}
-
Kent Tamura authored
They are used only in ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: Ia07346ed04b4cb0a70608dd1eaa10a41ca923cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215544 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
