GitLab

I'm planing to add MixedContentChecking related settings to
WorkerSettings for off-main-thread-fetch.
But WorkerSettings is not set correctly in ServiceWorkerGlobalScope.
So this CL just adds SetWorkerSettings() in
ServiceWorkerGlobalScope::Create().

BUG=607575, 443374

Change-Id: I0e32bb84ce316b7125bfe11facfe5182095ae63f
Reviewed-on: https://chromium-review.googlesource.com/571207Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486701}

DiscardVirtualMemory makes the contents of discarded memory undefined.
c.f. https://msdn.microsoft.com/ja-jp/library/windows/desktop/dn781432(v=vs.85).aspx

BUG=

Change-Id: Ifd06e6f75271dc6a38cf0a34027cb20f1a887cfe
Reviewed-on: https://chromium-review.googlesource.com/571621
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486700}

This CL introduces measuring the events that save/update bubbles are triggered
and reasons why save/update bubbles are dismissed.

NOTRY=true

Bug: 732846
Change-Id: I885985e0ffcd610af8c2f0a1d55824d63330b43f
Reviewed-on: https://chromium-review.googlesource.com/565286
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486699}

Bug: 
Change-Id: Ifc41fef8f84a0703da21af3afeffed9e1c9d81e9
Reviewed-on: https://chromium-review.googlesource.com/571204Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486698}

This CL is to fix the root cause for failures of service worker wpt
tests.

The test loads an url for an Image object with 'anonymous' crossOrigin
property at line227 of fetch-canvas-tainting-iframe.html, succeeds in
loading without tainting, and then it loads the url again for another
Image object with 'use-credentials' crossOrigin property at line234,
this is expected to result in loading error, but currently it results
in success. The root cause is that Memory Cache is reusing the first
time's response for the second time resource request, although these
two requests have different credentials mode.

BUG=735883
TEST=blink_tests
external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html
external/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html

Change-Id: I9acdcf3811b6dcd5ea2ffe858ec35f51f7f2cc3f
Reviewed-on: https://chromium-review.googlesource.com/567690Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#486697}

This patch
- Added CSSPropertyAPIBorderColor
- Implemented parseSingleValue method on CSSPropertyAPIBorderColor and
  CSSPropertyAPIBorderWidth, moving parsing logic from CSSPropertyParser
  legacy switch
- Added details of API implementations to CSSProperties.json5 so that
  generated files will be updated

Bug: 668012
Change-Id: I05487329dab8542022d2750ddb1d81a4dbc65a1f
Reviewed-on: https://chromium-review.googlesource.com/566346Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486696}

Since integers returned by SelectionStartEnd() don't relate 
each other if start LayoutObject != end LayoutObject.
To emphasize that for readability, we should split it.

Bug: 739062
Change-Id: I9609262fe2aeb63a49fa95a4d17de66c167d92f8
Reviewed-on: https://chromium-review.googlesource.com/566268
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486695}

2017-07-14T11:14:28

2017-07-14T11: 14:22
Bug: 
Change-Id: I39e2a7d0906be5f8883d7467d2414babf6a84362
Reviewed-on: https://chromium-review.googlesource.com/571559Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486694}

This is one of the efforts to organize core/dom files.
See https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit?usp=sharing
for details.

The name of core/typed_arrays honers the existing name of platform/wtf/typed_arrays.

We might want to remove DOM prefix from files in another CL.

Bug: 738794
Change-Id: Id5b637701fb003a4ce1531d3c5a9534d6708ca1e
Reviewed-on: https://chromium-review.googlesource.com/566756
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486693}

Test: interactive_ui_tests OobeTest.NewUser
Bug: 742695
Change-Id: I1779bc181f4c393ec74e523e346da601d1da6eef
Reviewed-on: https://chromium-review.googlesource.com/571525Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486692}

Now that ChildProcessLauncher has been moved to base, changed the
MultiprocessTestClient to use it instead of duplicating the
functionality.

Bug: 702316
Change-Id: I3828f7cf16d815b45c7aca9925ef4b69866e66f4
Reviewed-on: https://chromium-review.googlesource.com/562519
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486691}

It was needed because we couldn't use net errors in blink. We can use them
now.

Bug: 702845
Change-Id: I76ce587a437e6c64810de0b0b8d6894951162037
Reviewed-on: https://chromium-review.googlesource.com/571562Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486690}

HomedirMethods::MountEx was converting MountParameters to MountRequest proto.
To simplify this, remove MountParameters and use MountRequest everywhere.

- Construct MountRequest directly in MountEx's caller sites.
- Rename FillKeyProtobuf() in homedir_methods.cc to
KeyDefinitionToKey(), and make it public.

BUG=741274

Change-Id: Ibb8dd4a7975f6aff87ada881938be29300e7344c
Reviewed-on: https://chromium-review.googlesource.com/567844Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486689}

This CL takes advantage of the mechanisms introduced in
https://codereview.chromium.org/2979933002/ to run the UI Service inside the
browser process in Mushrome (i.e. when chrome is launched with --mus parameter).

UI Service runs on a separate thread with high priority. For now both the UI
Service and the GPU Service are moved. Once WS/GPU split if finished, GPU will
need to be moved into its separate process.

CrOS BrowserProcessPlatformPart owns the ImageCursorsSet used by the UI Service
for cursor manipulation.

BUG=722527

Review-Url: https://codereview.chromium.org/2983443002
Cr-Commit-Position: refs/heads/master@{#486688}

New animation first makes copies of screen, and chagnes
the rotation after these copies are made. If a device enters
tablet mode while coyping it may remember the wrong rotation.

BUG=742605
TEST=covered by unit tests. Also tested manually:
 1) Start portrait only ARC++ app
 2) Try to close and open the lid multiple times

Change-Id: I835b3409f34f101dac45784eda501635f7fe085e
Reviewed-on: https://chromium-review.googlesource.com/571258
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486687}

Using wpt-import in Chromium 8efa3b7d.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/312

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I9bbffc01856dfa827d0230c2a5637d3e1bb1e660
Reviewed-on: https://chromium-review.googlesource.com/571480
Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486686}

Use the title text instead of multi line message for "CAPS LOCK is ON"
notification.
Primarily fix for MD style notification but also works properly in
the current style.

BUG=740813
TEST=manual

Change-Id: I9121ae49fcf77fa4e7092d4a6a354b1d1a21d04e
Reviewed-on: https://chromium-review.googlesource.com/569329
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486685}

Spec: https://drafts.css-houdini.org/css-typed-om/#csstranslation

Additionally found during testing:
- Z should not be able to be set to null
- Use new CSS.px(1) syntax for inlinestyle/translation test for brevity

BUG=545318

Review-Url: https://codereview.chromium.org/2961243002
Cr-Commit-Position: refs/heads/master@{#486684}

https://skia.googlesource.com/skia.git/+log/ee3e0bacc8be..83d118550f72

$ git log ee3e0bacc..83d118550 --date=short --no-merges --format='%ad %ae %s'
2017-07-13 ethannicholas converted CircleEffect to SkSL
2017-07-13 fmalita Delete unread SkPicture mbox
2017-07-13 bsalomon Move GrAALinearizingConvexPathRenderer off GrLegacyMeshDrawOp
2017-07-13 egdaniel Add support for creating a GrContext backed by Metal.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: I1c4299ac66aa68f14c8c48a83bd2aa85c2d82f0e
Reviewed-on: https://chromium-review.googlesource.com/570994Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486683}

When performing a scrollIntoView, if some scrolling boxes in the chain has the smooth
behavior while the others don't, the sequenced smooth scrolls shouldn't be aborted.
This patch fixes the bug by setting the ScrollType to kSequencedSmoothScroll once we
noticed a smooth scroll in the scroll chain, so that ScrollableArea::SetScrollOffset()
will not abort the sequenced smooth scrolls.
This patch also moves the first call of RunQueuedAnimations() to
LayoutObject::ScrollRectToVisible() to make sure that all sequenced smooth scrolls get
a chance to run.

Bug: 735863
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8d72bcc873efcf82883ab7272328c3759789e7a3
Reviewed-on: https://chromium-review.googlesource.com/550237Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486682}

This should be a no-op functionality wise.

This patch introduces CustomTabsUiType as a better way to specify the
look&feel of the UI. In this and following patches I will aim to
minimize number of intent EXTRAs and replace multiple booleans
indicating visibility of various UI elements with a single value
specifying a UI type.

This patch takes care of only few low hanging fruits to make it easy to
review. I plan to make a few more code structure and readability
improvements on top of this later on.

This refactoring is considered a prerequisite to introducing Minimal-UI
PWA display mode, which is yet another UI type for Custom Tab.

Bug: 604390
Change-Id: Ifa75e341dd1f7ac64cfa70c4dbb507b3df9c7f6c
Reviewed-on: https://chromium-review.googlesource.com/567789
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486681}

Discussion at crrev.com/10983063. The comments at
crrev.com/10983063#msg16 says that the only issue with supporting
PurgeMemory for session storage is it would set is_initial_import_done_
to false and this could potentially cause an import if GetItem is
called. So, the fix should just be not setting import_done_ to false if
map is empty.
For the case when a SetItem is called before Purge, PurgeMemory would
be noop since it has uncommitted changes.

BUG=696112

Change-Id: I1a57c49dea41e030f5770b9d74742984b920f1d1
Reviewed-on: https://chromium-review.googlesource.com/560722
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486680}

TBR: thakis@chromium.org
Bug: 742670
Change-Id: I3e6bfb0d990f36c5643f3f766d63a0dae0c243c3
Reviewed-on: https://chromium-review.googlesource.com/571538Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486679}

BUG=727174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2962283002
Cr-Commit-Position: refs/heads/master@{#486678}

This CL moves the three standard functionality LayoutTests for 
mediacapture-fromelement to the external/wpt folder, adapting 
them accordingly and adding the necessary webmfiles.

Also removes the HTMLMediaElementCapture-*.html expectations.

Bug: 619625
Change-Id: If06df91ae918b5f0d3eacc597c88709a83227a82
Reviewed-on: https://chromium-review.googlesource.com/566151
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486677}

This is preparation to remove MockCryptohomeClient,
as preparation to replace Callback by OnceCallback in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: I4b6f21228e402973a18e07aa5d80a134b2018f58
Reviewed-on: https://chromium-review.googlesource.com/569798Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486676}

This CL refactors how mouse focus hides the focus ring by moving the
listener into the app and using keyboard events to restore the focus ring
instead of blur event. This reduces the number of event listeners and deals
well with window focus/blur.

BUG=740834
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2981503002
Cr-Commit-Position: refs/heads/master@{#486675}

- Update obsolete comments
- Remove UMA recording in virtual_keyboard_private because it's
  recorded in HideKeyboard.
- Remove an unused method.
- Move FullWidthKeyboardBoundsFromRootBounds to keyboard_test_util.
- Mark some methods of KeyboardController const methods.

Bug: 731537
Test: All tests pass.
Change-Id: I99b1956519465c805c4e8bee3debb41f1f194817
Reviewed-on: https://chromium-review.googlesource.com/568059Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486674}

This is to help track the effectiveness of warming up the service worker for
search from the omnibox.

This rather unfortunately adds a public content API since all the smarts
about detecting Google Search URLs are (rightly) in //chrome but we want to
log the UMA in //content. I think someday a patch like
https://chromium-review.googlesource.com/c/566764/ can be landed that
moves the UMA entirely to //chrome.

Bug: 724337, 732681
Change-Id: I1a4671111c583a30963b5a34a1c4bc605fc07f14
Reviewed-on: https://chromium-review.googlesource.com/569550
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486673}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/e79b0c77..137ec42a

$ git log e79b0c77..137ec42a --date=short --no-merges --format='%ad %ae %s'
2017-07-10 yusukes@google.com Add |create_server_socket| to arc.proto
2017-06-13 ljusten@chromium.org authpolicy: Add common_name to ActiveDirectoryAccountInfo

BUG=chromium:737148
TEST=try

Change-Id: Iba3d07cf332afa6b3596f508777a95ca9ae98378
Reviewed-on: https://chromium-review.googlesource.com/570884Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486672}

Enable NetInfo rtt, downlink, effectiveType APIs on all platforms.

Currently, NetInfo API is enabled only on Android and ChromeOS
platforms. To enable the rtt, downlink, effectiveType attributes
on all platforms, this CL also enables NetInfo API on all platforms
and then selectively disables other existing attributes
(type, downlinkMax, typeChange) on non-Android,
non-ChromeOS platforms.

Bug: 723068
Change-Id: Ife4388240d6434aebf3f31d7a402d310bd4f587c
TBR: pfeldman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/565342
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Charlie Reis (OOO until July 19) <creis@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486671}

This dumps more state notably including time since last begin frame and
the last few actions.

TBR=brianderson
BUG=622080

Change-Id: I51590aa3e2859b448ca2eafd45046f6f123e9331
Reviewed-on: https://chromium-review.googlesource.com/571286Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486670}

When:
 - a simple gesture nav affordance is performing a complete or abort
   animation; and
 - a new overscroll is started; and
 - the new overscroll is going to be ignored because, for example, there
   is no item in the navigation history to navigate to;
the overscroll updates should be ignored. Currently, they would be sent
to the animating affordance until its animation is complete and the
instance is deleted.

An example situation this can happen is when there is no page to
navigate back to, but there is a page to navigate forward to. If you
start a forward overscroll with touchpad, then swipe quickly in the
opposite direction, the forward overscroll will be aborted and a back
overscroll will be started. However, since there is no page to navigate
back to, no new affordance is created and overscroll updates would be
sent to the existing animating forward affordance. This bug is
introduced in r477865.

BUG=668296
TEST=manual

Change-Id: I110addf3a58132edd70384b881835cfe6c4c93c2
Reviewed-on: https://chromium-review.googlesource.com/565759Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486669}

Bug: 740102
Change-Id: I250fde1868f3c244c8db51a2fcf54d30c946f470
Reviewed-on: https://chromium-review.googlesource.com/564958
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486668}

There are two JS hooks we used in handling exceptions in extensions
bindings:
- There is an exposed "handleException" method, which handles exceptions
  encountered in running untrusted code.
- The test API allows us to set custom handlers for uncaught exceptions
  (so we can fail a test or verify expected errors).

Implement each of these in the utilities exposed to the JS bindings, and
add unittests for the same.

Bug: 653596
Change-Id: I246308c78b0760f5176949c2b1d88da07dca337a
Reviewed-on: https://chromium-review.googlesource.com/568692Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486667}

This is one of the efforts to organize core/dom files.

See https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit?usp=sharing
for details.

Bug: 738794
Change-Id: I953cc0bc075fea503770af09d7dbc76f38d85b67
Reviewed-on: https://chromium-review.googlesource.com/569532Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486666}

Bug: 
Change-Id: I505ff0549952be51a67ca9da38674e87a4f4fe31
Reviewed-on: https://chromium-review.googlesource.com/568086
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486665}

Use the ExceptionHandler when dispatching events to listeners, rather
than a verbose TryCatch. Add unit tests for the same.

Bug: 653596
Change-Id: Id510d9d3d406c68ef051d1a616d5f8e3586c6303
Reviewed-on: https://chromium-review.googlesource.com/568408
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486664}

Also:
- Print out `git apply` error message in LocalWPT.test_patch
- Add accidentally omitted return statement in WPTGitHub.pr_for_chromium_commit

Bug: 737898
Change-Id: Id35454a3a5a91dd4963c7e7f0f86d5a29fb79cfd
Reviewed-on: https://chromium-review.googlesource.com/571400Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486663}

This CL creates a protected extension for BookmarkHomeViewController,
so that subclasses can access the protected method and read/write
properties without exposing it on the super class API.

Bug: 705339
Change-Id: I1f6d447855ba5fbabd1676a7bc00bec38f4a1d8b
Reviewed-on: https://chromium-review.googlesource.com/569525
Commit-Queue: Ramya Sharma <ramyasharma@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486662}