GitLab

BUG=596760

Review-Url: https://codereview.chromium.org/2901843002
Cr-Commit-Position: refs/heads/master@{#473932}

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ12LwjKAAAJ

This CL fixes 168 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043

Review-Url: https://codereview.chromium.org/2881323002
Cr-Commit-Position: refs/heads/master@{#473931}

WebView applications can throw run-time exceptions within
WebView-callbacks. When such an exception is thrown from the callback
passed to evaluateJavascript it is not correctly propagated to Android's
feedback mechanism. This is because that callbacks is called through
JNI, and the default way (in Chromium) of handling Java exceptions
thrown on the Java-side of JNI calls is to print the stack trace for the
current exception to the logcat when the JNI call returns to native, and
then intentionally crash in native.

With this CL we avoid the problem of propagating a Java exception back
through JNI and the native stack by posting the WebView-callback (which
can cause the Java exception) as a new task to the current Java Handler.
In that way any Java exception thrown inside the WebView-callback can be
propagated directly up to the Android framework's
UncaughtExceptionHandler which then properly reports the Exception
through the framework's crash reporting mechanism.

BUG=719396

Review-Url: https://codereview.chromium.org/2900033002
Cr-Commit-Position: refs/heads/master@{#473930}

BUG=722949

Review-Url: https://codereview.chromium.org/2884393002
Cr-Commit-Position: refs/heads/master@{#473929}

Review-Url: https://codereview.chromium.org/2898153002
Cr-Commit-Position: refs/heads/master@{#473928}

This API will allow to use DidStartNavigation callback instead of
deprecated -[CRWWebDelegate webWillReload].
DidStartNavigation will check if NavigationContext::GetPageTransition
returns reload transition to act on reload navigation.

BUG=674991

Review-Url: https://codereview.chromium.org/2896623003
Cr-Commit-Position: refs/heads/master@{#473927}

BUG=
R=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2895213004
Cr-Commit-Position: refs/heads/master@{#473926}

This enum controls whether tasks posted within the scope of a
ScopedTaskEnvironment can run as they are posted or have to wait
until a call to RunUntilIdle() to run.

BUG=724077
TBR=gab@chromium.org

Review-Url: https://codereview.chromium.org/2891363005
Cr-Commit-Position: refs/heads/master@{#473925}

BUG=None

Review-Url: https://codereview.chromium.org/2884213002
Cr-Commit-Position: refs/heads/master@{#473924}

- Adds support for textfields with UIPickerView to edit view controller.
- Mediator dynamically creates editor fields based on selected country.
- Mediator loads regions asynchronously and notifies view controller.
- Hooks up address edit coordinator with country selection coordinator.
note: There is still no validation and saving the form results in DCHECK

http://imgur.com/a/P52tS

BUG=602666

Review-Url: https://codereview.chromium.org/2893353002
Cr-Commit-Position: refs/heads/master@{#473923}

Instead of dispatching events at begin-frame + offset, dispatch events
at regular intervals (~16ms). The timer starts at an offset from the
first begin frame.

BUG=722921

Review-Url: https://codereview.chromium.org/2886263002
Cr-Commit-Position: refs/heads/master@{#473922}

The following args are required to generate map files that work with
//tools/binary_size/supersize on Linux:
  * is_official_build = true
  * allow_posix_link_time_opt = false
  * generate_linker_map = true

BUG=723798

Review-Url: https://codereview.chromium.org/2896633002
Cr-Commit-Position: refs/heads/master@{#473921}

and corresponding tests.

BUG=718475

Review-Url: https://codereview.chromium.org/2884013002
Cr-Commit-Position: refs/heads/master@{#473920}

On macOS when the adapter turns off all devices are disconnected[1] but
didDisconnectPeripheral is not called by the OS.

This was causing us to think that the device was still connected,
keep around all its attributes and dispatch operations on the device
even though the device was disconnected.

Fixes the issue by calling didDisconnectPeripheral for each of our
connected BluetoothDevices.

[1] https://developer.apple.com/reference/corebluetooth/cbcentralmanagerdelegate/1518888-centralmanagerdidupdatestate?language=objc

Bug: 724300, 511025
Change-Id: I1dc0f63fcf55949a4596f0ba05a87f158840df16
Reviewed-on: https://chromium-review.googlesource.com/511882
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473919}

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG=723739

Review-Url: https://codereview.chromium.org/2890843003
Cr-Commit-Position: refs/heads/master@{#473918}

Add, implement, and call some methods in NetworkDelegate to check
whether sites are allowed to store reports and clients.

BUG=704259,676324

Review-Url: https://codereview.chromium.org/2891133003
Cr-Commit-Position: refs/heads/master@{#473917}

Before this patch, phone numbers in web payments UI on desktop were
displayed without formatting, e.g., "3103106000". This is hard to read.
This patch changes address and contact info to use formatted phone
numbers in labels and editors, e.g., "+1 310-310-6000".

Bug: 725196
Change-Id: I03ceb8e095f1e21c085ab19ab59b963464408f80
Reviewed-on: https://chromium-review.googlesource.com/511063Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473916}

BUG=721943
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2884563002
Cr-Commit-Position: refs/heads/master@{#473915}

This makes the "testDataDirectory" and the "testWebSocketPort" keys
being optional in the test config that can be accessed via the
chrome.test.getConfig method.

This allows to skip filling of these keys with some fake values in tests
that are not inherited from ExtensionApiTest.

Bug: chromium:626343
Change-Id: I142ddc22af7b798bc93484086a42b39d5fbd466d
Reviewed-on: https://chromium-review.googlesource.com/511142Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473914}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/213c7195..4eb9e4f0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2896283002
Cr-Commit-Position: refs/heads/master@{#473913}

The SwiftShader repository now contains the Subzero source code using
a Git subtree.

BUG=swiftshader:47

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862803003
Cr-Commit-Position: refs/heads/master@{#473912}

BUG=None

Review-Url: https://codereview.chromium.org/2893963002
Cr-Commit-Position: refs/heads/master@{#473911}

Disable benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter

It is flaky. See bug

TBRing a contributor to the test file.

BUG=725386
TBR=nednguyen

Review-Url: https://codereview.chromium.org/2896293002
Cr-Commit-Position: refs/heads/master@{#473910}

Use ids instead in case objects disappear before we have a chance
to fire the events.

BUG=725203

Review-Url: https://codereview.chromium.org/2900893003
Cr-Commit-Position: refs/heads/master@{#473909}

Previously there were many PNGs for the cards in Payment Request. Now
this code uses the Autofill assets, which are vector drawables.

Additionally:
* MIR, JCB and Diners cards are now a drawable in Autofill
(previously PNG or generic icon on Android)
* Fixed a few other drawables.
* Removing the border from the PR icons because it's now built-in the asset
* Using setImageDrawable because it appears to be more efficient

BUG=722651
TEST=visual

Review-Url: https://codereview.chromium.org/2888803003
Cr-Commit-Position: refs/heads/master@{#473908}

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment apps request full origin.

BUG=720027

Review-Url: https://codereview.chromium.org/2894153003
Cr-Commit-Position: refs/heads/master@{#473907}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892

Review-Url: https://codereview.chromium.org/2883273002
Cr-Commit-Position: refs/heads/master@{#473906}

We were previously skipping all symbols when calling GetOwnPropertyNames()
due to https://github.com/heycam/webidl/issues/294 being unresolved at the
time the code was written, as well as to maintain compatibility with Gecko,
which did the same at the time.

That GitHub issue has since been resolved: enumerable symbols should not be
skipped but rather just throw a TypeError when a string conversion function
is called on it. Gecko is also being updated, and this CL adjusts our code
accordingly.

The new tests being added to headers-record.html come from Boris Zbarsky
<bzbarsky@mit.edu> and were originally written in
https://bugzilla.mozilla.org/show_bug.cgi?id=1366032. They are being
included here mostly to both help test the CL, as I believe they will be
landed in Gecko and synced to web-platform-tests before this CL lands and we
end up upstreaming the changes.

While here, remove a duplicate test case in NativeValueTraitsImplTest.

BUG=724481
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2900743002
Cr-Commit-Position: refs/heads/master@{#473905}

Make sure to return resources of a surface immediately once it's
destroyed. Currently we have to wait until surface aggregation time.
This caused memory leak in webview after a recent change. In this CL
we notify cc::Display to release the resources through the
SurfaceObserver interface.

BUG=719379
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2897673002
Cr-Commit-Position: refs/heads/master@{#473904}

BUG=none
R=bauerb@chromium.org

Change-Id: Ia241e571e4e48290c9c612253a00156b44d92b0e
Bug: 725510
Reviewed-on: https://chromium-review.googlesource.com/512823
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473903}

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory: '/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the
  new test cases added in this CL. I am disabling these test cases for now, and
  added https://crbug.com/725271 to track the issue.

Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"
TBR=mcasas@chromium.org,rockot@chromium.org,piman@chromium.org,tsepez@chromium.org

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2896913002
Cr-Commit-Position: refs/heads/master@{#473902}

https://skia.googlesource.com/skia.git/+log/9f85d68887a6..92de631edd3e

$ git log 9f85d6888..92de631ed --date=short --no-merges --format='%ad %ae %s'
2017-05-23 robertphillips Remove compressed (ETC1) texture support from Ganesh (take 2)
2017-05-23 mtklein remove min from repeat and mirror generally

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ibabe967f315107fd15af425415277cd057e87c23
Reviewed-on: https://chromium-review.googlesource.com/512363Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473901}

tools\metrics\histograms/pretty_print.py fails to parse
tools/metrics/histograms/histograms.xml due to
1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult
2) ERROR:root:Unrecognized tag "obselete"

The failure of running pretty_print.py blocks uploading any CL
containing histograms.xml!

This CL removes DnsProbe.obsoleteProbeResult in three obsolete
histograms, and fixes "obselete" to "obsolete".

Running tools\metrics\histograms/pretty_print.py formats a few other
lines of code. This CL keeps this change.

BUG=725310

Review-Url: https://codereview.chromium.org/2896953002
Cr-Commit-Position: refs/heads/master@{#473900}

Stop using "setAutoCancel()". The docs say that this triggers the
"delete" intent, and we don't want to do that because that intent is
used to watch for dismissal. As it happens, the docs are wrong
(https://b.corp.google.com/issues/36961721), but one day Android might
fix that bug.

Guard all calls to recordCachedActionMetric() with
removeActiveNotification(). This should ensure that we only get one
action per notification. This already should have been the case (you
shouldn't be able to tap after dismissal), but might in theory be more
robust.

BUG=724081

Change-Id: I5f121bdaf07dee1988468e345634fe9d32e6fe34
Reviewed-on: https://chromium-review.googlesource.com/509615
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473899}

Revert of Attempt #3 at registry outage: ShellExecute reg delete (patchset #1 id:1 of https://codereview.chromium.org/2897483003/ )

Reason for revert:
Nuclear cleanup no longer needed (and having reg.exe run in parallel with the browser_tests that are starting can cause flakiness in itself).

Original issue's description:
> Attempt #3 at registry outage: ShellExecute reg delete
>
> Nuclear option to be reverted after the bots heal up.
>
> BUG=721245
> R=thakis@chromium.org
>
> Review-Url: https://codereview.chromium.org/2897483003 .
> Cr-Commit-Position: refs/heads/master@{#472945}
> Committed: https://chromium.googlesource.com/chromium/src/+/f26f6233d2d8be69c638ddac047db13fd6f14062

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=721245

Review-Url: https://codereview.chromium.org/2902683003
Cr-Commit-Position: refs/heads/master@{#473898}

Currently one BackgroundServiceManager is created per batch of browser_tests.
This ends up leaving the UI and Ash process running between tests.

This is especially problematic for tests with PRE_test where state is expected
to not be preserved into the following test.

This change delays the initialization of a BackgroundServiceManager until the
child test process has connected to the MojoTestState. Subsequent tests will
tear down the previous BackgroundServiceManager before creating the new one.

This also tears down the UI and Ash processes as desired.

TEST=mash_browser_tests
BUG=678687

Review-Url: https://codereview.chromium.org/2858103002
Cr-Commit-Position: refs/heads/master@{#473897}

This CL cleans-up an obsolete pref entry in BookmarkSuggestionsProvider.
As a result, PrefService is not needed anymore in this provider.

As a slightly unrelated cleanup, this CL removes anything bookmarks-
related from the iOS factory which does not create the provider any
more.

BUG=none

Review-Url: https://codereview.chromium.org/2895943002
Cr-Commit-Position: refs/heads/master@{#473896}

Wait to show the toolbar buttons until the sheet offset is less
than 45%. 45% is used rather than 50% so that the buttons
aren't shown in the half height state if the user is dragging the
sheet down slowly and releases at exactly the half way point.

BUG=725000,695157

Review-Url: https://codereview.chromium.org/2898093002
Cr-Commit-Position: refs/heads/master@{#473895}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
TBR=hirono@chromium.org, kinuko@chromium.org,

Review-Url: https://codereview.chromium.org/2887933002
Cr-Commit-Position: refs/heads/master@{#473894}

BUG=653259

Review-Url: https://codereview.chromium.org/2902523002
Cr-Commit-Position: refs/heads/master@{#473893}