GitLab

Without PurgePluginListCache(), the plugin list info in existing renderer processes
is not updated. User has to close the original tab and open a new tab to be able to
load the plugin.

BUG=394988
TEST=CDM loaded after refreshing tab after CDM update now.

Review URL: https://codereview.chromium.org/400273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284606 0039d316-1c4b-4281-b951-d872f2087c98

This CL does 2 things:

1. The setting of App Launcher dr=1 is now only used for GOOGLE_CHROME_BUILD.

2. Refactoring: In r273321, we extracted AppRegistrationData from BrowserDistribution,
and make it part of BrowserDistribution by composition. In this CL, we
use this new flexibility, and cut the dependence of app_list_service_win.cc
on ChromeAppHostDistribution by just giving it the AppRegistrationData part
it needs.

The required const kAppLauncherGuid now lives in chrome_launcher_support.

BUG=297647

Review URL: https://codereview.chromium.org/374413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284605 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Change TileManager iterators to be queues. (https://codereview.chromium.org/406543003/)

Reason for revert:
TileManagerTilePriorityQueueTest.EvictionTilePriorityQueueWithOcclusion consistently times out on Win7 bot
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/29899


Original issue's description:
> cc: Change TileManager iterators to be queues.
> 
> This patch is mostly just moving code around. It moves the iterators
> from tile manager to be in separate files, renames them to be queues.
> 
> It also adds a tile manager client interface for building the queues.
> 
> The rest is just fix ups for the tests.
> 
> R=reveman
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284506

TBR=reveman@chromium.org,vmpstr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/406183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284604 0039d316-1c4b-4281-b951-d872f2087c98

Before: https://drive.google.com/file/d/0B1B1Up4p2NRMLTQ1ZFc0blIwbzA/edit?usp=sharing
After: https://drive.google.com/file/d/0B1B1Up4p2NRMVUloNWhYY1luQjg/edit?usp=sharing

BUG=NONE
TEST=Start Chrome with --new-profile-management. Click on the avatar button.
The bubble's right edge should be perfectly aligned to the button's edge.

Review URL: https://codereview.chromium.org/404443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284603 0039d316-1c4b-4281-b951-d872f2087c98

Instead, just use plain gdb, which should be able to handle 32-bit binaries.

NOTRY=true

Review URL: https://codereview.chromium.org/404303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/409673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/385263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284600 0039d316-1c4b-4281-b951-d872f2087c98

Adding an Init method to the Broadcaster, that gets invoked while initializing the host.
The Init method broadcasts the original on_power_battery value to the new processes.

BUG=153139

Review URL: https://codereview.chromium.org/401083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284599 0039d316-1c4b-4281-b951-d872f2087c98

Mostly mechanical change to finish migrating time-related
methods from AudioRenderer to TimeSource.

BUG=370634

Review URL: https://codereview.chromium.org/403723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284598 0039d316-1c4b-4281-b951-d872f2087c98

This CL applies the default system font style to extension pages.
Extensions that specify their own fonts will still override these styles. 

BUG=141703, 395319

Review URL: https://codereview.chromium.org/400343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284597 0039d316-1c4b-4281-b951-d872f2087c98

R=bruening@chromium.org
NOTRY=TRUE
BUG=NONE

Review URL: https://codereview.chromium.org/406853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284596 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/398823010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284595 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/396273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284594 0039d316-1c4b-4281-b951-d872f2087c98

src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support
deferred loading of extension background pages when the profile isn't ready
yet. This is a layering violation.

* Remove Chrome concepts like "browser window ready" and "profile created"
from ProcessManager. Introduce ProcessManagerDelegate with a general concept
of deferring background page loading.
* Consolidate all the tricky Chrome-specific background page loading rules into
ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate
each block of special case code with the bug that inspired it.
* Extend unit test coverage for ProcessManager.

This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED
in ProcessManager in a later CL.

(Original CL https://codereview.chromium.org/381283002 broke valgrind bots
because it was initializing left-over BrowserContextKeyedServices from tests
running earlier in the same process.)

BUG=392658
TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual

Review URL: https://codereview.chromium.org/408523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284593 0039d316-1c4b-4281-b951-d872f2087c98

This makes lookups of a WebPreferences field fast.
In order do this, add code to listen to all preferences updates in order to recompute the cache.

BUG=390799

Review URL: https://codereview.chromium.org/373323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284592 0039d316-1c4b-4281-b951-d872f2087c98

Frameworks destroys the underlying EGLContext on after
certain levels of onTrimMemory, so webview must also release
its hardware draw resources to avoid using stale references.

Factor out release hardware resource code in aw_contents.cc
and browser_view_renderer.cc, and call it in onTrimMemory.

BUG=395657

Review URL: https://codereview.chromium.org/408803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284591 0039d316-1c4b-4281-b951-d872f2087c98

The previous version of this test could create up to 4 TestingProfiles:
1. TestingProfile from BrowserWithTestWindowTest::CreateProfile
2. TestingProfileWithHostZoomMap in the test body
3. An incognito version created by (2) via GetOffTheRecordProfile().
4. An incognito version created in the test body

Also the master/incognito relationships between these profiles are unclear.

Reduce this to the 2 needed instances:
1. TestingProfileWithHostZoomMap owned by BrowserWithTestWindowTest
2. An incognito version in the test body

BUG=395329
TEST=unit_tests OffTheRecordProfileImplTest.*

Review URL: https://codereview.chromium.org/403103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284590 0039d316-1c4b-4281-b951-d872f2087c98

This CL contains the implementation of PortAllocatorFactoryInterface in peerconnectioninterface.h. 
It bridges the gap in port allocation objects between WebRTC and Chromium. The factory produces a 
ChromiumPortAllocator that can successfully be used by the PeerConnection API.

Review URL: https://codereview.chromium.org/398813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284589 0039d316-1c4b-4281-b951-d872f2087c98

With compositing enabled by default this UMA always reports "active".

Review URL: https://codereview.chromium.org/405963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381484
TEST=Tested on Windows.

Review URL: https://codereview.chromium.org/404613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284587 0039d316-1c4b-4281-b951-d872f2087c98

Add an app icon mask (16*16, or 32*32 for retina display) on the bottom right corner of notifications to indicate source of the notification. The app icon is displayed in a way that takes only the alpha channel of the image passed in, masks it with white foreground and grey background.

BUG=284592

Review URL: https://codereview.chromium.org/308053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284586 0039d316-1c4b-4281-b951-d872f2087c98

This is similar idea which was already applied in png_codec.cc.
https://codereview.chromium.org/397673002/
(Sorry for making another review request.)

BUG=none
R=erg@chromium.org, sky@chromium.org, dcheng@chromium.org
TEST(DONE&PASSED)=gfx_unittests --gtest_filter="JPEGCodec*"

Review URL: https://codereview.chromium.org/404793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284585 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Telemetry] Disable a Dromaeo benchmark on XP due to OOM. (https://codereview.chromium.org/271583003/)

Reason for revert:
The issue is probably fixed by Blink r176006.

Original issue's description:
> [Telemetry] Disable a Dromaeo benchmark on XP due to OOM.
> 
> BUG=323782
> NOTRY=True
> TBR=dtu@chromium.org
> NOTREECHECKS=True
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268666

NOTRY=true
BUG=323782
TBR=tonyg

Review URL: https://codereview.chromium.org/407023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284583 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
r284521 fixed the underlying problem.

Original issue's description:
> Disable a flaky test.
> 
> BUG=395726
> TEST=none
> TBR=miu
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284516

TBR=pkasting@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395726

Review URL: https://codereview.chromium.org/410563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284581 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284580 0039d316-1c4b-4281-b951-d872f2087c98

22b31e0  Adjust null object check
baca770  Fix remaining -Wdelete-non-virtual-dtor violations on Windows.

BUG=none
R=thestig@chromium.org
TBR=thestig

Review URL: https://codereview.chromium.org/410513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284579 0039d316-1c4b-4281-b951-d872f2087c98

This is based off of http://crrev.com/322523002

BUG=370033

Review URL: https://codereview.chromium.org/370463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284578 0039d316-1c4b-4281-b951-d872f2087c98

Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (https://codereview.chromium.org/402443003/)

Reason for revert:
Broke Mac ASan 64 Builder
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/7520

obj/chrome/browser/ui/cocoa/browser_ui.version_independent_window.o
../../chrome/browser/ui/cocoa/version_independent_window.mm:109:44:error: cannot initialize a parameter of type 'NSComparisonResult (*)(id, id, void *)' with an rvalue of type 'int (*)(id, id, void *)': different return type ('NSComparisonResult' (aka 'long') vs 'int')
      [superview sortSubviewsUsingFunction:&ReorderContentViewToBack
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:175:75: note: passing argument to parameter 'compare' here
- (void)sortSubviewsUsingFunction:(NSComparisonResult (*)(id, id, void *))compare context:(void *)context;


Original issue's description:
> mac: [Yosemite] Fix bug where zoom button causes fullscreen mode.
> 
> In Yosemite, holding down alt while clicking the fullscreen button is supposed
> to zoom the window. This doesn't work because Chrome violates unstated AppKit
> assumptions.
> 
> The problem seems to lie in hit testing the location of the zoom button.
> Reordering the subviews by moving the tab strip and the content view behind the
> zoom button fixes the problem.
> 
> BUG=393808
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284544

TBR=andresantoso@chromium.org,shess@chromium.org,erikchen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393808

Review URL: https://codereview.chromium.org/402323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284576 0039d316-1c4b-4281-b951-d872f2087c98

WaitForExitCode() closes the process handle itself.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/406953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381290

Review URL: https://codereview.chromium.org/390553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284574 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284573 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/407733005/)

Reason for revert:
Seems to be causing xss-DENIED-method-with-iframe-proto.html to time out on multiple bots; see http://crbug.com/395882 .

Original issue's description:
> Update V8 to version 3.28.30 (based on bleeding_edge revision r22489).
> 
> Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.
> 
> TBR=svenpanne@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284420

TBR=svenpanne@chromium.org,machenbach@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/405313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284572 0039d316-1c4b-4281-b951-d872f2087c98

double <br> elements, and adjust CSS to make it look good. Fix up a couple of
IDL files to just use newlines rather than <br> elements.

R=mangini@chromium.org, asargent@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/404203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284571 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/405273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284570 0039d316-1c4b-4281-b951-d872f2087c98

There's only one time of badge icon now, so
remove the enum that specifies the type.

BUG=394855

Review URL: https://codereview.chromium.org/401333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394898
NOTRY=true

Review URL: https://codereview.chromium.org/397293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284568 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add ExtensionsTestBrowserContext class for test. (https://codereview.chromium.org/355223002/)

Reason for revert:
This is breaking the Chrome OS valgrind bots:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20(valgrind)(5)

For example:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/28278

This is a problem with mixing tests that use TestingProfile and TestBrowserContext.  See crbug.com/395820

Original issue's description:
> Add ExtensionsTestBrowserContext class for test.
> and Use ExtensionTestBrowserContext for ImageLoader unittest.
> 
> ExtensionsTestBrowserContext class does 
> set TestExtensionsBrowserClient from constructor and
> call DestroyBrowserContextServices from destructor.
> 
> ExtensionTestBrowserContext will be used instead of TestingProfile.
> 
> R=yoz@chromium.org, rdevlin@chromium.org
> BUG=354046
> TEST=unit_tests --gtest_filter=ImageLoaderTest.DeleteExtensionWhileWaitingForCache
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284330

TBR=jamescook@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/406093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395739,395743
TBR=nednguyen@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/406093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284566 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

BUG=390497

Review URL: https://codereview.chromium.org/407883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284565 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
BUG=http://code.google.com/p/drmemory/issues/detail?id=1528
NOTRY=true

Review URL: https://codereview.chromium.org/401313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284564 0039d316-1c4b-4281-b951-d872f2087c98