- 10 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bba04cfcf312..e93f30741256 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ib008fd525cbb8c541949a54b82c7d1cd59ac2029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815961}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602319457-99315dd935bfb1b8d29d7c96af31a8803cbd1a16.profdata to chrome-win64-master-1602340683-6235385b4e2333b080f0ddd7e9fd94a057a78ff0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0767612c74d4acd5d87a8bc4b736c128bb702c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815960}
-
Jeffrey Young authored
Perform disk operations in SequencedTaskRunner BUG=b:170346308 TEST=activate ambient mode, lock screen Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I5faefd46e74e6ec8ae7061d56e7f6abd0c80326f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460796 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815959}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba814c19c330..bba04cfcf312 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ib3ba43fdf78d83b5592b53936b07b5a92fba232c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463079Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4265.0-1601890590-benchmark-87.0.4280.9-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.15-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibbf8cb6d969e8d0786c35a59d30239e336717ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464742Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602319457-4f9bdaa69ac8be0210a3d1b8c8d37ed03f7eec60.profdata to chrome-win32-master-1602329287-4430a8255045839af70a229385d0ebd7f7aeb9aa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I367f6b34c70a60b70daea1f18f846a5274120934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463759Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium faf64668. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I55b9dd0d36b38f49137ca215858c9dbf5676d695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460955Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815955}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010100700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/cT9lCWDvv6veb3QkbQk0BRcglTeLjCZ2W35O2YG3ez0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ic4e403f440c925048e207b254f5c95ea9f7c7dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464572Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I7de56f894544d5be746a93abdf573a1954986305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463501Reviewed-by:
-
Adrian Taylor authored
This will enable automatic tooling to raise a security crbug if a future security vulnerability (CVE) is reported. Change-Id: I1ace4eb8ba7ef71d884ab0d9f52b3639075dd47c Bug: 895969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464069 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815952}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010100700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/IzAbSag8-IGOAkL2GSMql94a4unzsZtFfkhskHgLSCkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Idd13e3cde171aae305412117252fd2c045e6f90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464573Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cad0d35fe126..ba814c19c330 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I560ea6c93aa7168aa97c23703d7a8c8ec0386516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464570Reviewed-by:
-
Dylan Cutler authored
Bug: 973801 Change-Id: Ied5726f9add1ed7dbd84dbebf5953cf82e7a5ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436650 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815949}
-
Koji Ishii authored
This patch reverts the heuristic logic for hit-testing culled inlines added in r807114 <crrev.com/c/1127976>. This change makes hit-testing of a small number of really long lines (such as minimized HTML source) faster. The test in crbug.com/128937 improves from 180ms to 40ms. Reverting manually because r807114 has a test, which we don't want to revert. Summarizing the history of changes around hit-test performance of culled inlines: 1. Initially, NG took a different approach than legacy, to traverse fragments and check |LayoutObject| ancestors to find culled inlines. Legacy traverses |LayoutObject| tree. 2. r793989 crrev.com/c/2332083 changed to traverse |LayoutObject| to fix |getBoundingClientRect| performance. 3. r807114 crrev.com/c/1127976 reverted it only for descendant cursors. Hit-testing uses this codepath. This improved the performance for a large number of lines, but sacrificed a small number of really long lines. 4. r815524 crrev.com/c/2463086 added an early return to |NGBoxFragmentPainter::HitTestLineBoxFragment|. This improves NG more than the 3rd fix did, producing the similar performance as legacy both for a large number of lines and for a small number of lines. The 3rd fix still improves when there are many lines. This revert reduces `blink_perf/layout/culled-inline-hittest` from 3ms to 4ms, but: * The 4th fix made it fast enough to not need the improvement. * The sacrifice for a small number of lines is high. * The maintainance cost for |IsPartOfCulledInlineBox| is high. hence reverting the 3rd fix. If this revert causes issues in some other cases, we could bring this logic back in, with stricter conditions (only for a large number of lines). But the numbers look good enough and legacy does not have this heuristic that I don't think this will be needed. Bug: 1128937, 1127976 Change-Id: Ib411cf43727d2ba34a935fde98139a3f34261df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463026Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815948}
-
Xianzhu Wang authored
PaintArtifactCompositor::UpdateLayerProperties() now updates layer properties after paint for both pre-CompositeAfterPaint and CompositeAfterPaint. It updates background color, touch action region and non-fast scroll region of layers from paint chunks. It's called from PaintArtifactCompositor::Update or UpdateRepaintedLayerProperties() after paint. Remove original code path from ScrollingCoordinator for touch action and non-fast scroll region and the invalidation logic. Now the update depends on paint invalidation which has been proved to work before this CL. Bug: 1132717 Change-Id: I289008449bb06c98f68805c3af263446bb696d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462107Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815947}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6a560d576f95..46abe35c6554 2020-10-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1c166391c78a7edb63ed4d7e4f9417f92340573c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463874Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602309160-66743b24dcd3419510b8b49da91232ba79a7ac4a.profdata to chrome-linux-master-1602329287-d9e640c0f4fb081a95bb071b07a3e8b9abe79208.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4dcece0cbe91e94519ac9849313f88a985f619f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464569Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If1f7750796bc3e960c76c06cc2166e09de7f5614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463931Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602255148-ebeb3da431f3690e2790a05d46a0bb31c66dafca.profdata to chrome-win32-master-1602319457-4f9bdaa69ac8be0210a3d1b8c8d37ed03f7eec60.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idbd89dde11a4c423f805c89d66422709d8b7b423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464564Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13fc260c7080..aa64c352b349 2020-10-10 bsalomon@google.com Remove legacy gpu blur util code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Iae5f9fb198e4e0947189f6e70f6aa48586533e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464567Reviewed-by:
-
Felipe Andrade authored
This work is been done in preparation for enabling Kerberos on MGS. After that, a new Kerberos section containing the Kerberos Accounts subpage will be created, behind a new flag. Bug: 983041 Change-Id: I3bb06d4e00c146c3344c5693c5a35aa54c967b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450071Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#815941}
-
Antonio Gomes authored
aura::Window* properties in this file will be accessed by both Ash and Lacros code. This CL moves ash::kWindowStateTypeKey to //chrome//ui. It is used by //ash/public/cpp/caption_buttons. This is the last step to be able to move //ash/public/cpp/caption_buttons to //chromeos/ui. Note: Today Lacros code will access the properties directly, but the idea (for now) is to avoid a generic window property API, and instead have specific methods to access it (backed by Mojo) - follow up. BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: I2756bba39c6822ecc087149cf45356ed4514f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456946 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602309160-420cf15e4664325254f25e33474b89fec8e399bb.profdata to chrome-mac-master-1602329287-377f3782d4c02db29be26bdaf518b1d3cd99dfb6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3a9e1158f28f24eff74f71fb7296e6fcb8efbd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464568Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ac5ad08574f..cad0d35fe126 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I428538fc734f143833935b87c21d538516feba9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464566Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602287771-12f4a36a45ea262d6a30914c7505be521a4b9be7.profdata to chrome-win64-master-1602319457-99315dd935bfb1b8d29d7c96af31a8803cbd1a16.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia65bd97b3d505839693f59d04f2b3b1670973c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463773Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0119ad6bd4b4..6ac5ad08574f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I721de19ee0c51c7698b0ea3d2f53d2606d2b369e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461479Reviewed-by:
-
Viktor Semeniuk authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2450409 In this CL removed changes to PasswordViewControllerTestCase which caused flakiness. This change rewrites Passwords tests with new Password Details screen. Obsolete tests are deleted. Fixed flakiness for testSearchAndDeleteAllPasswords. Bug: 1075494 Bug: 1129441 Change-Id: I36fe982d496f641ce1855ac34c7d816a30e3fcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456609Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#815935}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped and AppList tests are no longer parameterized, so branching on kDesktopPWAsWithoutExtensions is no longer required. Bug: 1065748 Change-Id: I5ffc8cefc65e7526fd25c486967e08798481c263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462890 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815934}
-
Guido Urdaneta authored
Rename GetVideoTrack() to From() for consistency with MediaStreamAudioTrack and other similar methods. Make it take a MediaStreamComponent* instead of a WebMediaStreamTrack. Since MediaStreamVideoTrack is now an internal Blink class, there is no need to use the public WebMediaStreamTrack. Bug: 704136 Change-Id: I31d25f21d1c7fe28b301db1b12d1bd764186d4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453249 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#815933}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I863d14d47406e340a1b18df530899094d79c5f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463870Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815932}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602287771-6582fddffd79e54a4c5bb374e875a47a445d5a13.profdata to chrome-mac-master-1602309160-420cf15e4664325254f25e33474b89fec8e399bb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iff2732ca3e36830d7ad0f3660a74c89d450e4190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464562 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Chong Gu authored
Move processing the flag to target specification args. Remove the argument from being processed by the emulator target classes. Bug: 1131989 Change-Id: I6962d2de51d89c6cac8e3e07a6947c6c39b706c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444799 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#815930}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I8cf9ee060d3b681f60694e36030b4d9872e5b241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463707Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815929}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602244639-9ed9777b412f549b6770ee430e4768c83e1e2c1e.profdata to chrome-win64-master-1602287771-12f4a36a45ea262d6a30914c7505be521a4b9be7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6bb671b3864aadb1be16a62a56aeed2ae0301ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464463Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602287771-5a4744893ab8d8351bab84c392978fd4b5e8c1e1.profdata to chrome-linux-master-1602309160-66743b24dcd3419510b8b49da91232ba79a7ac4a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0c5728ff7dff262b58024c4c49de248e6d9b0efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464396Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f282004607b3..6a560d576f95 2020-10-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If08f351c73ab78608133ea223abef480da306909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464395Reviewed-by:
-
kylechar authored
It doesn't appear to be used anywhere and some of the flags it adds no longer exist. Fixed: 1133368 Change-Id: I32833b330ca574b18dc0ca5e457ab9acbe0ab333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450329 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815925}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0588e290272..0119ad6bd4b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I2b9c16e23536050b92f965cbae78ccd479225961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463867Reviewed-by:
-
Wenbin Zhang authored
This reverts commit e94960c9. Reason for revert: Windows build start failing since this build: https://ci.chromium.org/p/chrome/builders/ci/win64-builder-perf/231735 Error message: [8250/14154] CXX obj/device/vr/vr/oculus_device.obj FAILED: obj/device/vr/vr/oculus_device.obj ... ../../device/vr/oculus/oculus_device.cc(69,17): error: no member named 'stage_parameters' in 'device::mojom::VRDisplayInfo' display_info->stage_parameters = mojom::VRStageParameters::New(); ~~~~~~~~~~~~~~^ ../../device/vr/oculus/oculus_device.cc(77,17): error: no member named 'stage_parameters' in 'device::mojom::VRDisplayInfo' display_info->stage_parameters->mojo_from_floor = mojo_from_floor; ~~~~~~~~~~~~~~^ ../../device/vr/oculus/oculus_device.cc(81,17): error: no member named 'stage_parameters' in 'device::mojom::VRDisplayInfo' display_info->stage_parameters->bounds = ~~~~~~~~~~~~~~^ Original change's description: > Use a single, consistent path to update stage parameters. > > Removes stage_parameters from VRDisplayInfo and updates the XR frame > request loop to exchange an stage_parameters_id to indicate what version > of the parameters the session has so that only updates need to be sent. > > Part of an ongoing process to remove VRDisplayInfo entirely. > > Bug: 998146 > Change-Id: I6f41dc2426b529694903d1e46cdadc16841b2b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460976 > Commit-Queue: Brandon Jones <bajones@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815903} TBR=palmer@chromium.org,bajones@chromium.org,alcooper@chromium.org Change-Id: Ic7073de29891c16d5a62f88bb6672e8338b5ece2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464348Reviewed-by:
-
Kushagra Sinha authored
Notify AccountManager observers in lacros-chrome about account updates in AccountManager in ash-chrome. Bug: 1117478 Test: unit_tests --gtest_filter="*AccountManagerAshTest*" Change-Id: Ibddec136dc428c6f07413e106a49cc5e16d227e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461272 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
