- 16 Mar, 2016 40 commits
-
-
thestig authored
Review URL: https://codereview.chromium.org/1783133002 Cr-Commit-Position: refs/heads/master@{#381565}
-
pdr authored
This patch rebaselines the following svg tests: svg/batik/text/textAnchor3.svg svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg These tests just need new baselines. I manually verified they are correct. BUG=589525 TBR=fgorski@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1808653007 Cr-Commit-Position: refs/heads/master@{#381564}
-
fmalita authored
Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp interoperability: * adoptRef(sk_sp<T>) - for adopting sk_sps rvals into PassRevPtr (when transferring ownership from Skia->Blink) * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp (when transferring ownership from Blink->Skia) Update clients to use the new Skia shader factories ("makers" vs. prev "creators"), and sk_sp-based setters. A tangential change: deconstify SkPicture fields/args to align with the new Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now expects non-const SkPicture args). BUG=skia:5077 R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org Review URL: https://codereview.chromium.org/1789063005 Cr-Commit-Position: refs/heads/master@{#381563}
-
kulshin authored
BUG=561873 Review URL: https://codereview.chromium.org/1805803002 Cr-Commit-Position: refs/heads/master@{#381562}
-
dgozman authored
BUG=595348 Review URL: https://codereview.chromium.org/1811533004 Cr-Commit-Position: refs/heads/master@{#381561}
-
nektar authored
BUG=484228 TESTED=unit test, dump accessibility tree tests, manually with Jaws and NVDA screen readers R=dmazzoni@chromium.org,aboxhall@chromium.org Review URL: https://codereview.chromium.org/1768753003 Cr-Commit-Position: refs/heads/master@{#381560}
-
sergeyu authored
Spake2Authenticator requires that local_id and remote_id are the same on both ends of the connection, so JIDs need to be normalized to avoid issues when one of the ends gets JID in a different case. BUG=589698 Review URL: https://codereview.chromium.org/1803893002 Cr-Commit-Position: refs/heads/master@{#381559}
-
enne authored
To avoid cc::Scheduler having to sometimes own / sometimes create / switch between sources / manage parameters on sources, hoist all this logic up to the owners of cc::Scheduler. This refactoring makes it possible to eventually allow an OutputSurface to set a BeginFrameSource on its client and then forward that to the scheduler to use. That future is made easier by the scheduler having a single begin frame source managed by its owner. This patch adds a bit of duplicated logic in three places (single thread proxy / threaded proxy / tests) for the creation of the begin frame source. However, the single thread and threaded versions were already doing different things (re: authoritative vsync signals). The hope is that the vsync information and begin frame source creation for the synthetic sources can get further hoisted into OutputSurface itself. Depends on https://codereview.chromium.org/1762823002 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1765723002 Cr-Commit-Position: refs/heads/master@{#381558}
-
atanasova authored
If the icon path that we get from the manifest contains a reference to the parent directory ("..") we would not save it and associate with the whitelist. This is done in order to avoid malicious access to parent folders. Review URL: https://codereview.chromium.org/1770313004 Cr-Commit-Position: refs/heads/master@{#381557}
-
mdjones authored
This change introduces the OverlayPanelEventFilter; a single event filter for any of the actions that can occur on an OverlayPanel. This change will be used once OverlayPanels are SceneOverlays. Tests added here: https://codereview.chromium.org/1808653006 BUG=584340 Review URL: https://codereview.chromium.org/1739203003 Cr-Commit-Position: refs/heads/master@{#381556}
-
rdevlin.cronin authored
If there is an existing chrome://extensions page open, it should be able to be overridden to show an extension's options page if that options page opens in a view in the chrome://extensions page. BUG=595253 Review URL: https://codereview.chromium.org/1805013005 Cr-Commit-Position: refs/heads/master@{#381555}
-
sigbjornf authored
Drop the unnecessary restriction that eagerly finalized objects aren't allowed to touch access other eagerly finalized, but live, objects during finalization. They're allowed to access live objects in other heaps/arenas, so the same-heap restriction makes little sense. Simplify the HeapPage poisoning methods as a result. R=haraken BUG=594129 Review URL: https://codereview.chromium.org/1805343004 Cr-Commit-Position: refs/heads/master@{#381554}
-
bnc authored
git cl lint told me to: * include <vector> for vector, * mark single argument constructor explicit, * leave space before '('. Codesearch told me that SpdySession::pool_ is never set to nullptr, removing incorrect comment. BUG= Review URL: https://codereview.chromium.org/1801293002 Cr-Commit-Position: refs/heads/master@{#381553}
-
fgorski authored
Revert of Remove the leak expectation for web-animations-api/player-cancel-event.html since it seems to be wo… (patchset #1 id:1 of https://codereview.chromium.org/1766243002/ ) Reason for revert: https://codereview.chromium.org/1750453002 was reverted and now the leak is happening again. Original issue's description: > Remove the leak expectation for web-animations-api/player-cancel-event.html. > > It seems to have been fixed by https://codereview.chromium.org/1750453002 > > BUG=588598 > > Committed: https://crrev.com/bc817fe1b14552590efd801e683686074e928570 > Cr-Commit-Position: refs/heads/master@{#379721} TBR=alancutter@chromium.org,dsansome@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=588598 Review URL: https://codereview.chromium.org/1809783002 Cr-Commit-Position: refs/heads/master@{#381552}
-
lushnikov authored
BUG=none R=dgozman, pfeldman Review URL: https://codereview.chromium.org/1809773002 Cr-Commit-Position: refs/heads/master@{#381551}
-
robertocn authored
TBR=sullivan BUG=595069 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1801123003 Cr-Commit-Position: refs/heads/master@{#381550}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/07ebb39b800b..e4173cd91158 $ git log 07ebb39b8..e4173cd91 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1809763002 Cr-Commit-Position: refs/heads/master@{#381549}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d229a3a..e27a07b4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1805413003 Cr-Commit-Position: refs/heads/master@{#381548}
-
caryclark authored
Fixing bug referred to in crbug.com/591993 correctly changes the output of svg/W3C-SVG-1.1/painting-stroke-04-t.svg Suppress the test failure until it can be rebaselined. R=fmalita@chromium.org BUG=591993 Review URL: https://codereview.chromium.org/1812623002 Cr-Commit-Position: refs/heads/master@{#381547}
-
xjz authored
Main changes when receive a PLI message: 1. Request encoding a Key frame (for now keep the same resolution and bitrate). 2. Clear sending remaining frames before sending out the key frame. BUG=589934 Review URL: https://codereview.chromium.org/1709863002 Cr-Commit-Position: refs/heads/master@{#381546}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/c161310ffdbb..830dfd87a770 $ git log c161310ff..830dfd87a --date=short --no-merges --format='%ad %ae %s' 2016-03-16 reed add blitprocs to shaders 2016-03-16 cjacek Minor mingw cross compilation fix. 2016-03-16 robertphillips Revert of Add SkSpecialImage::extractSubset & NewFromPixmap (patchset #5 id:80001 of https://codereview.chromium.org/1787883002/ ) 2016-03-16 mtklein Use std::unique_ptr. 2016-03-16 senorblanco GrTessellator: don't reuse the previous vertex buffer on a cache miss. 2016-03-16 halcanary Doc: pdf illustration 2016-03-16 mtklein Revert of Use std::unique_ptr. (patchset #10 id:170001 of https://codereview.chromium.org/1780933003/ ) 2016-03-16 robertphillips Add SkSpecialImage::extractSubset & NewFromPixmap 2016-03-16 djsollen Cleanup download scripts related to new Android NDK. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810603002 2016-03-16 mtklein Use std::unique_ptr. 2016-03-16 mtklein Split uninteresting hash lines correctly on Windows. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1808663003 Cr-Commit-Position: refs/heads/master@{#381545}
-
timav authored
For Spitzer, the audio decoder that supports encryption has to be instantiated in the GPU process. The decoder has to be split between a proxy and a service. This CL contains Mojo interface only. BUG=542910 Committed: https://crrev.com/cabbc3cc9b0c18f25d91f17bb6cdded528366695 Cr-Commit-Position: refs/heads/master@{#381360} Review URL: https://codereview.chromium.org/1809483002 Cr-Commit-Position: refs/heads/master@{#381544}
-
khmel authored
BUG=593388 BUG=594622 TEST=cheets_ContainerSmokeTest passes Review URL: https://codereview.chromium.org/1809753002 Cr-Commit-Position: refs/heads/master@{#381543}
-
jkarlin authored
Now that periodic syncs are out of the BackgroundSyncManager we no longer need the RegistrationKey and can index registrations by tag. BUG=592599 Review URL: https://codereview.chromium.org/1774603002 Cr-Commit-Position: refs/heads/master@{#381542}
-
ericwilligers authored
Hyphenated names in Web Animations keyframes were deprecated in M50. camelCase is now required. BUG=588025 Review URL: https://codereview.chromium.org/1771733002 Cr-Commit-Position: refs/heads/master@{#381541}
-
wjmaclean authored
This CL implements a speculative fix for the associated bug, on the theory that sequences associated with context menus (triggered by GestureLongPress) may not be properly suppressed on Windows, leading to the observation of sequences without any target in RenderWidgetHostInputEventRouter. If this hypothesis is correct, then we should be correct in ignoring such sequences, and this CL implements that. This CL also removes the code for collecting debug data introduced in https://codereview.chromium.org/1783533002/. BUG=592319 Review URL: https://codereview.chromium.org/1810693002 Cr-Commit-Position: refs/heads/master@{#381540}
-
shreyasv authored
No longer needed. BUG=579697 Review URL: https://codereview.chromium.org/1804273002 Cr-Commit-Position: refs/heads/master@{#381539}
-
isandrk authored
This is cl #1 of 3 to tackle this issue: #1 boolean policy #2 actual changes in the Bluetooth code + policy handler #3 UI part. BUG=463578 Review URL: https://codereview.chromium.org/1736293002 Cr-Commit-Position: refs/heads/master@{#381538}
-
davidben authored
https://boringssl.googlesource.com/boringssl/+log/a857159dd61204bfe93bd8e2f00448434e8b0b99..9aa1562843fbe63bc520c513222d0100a2085780 BUG=none TBR=eroman@chromium.org Review URL: https://codereview.chromium.org/1810703002 Cr-Commit-Position: refs/heads/master@{#381537}
-
drott authored
Preparation for using UnicodeRangeSet in both CSSFontFace and HarfBuzzFace for sharing character range set restriction information. BUG=583450 R=eae Review URL: https://codereview.chromium.org/1808853002 Cr-Commit-Position: refs/heads/master@{#381536}
-
asvitkine authored
Since this code can be called from multiple threads, we should hold a lock when calling CheckTrialGroup since it modifies a std::map. The other call site was already holding the lock. BUG=595264 Review URL: https://codereview.chromium.org/1810593002 Cr-Commit-Position: refs/heads/master@{#381535}
-
mengyu authored
use_alsa_monotonic_raw_tstamps flag should be set to true for all audio products since alsa-lib is upgraded to 1.0.29 which added monotonic raw timestamp feature. Setting it to true so we don't need to add this flag to every internal audio targets and C4A partners. BUG=internal b/27654854 TEST=build pepperoni and make sure snd_pcm_sw_params_set_tstamp_type is called. Review URL: https://codereview.chromium.org/1804763002 Cr-Commit-Position: refs/heads/master@{#381534}
-
bokan authored
I introduced this bug in my refactoring in r380403. The fix is to simply use the document node as the element to scroll if the hit test doesn't return a node but does hit a scrollbar. BUG=594074 Review URL: https://codereview.chromium.org/1804063002 Cr-Commit-Position: refs/heads/master@{#381533}
-
dalecurtis authored
Spitzer is currently enabled as a 40% experiment on dev (soon on beta as well), but we have abnormally high video-only decode failure rates, so add some logging to try and track this down. ~10% of the time, this change will log the 'subresource_url' crash key as a non-crash dump when a decode error is encountered on Android where Spitzer is enabled. This will allow us to investigate and triage these crashes. We're already logging this key for normal crash dumps during DoLoad(). This is a temporary change which will be removed shortly after landing once any issues are identified. BUG=595076 TEST=none Review URL: https://codereview.chromium.org/1808473002 Cr-Commit-Position: refs/heads/master@{#381532}
-
kotenkov authored
Use RunLoop instead of MessageLoop. BUG=none Review URL: https://codereview.chromium.org/1801093002 Cr-Commit-Position: refs/heads/master@{#381531}
-
reveman authored
BUG=549782 Review URL: https://codereview.chromium.org/1804973003 Cr-Commit-Position: refs/heads/master@{#381530}
-
cwallez authored
espeially -> especially BUG=None R=brettw@chromium.org,tfarina@chromium.org Review URL: https://codereview.chromium.org/1807983002 Cr-Commit-Position: refs/heads/master@{#381529}
-
estade authored
BUG=595167 Review URL: https://codereview.chromium.org/1804343002 Cr-Commit-Position: refs/heads/master@{#381528}
-
oshima authored
BUG=595408 TBR=bcwhite@chromium.org Review URL: https://codereview.chromium.org/1806043003 Cr-Commit-Position: refs/heads/master@{#381527}
-
mikecase authored
Removing DEPRECATED_java_in_dir from the AndroidWebview apk test targets. Note that this will mean if you want to add a new test file or a new file to add to the AndroidWebView shell apk you will need to add the file explicitly to the java_files list. BUG= Review URL: https://codereview.chromium.org/1801033004 Cr-Commit-Position: refs/heads/master@{#381526}
-