- 28 Nov, 2018 40 commits
-
-
Darren Shen authored
This reverts commit b5418f5c. Reason for revert: FindIt says it's 74% confident that it's breaking KioskTest.LaunchAppUserCancel on linux cros. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/16574 Original change's description: > Run ClearSigninProfile on user session start > > Also, ClearSigninProfile now closes any browser window opened in the > profile. Ideally, no browsers would be open in the sign-in profile, but > we've had cases where that had happened. > > BUG=906837,901768 > > Change-Id: Ia231d2ce3420c5c743bcd17f839ad00f4a851874 > Reviewed-on: https://chromium-review.googlesource.com/c/1347105 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611442} TBR=tbarzic@chromium.org,achuith@chromium.org,alemate@chromium.org,jdufault@chromium.org Change-Id: I3f497a9076e926be8d28110f051685edb27e8f7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906837, 901768 Reviewed-on: https://chromium-review.googlesource.com/c/1352121Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611544}
-
Vlad Tsyrklevich authored
SafeStack support has been abandoned. Bug: 908597 Change-Id: I800af0440054fb4de593a01af347b9b341cc55e5 Reviewed-on: https://chromium-review.googlesource.com/c/1351778 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611543}
-
Vlad Tsyrklevich authored
SafeStack support has been abandoned. Bug: 908597 Change-Id: If425e16a2bed5781d32a935e0dca06a4666fabc4 Reviewed-on: https://chromium-review.googlesource.com/c/1351751Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#611542}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/752d220a5f31..3b7c9d099b0d git log 752d220a5f31..3b7c9d099b0d --date=short --no-merges --format='%ad %ae %s' 2018-11-28 enga@chromium.org Change offsets in MultiDrawElements* entrypoints to match glMultiDrawElements 2018-11-28 jmadill@chromium.org Remove gl::Error. 2018-11-27 timvp@google.com Enhance ANGLE for Android Developer Options 2018-11-27 jmadill@chromium.org Slight refactor to ErrorStrings.h. Created with: gclient setdep -r src/third_party/angle@3b7c9d099b0d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890539 TBR=fjhenigman@chromium.org Change-Id: I9745811bd3b3fcd37a1aff9bb1462953f0ad174c Reviewed-on: https://chromium-review.googlesource.com/c/1352605Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611541}
-
Peter Qiu authored
PrefService requires home directory to be setup before the underlying pref store (JsonPrefStore) can be initialized properly. Now that the creation of PrefService is moved from CastBrowserMainParts::PreCreateThreads to CastMainDelegate::PostEarlyInitialization, we need to do the same for home directory creation as well. Bug: internal b/119800555 Test: Test locally on a cast build Change-Id: I513680c3b30dbd0c9cc862d87604376e502be763 Reviewed-on: https://chromium-review.googlesource.com/c/1352038Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611540}
-
Darren Shen authored
Test is failing. TBR=ossu@chromium.org Bug: 909095 Change-Id: Iefcbf963b5d366d1bdf4ed4b572cf665de941efd Reviewed-on: https://chromium-review.googlesource.com/c/1351862 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611539}
-
Xida Chen authored
The forward declaration in in layer_tree_host_impl.h seems to be in alphabetic order where one of them isn't. This CL corrects the order, and also removes a forward-declaration for a struct which isn't needed. Bug: None Change-Id: I275a1af8392f20ec023a69107aa508b2a29b3d55 Reviewed-on: https://chromium-review.googlesource.com/c/1352515Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611538}
-
Hirokazu Honda authored
V4L2Device::VideoPixelFormatToV4L2PixFmt returns either single and multi plane v4l2 pix fmt, depending on VideoPixelFormat. This would rather return single or multi plane v4l2 pix format with given VideoPixelFormat and |single_planar|. V4L2VEA always uses multi plane formats. On the other hand, V4L2 IP depends on its caller's decision. So V4L2IP's caller specifies single or multi planes by the number of buffers on VideoFrameLayout. VideoFrameLayoutToV4L2PixFmt() is also added in this CL, which returns v4l2 pixel format from given VideoFrameLayout. This CL also adds IsMultiPlanarV4L2PixFmt(), which returns whether v4l2 pix fmt is multi planar or not. BUG=chromium:894381 TEST=VDA unittest with/without --test_import on hana TEST=VEA unittest with YV12 raw video data on hana Change-Id: I8cce3229e81fe041eb0bf8ea60f2735ef610e1b0 Reviewed-on: https://chromium-review.googlesource.com/c/1341428 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#611537}
-
rbpotter authored
The 3 linked bugs are all due to an issue with refocusing a list item from an element after the last control. In this case, the last control should be refocused, not the first control. This case can be identified by the first element in the focus event's path. This will be the list item itself if focus is coming from outside the control from an element that is before the list item in the tab order. It will be the last control if focus is coming from an element that is after the list item in the tab order. Bug: 908330, 908323, 908014 Change-Id: Ie2289547470e2f66cd9285d29e9ed1e0ab3207c1 Reviewed-on: https://chromium-review.googlesource.com/c/1351713 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611536}
-
Joshua Bell authored
Feature shipped in M69 Bug: 862455 Change-Id: Ie729a201fe30449123dcc22147301b152a5ff327 Reviewed-on: https://chromium-review.googlesource.com/c/1338721 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#611535}
-
Matthew Mourgos authored
Continuation dots no longer seen instead of complete folder name on hovering mouse pointer on Folder Name in App Launcher Constinuation dots are also no longer seen when editing folder name Bug: 870619 Change-Id: I58620f9011aacf264bf0b641c9b14e022add8b2f Reviewed-on: https://chromium-review.googlesource.com/c/1352582 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611534}
-
Tarun Bansal authored
Prefetch a URL only if it's score is more than the specified threshold. Additionally, only the highest ranking URL is now eligible for prefetching. Bug: 903945 Change-Id: I6c8166e8424da8c06f093998d606e1962184d20d TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1352034Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611533}
-
Sreerenj Balachandran authored
Current implementation allows only a keyframe as the first frame in the stream. This patch relaxes the requiremnt a bit and legalize the decoding when it starts with an Intra only frame. Also allows the resolution change if there is no prior decoded frames and the current frame is an intra only one. BUG=889768 Change-Id: Ic3bdedc329072b473f057407101193ac7ba4dc09 Reviewed-on: https://chromium-review.googlesource.com/c/1341146Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611532}
-
Travis Skare authored
Bug: 899964 Change-Id: Ib0ef4b64c162e10001bf3c96cd3443eb7f13de34 Reviewed-on: https://chromium-review.googlesource.com/c/1352810 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611531}
-
Wenzhao Zang authored
Spent some time trying to extract and reuse the |ImeListItemView|, but it's not easy since it contains IME specific logic (e.g. |set_last_item_selected_with_keyboard|). In fact I believe we should try to combine the class with |HoverHighlightView|, but it's a somewhat large refactoring and is beyond the scope of this CL. Bug: 877749 Change-Id: I9f4582fdcf865da7b3960a625cedbbdf710c7e4f Reviewed-on: https://chromium-review.googlesource.com/c/1341065Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611530}
-
Kunihiko Sakamoto authored
The latest gen-signedexchange cannot generate test data for the case because RSA keys support has been dropped. We still have VerifyECDSAP384 test case, so we will not lose test coverage for unsupported certificate types. Bug: 803774 Change-Id: I2a1aa7d6cbb57f15f07729eacaa4854a7cbb5ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1351344Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611529}
-
rbpotter authored
In kiosk app mode with no printers configured the preview spins forever because in kiosk mode we cannot fall back to Save as PDF. This currently only occurs on Chrome OS, as other platforms do not have app kiosk mode. Handle this case gracefully by notifying the user that there are no printers available. Also update the change button to the old behavior of disabled during load, since there should now be no case where the preview and destinations settings show spinners indefinitely. See the linked bug comment 9 for screenshot. Bug: 903680 Change-Id: I2c3e9a5b41520176cd8fe170886d97e317df05d3 Reviewed-on: https://chromium-review.googlesource.com/c/1344836 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#611528}
-
Katie D authored
In the next change we actually do the move into content/, this change sets that up: TtsPlatform will move to content/browser/public, while TtsPlatformImpl and the Mac, Win, Linux and Android impls will move to content/browser/speech. TtsChromeOs will stay in chrome/. This ensures that all dependencies on TtsPlatformImpl will also be moved into content/, and updates the interface in TtsPlatform to meet content/public interface guidelines. Bug: 517317 Change-Id: Ia09ca0e2bf86dadebd963cbdddc08d3568cfc26b Reviewed-on: https://chromium-review.googlesource.com/c/1351806 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#611527}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/09ee175d1056..36900aad7d96 git log 09ee175d1056..36900aad7d96 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-27 yshaul@google.com cbuildbot: Add noop TestPlanStage to cbuildbot Created with: gclient setdep -r src/third_party/chromite@36900aad7d96 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I47a63ada80bbcb31545df758dd57508e7126227b Reviewed-on: https://chromium-review.googlesource.com/c/1352601Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611526}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1561e23284f1..fb903439b213 git log 1561e23284f1..fb903439b213 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 treehugger-gerrit@google.com Merge "profiling: Fix cmdline parsing." Created with: gclient setdep -r src/third_party/perfetto@fb903439b213 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I86f658ac151509d2579b656f7cb50c541180099e Reviewed-on: https://chromium-review.googlesource.com/c/1352602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611525}
-
Kent Tamura authored
- LayoutTestSupport -> WebTestSupport - IsRunningLayoutTest() -> IsRunningWebTest() - SetIsRunningWebTest() -> SetIsRunningWebTest() - kLayoutTestResourcesDir -> kWebTestsResourcesDir - LayoutTestsFilePath() -> WebTestsFilePath() - BlinkLayoutTestsDir() -> BlinkWebTestsDir() Change-Id: If31f8d73f795d4271ccec76f51182a18c891fb30 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1352116Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#611524}
-
Matt Falkenhagen authored
Remove the failing and crashing expectations. It seems to only pass or timeout these days. Also it no longer fails on NetworkService. Bug: 849670 Change-Id: Ie5d67c154e06bcd32d77f32648d31bfebb8466fb Reviewed-on: https://chromium-review.googlesource.com/c/1352081Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611523}
-
Matt Falkenhagen authored
It was disabled due to a crash that looks similar to a bug that was fixed, issue 854993. Try re-enabling it. Bug: 838759 Change-Id: Ia3e21a9fdccd5239af270987e6c432612f5ae15c TBR: peter Reviewed-on: https://chromium-review.googlesource.com/c/1352082Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611522}
-
Darren Shen authored
The error message is saying to add a scoped task environment. TBR=nektar@chromium.org Bug: crbug.com/909062 Change-Id: I5aca973574fd8754bdfc1ef44af1319a494b3d13 Reviewed-on: https://chromium-review.googlesource.com/c/1352869 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#611521}
-
Owen Min authored
Load CloudManagementEnrollmentMandatory policy first. If not set, read the /Library/Google/Chrome/CloudManagementEnrollmentOptions file. If it contains Mandatory, then the enrollment is forced. Also, always use com.google.Chrome as the bundle Id of Preference. Bug: 904983 Change-Id: I1d45c48bef30c78ecddcb501e091a1132805b0ef Reviewed-on: https://chromium-review.googlesource.com/c/1348910Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611520}
-
Tatiana Buldina authored
Update atoms with Selenium code as of 11/26/2018. This includes fix to the error code returned by FIND_ELEMENT and FIND_ELEMENTS atoms when an invalid locator is used. The following WPT tests now pass: * webdriver/tests/find_element/find.py * webdriver/tests/find_elements/find.py The following WPT tests still fail and will be fixed in the future: * webdriver/tests/find_element_from_element/find.py * webdriver/tests/find_elements_from_element/find.py Bug: chromedriver:2677 Change-Id: I4e8c11d5f264e950312493f6fed491d8ef780302 Reviewed-on: https://chromium-review.googlesource.com/c/1352626Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#611519}
-
Aaron Krajeski authored
https://chromium-review.googlesource.com/c/chromium/src/+/1351501 has reverted some perf changes due to high-end mac laptops crashing. Re-add that CL piece by piece. This CL adds no new tests, only the RAF functionality. Current canvas benchmarks only measure CPU time. Using requestAnimationFrame (raf) in javascript we can measure CPU + raster + GPU time. This CL adds a mode to blink_perf.py that runs canvas all canvas test in a way that takes raster and GPU time into account. Roughly doubles the duration of `blink_perf.canvas` benchmark from ~2 minutes to ~4 minutes on a linux desktop. Bug: 894043 Change-Id: I50eeacbe47f3f3f0b09f1cb44806cabcad97dc2e Reviewed-on: https://chromium-review.googlesource.com/c/1352475 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#611518}
-
Sammie Quon authored
Partial reverted the cl which introduced this regression. I will reopen the original bug and try a better fix later. Test: manual Bug: 881756, 907002 Change-Id: Idbe3a587caad485968d78b0b4841f1bfa0105366 Reviewed-on: https://chromium-review.googlesource.com/c/1344221Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#611517}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d429f5426b5b..3e2cdea95cd8 git log d429f5426b5b..3e2cdea95cd8 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 tsepez@chromium.org Better tests for CFXJSE_FormCalcContext::Decode(). 2018-11-27 asweintraub@google.com Fix compilation issue when using clang. Created with: gclient setdep -r src/third_party/pdfium@3e2cdea95cd8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibbb5d6f26a492773ed580cac96e2738f186cbef4 Reviewed-on: https://chromium-review.googlesource.com/c/1352603Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611516}
-
bsheedy authored
Updates VR golden images for JavaScript dialogs and permission prompts that changed due to https://chromium-review.googlesource.com/c/chromium/src/+/1351790. TBR=huayinz@chromium.org Change-Id: I61d83a33d7d96e004496ed9d317fbd4b9315e869 Reviewed-on: https://chromium-review.googlesource.com/c/1352811Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#611515}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Icb9edd7ce1fddb023b92e27e289c27aa88c88473 Reviewed-on: https://chromium-review.googlesource.com/c/1351203Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#611514}
-
sangseok.jang authored
InkDrop is handled before View::OnMouseEvent() in OnMouseEvent(). So, If I want to override the functions associated with InkDrop(ex : CreateInkDropHighlight()), there is a problem with not getting the something appropriate(ex. Button::STATE). But, changing the order of handling inkdrop and mouse event causes crashes on windows. (See, http:://www.crbug.org/902279.) The cause of this crashes is calling views::OnMouseEvent() might delete "this". So We Check if it's being detroyed to avoid crashes. Bug: none Change-Id: I2051ddbff9d674418c42e8fd81fcd9a4ab47a984 Reviewed-on: https://chromium-review.googlesource.com/c/1335068Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611513}
-
Joey Arhar authored
Bug: 823392 Change-Id: I23d47a25a47c5be77971fcde0f24a4bc591788fd Reviewed-on: https://chromium-review.googlesource.com/c/1350170 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611512}
-
Fergal Daly authored
For consistency with https://crrev.com/c/1333014 - remove type="text/javascript" - replace "var" with "const" Change-Id: Ie809fa22763494fd6ca4b20112d4a3e6afdd1f0b Reviewed-on: https://chromium-review.googlesource.com/c/1350431Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611511}
-
Tetsui Ohkubo authored
Clear all notification animation consists of two phases: CLEAR_ALL_STACKED and CLEAR_ALL_VISIBLE. During CLEAR_ALL_STACKED phase, only the counter at the top should animate, so each notification should not move even though GetCurrentValue() might not return 1.0. See the bug for detail. TEST=UnifiedMessageListViewTest.ClearAllWithStackingNotifications BUG=908782 Change-Id: I24f369753cc17ad761d85c654743504a07e9e148 Reviewed-on: https://chromium-review.googlesource.com/c/1352111Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#611510}
-
Miguel Casas authored
This CL extracts a Fake TestingPlatformSupport with the GetGpuMemoryBufferManager implemented to a common location under the test/ folder. canvas_2d_layer_bridge_test.cc had two methods that were not used, this CL removes those. Bug: 902585 Change-Id: Iea41033d59794a9f3fb550739d0736345318f291 Reviewed-on: https://chromium-review.googlesource.com/c/1352472 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611509}
-
Clark DuVall authored
This is a follow up to http://crrev.com/c/1338165, so we can track the performance impact of extraHeaders. Bug: 827582 Change-Id: I91190cf9dd66ca0539a365725823a6647d674dd5 Reviewed-on: https://chromium-review.googlesource.com/c/1352356Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611508}
-
Dana Fried authored
Views now rely on layout manager for both preferred and minimum size, and layout managers can be notified when a view's layout is invalidated. Change-Id: I189eab4bf1ab4369db0d7ca5391b432ac3424fcc Reviewed-on: https://chromium-review.googlesource.com/c/1351967 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611507}
-
Wei Li authored
This test was disabled due to being flaky long time ago, especially on MacOS 10.6. It seems working fine on newer versions of Mac. So we re-enable it. BUG=84299 Change-Id: I1aca1edb36d6942e0ee4c7e0230e7bc76d874556 Reviewed-on: https://chromium-review.googlesource.com/c/1347276Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#611506}
-
Joey Arhar authored
Bug: 881327 Change-Id: I7e9f50f598210e75d613561855dd4bde95ebaa0f Reviewed-on: https://chromium-review.googlesource.com/c/1342761 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611505}
-