GitLab

This CL changes the creation of anonymous shared memory on Windows to
remove name generation on versions < 8.1. This was originally added as
Windows would ignore the security of an unnamed object on XP -> 7, however
from at least Windows 8.1 this is no longer the case as we can create
unnamed shared memory (which will reduce memory usage slightly as well as
clutter in the user's named objects directory) while still enforcing the
security requirements. While this is likely to work on Windows 8 it'll
only be enforced for 8.1 and above due to a lack of testing for 8.

This CL applies the same changes in shared_memory_win to the platform
shared memory APIs which just copied the original implementation.

Bug: 880064
Change-Id: I3c61c01823a78d09ac6d220b647b26a07821ab39
Reviewed-on: https://chromium-review.googlesource.com/1209603Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589335}

As part of the MultiDevice Unified Setup project, the Chromebook is
supposed to notify the user for each of the following situations:
(1) A user who has not been through the Unified Setup Flow has a phone
    capable of hosting some MultiDevice features (a.k.a. 'new host'),
(2) A user who has already been through the Unified Setup Flow has a
    new host phone on their accounts (a.k.a. 'host switched'), or
(3) The currently logged in account went through the Unified Setup Flow
    on a different Chromebook (a.k.a. 'Chromebook added').

In the original design, implemented in
https://chromium-review.googlesource.com/c/chromium/src/+/1081287 and
https://chromium-review.googlesource.com/c/chromium/src/+/1089828

the Chromebook would have a bit in its preferences to indicate that it
had been enabled as a MultiDevice client. However we no longer perform
the verification necessary for to turn this on as part of the Unified
Setup flow so the bit is longer a valid basis for determining whether/
when to fire the notifications listed above.

This CL refactors the class responsible for this determination
(formerly ObserverNotifier, now
AccountStatusChangeDelegateNotifierImpl) so that it uses the status of
an already set MultiDevice host (or the lack thereof) to decide whether/
when to fire the notifications. In particular, the HostStatusProvider
class makes the raw data required readily available.

-----

A minor functionality change was implemented in the 'Chromebook added'
event. Prior to this CL, the check for that event, i.e.
AccountStatusChangeDelegateNotifierImpl::
CheckForExistingUserChromebookAddedEvent, would not fire a notification
if the SetupFlowCompletionRecorder says that the Chromebook was
previously used for Unified Setup. We decided this is not ideal
behavior because of the following case:

A user goes through Unified Setup on Chromebook A, forgets the host on
Chromebook A, and then go through Unified Setup on Chromebook B. This
automatically enabled the MultiDevice features on Chromebook A.

In the intended behavior before this CL (I say 'intended' because the
implementation was incomplete) this would not trigger a notification
and a user could be in a state in which they do not realize that
Chromebook A is connecting to their host phone. Removing the check for
whether Chromebook A has gone through Unified Setup prevents this from
happening. It has a side effect that the user will see the 'Chromebook
added' notification on Chromebook A immediately following following a
successful setup on Chromebook A but this is a much smaller concern
than the potential privacy issue described above.

I filed a bug
https://bugs.chromium.org/p/chromium/issues/detail?id=881549 to
either use or get rid of the SetupFlowCompletionRecorder pointer in
AccountStatusChangeDelegateNotifierImpl.

-----

Note that most of the unit tests from the aforementioned CLs 1081287
and 1089828 remained relevant modulo some adaptations. A small number
were dropped altogether as they were inextricably tied to the
implementation.


Bug: 856848
Change-Id: I49d884847f7e21516ea8af1a7264843386103c70
Reviewed-on: https://chromium-review.googlesource.com/1205495Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589334}

This is motivated by HTTPS Server Previews wanting to pass a large
blacklist to the client to avoid unnecessary roundtrips to the
litepages server. We also may want to pass a LoFi blacklist in the
future and perhaps a Hint API whitelist so the proto definition
should allow such additions.

Bug: 864640
Change-Id: I6c74483e22dac7e5b9c4705057728ddfb1d60ea2
Reviewed-on: https://chromium-review.googlesource.com/1208951
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589333}

isUVPAA is only available on Android N+

TBR=wychen@google.com

Bug: 880885
Change-Id: Ic768ae32cc09013f1e7197fbbb605948e9040f5e
Reviewed-on: https://chromium-review.googlesource.com/1211732Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589332}

https://chromium.googlesource.com/libyuv/libyuv.git/+log/d694f0a82b4d..9a07219dc8fb

$ git log d694f0a82..9a07219dc --date=short --no-merges --format='%ad %ae %s'
2018-09-04 fbarchard Documentation update for GYP and envionment variables
2018-09-04 fbarchard Remove GYP support from libyuv
2018-08-16 efoo Remove Android MIPs BB builder
2018-08-13 efoo Flip mirrored Windows LUCI builders to prod

Created with:
  roll-dep src/third_party/libyuv

Bug: libyuv:816
Change-Id: Ib4f63018b2aca0329f8eb9da309ae94d366c7f12
Reviewed-on: https://chromium-review.googlesource.com/1210723Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589331}

When a wheel event is not consumed it will lead into either scroll or
page zoom.

This CL adds an enum type EventAction and a corresponding getter on
WebMouseWheelEvent to clarify the action associated with a wheel event
(should it not get canceled by a handler). This field simplifies the
logic around finding scroll direction with use cases in feature policy
vertical-scroll.

Bug: 853292
Change-Id: I3d554d6b97189ed63911d97607cf7cb03bfab64a
Reviewed-on: https://chromium-review.googlesource.com/1127347Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589330}

The bug is that when transitioning to tablet mode with a window
(which will expand to fullscreen) open and a shown AppList results in
a stale shelf background.

This is a corner case, where the AppList does not change in visibility,
it remains visible and the shelf does not know to re-evaluate its
background.

Maybe the shelf should observe active windows instead of relying on
AppList visibility state changes?

For now, we fix this corner case by forcing the shelf to re-evaluate
it's background when the launcher stays open during the tablet mode
transition.

Test=automated and manual

Bug: 879591
Change-Id: I71c8d97672824853b0edac77e1a91734ba148af0
Reviewed-on: https://chromium-review.googlesource.com/1200408Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589329}

The inspect element keyboard shortcut when it was added 8 years ago was
intended to be command + shift + c. Due to a bug in the implementation, it
triggered off of both <cmd + shift +c> and <cmd + option + c>.

See https://codereview.chromium.org/3011002.

Recent refactors fixed the logic so that it correctly triggered off of only <cmd
+ shift + c>. Since some users have gotten used to <cmd + option + c>, this CL
manually adds that also as a hidden shortcut for devtools.

Bug: 880867
Change-Id: Idb70ee26afa485874674171642b8d380b50528ad
Reviewed-on: https://chromium-review.googlesource.com/1211504Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589328}

Allow AppList autocomplete to complete suggestions
if SearchBoxView recieves a mouse press event.
Approved by UX.

Bug: 881465
Change-Id: I028b809150513567a45782fd176a8ca93ce532ca
Reviewed-on: https://chromium-review.googlesource.com/1211622Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#589327}

Just the @interfaces for now.

Bug: 867548
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3be40a5d150726d39b5cb6934e2f642093dee32f
Reviewed-on: https://chromium-review.googlesource.com/1197726
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589326}

Specifics:
      +646,547 bytes normalized apk size
            +3 zip entries file count
       +41,648 bytes main lib size
      +409,700 bytes main dex size
InstallSize:
      +238,503 bytes APK size
  +1,893,691.0 bytes Estimated installed size
InstallBreakdown (+1,891,712.0 bytes):
        +1,656 bytes unwind_cfi (dev and canary only) size
        +1,441 bytes Non-compiled Android resources size
       +41,648 bytes Native code size
          +135 bytes Package metadata size
  +1,832,156.0 bytes Java code size
       +14,676 bytes Compiled Android resources size
Dex:
        +2,020 entries fields
        +2,750 entries methods
          +655 entries types
        +1,370 entries strings

Change-Id: I937ce431e22fe32774473ec94147b458bfac4e47
Reviewed-on: https://chromium-review.googlesource.com/1211703
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589325}

Adding automated test for set and reset custom background attribution.
The attribution should be removed when we cleared the custom background
and when a theme was applied.

Bug: 857256
Change-Id: Iccabe90925bc7e7d3da8ca0fa03705264493cf7b
Reviewed-on: https://chromium-review.googlesource.com/1208469
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589324}

This reverts commit 074455de.

Reason for revert: Suspected of causing check failures across a variety of tests on the Android CFI bot. See https://crbug.com/881538 for more details.

Original change's description:
> Strengthen requirements on CORS-safelisted request-headers
> 
> With this CL, some request headers that used to be treated as
> CORS-safelisted are not CORS-safelisted any more. Specifically,
> 
>  - "accept", "accept-language" and "content-language" have a stronger
>    check on its value
>  - All headers whose value exceeds 128 bytes are treated as not
>    CORS-safelisted
>  - If the sum of value length of CORS-safelisted headers exceeds 1024,
>    then all of them are treated as not CORS-safelisted.
> 
> This CL also implements
> https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header.
> 
> This is for https://github.com/whatwg/fetch/pull/736.
> 
> Bug: 824130
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ib12a7dbff6367717a43130ae59304dca55b7bf4e
> Reviewed-on: https://chromium-review.googlesource.com/1196563
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589153}

TBR=toyoshim@chromium.org,yhirano@chromium.org

Change-Id: I9952df291ff0aeaab0b50c6cff3de418b2272e71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824130, 881538 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1211958Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589323}

This CL adds the implementation in the Mirroring Service to connect to
the GPU service to support the HW encoding if available.

Bug: 734672
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3380ed0dcf2f06ae0ee42dbf30bf0905475e3d78
Reviewed-on: https://chromium-review.googlesource.com/1189122Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589322}

In Chromium, WebRTC's metrics implementation is never used. This is
the only use case of them and it is probably possible to use the
Chromium implementation provided by //third_party/webrtc_overrides.

This CL moves metrics specific symbols out of the build target
//third_party/webrtc_overrides:init_webrtc in order to avoid to compile
too much in cases where metrics is the only thing needed.

Bug: webrtc:9631

Change-Id: Id6e07a33eb2df95debee35297d99551224d2ba6e
Reviewed-on: https://chromium-review.googlesource.com/1192923
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589321}

Currently retry only re-checks the ready status of the scripts.
To properly retry, the scripts need to be reinjected so a new ready
status can be provided.

Bug: 879821
Change-Id: I3f188a3358435304006c907b7dd3799d907c6a80
Reviewed-on: https://chromium-review.googlesource.com/1200573
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589320}

Use a new Smart Lock user pref to track if Smart Lock is fully enabled. This
removes the need to consider additional complexity when migrating to Unified
Setup.

Additionally, make EasyUnlockServiceRegular and ProximityAuthProfilePrefManager
now consult MultiDeviceSetupClient if Smart Lock is enabled (and listen on
feature state changes from it). To be clear, these two classes no longer
directly set the Smart Lock user pref, and instead only determine if Smart
Lock is enabled by asking MultiDeviceSetupClient.

R=jhawkins@chromium.org, jlklein@chromium.org

Bug: 881435
Change-Id: I0a8535c19789e826d277258f76ce384e27cc8652
Reviewed-on: https://chromium-review.googlesource.com/1211246Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589319}

This reverts commit bd27fde7.

Reason for revert: Suspected of causing check failures across a variety of tests on the Android CFI bot. See https://crbug.com/881538 for more details.

Original change's description:
> FetchManager should not set "referer" HTTP header
> 
> Instead it should use ResourceRequest::SetReferrerString and
> ResourceRequest::SetReferrerPolicy.
> 
> Bug: 863769
> Change-Id: I4de47bae9aa259ace5ffb5bbdd17d6cf423931d7
> Reviewed-on: https://chromium-review.googlesource.com/1203474
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#589159}

TBR=yhirano@chromium.org,domfarolino@gmail.com

Change-Id: Ie5e58f0e1b794acf2e9ca2f7d1ae24f043d9fe8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863769, 881538 
Reviewed-on: https://chromium-review.googlesource.com/1211957Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589318}

The test fails due to a race of UkmRecorder::AddEntry with DOMMessageQueue::Observe:
https://cs.chromium.org/chromium/src/services/metrics/public/cpp/delegating_ukm_recorder.cc?q=src/services/metrics/public/cpp/delegating_ukm_recorder.cc&sq=package:chromium&g=0&l=137

Bug: 880217
Change-Id: Icf099c3eb1094d8a571dc6f87b152e3c838807dc
Reviewed-on: https://chromium-review.googlesource.com/1204011Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589317}

Bug:881469, 879151
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I419072d72f2bae1352f97a1283892f4ec5b5d04c

NOTRY=true # ios-simulator flake

Change-Id: I419072d72f2bae1352f97a1283892f4ec5b5d04c
Reviewed-on: https://chromium-review.googlesource.com/1211463
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589316}

This reverts commit 0af66703.

Reason for revert: Suspected of causing check failures across a variety of tests on the Android CFI bot. See https://crbug.com/881538 for more details.

Original change's description:
> Remove cors:: namespace specifier in the namespace
> 
> Bug: None
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ib487fee40beaac941b74c090d31133b12d61ea4a
> Reviewed-on: https://chromium-review.googlesource.com/1203517
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589158}

TBR=toyoshim@chromium.org,yhirano@chromium.org

Change-Id: I1f7065dbeb733c4378babfba36236f2467073a5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881538
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1211949Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589315}

In https://chromium-review.googlesource.com/c/chromium/src/+/1197462
we changed box_model_.Paint() to LineBoxListPainter so we no longer
supported text clip for descendants other than inline contents.

This CL calls ToLayoutBlock(box_model_).PaintObject() to support text
clip of other descendants, and still avoid the original double paint
offset issue of box_model_.Paint().

Bug: 880825
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2c4b0e23df11bf300c01f9c804fb7e7d129f3aa0
Reviewed-on: https://chromium-review.googlesource.com/1211244Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589314}

GetPrefName function are collision with jumbo, so we need to change
name to avoid build fail with jumbo.
And enable jumbo build in components/content_settings/.
Use jumbo build after adding "use_jumbo_build=true" args in GN.

Bug: 869381
Change-Id: Ic45971922b4c34cb7deb48e246da145e752e5383
Reviewed-on: https://chromium-review.googlesource.com/1203478Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#589313}

Roll src/third_party/spirv-headers/src/ 2c512180c..dcf23bdab (1 commit)

$ git log 2c512180c..dcf23bdab --date=short --no-merges --format='%ad %ae %s'
2018-09-06 cepheus Headers for revision 4 of SPIR-V 1.3, including SPV_KHR_vulkan_memory_model.

Roll src/third_party/SPIRV-Tools/src/ 21bcb9d8b..7600fc0e1 (2 commits)

$ git log 21bcb9d8b..7600fc0e1 --date=short --no-merges --format='%ad %ae %s'
2018-09-05 dneto Update Dim capabilities
2018-06-01 dneto Support SPV_KHR_vulkan_memory_model rev2

Created with:
  roll-dep src/third_party/SPIRV-Tools/src

TBR=dneto@chromium.org

Change-Id: Idd3e61f9aaa01a5787465fefc20f2c232d828a08
Reviewed-on: https://chromium-review.googlesource.com/1211428Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589312}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f23b4ab8b889..23d65fd54de1


git log f23b4ab8b889..23d65fd54de1 --date=short --no-merges --format='%ad %ae %s'
2018-09-06 vapier@chromium.org binhost_test: run with -v by default
2018-09-06 vapier@chromium.org binhost/config: drop release-group tests
2018-09-06 vapier@chromium.org binhost: GetChromeUseFlags: make sure we always use simple output
2018-09-06 dhanyaganesh@chromium.org generic_stages: Add non-cumulative stage duration metric
2018-09-06 vapier@chromium.org binhost: fix trailing whitespace in generated json files
2018-09-06 lannm@chromium.org Rename osutils.ResolveSymlink to ResolveSymlinkInRoot
2018-09-06 vapier@chromium.org binhost_test: use standard logging
2018-09-06 vapier@chromium.org binhost_test: drop dead boards
2018-09-06 lannm@chromium.org Add scripts/create_manifest_snapshot
2018-09-06 lannm@chromium.org Add dry_run argument to git.GitPush
2018-09-06 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@23d65fd54de1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7aaada839423efe13fc4f582dcd07c5c1ded9d51
Reviewed-on: https://chromium-review.googlesource.com/1208974Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589311}

Adding a list of new actions to the Captured Sites Automation framework,
as well as a measure to hide the geolocation dialog, and a measure to
dismiss modal beforeunload JavaScript dialogs.

Bug: 847905
Change-Id: Icb687ebc46a339c0ecc6be799200aac73b32b5ae
Reviewed-on: https://chromium-review.googlesource.com/1207892
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589310}

getLocStart and getLocEnd have been deleted. The replacements are
functionally equivalent.

Sending TBR to green the clang ToT waterfall.

TBR=thakis@chromium.org,dcheng@chromium.org
NOTRY=True

Bug: 880827
Change-Id: Ic76e3c3380454425b79c1d4211a14c9c35206d3c
Reviewed-on: https://chromium-review.googlesource.com/1211740
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589309}

This is to prepare the field for removing feature
kAutofillExpandedPopupViews.

Bug: 831603
Change-Id: I7db276de2da430634e146ad7641669e139fc6fa1
Reviewed-on: https://chromium-review.googlesource.com/1210387Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589308}

- Assistant flow will show after PlayStore flow and before User Image
  select screen.
- Verified on both desktop and device build oobe flow went through well.

Bug: b/114055787
Test: Manual Test
Change-Id: I84092a3a17be3b89bde37476b4bdda43aa2bcbd0
Reviewed-on: https://chromium-review.googlesource.com/1207578Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589307}

Frame owners may have pointer-events: none property which blocks them
from receiving mouse and touch events. Currently in V2 viz hit testing
hit test data provider has no information about whether OOPIFs have
pointer-events: none property.

This CL plumbs pointer-events: none property from HTMLFrameOwnerElement
to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl
will be able to generate proper hit test data for pointer-events: none
OOPIFs.

Bug: 841358

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I381c8f0b1dcfb14b7ef24c7b2b3806ae60ec4182
Reviewed-on: https://chromium-review.googlesource.com/1127440
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589306}

This is to prepare the field for removing feature
kAutofillExpandedPopupViews.

Bug: 831603
Change-Id: I3f0d8ee5359be4c89b5284aef6bbdca0edf86da1
Reviewed-on: https://chromium-review.googlesource.com/1210545
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589305}

Bug: 875284
Change-Id: Id802fe60adaa4f49af2105fffedca7a024c0c82d
Reviewed-on: https://chromium-review.googlesource.com/1211107
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589304}

This CL shows a policy indicator and a disabled toggle when the suite
or a specific feature (on the subpage) is prohibited by policy.

Note that some unrealistic cases are not handled. This includes:

1) suite is prohibited but the mode (a.k.a. host status) is something
other than "no eligible hosts"
2) the user is in the subpage but the suite is prohibited by policy.

Screenshots:

Suite prohibited by policy (main Settings UI page):
http://screen/EbYef2RFFrf

Individual feature prohibited by policy (subpage):
http://screen/D3iqHQCW4B3


Bug: 870127
Change-Id: Iebeed37255e4a3dffb4f1b6376acfe5a9c26cc2d
Reviewed-on: https://chromium-review.googlesource.com/1208900Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589303}

Builds the Surface tree considering Surfaces that correspond to
RootFrameSinks and detached Surfaces as root Surfaces. All of these are
attached to RootElement.

Bug:816802

TBR=sadrul@chromium.org

Change-Id: I74d11ddb0fed9dc31712dc6e98cf20e936856400
Reviewed-on: https://chromium-review.googlesource.com/1185964
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589302}

When Chrome tries to figure out which text field of a password form
is the username, it picks one and stores the rest in
PasswordForm::other_possible_usernames.

This field has so far only been populated by the old form parser
(password_form_conversion_utils.cc). This CL also teaches the new
parser to populate that field.

However, there is a slight change: the new parser will include also
the username which Chrome picked, for simplicity of the processing of
the information later. The change in meaning is not breaking, because
the output of the old and the new parser is consumed by different
versions of PasswordFormManager. https://crbug.com/881346 tracks
renaming of the other_possible_usernames field once there is only one
meaning to it.

Bug: 880721
Change-Id: I114472dc8d1b37a8f77bdb79689008e7795d81a4
Reviewed-on: https://chromium-review.googlesource.com/1210503
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589301}

Bug: 876432

Change-Id: Id2b3539f1072289f7110db126793ad69f66240e9
Reviewed-on: https://chromium-review.googlesource.com/1192588
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589300}

The max and min valures for the OscillatorNode.detune parameter has been
reduced according the latest version of the spec.  Make it so.

Also implement clamping of the total frequency to Nyquist so that we don't
generate infinity or NaN doing the computations.  This is ok because anything
beyond Nyquist would output 0 anyway.  But we're careful to preserve the slope
of automations; test added for this as well.

Update expectations for AudioParam/audioparam-nominal-range.html because of
the new warnings produced by clamping detune.

Bug: 865552, 860347
Test: the-oscillatornode-interface/detune-limiting.html
Change-Id: I35a214b0f3156ad8912718dcb277f1967f70df8f
Reviewed-on: https://chromium-review.googlesource.com/1138638
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589299}

Adds an exception to contents/description experiment for
DOCUMENT_SUGGESTION result types.

Bug: 876429
Change-Id: I66aa037b36460c7c08b310474c60b02500bd1c8f
Reviewed-on: https://chromium-review.googlesource.com/1192328
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589298}

Settings WebUI: prevent settings-subpage from removing itself as a FindShortcutListener if it was not already added as one.

Ensure |active_| has changed value and change onActiveChanged_
observer to a compound observer that also depends on |searchLabel|
to ensure |searchLabel| has been initialized.

Bug: 881104
Change-Id: Icf4e740c766d1069aba9da13b25879c95a1959eb
Reviewed-on: https://chromium-review.googlesource.com/1208822Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589297}

Bug: 871908, 871912, 875059
Change-Id: I2a071d9a2d9b6cdf449d69e42e5bec8fe68f7884
Reviewed-on: https://chromium-review.googlesource.com/1204601Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589296}