- 02 Jan, 2020 40 commits
-
-
Ian Kilpatrick authored
In order to get use the correct min/max sizes for flex-items we need to perform a layout *before* calling ComputeMinMaxSize. (This is yet another reason why we should merge the min/max sizes pass with regular layout). Additionally this patch implements the: LayoutBox::HasTopOverflow LayoutBox::HasLeftOverflow methods to correctly calculate the scrollable overflow. Bug: 845235 Change-Id: I3059dfa72969c690abe3808629166194c84fcd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978103 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728071}
-
Mason Freed authored
Prior to this CL, some parts of FormControlsRefresh were keyed off of the base::Feature, while others were based on the RuntimeEnabledFeature. That made it difficult to reason about when the feature was enabled or disabled. E.g. an attempt to set the default for the RuntimeEnabledFeature to "test", to enable it for testing only, would result in only part of the feature being enabled in that case. With this CL, the RuntimeEnabledFeature has been removed, and all of the new look and feel is controlled solely from the base::Feature. The feature can be enabled with: --enable-features=FormControlsRefresh Bug: 1012106, 1035510 Change-Id: If3ea206cb5a89beb8c21dc105df7ba36ba41f0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984748 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#728070}
-
Brian Sheedy authored
Works around a StrictMode violation coming from ArCore by allowing disk writes when checking for ArCore APK availability. Bug: 1038757 Change-Id: I0fbc469d243d89e14068b5d9ab3fca19999f122b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986246Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728069}
-
Caleb Rouleau authored
Note that this change also reshards the Win 7 Builders, which may cause false positive regressions. In the event of perf regressions, this CL should not be reverted, since it is not causing the regression; it is just moving the test to run on a different device (of the same model and OS). Also, move to only use 4 shards instead of 5. We are seeing that these bots die sometimes (examples: crbug.com/1038720, crbug.com/1038719), so it is better to keep one device in reserve to help out if another one dies. See https://chromium-review.googlesource.com/c/chromium/src/+/1983326 for background. This moves all the gtest perf tests on Win 7 Perf and Win 7 Nvidia GPU Perf into the performance_test_suite and onto the shard maps. This allows us to run them in parallel with the Telemetry benchmarks and account for their runtime within our system. Bug: 921353 Change-Id: I284924447435325da2263131e0b7df6411b04e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985134 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728068}
-
Christopher Cameron authored
We don't send the color space to the browser's ui::Compositor on macOS. This has been broken on macOS for an unknown period of time. It didn't actually make a difference because - that only set the raster space for browser UI, which is sRGB anyway - the renderer got the correct color space for raster via RenderWidgetHostImpl::GetScreenInfo - we would draw using CoreAnimation (not GLRenderer) >99.9% of the time, so the ui::Compositor's GLRenderer's color space didn't matter Because of rounded corner rects, we hit the GLRenderer more often, causing this bug be visible. Change RecyclableCompositorMac::UpdateSurface to take a required color space argument, ensuring that all callers specify a value. Bug: 1038723 Change-Id: Icde934718371802356c5c26277a628361705009f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985127Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#728067}
-
Haiyang Pan authored
Bug: 986990 Change-Id: I0a6d4f292fa5faea259af45cee83f271ac7cdcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985129Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#728066}
-
Devlin Cronin authored
I'm not currently looking at these; update ownership to the web ui team and extend the expiration date. Bug: 1037109 Change-Id: I54a78afd636883954ef057899f135e6583e1d339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981061Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#728065}
-
Nate Fischer authored
No change to logic. This adds several more features/flags to the Dev UI flags Activity. This changes makes a small change to the build file so common_java can depend on common_commandline_java so we can use a string constant. Bug: 981143 Test: Manual - verify the new features show up in the UI Test: Manual - toggle committed SB interstitials, observe behavior \ Test: change in demo app (CI currently creates an extra net error) Change-Id: I034a06f30739a1c33950de7745e1bb39de05ca76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981193Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728064}
-
Ayu Ishii authored
Bug: 1007667 Change-Id: I9323b7df3b276263bc5e09acb3e8aa5aae36b265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979012Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#728063}
-
Philip Rogers authored
Hit test rects depend on the size and location of an object and need to be invalidated if this changes. Change-Id: I1eda93969818d4c21be15882f027e3c134a64c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984463Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728062}
-
Michael Irani authored
Change-Id: I5ca6113546e431318b55fd4435ce4cc7896c33db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981138Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Michael Irani <michaelirani@chromium.org> Cr-Commit-Position: refs/heads/master@{#728061}
-
Nate Fischer authored
This refactors developer mode logic, so the implementation can be shared by both the developer UI and the embedded WebView code. This also renames the ContentProvider so it can be used more generally in the future. Bug: 1036533 Test: Manual - verify flags Activity continues to work Change-Id: I6cb4b0dfb751cd04884af3768f051ebe6795ea5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982232Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0bad0c3f9858..f3b0f52a1eb1 git log 0bad0c3f9858..f3b0f52a1eb1 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 anubmat@microsoft.com DevTools: Add Supporting function for Performance panel a11y tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@f3b0f52a1eb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I83d6c3f5112a4350c134e69e69ad6c70e032f9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986174Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728059}
-
Andrew Grieve authored
This reverts commit 90164da9. Reason for revert: Underlying issue was fixed (see bug) Original change's description: > Revert "Remove native deps from chrome_junit_tests" > > This reverts commit 4b1723f2. > > Reason for revert:crbug.com/1035586 > > Original change's description: > > Remove native deps from chrome_junit_tests > > > > And adds an "assert_no_deps" to prevent regressions. > > Would be nice to assert that the junit target does not depend on //base, > > but it looks like all grit targets depend on //base, and fixing that > > would require a larger refactor. > > > > Bug: None > > Change-Id: I970cdb458d50a32f55165756a10e66857470d75a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953400 > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#723080} > > TBR=wnwen@chromium.org,agrieve@chromium.org,mattreynolds@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: None > Change-Id: I5f5d1e67637e6aa4d1008b8227c84ce114bcf867 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974586 > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726168} TBR=wnwen@chromium.org,agrieve@chromium.org,mattreynolds@chromium.org,alcooper@chromium.org Bug: 1035586 Change-Id: Ie3ffcc34137302d07d0114099281107b8402a728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985556Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728058}
-
Jeremy Roman authored
On the way, refactor how the Portal <-> WebContentsImpl pointers are maintained, as this work caused the raw WebContentsImpl* to dangling while writing the main code of this CL, which made for a confusing bug. This refactoring is mainly a mechanical gathering of the code responsible for updating these into a small nested class. Bug: 964481 Change-Id: I8a63e1a5531de4807569b35ea0f3fcb19baf343c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976000Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728057}
-
Takashi Toyoshima authored
Since WebView launch is planned at m81, and launch metrics review will need them, we need to keep them for a while after m81 stable promotion. Current expiry date is defined as after M82, and it effectively means around Apr 4, 2020. So, it's better to keep them for one more milestone. Bug: 1037154 Change-Id: If1f479c1802690a37915f39a5b60761e4684b402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981248 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Eugene But authored
This histogram can be useful for detecting URL spoofing bugs in WKWebView. Bug: 1037354 Change-Id: I85e2c50912b93097f55140305edb7bb157e95e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980905 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This is a followup to https://crrev.com/c/1977309 to fix cellular network technology icon inconsistency. The previous CL adds checks for network technology changes when checking for active network changes. This CL makes changes to NetworkStateHandler that ensures that these checks are run for network technology property changes in the first place. Unit tests were also added. Fixed: 994445 Change-Id: I7790c3794f27c26e099eaab9e7db718b00aff73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982238Reviewed-by:
-
Dana Fried authored
Moves slide animation up from account toolbar icon container to the base ToolbarIconContainerView code, so all containers (currently, account and extensions) use that animation. Bug: 1038571 Change-Id: I2ee636e6df388255699157ceaa09b854b9ced716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985165 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728053}
-
Pavel Yatsuk authored
This change drops SnackbarTest's dependency on ChromeActivity, allowing test to be moved to chrome/browser. BUG=1028382 R=twellington@chromium.org Change-Id: Ia22613b9666a934e5bb6be1aeb7325e9022ed1da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986219Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#728052}
-
Alex Cooper authored
Currently, getPose for a screen tap on a sensorless inline session fails because there is no "MojoFromViewer" pose available. In a sensorless session "Mojo" Space and "Viewer" space are the same, so this should return identity. Fixed: 1031596 Change-Id: Ic09590be6bbeff84cfaad894a2c1702ed7d3f896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978901 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#728051}
-
Dana Fried authored
Exactly what it says on the tin: icons (save credit card, save passord) now slide out from under the profile icon instead of just appearing. Updated a couple of browser tests to make sure we don't have flaky behavior due to the new animations. It looks pretty cool tbh. Bug: 1037946 Change-Id: I70803e204e8ccb14273ce2e57f21f808e947d068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981334 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Sophie Chang authored
Previously, we were over-counting when a race has finished but there was no hint for some reason (either request failed or no hints for host were returned) Bug: 1038387 Change-Id: Id9fca026e6bd83f65f804f9677385853aa3bbcaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986066Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728049}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/77faebf0..2eca5b1e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib10088b7d85bcc80bc9c9302f0931b6ef795bca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985606Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728048}
-
Sergey Ulanov authored
Previously the frame to be deleted was search in |frames_| twice, which is not necessary. Change-Id: Ieb0df172ef6c04249d2c44588a932d28f5158908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986190 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#728047}
-
Chris Harrelson authored
This is probably only a problem with rendersubtree-locked subtrees, because the compositing inputs dirty bits get left around for these subtrees. Bug: 1033795 Change-Id: I3dca73eed34b39c70c7609bdfb9d052dc1b6af2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977306Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728046}
-
Caleb Rouleau authored
https://bugs.chromium.org/p/chromium/issues/detail?id=1036846#c20 these are believe to be causing the bots to die. TBR=johnchen@chromium.org Bug: 1036846 Change-Id: I4c6508948b73f07966d6d2e894977e23b7f20699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985232Reviewed-by:
-
Gabriel Marin authored
Change-Id: Iddf32f7047287a98a06a7710efb8948b38a88eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841654Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#728044}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c9e75ab1ff47..7c4300cb193f git log c9e75ab1ff47..7c4300cb193f --date=short --first-parent --format='%ad %ae %s' 2020-01-02 dberris@chromium.org Dashboard: Tweak Clustering For Better Placement 2019-12-31 khokhlov@google.com Reland "Reland "[Telemetry] Make proto trace format the default"" Created with: gclient setdep -r src/third_party/catapult@7c4300cb193f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028612,chromium:922256 Tbr: sadrul@google.com Change-Id: Ic665371500d46a8555679949bfd81a6185f599bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984995Reviewed-by:
-
Moe Ahmadi authored
Rather than querying the autocomplete system on the NTP realbox getting focus, this CL makes it such that the autocomplete system is queriesd on explicit user gestures such left moust button click, tap and tab/shift+tab into the NTP realbox. This fixes the bug where opening a new tab or committing a navigation gives the realbox input automatic focus causing zero-prefix suggestions to show. Bug: 1026948 Change-Id: I0a5e5fdb5e158a26a7a2ea1cbac9958ebd2c2886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963332 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Peter Boström authored
Bug: None Change-Id: I0e40f2452674d4dfbb9b2ab68cae92701058f3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984750Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728041}
-
Tarun Bansal authored
Add DCHECK to ensure that FIFO ordering in set in resource scheduler for each request before it is consumed. Note that FIFO ordering is used to decide the order in which requests are dispatched to the network. This CL does not make any functional change. Change-Id: Iabd7562c1b680c10d10c4890e8c42d04c379486d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984902Reviewed-by:
-
Tarun Bansal authored
These tests are no longer needed because NoStatePrefetch does not run JavaScript (so client redirects are not possible) and no longer does the swap. Change-Id: I40722f50e2e6c9ddc2345701545926f3c8f64933 Bug: 846318,755933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985167Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728039}
-
nancy authored
The ARC app shelf id could have prefix "shelf_group:", and AppService can't find the app type for that shelf id, so check ARC app shelf id first before checking from AppService record. Update ARC tracker to use the app shelf id as the app id and checking the profile when getting the ARC shelf id to resolve the unit test failed issue and user switch crash issue due to the above change.. BUG=1011235 Change-Id: I817f059bb0cf65dc89a458b6b2bdf78ab22afc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984783Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728038}
-
Avery Musbach authored
The drop target in each overview grid shall have bounds representing anticipation that if the dragged window is dropped into that grid, it will shrink to fit into the corresponding work area. Bug: 961170 Change-Id: I909723441c859dce0e0131e4f7e990b54b6e9e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982233 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#728037}
-
Haiyang Pan authored
This enables the android app bundle, as introduced in crrev.com/c/1975037 Bug: 986990 Change-Id: Ie63c87936fae97ee72fd1fc96dbb4aa3968eac54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959377Reviewed-by:
-
Dave Tapuska authored
Add helper to MainThreadEventQueue unittest to compare the fields of the classes instead of using a memcmp function. BUG=836826 Change-Id: Iaa280074743593d8687ce923c48f778d16f1d4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979260 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728035}
-
nancy authored
Set the window's property AppType for Crostini apps. This is the current implementation in Crostini app window launcher controller: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc?q=ash::AppType::CROSTINI_APP&l=275&dr=C BUG=1011235 Change-Id: I82a816e0f6dc631608bd368b16b765dfc345d131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985623Reviewed-by:
-
Vincent Scheib authored
Convert base::Callback to base::OnceCallback in device/bluetooth/dbus/bluetooth_agent_manager_client.h This changes BluetoothAgentManagerClient::ErrorCallback to a OnceCallback, and updates calls in bluetooth_adapter_bluez.cc to be base::BindOnce. Bug: 1007780 Change-Id: I32af4f619b5cfeccc70bb1b33e6d3b61fbdeea3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982243Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#728033}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I7499856e853c87c1e374a22ca84d94133b3c4a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984344Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728032}
-
