GitLab

BUG=none


Review URL: http://codereview.chromium.org/8922016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114129 0039d316-1c4b-4281-b951-d872f2087c98

instead of a per-install ID.

BUG=106208
TEST=none

Review URL: http://codereview.chromium.org/8893015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114127 0039d316-1c4b-4281-b951-d872f2087c98

bug with ChromeOS where the Select File dialog's selected text color was
white on white.

BUG=chromium-os:23379
TEST=see bug for repro

Review URL: http://codereview.chromium.org/8894021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114126 0039d316-1c4b-4281-b951-d872f2087c98

Original commit text:

Add some suggested performance improvements to geturl.

Original Review URL: http://codereview.chromium.org/8603014

BUG=None
TEST=None
TBR=bradnelson@chromium.org

Review URL: http://codereview.chromium.org/8922018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114125 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=brettw@chromium.org


Review URL: http://codereview.chromium.org/8820016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ajwong

Review URL: http://codereview.chromium.org/8919016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114122 0039d316-1c4b-4281-b951-d872f2087c98

The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.

We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.

We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.

I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.

BUG=none
TEST=unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114095
Review URL: http://codereview.chromium.org/8894018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114121 0039d316-1c4b-4281-b951-d872f2087c98

Remove an outdated comment from nacl.scons
Left over from a previous CL - apparently commit queue ignores svn 'D' files.
Will submit this CL via gcl...
BUG=none
TEST=ppapi_geturl
Review URL: http://codereview.chromium.org/8922019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114119 0039d316-1c4b-4281-b951-d872f2087c98

Pulls out the core of gbillock's http://codereview.chromium.org/8283002/
- Move NOTREACHED and similar checks into the sql:: implementation code.
- Add malformed SQL checks to Connection::Execute.
- Add SQL-checking convenience methods to Connection.

The general idea is that the sql:: framework assumes valid statements,
rather than having client code contain scattered ad-hoc (and thus
inconsistent) checks.

This version puts back Statement operator overloading and loosy-goosy
Execute() calls to allow other code to be updated in small batches.

R=gbillock@chromium.org,jhawkins@chromium.org,dhollowa@chromium.org 
BUG=none
TEST=sql_unittests,unit_tests:*Table*.*


Review URL: http://codereview.chromium.org/8899012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114118 0039d316-1c4b-4281-b951-d872f2087c98

Tested using html5 drag demo and bookmark dragging to make sure that the patch didn't break dragging

BUG = 105886
Test = Manual


Review URL: http://codereview.chromium.org/8788002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106218,104368
TEST=Bookmark a host, then restart it. The bookmark should still work.

Review URL: http://codereview.chromium.org/8782001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8888033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114115 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 84677847.

TEST=ran browser tests on OSX
BUG=103989
TBR=apatrick@chromiu.org

Review URL: http://codereview.chromium.org/8919014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107234
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8905020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107246
TEST=fixed


Review URL: http://codereview.chromium.org/8921016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114111 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r112107.

BUG=107269
TEST=as in bug

Review URL: http://codereview.chromium.org/8928001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114110 0039d316-1c4b-4281-b951-d872f2087c98

I'm doing this to pick up a naming change for a not-yet-used
D-Bus signal that'll be sent by the power manager
("PowerButtonEvent" becomes "ButtonEvent").

BUG=98328
TEST=ran "gclient sync"
TBR=satorux@chromium.org

Review URL: http://codereview.chromium.org/8919023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114108 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
TEST=Use an account with ASP, be able to easily navigate to the ASP input when
prompted on the sync setup overlay and full page promo.
BUG=98928


Review URL: http://codereview.chromium.org/8923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101099
TEST=
  1. Enable Full Keyboard Access in System Preferences
  2. Create a folder on the bookmarks bar containing many (20+) bookmarks.
  3. Press the Tab key until this folder is selected in the bookmarks bar.
  4. Press the Space key to open the folder.

  After these steps, the folder should look identical to how it looks when you click on it directly.


Review URL: http://codereview.chromium.org/8789010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114104 0039d316-1c4b-4281-b951-d872f2087c98

The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.

We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.

We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.

I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.

BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8926004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107254,107255
TEST=as described in the bug

Review URL: http://codereview.chromium.org/8922014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114100 0039d316-1c4b-4281-b951-d872f2087c98

This change causes incognito requests to effectively have a different SSL
session cache from other requests. SSL session information will therefore not
leak into or out of incognito mode.

BUG=30877
TEST=net_unittests

Review URL: http://codereview.chromium.org/8857002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114098 0039d316-1c4b-4281-b951-d872f2087c98

The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.

We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.

We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.

I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.

BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95845
TEST=Print preview a  webpage. Increment the number of copies to 2.
Observe the state of collate checkbox. It should be checked by default.


Review URL: http://codereview.chromium.org/8918013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106381
TEST=NONE
TBR=willchan,acolwell,grt
Review URL: http://codereview.chromium.org/8919018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104393
TEST=tested on aura linux, and chromeos aura


Review URL: http://codereview.chromium.org/8908001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114092 0039d316-1c4b-4281-b951-d872f2087c98

Database sizes are low so it is safe to reduce the minimum user text length. This should increase coverage.

To help track potential coverage increases, it is good to remove trivial 0 confidences from the histogram of confidences.

BUG=107212,107213

Review URL: http://codereview.chromium.org/8870006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114091 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=

Review URL: http://codereview.chromium.org/8822017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114090 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114089 0039d316-1c4b-4281-b951-d872f2087c98

Adding metrics to track browser launches per primary/secondary profile. Adding metrics to track number of profiles per machine.

BUG=160771,106774
TEST=none

Review URL: http://codereview.chromium.org/8890054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=builds on gcc 32 bit for linux
Review URL: http://codereview.chromium.org/8894028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Click avatar menu and press Tab key to navigate through the menu.
Selected menu items should have a focus ring.

Review URL: http://codereview.chromium.org/8921003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114086 0039d316-1c4b-4281-b951-d872f2087c98

This code was platform independent so could just be copied over into the
platform independent file with no changes.

Review URL: http://codereview.chromium.org/8899015

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8926003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114085 0039d316-1c4b-4281-b951-d872f2087c98

Unit tests now instantiate their own AudioManager and can choose to
use the default one or provide their own mock implementation without
having to worry about conflicting with the singleton.

The teardown sequence of the AudioManager and its thread has been cleaned
up significantly and I don't think it has been completely tested before as
the audio thread was terminated before all objects that belonged to the
thread had a chance to do cleanup.  The AudioManager unit tests do not use
the actual audio thread, so this part seems to have been left out.

In Chrome, the AudioManager instance is now owned by BrowserProcessImpl
and always constructed on the UI thread.  This instance is then shared
in the same way that several other 'manager' type objects are shared to
'content' code, via content::ResourceContext.  Audio specific classes
do though receive a direct pointer to the AudioManager and are required
to do proper reference counting if they need to hold onto the instance.
I chose to use the ResourceContext rather than direct use of g_browser_process
to avoid requiring another singleton when writing relatively simple tests
that touch the AudioManager.

I added a couple of safeguards to guard against future regressions:
- Not more than one instance of the AudioManager should be created.
- The AudioManager should not be addrefed by its own thread.  This
  can basically become a circular reference and prevent deterministic
  shutdown.

Reviewers:  Of course you're free to review everything,
but here's the breakdown in terms of the bare minimum from
the standpoint of "Owners approval".  I'm asking Henrik to be the
main reviewer of the entire patch (sorry!).

Henrik: Everything minus the below, but it would be great if you could
        take a look at the whole thing, specifically media/audio.

Pawel:  I'd like you to take a generic look at this approach.
        The key areas as far as the singleton itself goes are in
        media/audio/audio_manager[_base].* and
        chrome/browser/browser_process*.*

Satish: content/browser/speech/*
        media/audio/audio_manager_base.* (new reference counting code)

Andrew: content/browser/renderer_host/media/*
        content/renderer/media/webrtc_audio_device_unittest.cc (Owner)

Avi:    content/browser/renderer_host/render_process_host_impl.cc
        content/browser/resource_context.*

William: chrome/browser/profiles/profile_io_data.cc
	 chrome/browser/browser_process*.*

Robert:  This is basically a heads up. I hope that I didn't break the OpenBSD
         implementation, but unfortunately I have no way of knowing for sure.

Shijing: Please take a look at AudioManagerLinux.  I replaced the set of
         active streams with a simple counter.

BUG=105249
TEST=content_unittests, media_unittests, browser_tests.
Review URL: http://codereview.chromium.org/8818012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114084 0039d316-1c4b-4281-b951-d872f2087c98

This application icon index values are being changed from ints to StringOrdinals to decrease the potential number of syncs required when icons are moved, by only needing to change 1 StringOrdinal instead of all the integers.


BUG=61447
TEST=Open up an instance of chromium with multiple application icons and ensure
that icons can still have their page and order changed. There should be no
behaviour change.


Review URL: http://codereview.chromium.org/8198003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114083 0039d316-1c4b-4281-b951-d872f2087c98

This bugs in isMark and isLetter lead 'init' feature to be applied
even when a syllable is not at the beginning of a word.

See http://www.microsoft.com/typography/otfntdev/bengalot/features.htm
for 'init' feature application in Bengali.

It turned out that the upstream also fixed this (see https://bugs.freedesktop.org/show_bug.cgi?id=30319) exactly the same way.

Change the upstream reference to 93d8573ddcf97648983a1c1b5cdda8a3ec6d4432
in README.chromium and remove 2 patches in chromium.patch because
they're all landed in the upstream @93d8573ddcf97648
Two removed patches are:

  - Fix OOB access (in Tibetan shaper) @ff0612c2e7df1b86fc
  - Fix crash! (in harfbuzz-gpos.c) @81c8ef785b079980a

In addition, the following upstream fix is included by going to 93d8573ddc.

  - Fix bug in contrib/harfbuzz-unicode.cc @93d8573ddcf9

Webkit bug to add a layout test for 'init' is
   https://bugs.webkit.org/show_bug.cgi?id=74310

BUG=107031
TEST=With Lohit Bengali font installed (the default on CrOS devices), go to http://i18nl10n.com/fonts/beng3.html and the result should be the same as the left in the screenshot attached to the bug instead of the right. A webkit layout test will be added and will be mentioned in the bug later.
Review URL: http://codereview.chromium.org/8895014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114082 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of r113823, hopefully without breaking the Pepper tests.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114081 0039d316-1c4b-4281-b951-d872f2087c98

This goes most of the way to re-enabling chrome_frame_net_tests by making it a content::BrowserMainParts.  The tests are still disabled until we are able to test them on IE8 and older; on IE9 all tests currently pass except for a few that hang.

Additionally, this makes chrome_frame_net_tests determine protocol version using the exact same version information as npchrome_frame.dll does, so that version mismatch due to the RC dependency problems we have sometimes seen should not happen any more with this test suite.

While in there, I also updated the poor_mans_trybot.bat script.

BUG=105435

Review URL: http://codereview.chromium.org/8894008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114080 0039d316-1c4b-4281-b951-d872f2087c98

The current code is for update time run, so it can generate correct list per OS.  However, we changed it to run locally and check the generated list in, so we need to have OS conditions for tests.

Also, add DEBUG/RELEASE modifier so we can mark test failures better.

BUG=
TEST=gpu_tests built
R=kbr
Review URL: http://codereview.chromium.org/8885003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114078 0039d316-1c4b-4281-b951-d872f2087c98

This code was platform independent so could just be copied over into the
platform independent file with no changes.

Review URL: http://codereview.chromium.org/8899015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114076 0039d316-1c4b-4281-b951-d872f2087c98