- 09 Mar, 2020 40 commits
-
-
Owen Min authored
Bug: 'ChromeReportingExtension' Change-Id: If39c8ae2df58eaf34ce1e5e42ed47263375736a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090504Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748232}
-
chrome://termsBen Mason authored
Bug: 1055504 Change-Id: I291094220bf31990927b780aa76d5094c517fbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082314Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#748231}
-
John Abd-El-Malek authored
Change-Id: I9a9d1202fea45903a138f8da5376cb04e98ccb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090497 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#748230}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d807280d52bf..ebcfc4bfc670 Created with: gclient setdep -r src-internal@ebcfc4bfc670 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046374,chromium:1049638 Tbr: jbudorick@google.com Change-Id: Iccee1db33bce59fc0e0f302996120c6e7be73259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094608Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748229}
-
Lukasz Anforowicz authored
Bug: 920638 Change-Id: I6c2d20e119ffa5219df32ffb0c6e747fa1a5c427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082606Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#748228}
-
Mehran Mahmoudi authored
This adds a new test for the player that displays an already captured paint preview. The test asserts that the player view is generated. Bug: 1049303 Change-Id: I3a2c0bb451c8624d18da6926ad9014e7a07ecf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076099Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748227}
-
Mohamed Heikal authored
The API key is not actually required to perform the request as long as you are only dealing with authenticated requests (The access token is enough of an identifier). This CL removes the API key (which has since been revoked) as well as fixes a (use before define) bug in auth.js Change-Id: I5abdde63b65b868d79a3bc4ca47ff59bc65cb25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092423Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748226}
-
Anton Bikineev authored
The write barrier doesn't have to be triggered when a source object is allocated on stack. The future implementation of the write barrier (with generational heap in mind) will bailout if the source object is on stack. This CL fixes tests that expect write barriers to be triggered for source objects on stack. Bug: 1029379 Change-Id: I5f8849c44bb42d42a472a9a8e8cab4f1eab6beef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094301 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748225}
-
Kevin Ellis authored
Bug: 1006086 Change-Id: I0dd70c3b901b6f1cb1e979dda893c0aaef079943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091586Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#748224}
-
Gyuyoung Kim authored
This CL converts ViewMsg_ZoomToFindInPageRect message to blink.mojom. LocalMainFrame interface. This CL moves ZoomToFindInPageRect() from WebViewImpl to LocalFrame. Then, it calls some WebViewImpl functions through ChromeClient in LocalFrame::ZoomToFindInPageRect(). And, ZoomToFindInPageRect() is removed in WebView.h because it's not called by RenderViewImpl anymore. Bug: 1047467 Change-Id: I8c06c9857ce7f9805ab1b28c43d8b4b847895403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079714 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748223}
-
Stephen Nusko authored
This is failing consistently. BUG=1059767 NOTRY=true CC=sadrul@chromium.org,vmiura@chromium.org TBR=crouleau@chromium.org Change-Id: I49e9e98852709daf004d7409f1f49458bc309477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093596Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#748222}
-
Yifan Luo authored
Currently, we only have tests test how normal script policies affect on setTimeout and setInterval handlers. This CL add four new tests aimed to test the behavior via default polices. Bug: 1059755 Change-Id: I820d08cebb0fe72e2787ce9f58c86a4a9a3068fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094133Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#748221}
-
arthursonzogni authored
Design doc: https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit?usp=sharing Base + enabled on subframe : This CL + enabled on main frame: https://chromium-review.googlesource.com/c/chromium/src/+/1477694 A few tests are still failing. They can be seen at: https://chromium-review.googlesource.com/c/chromium/src/+/2050308 Bug: 936696 Change-Id: I1451ae6917aeb60c12926500231d7f1eb4b5b687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533913 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#748220}
-
Viktor Semeniuk authored
This change adds special handling for compromised credentials from mobile apps. Instead of a button Change password user see a label which tells him to open the app and change password there. Bug: 1047726 Change-Id: I29c633015a0dcbe22949d5ba7fe97b79883b63d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087583Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#748219}
-
Tsuyoshi Horo authored
There is a bug that navigation of OOPIF's remote iframe in Web Bundle file cause DCHECK failure. The root cause of the bug is that: - When NavigationControllerImpl::NavigateFromFrameProxy() is called for a remote iframe, this method clones the committed NavigationEntryImpl. - NavigationRequest's constructor clones the WebBundleNavigationInfo of the passed NavigationEntryImpl. This is not correct, because WebBundleNavigationInfo should be attached to the frame, not the page. To fix this bug, this CL moves WebBundleNavigationInfo from NavigationEntryImpl to FrameNavigationEntry. Bug: 1058721, 1040800 Change-Id: Ia654876cfd08433550d1bdb9b81e0aac402fe61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091191Reviewed-by:Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748218}
-
Markus Heintz authored
This reverts commit 956b131c. Reason for revert: Specualtive revert in order to fix broken test in https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-chrome/2747 Original change's description: > arc: net: remove ARC N legacy APIs > > This patch removes net.mojom APIs and fields only used in ARC N: > - NetworkConfiguration mac_address: the host mac_address of a network > is now completely hidden in ARC P. > - GetDefaultNetwork and DefaultNetworkChanged: ARC P is multinetwork > aware and always need the full list of connected services. > > BUG=b:149716479 > BUG=b:145960788 > TEST=Compiled, flashed eve, ran CtsNetTestCases. > > Change-Id: I3368d620d44dd910aae7a12c84c207c3d5cb6cf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086362 > Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Hugo Benichi <hugobenichi@google.com> > Cr-Commit-Position: refs/heads/master@{#748094} TBR=kinaba@chromium.org,jorgelo@chromium.org,hidehiko@chromium.org,mnissler@chromium.org,dominickn@chromium.org,hugobenichi@google.com,garrick@chromium.org,jasongustaman@chromium.org,taoyl@chromium.org Change-Id: Id248f5e5f23d8c995404f509c30289b77f94e2cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:149716479, b:145960788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094307Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748217}
-
Takashi Toyoshima authored
sendBeacon depends on OOR-CORS and BlinkCORS does not support it. NOTRY=true TBR: yhirano@chromium.org Change-Id: Ibd2d0d5b7f67fe3c9d680f985915326767b9be45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094421Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748216}
-
Maksim Ivanov authored
To address the UX feedback, this CL makes the error messages displayed in the smart card PIN scenarios shorter: 1. Don't display "Please try again". 2. Don't display the number of attempts left when it's greater than 3. Bug: 1024251 Change-Id: I6450cd96a62a60fc2c414e71ef81af06d93e0e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091355Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#748215}
-
Kevin Ellis authored
Bug: 1006086 Change-Id: I7abf288db967ebb09a6a61be54fcbeaddab8febd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091587 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL converts FrameHostMsg_DidFinishLoad message to blink.mojom. LocalFrameHost interface. WebLocalFrameImpl::DidFinish() starts to invoke LocalFrameHost:: DidFinishLoad first, then it calls RenderFrameImpl::DidFinishLoad because this CL can't move all logics of it to WebLocalFrameImpl:: DidFinish yet. RenderFrameHostImpl begins to override DidFinishLoad. Then, it invokes OnDidFinishLoad implemented in WebContentsImpl class through RenderFrameHostDelegate class. In WebContentsImpl class, OnDidFinishLoad is moved to from IPC handlers to the implements of RenderFrameHostDelegate class. Bug: 1047335 Change-Id: Id5e38f3338759345dae4654cb8843e9069f8bafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074457 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Jana Grill authored
Bug: 1022143 Change-Id: I5ff3ade372059ef4faabe904ae85582de2339d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089692 Commit-Queue: Jana Grill <janagrill@chromium.org> Reviewed-by:
-
Nico Weber authored
This reverts commit 2714fec9. Reason for revert: Breaks GN's MSVC generator, https://crbug.com/1059666 Original change's description: > Support typemaps inlined as GN targets > > This introduces support for typemaps specified as GN targets, with new > cpp_typemaps and blink_cpp_typemaps variables that mojom() targets can > used to reference their typemap rules. > > The underlying work to use the typemap configuration is shared with the > existing typemap infrastructure, but the net result is that we no longer > need separate .typemap files or global "bindings configurations" once > everything is converted to this approach. > > Bug: 1059389 > Change-Id: Id2e5fe765d3c7600a3f50e337fb693f1b3a3cc0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090716 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747990} TBR=rockot@google.com,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1059389 Change-Id: I060cf9d20c7d03c930296a9e777ab5e8c4e2a7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093136Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#748211}
-
Benoît Lizé authored
The "Memory.ParkableString.*.5min" histograms are useful to get data about how the ecosystem is changing, as they mostly reflect the behavior of sites. In addition, they do not take a lot of space either on the client or on the server as they are recorded once per renderer for renderers surviving more than 5 minutes. As a consequence, extend these, and align their expiration milestone. Bug: 1025871, 1025856, 1025856, 1025844 Change-Id: I1d9a613b0c458c491dde795fe51e837ae2abc725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094131Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748210}
-
Simon Zünd authored
The same functionality is already tested here: https://source.chromium.org/chromium/chromium/src/+/a15fa1cd393dd9672d412a08cb7397ff06714f8a:third_party/devtools-frontend/src/test/unittests/front_end/platform/utilities.ts;l=36 So the layout test version can safely be removed. R=petermarshall@chromium.org Bug: chromium:1050549 Change-Id: Ibb1f95bf77255f0d55d89d6d6a80343e988daf02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095065 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#748209}
-
Michael Spang authored
This is not currently compatible with --enforce-vulkan-protected-memory. which forces all shared images to be protected, including canvas resources. Bug: 766360 TBR=sergeyu@chromium.org Change-Id: I784d2fe690cdced6a733f85d6104fbbaf2532057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092871Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748208}
-
Monica Basta authored
This CL removes the sub label for 'Sync everything' and 'Customize sync'. It also removes the segmentation line between the 2 options. Bug: 1043122 Change-Id: I07d11da1025cfe34e07feb2456211f0572770725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095008Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#748207}
-
Tanmoy Mollik authored
This cl adds render tests for the 3 types of SyncErrorInfoBar currently available. Bug: 1031632 Change-Id: Idf8ad0d7856f10f6701207789db518a5aa68b99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083307Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#748206}
-
Nohemi Fernandez authored
Bug: 971989 Change-Id: I406a94c3b6918f401e74e109afd6e98df2fc5803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095115 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#748205}
-
Glenn Hartmann authored
See http://go/webapk-retention-metrics, http://go/webapk-retention-metrics-impl for details. The eventual hope is to augment this metric so that it records page-loads to installed experiences as well, and record a boolean value along with the metric so we can distinguish between the scenarios. This will give us a more direct way to see exactly what proportion of installable page-loads per app are taking advantage of the benefits of installation. It seems like that might require some refactoring to do properly, so I'm going to do the easy part first so we can start getting at least some numbers ASAP, then we can look at improving the situation later. Bug: 1044709 Change-Id: I472012cffe4d0860457a586b2b01a3e7c573a342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057108 Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#748204}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff9b8cccfc47..13188a24a490 git log ff9b8cccfc47..13188a24a490 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 599bebd3..b57f55e2 (747722:748149) 2020-03-09 jianj@google.com VP9 test: change threshold to allow resizing for twice Created with: gclient setdep -r src/third_party/webrtc@13188a24a490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I98b3ffd4a2f76be657fe676d37bd55a6d769d2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094604Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748203}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0154105fc14c..424d28b0701d git log 0154105fc14c..424d28b0701d --date=short --first-parent --format='%ad %ae %s' 2020-03-09 borenet@google.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@424d28b0701d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I34df0232e61a6de698d75ee44ed9bf28e6c8147b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095018Reviewed-by:
-
Jan Wilken Dörrie authored
Bug: 934326 Change-Id: I90790d9dfc1d84ac72b04a2b9d4814a8b0589e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095057 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Yifan Luo authored
Since previous Cls, https://chromium-review.googlesource.com/c/chromium/src/+/2012284 and https://chromium-review.googlesource.com/c/chromium/src/+/2013125, created StringContext WebIDL extended attributes and removed the usage of union types, the InnerHTMLFromString, OuterHTMLFromString, SetInnerHTMLFromString and SetOuterHTMLFromString are no longer needed, so this CL removes them and the related usages. Bug: 1043136 Change-Id: Ic283100c68b4ad8596b4f7559be6cd253cd2c5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089854 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#748200}
-
Benoît Lizé authored
The overhead of ParkableString is: - sizeof(ParkableString) - sizeof(ParkableStringImpl) + digest + compressed data (if compressed) The first one is small (sizeof(scoped_refptr<>), which is sizeof(void*)), but the second one is non-trivial. This is due to: - Need to cache metadata about a string when it is parked, for instance Is8Bit(), or its initial length. - SHA256 hash used to deduplicate parked and unparked strings - WTF::Mutex, which includes a pthread_mutex_t, which is large on most platforms. - Handling of recursive locking, plus ParkableStringImpl being a refcounted class itself. This is problematic, since it means that callers must know whether the string is large, and either use WTF::String for small ones, or ParkableString for large ones. It leads to more complex and duplicated code, or to potential memory regressions. As ParkableString is starting to be used in more places (e.g. for trusted scripts), having to handle this becomes cumbersome and more error-prone. On the other hand, all the metadata outlined above is not necessary if the string is never parked, which is the case for small ones. So the desired state is: short ParkableStrings are cheap enough so that they can be used no matter the string length. There are two simple ways to handle this: - Have ParkableString hold the StringImpl directly for short strings - Separate the metadata in ParkableStringImpl. The first approach seems simpler, but would introduce non trivial complexity in V8's value cache for strings (since it caches a ref-counted impl for strings, and would need to know about the short and long ParkableStrings). So the second one is selected here. The new overhead is: - Short ParkableStrings: - sizeof(ParkableStringImpl) == 3 * sizeof(void*) compared to WTF::String - savings of sizeof(ParkableStringImpl::Metadata) compared to ParkableString - Long ParkableStrings: 0 vs the previous overhead (by replacing a std::unique_ptr<SecureDigest> with a std::unique_ptr<ParkableStringImpl::ParkableMetadata>) Given that client code had to keep a ParkableString *and* a String to handle short ones, the net cost is 2*sizeof(void*) for short strings, and no code duplication. As a consequence, ParkableString can now be used for short and long strings without any custom code. CharacterData is converted accordingly. A forthcoming CL will evaluate using ParkableString for *all* CharacterData instances. Also some cleanup: - "git cl lint" warnings: include-what-you-use and explicit constructor - Move mutex runtime assertions to compile-time checks. - Make the ordering in parkable_string.cc consistent with the .h Bug: 1059268, 877044 Change-Id: Ic397751970c6beeaf9d524102f50d5d71ec4a0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091494 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: -
Maksim Moskvitin authored
This CL removes remaining ObjectID usages (mostly in components/invalidation) from C++ codebase. Cleaning up the dependencies on cacheinvalidation outside of components/invalidation will be done in follow up patches. Tbr: fukino@chromium.org Bug: 1029698 Change-Id: Ib6b2aa064be72f35c9ddef191a7471e194090588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087338 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#748198}
-
Michael Ershov authored
Make a keyed service from the platform_keys.h file and add a mock class for it to allow unit testing of a code that depends on that code. Bug: 1045895 Change-Id: I5008805ac7aaf85af65177d67b45a9411c1726a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078614 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#748197}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/717fa7a90e52..f77f10f33266 git log 717fa7a90e52..f77f10f33266 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 66a682b6a8f9..4c027048d88b (3 commits) 2020-03-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 9bd3f561bcee..74556a131735 (1 commits) 2020-03-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src aa95c80e1a89..6861ea4e10a1 (1 commits) Created with: gclient setdep -r src/third_party/angle@f77f10f33266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I4979ab5dce2a1fdfa9e5dbc86d37d27051d43bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095157Reviewed-by:
-
Ewann authored
The coordinator now creates the page view site security with an object that contains the information to be displayed. Bug: 1038919 Change-Id: I541fe3171dbc9dd6a0860e0691fc7504fedaa16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090423Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#748195}
-
Nico Weber authored
This reverts commit aa7438aa. Reason for revert: prereq for reverting #747990, https://crbug.com/1059666 Original change's description: > Convert some mojo_base typemaps to GN targets > > Uses new GN-based typemap definitions to replace some typemap files in > mojo/public/cpp/base. > > Bug: 1059389 > Change-Id: If1389c9ceec8ae90df753895af0abd9f72c704a0 > Tbr: dtapuska@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090723 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#748056} TBR=dcheng@chromium.org,rockot@google.com,darin@chromium.org,tsepez@chromium.org,oksamyt@chromium.org Change-Id: Ie1e57392e084f2e6a8a62bfe2667f5f451380a29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095215 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
This reverts commit 1b21e379. Reason for revert: prereq for reverting #748056, https://crbug.com/1059666 Original change's description: > Migrate URL and Origin typemaps to GN definitions > > Also moves some longer bits of code out-of-line. > > Bug: 1059389 > Change-Id: Idd1b3606e26504ab92e9aefebc933823919a2431 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092695 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748058} TBR=dcheng@chromium.org,rockot@google.com,dtapuska@chromium.org Change-Id: I2573e9bea2f125e5dafe7a1d9b9b46ac1d12025a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095216Reviewed-by:
-
