GitLab

BUG=628379

Review-Url: https://codereview.chromium.org/2151113002
Cr-Commit-Position: refs/heads/master@{#406019}

Currently, there can be a situation where if the plugin removes itself
during initialization, the container is destroyed but the placeholder
plugin is not. This patch fixes this issue.

BUG=620515

Review-Url: https://codereview.chromium.org/2151483007
Cr-Commit-Position: refs/heads/master@{#406018}

There was a bad interaction between throttled task queues and
logic in TimerBase::setNextFireTime that could cause setInterval
to stop firing.

If a timer was posted to a throttled task queue after running on
a normal task queue, it was possible for NOW to be in the past.

Logic existed in TimeDomain::ComputeDelayedRunTime to compensate
for this. Usually that worked fine, however the anti-drift logic
in TimerBase for repeating tasks could cause the scheduled run
time (as visible to TimerBase) to fall on the exact same time as
the previous run.  This would cause TimerBase::setNextFireTime
to nop out, which would cause the setInterval to stop firing.

This patch prevents that by changing ThrottledTimeDomain to be based
on RealTimeDomain.  This means Now() is the real time rather than a
periodically updated virtual time.  I.e. it's monotonically increasing.

At the same time I've remove the now useless
TimeDomain::ComputeDelayedRunTime

BUG=625041

Review-Url: https://codereview.chromium.org/2155143002
Cr-Commit-Position: refs/heads/master@{#406017}

Reland of New PaintController under-invalidation checking (patchset #1 id:1 of https://codereview.chromium.org/2156053002/ )

Reason for revert:
The original CL is to discover such bugs. Will mark the test failure in the reland.

Original issue's description:
> Revert of New PaintController under-invalidation checking (patchset #7 id:120001 of https://codereview.chromium.org/2114653003/ )
>
> Reason for revert:
> NOTREACHED being hit in checkUnderInvalidation on WebKit Win7 (dbg); see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6481.
>
> Original issue's description:
> > New PaintController under-invalidation checking
> >
> > This is a follow-up of https://codereview.chromium.org/2107103002/
> > which broke the original under-invalidation checking in
> > PaintController.
> >
> > BUG=596983,510908
> >
> > Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1
> > Cr-Commit-Position: refs/heads/master@{#405805}
>
> TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=596983,510908
>
> Committed: https://crrev.com/f2f05c78616f02157cd1414905a8692f227d9a64
> Cr-Commit-Position: refs/heads/master@{#405988}

TBR=chrishtr@chromium.org,pdr@chromium.org,grt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596983,510908

Review-Url: https://codereview.chromium.org/2162603002
Cr-Commit-Position: refs/heads/master@{#406016}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/db420127..3b4db493

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2162553002
Cr-Commit-Position: refs/heads/master@{#406015}

Count the SetOutputNodeVolume requests sent during the audio initialization and track them with the OutputNodeVolumeChanged signals responding from cras, do not pop up the volume bar for such signals.

BUG=625222

Review-Url: https://codereview.chromium.org/2146313005
Cr-Commit-Position: refs/heads/master@{#406014}

Several failures have tracking bugs or were mis-classified.

BUG=483282,627531,624506,626068
BUG=angleproject:1246,angleproject:1268
R=kbr@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2146593002
Cr-Commit-Position: refs/heads/master@{#406013}

https://chromium.googlesource.com/chromium/src/+/b5683a83c

BUG=624285
TBR=jgruber@chromium.org

Review URL: https://codereview.chromium.org/2156233002 .

Cr-Commit-Position: refs/heads/master@{#406012}

presentSSLError:forSSLStatus:recoverable:callback: is not implemented
by Tab anymore.

BUG=602298

Review-Url: https://codereview.chromium.org/2146763003
Cr-Commit-Position: refs/heads/master@{#406011}

https://chromium.googlesource.com/skia.git/+log/eaf6d4102258..490c07d77670

$ git log eaf6d4102..490c07d77 --date=short --no-merges --format='%ad %ae %s'
2016-07-18 msarett Test auto merger

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2159783002
Cr-Commit-Position: refs/heads/master@{#406010}

When loading the STHs, the STHSet Component will invoke the
SafeJsonParser up to half a dozen times (one for each STH), which
can have performance implications.

Also update the PostAfterStartupTask documentation to indicate the
task will be posted immediately if called after start-up.

BUG=607946

Review-Url: https://codereview.chromium.org/2140093002
Cr-Commit-Position: refs/heads/master@{#406009}

There is a place in RenderFrameImpl::OnFind where after one find match is found, it reports that single match just to indicate that there is at least one match in the frame. This is useful when searching the frame for the first time, but pretty meaningless during a "find next" request since the whole frame will have already been searched and all of the matches reported beforehand. It's also detrimental since it will temporarily lower the global match count and then have to recalculate various things when it goes back up.

This patch prevents this single match reply during "find next" requests.

BUG=457440

Review-Url: https://codereview.chromium.org/2122263004
Cr-Commit-Position: refs/heads/master@{#406008}

BUG=

Review-Url: https://codereview.chromium.org/2083743002
Cr-Commit-Position: refs/heads/master@{#406007}

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447

Review-Url: https://codereview.chromium.org/2130443002
Cr-Commit-Position: refs/heads/master@{#406006}

This was introduced in r135340 in an attempt to fix a crash in issue
125969, which it ended up not fixing, but nobody reverted it
afterward.  It doesn't appear to be necessary.

BUG=466297

Review-Url: https://codereview.chromium.org/2145353004
Cr-Commit-Position: refs/heads/master@{#406005}

Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2155193002/ )

Reason for revert:
CL falsely blamed for red layout test. Relanding it.

Original issue's description:
> Revert of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2154193002/ )
>
> Reason for revert:
> Relanding this has potentially caused a layout test to fail (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8452). The build sheriff has asked me to revert it.
>
> Adding aelias & vmiura so they can do a more refined revert on their return from vacation.
>
> Original issue's description:
> > Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ )
> >
> > Reason for revert:
> > Reverting change now that we have collected data from telemetry.
> >
> > Original issue's description:
> > > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ )
> > >
> > > Reason for revert:
> > > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790).
> > > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result.
> > >
> > > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted.
> > >
> > > Original issue's description:
> > > > Re-enable GPU Rasterization for content with any author defined viewport.
> > > >
> > > > BUG=591179
> > > >
> > > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339
> > > > Cr-Commit-Position: refs/heads/master@{#402702}
> > >
> > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=591179
> > >
> > > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4
> > > Cr-Commit-Position: refs/heads/master@{#405750}
> >
> > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=591179
> >
> > Committed: https://crrev.com/5f19720ded2369857bee408ab48e11e7b5d28f7b
> > Cr-Commit-Position: refs/heads/master@{#405974}
>
> TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=591179
>
> Committed: https://crrev.com/1ce44d25cbafd74f034c30ddfd4b0f3caed9978d
> Cr-Commit-Position: refs/heads/master@{#405983}

TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org,alexclarke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591179

Review-Url: https://codereview.chromium.org/2161663002
Cr-Commit-Position: refs/heads/master@{#406004}

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)

Review-Url: https://codereview.chromium.org/2141703003
Cr-Commit-Position: refs/heads/master@{#406003}

Calculate the number of event listener invocations that we didn't actually
end up allowing preventDefault to actually execute. The denominator
in this metric is the total number of invocations that we force passive
on.

BUG=625675

Review-Url: https://codereview.chromium.org/2137483003
Cr-Commit-Position: refs/heads/master@{#406002}

Registering a KeepAlive during shtudown is forbidden and hits
a CHECK, so we should avoid starting some operations that do
it.

This CL adds checks to avoid such situations:
- push notifications received from GCM while shutting down
will be dropped early instead of causing a crash and being
dropped anyway.
- Extension functions using chrome_details validate before
running that the browser process is not shutting down.

BUG=625646

Review-Url: https://codereview.chromium.org/2118473002
Cr-Commit-Position: refs/heads/master@{#406001}

Just a couple of improvements to MixedContentChecker:
- Remove uneeded check for data protocol: it's already included in the protocols
checked in SecurityOrigin::isSecure.
- Improved check for localhost by name to be more complete.

BUG=607878,624275

Review-Url: https://codereview.chromium.org/2151473002
Cr-Commit-Position: refs/heads/master@{#406000}

The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes.

BUG=626993

Review-Url: https://codereview.chromium.org/2145393004
Cr-Commit-Position: refs/heads/master@{#405999}

This patch renames browsing_*.wpr to memory_system_health_*.wpr so
that all references in memory_system_health_*.json start with the same
prefix 'memory_system_health'.

For more context see https://codereview.chromium.org/2144073004/#msg21

BUG=589726

Review-Url: https://codereview.chromium.org/2161583003
Cr-Commit-Position: refs/heads/master@{#405998}

This a a partial, somewhat naive, fix for a bug where CJK names were
split the same way as western names. CJK names have the family name
(surname) first, and don't usually have a space in-between the two parts.

For a complete fix, we might need to improve Japanese name detection,
when there is no space between the two names. It's unclear how often
users actually enter their name without spaces in a form field.

We might also want to fix the opposite use-case: when the user enters
their first & last name in separate fields, we should infer their full
name in the right order (with ordering based on the script used).

BUG=89111

Review-Url: https://codereview.chromium.org/2132103002
Cr-Commit-Position: refs/heads/master@{#405997}

This is a test patch that fixes a memory leak caused by the reference between
HTMLMediaElement and ElementVisibilityObserver.

The previous patch breaks the reference cycle but seems doesn't fix the leak.
Using WeakPersistent is a workaround, but seems does not fix the leak entirely.
Keeping https://crbug.com/627539 open to keep track of the remaining leaks.

BUG=628367,627539

Review-Url: https://codereview.chromium.org/2151243002
Cr-Commit-Position: refs/heads/master@{#405996}

The former is misleading; Chromium hasn't used WebKit for over three years.

The Blink version no longer adds more information. Since the repository merge,
the Blink version number is a constant 537.36 and its revision always matches the
Chromium revision.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2125473002
Cr-Commit-Position: refs/heads/master@{#405995}

BUG=none
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2158813002
Cr-Commit-Position: refs/heads/master@{#405994}

https://boringssl.googlesource.com/boringssl/+log/10f97f3bfcecc3fbe8e9f02e7c426f7e340f7f54..8d315d70563b49868469c57199aa5d69c7c818dd

BUG=none

Review-Url: https://codereview.chromium.org/2156973002
Cr-Commit-Position: refs/heads/master@{#405993}

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG=629013

Review-Url: https://codereview.chromium.org/2145963002
Cr-Commit-Position: refs/heads/master@{#405992}

This issue happens when a resolution change happens right
after a reset. First the client requests a reset. The image
processor is still processing some buffers and they will be
ignored when returning to V4L2VideoAccelerator. Then a
resolution change occurs and V4L2VDA stops the output queue.
The image processor returns a buffer and V4L2VDA queues it
back. Since the queue is stopped, STREAMON will be called to
start the queue. Finally REQBUFS will fail during resolution
change because the queue is not stopped.

The fix is we should not queue the buffer returned from
image proessor if a resolution change is in progress.

BUG=chrome-os-partner:55347
TEST=Seek when playing switch_1080p_720p.mp4 on oak.
The video is from gs://chromiumos-test-assets-public/Shaka-Dash.

Review-Url: https://codereview.chromium.org/2156003002
Cr-Commit-Position: refs/heads/master@{#405991}

If a display power change request arrives before the previous one
finishes or if a previous power change request failed the state becomes
inconsistent and future requests are optimized out.

BUG=627795
TEST=New unittest in display_unittests and manually checked on Samus

Review-Url: https://codereview.chromium.org/2154743003
Cr-Commit-Position: refs/heads/master@{#405990}

This reverts commit d3e00ac3.
ChromeOS would crash at boot and could not reach login screen with
commit d3e00a.

BUG=chromium:593461
TBR=dpranke@chromium.org
TBR=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2155183002
Cr-Commit-Position: refs/heads/master@{#405989}

Revert of New PaintController under-invalidation checking (patchset #7 id:120001 of https://codereview.chromium.org/2114653003/ )

Reason for revert:
NOTREACHED being hit in checkUnderInvalidation on WebKit Win7 (dbg); see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6481.

Original issue's description:
> New PaintController under-invalidation checking
>
> This is a follow-up of https://codereview.chromium.org/2107103002/
> which broke the original under-invalidation checking in
> PaintController.
>
> BUG=596983,510908
>
> Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1
> Cr-Commit-Position: refs/heads/master@{#405805}

TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596983,510908

Review-Url: https://codereview.chromium.org/2156053002
Cr-Commit-Position: refs/heads/master@{#405988}

BUG=624285

Review-Url: https://codereview.chromium.org/2147213003
Cr-Commit-Position: refs/heads/master@{#405987}

Add template type parameter to KMP, fuzzy and URL pattern matching tools. The
introduced IntType parameter denotes the type of the failure function elements.
Use uint8_t to store failure functions of URL patterns in the FlatBuffer.

BUG=609747

Review-Url: https://codereview.chromium.org/2153743002
Cr-Commit-Position: refs/heads/master@{#405986}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/946f9cc0..db420127

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2156943002
Cr-Commit-Position: refs/heads/master@{#405985}

BUG=550886

Review-Url: https://codereview.chromium.org/2143693003
Cr-Commit-Position: refs/heads/master@{#405984}

Revert of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2154193002/ )

Reason for revert:
Relanding this has potentially caused a layout test to fail (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8452). The build sheriff has asked me to revert it.

Adding aelias & vmiura so they can do a more refined revert on their return from vacation.

Original issue's description:
> Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ )
>
> Reason for revert:
> Reverting change now that we have collected data from telemetry.
>
> Original issue's description:
> > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ )
> >
> > Reason for revert:
> > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790).
> > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result.
> >
> > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted.
> >
> > Original issue's description:
> > > Re-enable GPU Rasterization for content with any author defined viewport.
> > >
> > > BUG=591179
> > >
> > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339
> > > Cr-Commit-Position: refs/heads/master@{#402702}
> >
> > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=591179
> >
> > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4
> > Cr-Commit-Position: refs/heads/master@{#405750}
>
> TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=591179
>
> Committed: https://crrev.com/5f19720ded2369857bee408ab48e11e7b5d28f7b
> Cr-Commit-Position: refs/heads/master@{#405974}

TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591179

Review-Url: https://codereview.chromium.org/2155193002
Cr-Commit-Position: refs/heads/master@{#405983}

webp_transcode is now only used from ios/chrome/browser.

BUG=627509
TBR=jam

Review-Url: https://codereview.chromium.org/2146833002
Cr-Commit-Position: refs/heads/master@{#405982}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8ae70d714551..d2b666834a28

$ git log 8ae70d714..d2b666834 --date=short --no-merges --format='%ad %ae %s'

BUG=627166

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2157923002
Cr-Commit-Position: refs/heads/master@{#405981}

r141724 added code to the toolkit-views content settings bubble to
disable the radio buttons on a content settings popup if the setting was
controlled by enterprise policy, but this never made it to Cocoa.

Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass
the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled.

Screenshot at http://crbug.com/509249#c30

BUG=509249, 98029

Review-Url: https://codereview.chromium.org/2153393002
Cr-Commit-Position: refs/heads/master@{#405980}