GitLab

Queued immediately after an OnSettings() visitor call.

Use a placeholder frame as needed in impacted tests,
so that test flow isn't protocol-version dependent.

BUG=345769

Review URL: https://codereview.chromium.org/289823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270807 0039d316-1c4b-4281-b951-d872f2087c98

I don't really this is the root cause of r371851, but anyway,
tighten up the logic seems reasonable.

BUG=371851
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/283823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270806 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270805 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373500

Review URL: https://codereview.chromium.org/288243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270804 0039d316-1c4b-4281-b951-d872f2087c98

This is a poor-man's solution to unblock the apps v2 release. It causes an
existing Chrome window (or a new one if there aren't any) to download the
installer. This is needed because the v2 app doesn't have a brower context,
which means no download shelf for the user to click when the download completes.
The UX is pretty horrible because the Chrome window pops on top of the app
window, typically obscuring the instructions. I'm open to better solutions.

This also fixes a bug in the host setup and install dialogs, which were not
showing the translucent screen that normally obscures the main UI while a
modal dialog is open.

Review URL: https://codereview.chromium.org/282113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270802 0039d316-1c4b-4281-b951-d872f2087c98

    
We will be using ImageStore with
BrowserThread::PostBlockingPoolSequencedTask which doesn't always
guarantee same thread execution.
    
BUG=368034

Review URL: https://codereview.chromium.org/288573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371295

Review URL: https://codereview.chromium.org/271853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270800 0039d316-1c4b-4281-b951-d872f2087c98

Speciffically, handle case when a non ASCII UTF8 character is read
partially from the process output. Instead of reporting read character
bytes imediatelly, cache them until the rest of the character is read
from the process output.

BUG=278340
TEST=in crosh (see comment #1 in the bug):
$python
>>> print(u"\u20ac" * 10000)
Verify a series of EURO signs is displayed (without "unknown" characters)

Review URL: https://codereview.chromium.org/261743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270799 0039d316-1c4b-4281-b951-d872f2087c98

Causing Android Tests failure in telemetry_perf_unittests.

> [telemetry] Make testMeasurementSmoke generate separate tests.
> 
> This way failures in one benchmark won't stop the rest of the tests, and it'll print separate GTest steps for each benchmark.
> The test names follow the format BenchmarkSmokeTest.benchmark.name so you can still find BenchmarkSmokeTest with a search.
> 
> Also:
> - Rename it to the more apt BenchmarkSmoke.
> - Print Chrome stack trace when there's a tab crash at Chrome startup.
> 
> 
> BUG=368401,371613,373385
> TEST=tools/perf/run_tests benchmark
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/287773002

TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/289053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270798 0039d316-1c4b-4281-b951-d872f2087c98

> Suppressed screen rotation notifications triggeres by the accelerometer
> 
> BUG=364949
> Test=MaximizeModeControllerTest.BlockRotationNotifications
> 
> Review URL: https://codereview.chromium.org/267743010

TBR=bruthig@chromium.org

Review URL: https://codereview.chromium.org/290563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270793 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/278113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270791 0039d316-1c4b-4281-b951-d872f2087c98

Remove include of Xlib.h in x11_atom_cache.h and forward declare the necessary X11 types. This is needed for tests because the definition of None in X.h conflicts with the definition of None in gtest-type-util.h

BUG=None
TEST=None
TBR=sadrul

Review URL: https://codereview.chromium.org/286103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270790 0039d316-1c4b-4281-b951-d872f2087c98

Instead of skipping the interception, abort the prerender so that the prerender
doesn't cause the actual navigation to bypass the interception.

BUG=370519

Review URL: https://codereview.chromium.org/265293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270789 0039d316-1c4b-4281-b951-d872f2087c98

Make bisects to look for the pattern RESULT lines with  {mean, stddev} format while parsing results log.

BUG=366431
NOTRY=true

Review URL: https://codereview.chromium.org/288843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270788 0039d316-1c4b-4281-b951-d872f2087c98

Before delegated rendering, it was needed to throttle resizes beyond the
existing resize ack mechanism, because we could receive the frame after
the ViewHostMsg_UpdateRect with the ack.
With delegated rendering, we receive the frame before the ack (ack is
sent in RenderWidget::didCompleteSwapBuffers, which necessarily happens
after CompositorOutputSurface::SwapBuffers which sends the
ViewHostMsg_SwapCompositorFrame)

This then avoids RenderWidgetHostViewAura::GetViewBounds from changing
based on renderer state, which removes transient states (and related
test flakiness).

This depends on https://codereview.chromium.org/286053002/ because this
exposes test flakiness.

BUG=None

Review URL: https://codereview.chromium.org/286953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270786 0039d316-1c4b-4281-b951-d872f2087c98

R=kbr@chromium.org
BUG=252046, 371592
NOTRY=true

Review URL: https://codereview.chromium.org/282953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270785 0039d316-1c4b-4281-b951-d872f2087c98

The Doom* contract is meant to follow conventions used for other browsing data
types, like the cookie monster. This CL clarifies the time comparisons to use.

It also removes an extra delay introduced in r219969.

BUG=330926
TEST=current

Review URL: https://codereview.chromium.org/118123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270784 0039d316-1c4b-4281-b951-d872f2087c98

I don't see any reason for not calling it there as we already do this in
the other cases.

BUG=None
TEST=None
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/282163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270783 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/282183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270782 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/252583007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270781 0039d316-1c4b-4281-b951-d872f2087c98

Moves existing ozone platform flag to new .gni file with all ozone flags in it.

R=piman@chromium.org, rjkroege@chromium.org, spang@chromium.org

Review URL: https://codereview.chromium.org/285103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270780 0039d316-1c4b-4281-b951-d872f2087c98

This was not hooked up but I kept it being acceptsed until all uses can be deleted. This deletes the remaining uses from the tree.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/283883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270779 0039d316-1c4b-4281-b951-d872f2087c98

The android pixel tests use the ui::Snapshot code to get a pixel copy
of the content_shell's output. Make this behaviour match the aura
implementation of ui::Snapshot by returning false in the synchronous
verion, causing callsites to fall back to the async one.

This implements the async snapshots by moving the aura implementation
out into snapshot_async.cc and reusing that code (with one #if for
RGBA vs BGRA ordering).

After this, the pixel tests get a bitmap from cc instead of creating
their own bitmap. The result is that the bitmap has a slightly
different size (384x528) which is the size of the root layer. The
pixel tests were previously trying to crop to 400x300, which is
outside the bounds of this bitmap, so change them to crop to 300x300
instead, and increment their versions to pick up the new pngs.

BUG=252046, 371592

Review URL: https://codereview.chromium.org/281003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270778 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer needed (as try jobs indicate), possibly since r269230.

R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/288813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270776 0039d316-1c4b-4281-b951-d872f2087c98

Fix x509_certificate_model::RegisterDynamicOids not getting called since gtk certificate viewer was removed.

BUG=338887,371171

Review URL: https://codereview.chromium.org/271753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270775 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/288993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270774 0039d316-1c4b-4281-b951-d872f2087c98

signin/sync status changed. It invokes given backup/rollback callbacks if conditions are met.

BUG=362679

Review URL: https://codereview.chromium.org/266233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270773 0039d316-1c4b-4281-b951-d872f2087c98

  - note that this entailed moving getDesktop to the same callback system as getTree()
- Remove "enable automation API" flag
- Convert all Automation API functions into UIThreadExtensionFunctions

BUG=309681
NOTRY=true

Review URL: https://codereview.chromium.org/281763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270772 0039d316-1c4b-4281-b951-d872f2087c98

(The other dangerous default argument, _processed_files, is as intended,
since it's meant to memoize across all invocations.
_imported_filename_stack was unnecessarily dangerous, but there was no
bug since we never modified it.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/285413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270771 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270770 0039d316-1c4b-4281-b951-d872f2087c98

content::BrowserPluginTest_ResizeFlowControl_Test::TestBody

TBR=bruening@chromium.org
BUG=373393

Review URL: https://codereview.chromium.org/289883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270769 0039d316-1c4b-4281-b951-d872f2087c98

Roll to the top of the es2-legacy branch.  Contains fixes for some Google
Maps shaders, D3D11 uniform packing and polygon offset.

Review URL: https://codereview.chromium.org/278973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270768 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/282073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270767 0039d316-1c4b-4281-b951-d872f2087c98

This way failures in one benchmark won't stop the rest of the tests, and it'll print separate GTest steps for each benchmark.
The test names follow the format BenchmarkSmokeTest.benchmark.name so you can still find BenchmarkSmokeTest with a search.

Also:
- Rename it to the more apt BenchmarkSmoke.
- Print Chrome stack trace when there's a tab crash at Chrome startup.


BUG=368401,371613,373385
TEST=tools/perf/run_tests benchmark
NOTRY=true

Review URL: https://codereview.chromium.org/287773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270766 0039d316-1c4b-4281-b951-d872f2087c98

Add SetAttribute method to MockObject to avoid setting attributes outside of the
class.
Remove unused variables.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/272183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270765 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Use ExtensionRegistryObserver instead of deprecated extension notification from autocomplete (https://codereview.chromium.org/271393003/)

Reason for revert:
Crash is reported.
See https://code.google.com/p/chromium/issues/detail?id=373624

Original issue's description:
> Use extensions::ExtensionRegistryObserver instead of deprecated extension notification from autocomplete
> 
> R=pkasting@chromium.org
> CC=kalman@chromium.org
> BUG=354046, 354458
> TEST=unit_tests
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270268

TBR=pkasting@chromium.org,kalman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=354046, 354458

Review URL: https://codereview.chromium.org/290043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270764 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Enabling it for M37 dev builds.

Original issue's description:
> Remove instant-search-clicks flag.
> 
> BUG=373381
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270706

TBR=yfriedman@chromium.org,ksimbili@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373381

Review URL: https://codereview.chromium.org/284233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270763 0039d316-1c4b-4281-b951-d872f2087c98

Cleanups:
- most places now directly use ContentViewCore instead of ContentView
- ContentView.getContentViewCore is removed (as you should be using
  CVC directly and CVC.getContainerView())
- Tab.getContentView is removed. Use Tab.getView or
  Tab.getContentViewCore().getContainerView(), with the latter being for
  content rendered without android views.

BUG=360664
NOTRY=true

Review URL: https://codereview.chromium.org/275733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270762 0039d316-1c4b-4281-b951-d872f2087c98

This CL uses TranslateTabHelper instead of Profile and also cleans up
some unused code and irrelevant dependencies.

BUG=371845

Review URL: https://codereview.chromium.org/286973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270758 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/288133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270757 0039d316-1c4b-4281-b951-d872f2087c98