GitLab

This is a minimal amount to get the `views` target compiling on Mac. It
adds an implementation of NativeWidgetMac that spews NOTIMPLEMENTED().
So, nothing works yet, but this gives an FYI builder something to chew
on to catch regressions in things ported so far.

BUG=366007

Review URL: https://codereview.chromium.org/249113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272849 0039d316-1c4b-4281-b951-d872f2087c98

This test depends on the initialization of ResourceBundle, now that we
have GfxTestSuite initializating it we can move it into gfx_unittests
target.

BUG=331829
TEST=ui_unittests, gfx_unittests
TBR=danakj@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/298083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272848 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) dom_action_types.h
2) install_warning.h

Review URL: https://codereview.chromium.org/296173011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272847 0039d316-1c4b-4281-b951-d872f2087c98

VideoDecoderVpx has supported VP9 for a while, but was missing a colour
conversion codepath from I444 frames to ARGB.

BUG=377239,260879,134202

Review URL: https://codereview.chromium.org/300653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370175

Review URL: https://codereview.chromium.org/292663018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272845 0039d316-1c4b-4281-b951-d872f2087c98

into view seems to be not working. Implement user pod scroll into view depending
on the number of user pod rows available.

Login pods scroll into view is triggered only on window resize and when keyboard is shown.
This means that if keyboard is already shown (i.e. no resize is happening) and user selects
another user pod in different row no scrolling happens i.e. relying on user to scroll pods manually.

Also updating outer-container min-height based on primary display resolution.

Note: Lock screen has overscroll enabled since default scroll into view implementation is working fine there.

Main changes are in
login_display_host_impl.cc
display_manager.js
user_pod_row.js
keyboard_util.cc
The rest is just adding 2 new common methods into the interfaces.

To disable this feature: --disable-login-scroll-into-view

Screenshots: https://folio.googleplex.com/loginvk

BUG=363635
TEST=Manual: 1..6 rows of user pods, bring up VK. Both landscape and portrait mode, incl. screen rotation.

Review URL: https://codereview.chromium.org/292233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272843 0039d316-1c4b-4281-b951-d872f2087c98

As far as update engine that process Rollback requests requires rootfs verification, we're unable to set usual flag for testing Rollback option.

So existence of /tmp/enable_rollback_ui.flag file is the new flag for Rollback reset option.

BUG=368860

Review URL: https://codereview.chromium.org/292973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272840 0039d316-1c4b-4281-b951-d872f2087c98

This will allow Wrapper::Shutdown to drop all process references synchronously
in a future change, which will make it possible to shutdown Chrome with service
workers running and without hitting the DCHECK in
ProfileDestroyer::DestroyProfileWhenAppropriate().

BUG=368570

Review URL: https://codereview.chromium.org/292973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272839 0039d316-1c4b-4281-b951-d872f2087c98

It seems there is a problem running gsutil on cros dtus, so adding few
extra log statements around that code.

BUG=351143

Review URL: https://codereview.chromium.org/298863016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=rsesek

Review URL: https://codereview.chromium.org/304443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272837 0039d316-1c4b-4281-b951-d872f2087c98

+ Flip a coin and if we have persisted 1000 MRU servers, then load only
  either 200 or 1000 servers from disk.

+ Persist only one server (or don't duplicate server names) that
  spoke QUIC for canonical suffixes like:
  + .c.youtube.com
  + .googlevideo.com

+ Bumped up the version number of http_server_properties.

+ Added two histograms to measure the impact of persisting 1000
  alternate protocol servers.
  ++ Net.AlternateProtocolUsage.200Truncated
  ++ Net.AlternateProtocolUsage.1000Truncated

R=jar@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/298683010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81979

Review URL: https://codereview.chromium.org/301483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81979

Review URL: https://codereview.chromium.org/293343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272834 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes MetricsService and MetricsLog to take in a |local_state| param
in their constructors. It additionally changes several static MetricsService
functions to take in a |local_state| param.

BUG=374299,374300
TBR=jochen

Review URL: https://codereview.chromium.org/282093012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272833 0039d316-1c4b-4281-b951-d872f2087c98

This flag prevents redundant auto zoom commands when scrolling an
editable node into view. It had the side effect of making it so that
a keyboard being dismissed using the dismiss button (without losing
focus on the current node) wouldn't scroll the node back into view
if it was tapped on again. This patch clears the flag when the
visible viewport size changes, as happens when the keyboard is shown
or hidden.

BUG=375722

Review URL: https://codereview.chromium.org/289343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/299833008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272831 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes some of the callsites to RenderProcessHost::IsGuest.

BUG=364141, 330264
TBR=benm@chromium.org for trivial android_webview change.

Review URL: https://codereview.chromium.org/291403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272830 0039d316-1c4b-4281-b951-d872f2087c98

Reapply the animation of TrayBackgroundView. Update to account for visibility changes that occur during animations.

Added a test for to cover state changes during animations.

Original review: https://codereview.chromium.org/251193004/
Revert review: https://codereview.chromium.org/281793002/
This reverts commit 399aa22e

TEST=SystemTrayTest
BUG=372285,363714

Review URL: https://codereview.chromium.org/289743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272829 0039d316-1c4b-4281-b951-d872f2087c98

the only one to run with a reference file and moves the normal tests to
use the generating fake device (i.e. the spinning green ball). This is
fine since the main test doesn't care, whereas the perf test must have
a somewhat realistic video to give realistic encode/decode numbers.

The CPU test can be thrown away since we have telemetry tests for that
now.

BUG=375240

Review URL: https://codereview.chromium.org/294053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272828 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272827 0039d316-1c4b-4281-b951-d872f2087c98

useful for tracking stats but won't have any real effects.

Modify the AccountReconcilor_unittest to execute with the new_profile_management flag on.

BUG=357693
TEST=Account Reconciler should function normally when
new_profile_management flag is on. Should not have effects when the
flag is off, but UMA stats (histograms) and logging (for
--vmodule=account_reconcilor=1) should still trace the execution path.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272131

Review URL: https://codereview.chromium.org/276463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272826 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174716:174779&mode=html
TBR=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/299393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272825 0039d316-1c4b-4281-b951-d872f2087c98

by prerender. This can be used to emergency disable the feature, or to do
comparisons of other metrics.

R=davidben@chromium.org

Review URL: https://codereview.chromium.org/293123010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/299353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377337

Review URL: https://codereview.chromium.org/302453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/305483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272806 0039d316-1c4b-4281-b951-d872f2087c98

They are broken on ImportError: No module named gyp in gclient sync.
They may need to cycle after a broken DEPS roll revert.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/4940/steps/gclient%20runhooks/logs/stdio
http://src.chromium.org/viewvc/chrome?view=rev&revision=272796

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272801 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272797 0039d316-1c4b-4281-b951-d872f2087c98

> Roll pdfium to 887dc5d8
> 
> TBR=tapted@chromium.org
> 
> Review URL: https://codereview.chromium.org/297363002

TBR=raymes@google.com

Review URL: https://codereview.chromium.org/302583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272796 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Suspected for android compile failure on waterfall starting

http://build.chromium.org/p/chromium/builders/Android/builds/24321

Errors are pretty obscure. Things like

BUILD FAILED
/b/build/slave/Android/build/src/build/android/ant/apk-obfuscate.xml:161: /b/build/slave/Android/build/src/out/Release/multiple_proguards_test_apk/proguard.txt (No such file or directory)
	at proguard.ant.ConfigurationTask.addText(ConfigurationTask.java:315)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

FAILED: cd ../../build/android/tests/multiple_proguards; /*snip*/ build/android/ant/apk-obfuscate.xml
Traceback (most recent call last):
  File "../../../../build/android/gyp/ant.py", line 34, in main
    stdout = build_utils.CheckOutput(['ant'] + verbose_args)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 113, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)

Original issue's description:
> Remove apk-codegen.xml
> 
> process_resources.py already implements almost everything from 
> apk-codegen.xml so just use that instead.
> 
> BUG=359249,375324,375431
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272783

TBR=yfriedman@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=359249,375324,375431

Review URL: https://codereview.chromium.org/301543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272795 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272794 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/297363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272793 0039d316-1c4b-4281-b951-d872f2087c98

We already have a variable for tracking the system libdir name in the
gyp files, so let's use that instead of hardcoding the logic based on
the arch.

BUG=chromium:219015
TEST=`cbuildbot amd64-generic-tot-chrome-pfq-informational` works

Review URL: https://codereview.chromium.org/244593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272792 0039d316-1c4b-4281-b951-d872f2087c98

r=rch
BUG=377194
NOTRY=true

Review URL: https://codereview.chromium.org/299423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272791 0039d316-1c4b-4281-b951-d872f2087c98

Previously the host was not sending empty keep alive messages when
video stream is paused or when it's blocked on the encoder, this
triggers reconnect too often.
Refactored keep-alive logic in VideoScheduler so now it always
sends keep-alive messages when there is no other activity on the
stream.

BUG=376528,375568

Review URL: https://codereview.chromium.org/292373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272790 0039d316-1c4b-4281-b951-d872f2087c98

Previously the client was calling EnsureSSLServerSockets(), which
internally calls EnsureNSSSSLInit(). It's not necessary to initialize
server socket so that call was removed in r263951, and NSS is no longer
initialized, which sometimes breaks the client (see the bug). Also
removed the workaround.

BUG=364689

Review URL: https://codereview.chromium.org/297863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375568

Review URL: https://codereview.chromium.org/296703013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272788 0039d316-1c4b-4281-b951-d872f2087c98

It seems we can just pass |peer| directly to AddPendingRequest()
function and thus remove this variable, simplifying
IPCResourceLoaderBridge.

BUG=265753, 338338, 237249
TEST=content_shell + content_unittests
R=jam@chromium.org

Review URL: https://codereview.chromium.org/294043012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272787 0039d316-1c4b-4281-b951-d872f2087c98

App shims have been enabled by default for 3 milestones
(since r242711).

BUG=350161

Review URL: https://codereview.chromium.org/298953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272786 0039d316-1c4b-4281-b951-d872f2087c98