GitLab

Continuing along with the attempt to rebalance test suites, up to
the 75th percentile, telemetry_perf_unittests still has nearly 3x
to 4x more overhead than chrome_public_test_apk and
content_browsertests. It also runs a lot faster. Looking at the numbers
in https://bugs.chromium.org/p/chromium/issues/detail?id=1021686#c12
and fudging it a little, we can reduce 3 shards of
telemetry_perf_unittest to slow down runs by about 23% without
making it into the long pole. We might be able to pull it down further
but variance in data makes it hard to fully reason about this.

These extra 3 shards can translate to 6-12 more shards of
chrome_public_test_apk of content_browsertests depending which
percentile you look at.

Making a guess, this will let us pick up 5 more content_browsertest
shards (this has lower overhead) and 3 more chrome_public_test_apks
shards.

Bug: 1021686
Change-Id: I7acf9db5d9ee2b2b33b366da0702b1658444d4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922975
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716894}

Run clang-format on the JS files in:
chrome/browser/resources/bookmarks
chrome/test/data/webui/bookmarks

and remove extra indentation from HTML files in
chrome/browser/resources/bookmarks.

Bug: 1022213
Change-Id: I574e1c768247dbf5b437d5db9cf31bfe3f4cc738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922593
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716893}

Bug: 1009686
Change-Id: I63a4ff8b18ff7c7ec53586d10441b9e53cdb136c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925241
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716892}

The type-specific typed-array files like int16-array.h were unnecessary
and did not add functionality. I replaced them now with a templated
version of the original base class.

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: I04b2c392af8737162b4251249d7af6ff50eee7bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919354Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716891}

Previously, we only store phished saved password bit
in compomised_credentials only when it's reused on a
phishing site. However, when a saved password is reused
on a low reputation site, it should also be persisted.

Bug: 1026006
Change-Id: Ie4dd0431690a1e91521e493225375ae4221f167f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922948
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716890}

Switches the win10_intel_hd_630_experimental mixin back to triggering
tests on the stable driver version, as the experimental version has some
issues that will prevent us from promoting it to stable.

TBR=ynovikov@chromium.org

Bug: 1016459
Change-Id: I32ca010c0a90b893eb69b8c9a1f624b4f6de2827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925422Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716889}

During the GPU initialization, Some heavy jobs, like LoadLibrary, which are not
running on the GPU drivers might be very slow and cause the GPU watchdog to
terminate the GPU main thread. This CL adds two new functions PauseWatchdog()
and ContinueWatchdog() to allow the GPu watchdog to be paused and continued when
needed.

The implementation is added in GPU watchdog V2 only, no V1.

Bug:949839

Change-Id: Ia8a60fd08a5c07686499dbdc10a7abd19e47a507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861094
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716888}

This reverts commit 70df16a3.

Reason for revert: This is a culprit CL which fails
UnifiedMessageCenter ash_unittests 

Example:
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15343

Original change's description:
> Implement pop in and out animations for stacked notification icons
> 
> Bug: 1025050
> Change-Id: I5073cb6f54036b86f1bf455e89f29d529ad25a4e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918038
> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716782}

TBR=xiyuan@chromium.org,tengs@chromium.org,amehfooz@chromium.org

Change-Id: I366f50b2c2e1e1468178bd137fb5d5d8d7b559ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1025050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925842Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716887}

This reverts commit 3e5e2582.

Reason for reland: Added proguard_enabled = true to test apk

Original change's description:
> Revert "Remoting: Enable Proguard tree-shaking to reduce method count"
>
> This reverts commit f31ef558.
>
> Reason for revert: compile failure on android-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/6720
>
> Original change's description:
> > Remoting: Enable Proguard tree-shaking to reduce method count
> >
> > Bots are failing because remoting_apk is over the single dex method
> > limit.
> >
> > TESTED=Launched app and made sure it didn't crash.
> >
> > NOTRY=true  # Previous patchset passed. Urgent to fix build.
> >
> > Bug: 1026161
> > Change-Id: I2156f84d55ff214eab5cf0d77811baaa3b5f77e8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925215
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#716776}
>
> TBR=lambroslambrou@chromium.org,agrieve@chromium.org,estevenson@chromium.org
>
> Change-Id: I67d7c775be0d06f04bcf69f9331bceb364642fcc
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026161
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925513
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716798}

TBR=lambroslambrou@chromium.org,agrieve@chromium.org,estevenson@chromium.org,steimel@chromium.org

Change-Id: I9e9e301a86c9a75d615df713884777b80bdbba8a
Bug: 1026161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925786Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716886}

This CL adds back the resource load priority preload audio and video
tests so they are not forgotten, but disables them which was the
intention of crrev.com/c/1440522. Also adds a note indicating pointing
to the spec complexity around why they are disabled.

R=yoavweiss@chromium.org

Bug: 735014,977033
Change-Id: I2707a1bd39102e894b803f10f3305b8b8efea796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902481
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716885}

These checks are using an obsolete a11y testing framework, based on
axs_testing.js.

Also in some of these cases these checks were already disabled, but the
suppression were still present in the code.

Bug: 807458
Change-Id: I9c5eb05b692df65b546f9ad0d4486deb4868995b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924698Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716884}

It's unlikely that we are going to move to this tech so I'd like
to remove this to streamline the codebase and prevent extraneous
work during maintenance and migrations.

BUG=954566

Change-Id: Icf0ac6e7d7bef36d6f40514ba8d02940de3a1546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924975Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716883}

It's possible to try to find the Object Replacement Character (ORC), so
we should not use that as a delimiter of invalid elements as we might
wrongfully think that the delimiters are an actual match, causing
crashes.

Additionally in some cases layout might fail causing the FindBuffer to
have null NGOffsetMapping, causing crashes. In this case we should skip
the entire block as we can't get the ranges correctly.

Bug: 1020105, 1002753, 1024256
Change-Id: I4c4cc886a84a919a617789db6d3bb0351a5d7477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924031Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716882}

This reverts commit eb4de739.

Reason for revert: breaks ios.cronet builder https://ci.chromium.org/p/chrome/builders/ci/cronet-ios

Original change's description:
> [promises] Make sure alignas value is compatible with heap allocations
>
> Allocators must return memory that is aligned at least as strictly as std::max_align_t. So make
> sure we do not ask for more, otherwise we risk getting misaligned memory in heap allocations.
>
> For more context, see discussion in https://crrev.com/c/1648176/18/base/task/promise/dependent_list.h#61
>
> Change-Id: I91d69844e9a83899f3a9453f0e060a9779b40028
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810960
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Carlos Caballero <carlscab@google.com>
> Cr-Commit-Position: refs/heads/master@{#714395}

TBR=gab@chromium.org,thakis@chromium.org,alexclarke@chromium.org,carlscab@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Idbdb94a682ceb855a53b6108005d8fed57595ce3
Bug: 1026037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925776Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716881}

Previously the post delayed task will cause crashes on Linux and Mac. Every time we post a delayed task, then we refresh/close the tap, it will crash when the delayed task executed. It might because the WaitableEvent can only be used within single address space for Non-Windows systems[1]. And when we refresh/close the tap, the credit_card_access_manager is reset when DidNavigateMainFrame [2].

In order to fix it, we replace the callback with CreditCardAccessManager::SignalCanFetchUnmaskDetails function together with weak_ptr of credit_card_access_manager. With the weak pointer, the BindOnce callback won't be executed when credit_card_access_manager is reset.

[1] https://cs.chromium.org/chromium/src/base/synchronization/waitable_event.h?l=39-41&rcl=0b35f9e032c5ac21ef25df8d5cf113529ce2f4c3
[2] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?l=1450-1451&rcl=fd806bd17d805398213f349649276356c5616c6e

Bug: 949269
Change-Id: I8e7acdb411e4421b55a685ff470b82fd954149d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922913
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716880}

Changes the following builder def functions to set Goma RBE backend by
default:
- in ci.star:
  - fyi_mac_builder()
  - gpu_fyi_mac_builder()
  - mac_builder()
- in try.star:
  - blink_mac_builder()
  - gpu_mac_builder()
  - mac_builder()

The changes to cr-buildbucket.cfg are all for setting Goma RBE as the
default for testers, which is a no-op.

Bug: 1025325
Change-Id: Ica7fc988f387c97a9eaada694dd5bb066e6ebbac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924333Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716879}

This is a follow up CL for
https://chromium.googlesource.com/chromium/src/+/0cf9a1a417bfc0d0a4ccec4ee30e9cc5f4375863

Bug: 1022263
Change-Id: I938f2cc0c10c6dfb3f3d4269f9ce6cbd6656a328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925828
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716878}

Bug: 939235
Change-Id: I72f4c1cafa13b9888556789aef644e9026019ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923981Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716877}

This CL updates the screen.orientation.angle web API to output relative to the
device panel. screen.orientation.angle is used by web apps using a desynchronised
WebGL canvas to achieve low latency performance via hardware overlays. This
requires alignment with the device output panel.

Fixed: 998131
Test: PanelRotationBrowserTest.ScreenOrientationAPI
Change-Id: I05efbfb8aecd5015b18f0e4f434ab67df6ca50b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911344
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716876}

This is a followup to [1] to use the terminology "subpage button"
rather than the pre-[1] behavior of a mix of "button" and "link" to
describe subpage routing buttons. This handles cases with
'cr-icon-button's with the CSS class 'subpage-arrow' that are not
contained in a cr-link-row (that case was handled in [1]).

Note that this does not apply the "subpage button" role description to
cases in browser settings with a cr-icon-button with the CSS class
'subpage-arrow' that do not actually route to subpages.

Also note that both this CL and [1] passed over some cases in which
the logic determining whether a button's effect is a subpage route is
conditional. It would be good to return to these cases in a followup,
but they are relatively few.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1881816


Bug: 1012104
Change-Id: I17d8a0ea9a20c44e060932b300cc3681d17b15c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925435Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716875}

Previously, each run of nfc_test() creates a new nfc mock object in the
start and destroyes it in the end.

Considering a test file containing multiple nfc_test() runs, in Blink we
have just one NFCProxy instance per page context to talk to these mocks,
that means our NFCProxy gets a broken NFC Mojo connection each time the
previous nfc_test() runs to the end then has to reconnect to another new
nfc mock for the coming nfc_test().

This is unnecessary and does not align with the product code logic that
always keeps one NFC Mojo connection alive per page context, unless
something unexpected happens in Device Service.

Also, this makes it easier for a nfc_test() to interfere with the next
one, e.g. a nfc_test() ends and closes the NFC Mojo connection, the
disconnection message will arrive at our NFCProxy asynchronously and we
can not have any assumptions on the arrival time, assuming it's still on
the way and the next nfc_test() has already started, at that point our
NFCProxy has no idea that the current Mojo connection was already closed
but continues to talk to it.

This CL makes one nfc mock object be reused throughout one test file to
address the above concerns.

BUG=1019663

Change-Id: I7e2ae9816936081e1f59688652e34b35a5295af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913588
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716874}

Create cc::Layer for composited ScrollHitTestDisplayItems only.

Non-composited ScrollHitTestDisplayItems will contribute non-fast scrolling
regions in the containing layer.

Bug: 738613, 931486
Change-Id: I9ea21b7a697c13b8c80355d82de78fe184d8e2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920914
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716873}

Bug: 1012578, b/144121590
Change-Id: I8857cbd29cac21d986dca05282ade1493c1048d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924337
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716872}

There are a few reasons why this is desirable:
(1) Reduces need for complete event stack in ThreadLocalEventSinks,
    which was brittle before (e.g. crbug.com/983307).
(2) Makes it possible to flush event sinks while tracing in the future
    without losing not-yet-completed COMPLETE events from the stack
    (streamed tracing use case). Events that didn't end before the
    flush will still be present in the trace as BEGIN only.
(3) Prevents reordering of nested COMPLETE events - something which
    could confuse TraceProcessor in the past (events with identical
    begin timestamps would be imported incorrectly).

To achieve this, this patch also plumbs the EXPLICIT_TIMESTAMP flag
and thread id through to TraceLog::UpdateTraceEventDurationExplicit,
because it seems that android can add COMPLETE events with explicit
timestamps / threads [1].

[1] https://cs.chromium.org/chromium/src/base/android/early_trace_event_binding.cc?q=INTERNAL_TRACE_EVENT_ADD_WITH_ID_TID_AND_TIMESTAMPS&ss=chromium&l=31

Bug: 983307, 928738, 1006770
Change-Id: I66e685c04c068646d550f182185d3c45febcbfa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899852
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716871}

On Fuchsia official builds, unwind tables are disabled. This causes
base::debug::StackTrace to not have a proper stack trace. This CL
clarifies that this is the expected behavior for Fuchsia official
builds.

Bug: 1025329
Change-Id: I1ad87efb7bf6fefb18444eea121d1ec181ae3fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925767
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716870}

This simplifies the interface for the Previews Decider and UI service

Change-Id: Id50c986ba9e5fe00f6d8547101b1a7d162fc9584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925434Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716869}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0d10afabcf7a..d364d7600c32

git log 0d10afabcf7a..d364d7600c32 --date=short --no-merges --format='%ad %ae %s'
2019-11-19 rharrison@google.com Migrate away from nosetest to unittest (#896)

Created with:
  gclient setdep -r src/third_party/shaderc/src@d364d7600c32

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I7e226b7ac37e35d2480ba676ff65e9fb028cbc45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925367Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716868}

pdf_extension_test.cc is using the hash to help shard tests, so use
base::PersistentHash() for stability of results across different shards.

Note: it's unclear why it's doing this instead of depending on the
normal test sharding logic...

Bug: 1025358
Change-Id: Ie03c8d8e73ac5923208de869d06782694e428a5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924794
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716867}

Changes the following builder def functions to set Goma RBE backend by
default:
- in ci.star:
  - android_builder()
  - android_fyi_builder()
- in try.star:
  - android_builder()

The changes to cr-buildbucket.cfg are all setting Goma RBE as the
default for testers, which is a no-op.

Bug: 1025325
Change-Id: Ib016c30ca04adf7aa119f6afd8e881a33b4611ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924332
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716866}

This reverts commit 24083475.

Reason for revert: <INSERT REASONING HERE>
This is a heavy handed workaround for issues in Blink. Root cause was fixed in Blink.
https://chromium-review.googlesource.com/c/chromium/src/+/1872422

Original change's description:
> Use tree path recovery in ChromeVox
>
> With the on-going changes in the Blink tree, ChromeVox can once again not rely on nodes persisting their ids.
>
> Blink may choose to destroy and re-create an entire subtree of nodes in reaction to a page making some kind of update. The actual DOM does not change, but Blink re-creates the accessibility subtree (resulting in new nodes, with new ids).
>
> Note that ChromeVox has flip flopped on using tree path recovery in the past.
> Related bugs:
> 885244
> 945708
> (each of these were verified to work after this change).
>
> Related changes:
> https://chromium-review.googlesource.com/c/chromium/src/+/1889165
> https://chromium-review.googlesource.com/c/chromium/src/+/1539262
>
> Change-Id: I1c0bb78ce448c601d116aa90e408c36cab21b3d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872557
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#708044}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: If87d5b96c4f658bce34098466c4a240ac38490dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922915Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716865}

This CL:
- Moves create() methods from WebappIntentDataProvider.java and
WebApkIntentDataProvider.java to WebappIntentDataProviderFactory.java
and WebApkIntentDataProviderFactory.java respectively
- Makes WebappIntentDataProviderFactory and
WebApkIntentDataProviderFactory both create a
WebappIntentDataProvider object. This is helpful as I am planning to
make WebappIntentDataProvider override more of
BrowserServicesIntentDataProvider's methods:
- Moves public methods for getting information from
Homescreen-Shortcut/WebAPK launch intents to WebappIntentUtils
- Unifies WebappInfo#createEmpty() and WebApkInfo#createEmpty() logic

BUG=1015835

Change-Id: Ie9f47241f387e92b9bd8a5ff061658bf6d471112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921732
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716864}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I76ddf226c9848b6f0121b8dd1f54a84dad85de38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925595Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716863}

- Change public service API getImpressionDetail to
getClientOverview.

- New API returns a struct ClientOverview including info about
notifications in the scheduler also ImpressionDetails.

- The glue layer wrapped result queried from ImpressionTracker
and result queried from ScheduledNotificationManager to
ClientOverview struct.

Bug: 1025387
Change-Id: Iab6bad5be5e914730645975af86293c2b6395810
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918651Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716862}

This CL changes NetworkService, so that when a DumpWithoutCrashing
(DwoC) is called during a call to CreateLoaderAndStart, then the crash
report will include crash keys that capture the request url and the
request initiator.

This CL helps prepares for starting to enforce
request_initiator_site_lock in a follow-up CL (enforcing = treating as a
bad message and calling DwoC if the lock doesn't match the actual
request initiator).  The enforcement might need to be reverted (there is
still a very low volume of uninvestigated cases where the request
initiator doesn't match the lock).  The url and request initiator crash
keys are desirable for the long term, so landing them in this, separate
CL prevents unnecessary churn when working/landing/reverting/relanding
the lock enforcement.

Bug: 920634
Change-Id: I3900bf6a8f4a07d04166102dd78bfac53c3d0d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922698Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716861}

CI:
- linux-chromeos-code-coverage
- linux-chromeos-dbg
- linux-chromeos-rel

Try:
- linux-chromeos-dbg
- linux-chromeos-rel
- linux-chromeos-compile-dbg

Schedule of migration:
https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0

Bug: 950413
Change-Id: I427fcfee66b192ac7cc107d47d2547c5f2ecde9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923225Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716860}

H264 main profile can be read from json file in VDA test. This adds baseline
and high profile so that they can also be read from json file.

Bug: 1022246
Test: video_decode_accelerator_tests on kevin
Change-Id: I73fc85dc1c99e8e3a4214de9c29871f4e7a695d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923982
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716859}

Bug: None
Test: Used in new eureka-internal unittests.
Change-Id: I6e27df4fc9ef5bbdd961d38610049827f63ddacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922691Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Matt Swartwout <mwswartwout@google.com>
Cr-Commit-Position: refs/heads/master@{#716858}

This allows the system to control certain properties of all Contexts.

Initially the following arguments are allow-listed:

  renderer-process-limit - Allows the system to configure Contexts for
  lower memory usage with an advisory limit on the number of renderer
  processes.  This may still be exceeded to maintain site-isolation.

  min-height-for-gpu-raster-tile - Allows the system to tailor the
  dimensions of tiles to better suit the physical display.

Bug: 1025455
Change-Id: I019a2717283ef23e93c7db7396b534d931713835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922469
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716857}

When we emit a trace event, we check whether the current sink is for the
current session. But we weren't handling startup tracing sessions
correctly in all cases: If startup tracing was enabled in between two
sessions (like background tracing may do), a sink created while startup
tracing would have the old session id and thus could be flushed away
later.

Instead, we now increment the session ID when setting up startup tracing
and track whether startup tracing is currently active to avoid
incrementing the ID again when the service tells us to start tracing.

This also prepares for the removal of the thread_will_flush hint in
crrev.com/c/1829343.

Bug: 1007611
Change-Id: I569b359525f7d60679d6a60d6461c8d7d8150a3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925048Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716856}

When promoting DrawQuads to overlays with SkiaRenderer there isn't
always a SyncToken corresponding to the Mailbox. Remove the DCHECK
instead.

Also enable failing skia_renderer_pixel_skia_gold_tests again.

Bug: 1003040
Change-Id: I14a289d9d4856013e56a2f7da63b7845636c12a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924659Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716855}