- 08 Jan, 2020 40 commits
-
-
Sergey Ulanov authored
AudioRenderer interface allows StartTicking() to be called after Flush(). FuchsiaAudioRenderer wasn't handling this case correctly: it was calling AudioConsumer::Start() without Stop(). Fixed StartTicking() implementation to call Stop() when necessary. Also reversed order of arguments in Start(). Bug: 1027048 Change-Id: Id30a552b2bdebce51b9deec074605c06f4e852f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982798 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#729460}
-
gogerald authored
Bug: 1039970 Change-Id: Ib641bbac8af6a6fdce4f85a3955f060fb752d487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992261 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729459}
-
Synthia Islam authored
If user attempts to change date value when max value below min, correct validation message will be shown. Bug: 979227 Change-Id: I0bb1d092ec3dcfb993c9622ff3e9986b6b0c35b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916527Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#729458}
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Idb3389fcad53c9f7f936a054abe425ffd783b229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988917Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729457}
-
haozhe authored
Chrome and firefox passes all Bug: 1034538 Change-Id: I5c269ae99ab6a34cc70c238d1b6fb9f9eafb3eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974696Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#729456}
-
Tarun Bansal authored
Add field trial experiment to disregard |always_access_network| when computing the total prediction score. Change-Id: Ibc727a50499795953d6f49e43369a9c81b1c760e Bug: 1039025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984624Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#729455}
-
Vladimir Levin authored
This patch adds a perftest that verifies that child layout is skipped in a fieldset container. Verified run is ~700ms per iteration without render subtree and ~16ms with render subtree. R=chrishtr@chromium.org Bug: 966487 Change-Id: I0f5bf855f5933f182a3052682cbac3f870630ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991780Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729454}
-
haozhe authored
Chrome passes all and firefox failed the translate-composition due to expect 'None' and got '0px' Bug Filed:https://bugzilla.mozilla.org/show_bug.cgi?id=1607313 Bug: 1034538 Change-Id: I1700cae51d539ea0d76ebe73efbaa6e038d6f5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982776Reviewed-by:
-
dalyk authored
This change adds a new field, disable_secure_dns to the URLLoaderFactoryParams, which gets propagated to every URLRequest. Follow-up cls may add this param to worker URLLoaderFactories. Bug: 10161646 Change-Id: I81686054b38a7ef993c20eba274c8f8474317ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888099Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#729452}
-
Tibor Goldschwendt authored
Bug: 1032327 Change-Id: I4c8ac4b77c8c7676193ce4e50ded6d349f00ba20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986282 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#729451}
-
Ryan Daum authored
Transition from WebviewAsyncService to PlatformViewsAsyncService lost reference to CastWindowManager, so lost rounded corners on webviews. Bug: b/141369549 Test: manual Change-Id: I4e58af33086270313ac168c50e533f906783d2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992164Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#729450}
-
John Lee authored
Change-Id: I9fcd6709408c3d975032e651a330a47eeeed1d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989857 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#729449}
-
haozhe authored
Chrome and Firefox pass all Bug: 1034538 Change-Id: I8f7de63e8c10ae3c6730bcd577de82cfce39a0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985120Reviewed-by:
-
Michael Spang authored
Changli Gao (1): Don't call close(2) more than once Fabrice Fontaine (2): src/symbolize.cc: fix build without dlfcn.h src/symbolize.cc: do not check for HAVE_DLFCN_H for macOS Michael Spang (1): Use file offsets in traces if object has no symbols (#513) Bug: 1040148 Change-Id: I1a7e4b543200ed32f18fe049c932160a00c4e66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991726Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729447}
-
haozhe authored
Both chrome and firefox passed Bug: 1034538 Change-Id: Ieb8ccf890f14a77c098378785f34580f16a8e1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988677Reviewed-by:
-
Joshua Berenhaus authored
When the Metrics State Manager is constructed on first launch with consent, the backup runs before the install date is created. In this scenario, install date will not get backed up again unless consent is changed. Instead, we can run the backup after we create the install date for the first time. Change-Id: Idc68d03c632790e59a5a64b20d5ffe4680cc0700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990570 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Cr-Commit-Position: refs/heads/master@{#729445}
-
gogerald authored
Bug: 959494 Change-Id: Icc807dda07d5e10d0798d951c3ed34a5d6b7c256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989986Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#729444}
-
Ben Pastene authored
Apparently the test never uses a device. So let's move it to a device-less pool. Bug: None Change-Id: I96bca98916c769ea02859b44dc822582a6408539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606221 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729443}
-
Dominique Fauteux-Chapleau authored
Add a DCHECK to ensure the file types are sorted. Update the UploadFileForDeepScanning DCHECK to handle the case where no DLP is being done. Change-Id: If2f43e1b4ff4d47ed194332a60636b2ce4ce3021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988213Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#729442}
-
haozhe authored
Chrome and FF pass all Bug: 1034538 Change-Id: I2edcd09a13f21808ab987efef5bb5aa0158d8347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986034Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/96f79f6db56b..9b2712456fe6 git log 96f79f6db56b..9b2712456fe6 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 enga@chromium.org Revert "Use Swiftshader by default when fuzzing" 2020-01-08 enga@chromium.org Metal: Add CommandRecordingContext 2020-01-07 brandon1.jones@intel.com Temporarily Disable Use of D3D12 Render Pass API 2020-01-06 yunchao.he@intel.com Fix a comment in BindGroupValidationTests.cpp 2020-01-06 enga@chromium.org fuzzing: Create Instance and discover Adapters only once 2020-01-06 enga@chromium.org Reland "fuzzing: Add supportsErrorInjection option to DawnWireServerFuzzer" 2020-01-06 enga@chromium.org Use Swiftshader by default when fuzzing Created with: gclient setdep -r src/third_party/dawn@9b2712456fe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1038952 Tbr: cwallez@google.com Change-Id: I2a107b8f0451d2196d775ce6431d69a8056ebb9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729440}
-
John Budorick authored
Bug: 922145 Change-Id: I7b461caec3e5c78079e9bd4ed43246b822fe83b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988588Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#729439}
-
haozhe authored
Both Chrome and Firefox pass the test Bug: 1034538 Change-Id: I3e43cf22a1ed9ce8d4d10aca5250dcbf243ebb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985813Reviewed-by:
-
Jesse Schettler authored
Crash reports show a crash occurring in PrintRenderFrameHelper when OnPrintPreviewDialogClosed() is called. Add CHECKs to determine the cause of the crash. Bug: 1019847 Change-Id: I0110438b3b1db93bebdd0122a32ea34b064875d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979011 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#729437}
-
Bruce Dawson authored
In order to investigate page-loading performance it is helpful to get the First Contentful Paint message. This is emitted in the loading category of chrome://tracing events. This change adds loading to the list. A separate change modified UIforETW to add this and the recently added media flag so that these categories can be conveniently requested, and this change was used to test the loading flag. Bug: 927165 Change-Id: I0c0a41d3fae1a8aa33ee0771c013821dd888684a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990421Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#729436}
-
Chris Lu authored
Adds WebState as a parameter to InfobarBadgeTabHelperDelegate's addInfobarBadge:. Then BadgeMediator returns early if the WebState passed is not the same as the WebStateList's active WebState. This prevent a situation where an inactive WebState gets a new Infobar and the BadgeViewController then adds its badge to the UI even though there is no such Infobar for the currently active WebState. Fixed: 1039668 Change-Id: I1eaf5aae4385d372d025dddce72a362e521fece0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989993 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#729435}
-
Balazs Engedy authored
Extend the lifetime of the histogram until M90, and update owners. Bug: 1036997 Change-Id: I9a52049a5403422c7737ee44304954ec3e565d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985959Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/28c4ea91f668..9506caf2ea1f git log 28c4ea91f668..9506caf2ea1f --date=short --first-parent --format='%ad %ae %s' 2020-01-08 sullivan@chromium.org Fixed speed index computation in case of zero visible area. 2020-01-08 khokhlov@google.com Revert "telemetry: Increase timeout for trace collection." Created with: gclient setdep -r src/third_party/catapult@9506caf2ea1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027667,chromium:1039734 Tbr: oysteine@google.com Change-Id: I4aad96525abcf98ab436ac740de182fcef3e0259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992001Reviewed-by:
-
Yi Gu authored
Now that viz hit testing has been launched, some of the related metrics should be deleted. Note that the following metrics could help with future improvement by making more hit tests synchronous therefore they are not deleted. - Event.VizHitTest.AsyncHitTestReasons - Event.AsyncTargeting.AsyncClientDepth - Event.AsyncTargeting.ResponseTime Bug: 1037067, 1037081 Change-Id: I2f416e629804ca150c515513cd23fcd31de3cfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988413Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729432}
-
sebsg authored
This reverts commit ea98315a. Reason for revert: Did not fix the test failures Original change's description: > Revert "Add media_devices.typemap Blink variant" > > This reverts commit 086dd4c4. > > Reason for revert: Suspecting it to cause the consistent crash of several media_unittests on Linux CFI. See crbug.com/1040107 for more info. > > Original change's description: > > Add media_devices.typemap Blink variant > > > > Now the conversion between > > blink.mojom.FacingMode <-> media::VideoFacingMode is allowed. > > > > BUG=704136 > > R=dcheng@chromium.org, haraken@chromium.org > > > > Change-Id: Ida3e7a47ea915f0747b64c004ad044c67b078035 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989927 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#729202} > > TBR=dcheng@chromium.org,haraken@chromium.org,tonikitoo@igalia.com > > Change-Id: I5dcd9fd57b29f88c8f0ffb114f0cd3135e562220 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 704136 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990312 > Reviewed-by: sebsg <sebsg@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729340} TBR=dcheng@chromium.org,haraken@chromium.org,sebsg@chromium.org,tonikitoo@igalia.com Change-Id: I185e76b268183a68e7607e4ec072d030ce741aaa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 704136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992262Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729431}
-
gogerald authored
When start surface is enabled, click back button may close the last tab and show start surface Bug: 1035338 Change-Id: I8c00458696f215047af28091ec9d099c3236b939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974811Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#729430}
-
Peng Huang authored
Set enable_swiftshader_vulkan = false can save build time on Linux. Bug: 1001433 Change-Id: I55a60e6f3f2f47fc339a794aa27c221ab7309a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991088 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729429}
-
Dominic Mazzoni authored
When the --export-tagged-pdf flag is enabled and when exporting a PDF using Chrome Headless, generate a tagged (accessible) PDF instead of an untagged one. The details are described in the design doc: https://docs.google.com/document/d/1ku6QNtAHEqVnRGqFzpmlMe1fowkjCX9miHj8Kx1cFlk In a nutshell, PrintRenderFrameHelper captures a snapshot of the accessibility tree for the page and returns it in the metafile. This snapshot includes blink DOMNodeIds. In addition, we ensure that all text drawing commands captured for printing also include DOMNodeIds (this was originally added to support content capture). Finally, printing::MakePdfDocument is modified to convert the accessibility tree into a structure tree and pass this through to Skia. A follow-up change adds an end-to-end test of generating a tagged PDF using Chrome Headless: http://crrev.com/c/1970744 Bug: 607777 Change-Id: Ib2bfa2de94f622c766c4b4c73c013437e404bbde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970742 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#729428}
-
John Budorick authored
Encountered this while working on emulator test failures. The current logic parses parameterized test failures as UNKNOWN because of the GetParam() portion of the log line. This CL updates and documents the regex responsible for parsing those lines. Change-Id: Ia4339a6c03cd928bdd46f1103f0d6964f12935d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990474Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#729427}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/622690c9..07c5cd8f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee3473867300fe856d15fbe36883f1bb413ec03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991406Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729426}
-
sebsg authored
Bug: 1040153 Tbr: ryansturm@chromium.org Change-Id: Ib35e85fd6583ad4894956902b036c6a71dd025ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991922Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa424b2e6a34..403c80797189 git log fa424b2e6a34..403c80797189 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 reed@google.com Revert "Revert "Extend SkCanvas matrix stack to be 4x4, but with (basically) the same public API."" 2020-01-08 michaelludwig@google.com Revert "Avoid loop-dependent behavior in GrMemoryPoolBench" 2020-01-08 michaelludwig@google.com Avoid loop-dependent behavior in GrMemoryPoolBench Created with: gclient setdep -r src/third_party/skia@403c80797189 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I217b1e36b2e7e69025ad3ff090f4287289313cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991720Reviewed-by:
-
Pavel Yatsuk authored
BUG=1028382 R=twellington@chromium.org Change-Id: I13654e36ffa86507872507258e53a5345a1358de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990489Reviewed-by:
-
Vincent Scheib authored
This is part of a code cleanup effort to make callbacks explicitly Once or Repeating. dbus::PropertySet objects will call PropertyChangedCallback objects repeatedly when properties are upaded. The PropertyChangedCallback type is already a base::RepeatingCallback. base::BindRepeating is appropriate for any clients. Also, several unecessary static_casts were removed. Bug: 1007780 Change-Id: Id1f145a3cfff2dcb7ec8f80b5ae0fffae0e081ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984708 Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#729422}
-
Bence Béky authored
Reorder methods so that order in .h and .cc files matches. Remove unused private method MaybePrependErrorCode. Remove bogus comment from MakeResponseHeadersPacket() definition. Change-Id: Ie28bae97ee9d3a3c0c14cf613641b9cf7fedaf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987499 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#729421}
-
