- 15 Jul, 2020 40 commits
-
-
Colin Blundell authored
Missing README files for directories of which I'm an OWNER. Change-Id: I48a3bd92f0c156901edfca48c341d0634bc415fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297521Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#788520}
-
Peter E Conn authored
For modularization, we don't want ExternalAuthUtils to rely on AppHooks. Since AppHooks is required for the creation of an ExternalAuthUtils, we have AppHooks hold the singleton instance instead of having ExternalAuthUtils do it itself. Change-Id: I5845333ddf92a6f2fdeb61f7d12b2b632e849f16 Bug: 1104817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296088Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#788519}
-
Yutaka Hirano authored
This is aligned with the spec. Bug: 1097227 Change-Id: Id5b5170cd90cfe6f0818e0b3a80dc2b0db66f27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298887Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#788518}
-
Noel Gordon authored
File-ng requires an 8px vertical gap between any action-icon and their drop down menu. Action icon have a 48px x 48px tap target and the drop down menu should not overlap that tap target, hence the 8px gap. Bug: 1066727 Change-Id: Ic91d2fda156abb359e5110c32488b9b1cec41406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298847Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788517}
-
Yoshifumi Inoue authored
This patch changes |NGLineBreaker::Rewind()| to skip empty text item to adjust |item_index_| for making next line break to work correctly. Before this patch, we hit |DCHECK_EQ()| in |NGLineBreaker::RewindOverflow()| after |Rewind()| when line breaking occured at a space item followed by empty text, e.g. "abc..."(long text) ""(empty text) " "(a space for line break). Example: <div><i>0123456789<b> </b>ab</i></div> [0] kOpeNTag 0-0 <i> [1] kText 0-10 "012345679" [2] kOpenTag 10-10 <b> [3] kText 10-10 "" [4] kText 10-11 " " <== line break [5] kCloseTag 11-11 <b> [6] kText 11-13 "ab" [7] kCloseTag 13-13 <i> Bug: 1104582 Change-Id: Ibcc145a97d9f1b94159035a9eb6b65a50f2b8bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298960 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#788516}
-
Lan Wei authored
This reverts commit 01da6796. Reason for revert: Test fails on Mac10.14: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/6447 Original change's description: > Reland "Avoid testRunner.eventSender in > overflow-scroll-in-overflow-scroll-scrolled.html" > > Avoid testRunner.eventSender in > paint/invalidation/scroll/overflow-scroll-in-overflow-scroll-scrolled.html > > TBR=wangxianzhu@chromium.org > > Bug: 1047176 > Change-Id: If4522d945a8e5d2d269bd7e8eedf8b070a81cc6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298277 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788491} TBR=wangxianzhu@chromium.org,lanwei@chromium.org Change-Id: I2f2bafa448c7eb653c2e4b11c22d8157f5dd88f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299140Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#788515}
-
Keishi Hattori authored
Change global variables referencing LayoutObjects to Persistents in anticipation of oilpanization of LayoutObjects. Because global variables need to be added to the GC root set. Bug: 1030176 Change-Id: Ie0ab6e52052f0819172aa0ff6ff9926f167566a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297038Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788514}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9421094d01b1..6e7083de3589 2020-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cd0af6456eb1 to 1de497cc50ab (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I5ed0586fea7024ef28a9ddc2b67ea1883f51ad42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788513}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I63d349b6d0accaf80f4cf600e46d749bc3bdec63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299019Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788512}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7b1e2d2f6d2726cee57a4b0f55f0417942a0250b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299059Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds util::ranges implementations of the algorithms found in [alg.replace], [alg.fill] and [alg.generate]. Bug: 1071094 Change-Id: I00780a4550febd4bc1b709ac650f260aa04204b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284501Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#788510}
-
Alan Cutter authored
This CL moves the logic where we make a web app's theme_color opaque to UpdateWebAppInfoFromManifest() instead of at installation (BMO) or at read (bookmark apps). This is important for manifest update checks that needs to compare the transformed installed web app manifest data with the current page's manifest data under the same transformations. Bug: 1103590 Change-Id: Ib243227999ea13c1f00e146b20bb55c39482978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288719Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788509}
-
Dominic Farolino authored
This CL fixes a renderer crash caused by blink::RemoteFrame::Navigate not calling LazyLoadFrameObserver::CancelPendingLazyLoad(), thus disconnecting the underlying intersection observer. The problem was that when the intersection observer does not get disconnected and detached from the iframe element, then LazyLoadFrameObserver::LoadImmediately gets called N times for a given element, however after the first time it gets called, its |lazy_load_request_info_| gets moved, and therefore is in an invalid state, so future invocations of LoadImmediately try and reuse this invalid state. The problem could have been caught if the DCHECKs in this method were CHECKs, so this CL turns them into CHECKs until we confirm that there are no more issues. If there are, the CHECKs will make them much easier to track down. R=kinuko@chromium.org, sclittle@chromium.org Bug: 1104664 Change-Id: I0adc8e26375406f0016031dd2d2d89ad043dd6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298331Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#788508}
-
Vikas Soni authored
Set GrContextOptions::fPreferExternalImagesOverES3 to true which causes Skia to use ES2 instead of ES3 if GL_OES_EGL_image_external_essl3 is not available and GL_OES_EGL_image_external is available. Bug: 1031383,1104891 Change-Id: I87c2e35e4f1ae95a4882a275d3aceb416c47bd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296875Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#788507}
-
Dale Curtis authored
This is blocking our ability to handle HDR images since the function always forced HDR color spaces to P3. This change removes this method and updates a few call sites to expect that. Most callers are unchanged since they properly handle the HDR color space. R=ccameron Bug: 960620, 1076568 Change-Id: If507cae148a1e510b3569907773f6d84c5ed2d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298580 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#788506}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35dec5f127c3..9d9199a509bf 2020-07-15 chanli@chromium.org [led] Roll to latest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099018 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ic1747423c2e82c118349278d065ac5e1beeeb4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298812Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb20ab83..a721ddba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ae80d5f8ae8a07aae99894f1c77d2953ba18057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298740Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788504}
-
Matt Falkenhagen authored
Bug: 1092329 Change-Id: I7e5697631a0eedd12202533f59c48b15aba674be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298843Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788503}
-
Brett Kilty authored
Update the IS_ANDROID_THINGS check to use the superset IS_ANDROID_APPLIANCE, covering cases using other Android platform builds. Bug: b/156263192(internal) Test: local build (device) Change-Id: Ia750c8d31a98881e7efaa6e69b10f2f7a6ba0ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298342Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#788502}
-
David Vallet authored
BUG=1068382 Change-Id: I1e717499d26e0d8984d731bdd74b59700285b861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291134 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#788501}
-
Jit Yao Yap authored
Sync server-side changes from cl/320034367. Change-Id: I16909359e462681ec2a3b1b7a7be8ef2730c60b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294659Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#788500}
-
Hajime Hoshi authored
TBR=agl@chromium.org Bug: 997732 Bug: 1105733 Change-Id: Iab83322d35a5e24f3ea1ee5bbdb25daae33ecc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298961Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788499}
-
Zhongyi Shi authored
connectivity related errors. Early data indicating that most connections has been closed by the time a network change happens, which is the main motivation for me to track the count for closed connections caused by connectivity related errors. Some connection may get closed early due to connectivity related issues: 1. public reset by the peer post handshake is typically caused by NAT rebinding. 2. QUIC_PACKET_WRITE_ERROR by self is typically early signal indicating network no longer being usable. 3. QUIC_TOO_MANY_RTOS by self is typically caused by silent blackholing. This change also moves metrics logging to QuicConnectivityMonitor. Bug: 1090532 Change-Id: Ic0d05fc788aeb35b49ae853b0b8b652673c16ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293261Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788498}
-
Mei Liang authored
TabSuggestionMessageCardTest#groupTabSuggestionReviewedAndDismissed is flaky when running on an emulator. This CL is to disable this test on the emulator testers. TBR=wychen@chromium.org Bug: 1102423 Change-Id: I8196a21a028d40cce846d47ee7cd4d8bf6fda0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296292Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7cdf3fb532c2..24010e318dc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: hajimehoshi@google.com Change-Id: Ie0d76a0beca7f5f1a77f4b9ab1aa90d330c660d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298804Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788496}
-
Takashi Sakamoto authored
Bug: 1092288 Change-Id: I194809d2690e969ace4ed2fa9db34f5bb20f40cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270287 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Convert reference members to LayoutObjects to pointers in anticipation of oilpanization of LayoutObjects. Because reference members cannot be used to reference on-heap objects. Bug: 1030176 Change-Id: I78f404a38bca26b2f24c4a1abf5faabafe55fcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277906Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/100707a33723..1de497cc50ab 2020-07-14 natsu@google.com Support Gralloc3 in SwiftShader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8d51994ce5874c55f8ddd0389cf8c8ae198e6cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298801Reviewed-by:
-
Mohsen Izadi authored
Every time this file is modified, there is a cpplint complaint about the C-style cast. Fixing the cast to avoid cpplint complaint. Bug: none Change-Id: I8b93c028a2208c71332e8ff1de49f8af9ae32a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299020 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788492}
-
Lan Wei authored
overflow-scroll-in-overflow-scroll-scrolled.html" Avoid testRunner.eventSender in paint/invalidation/scroll/overflow-scroll-in-overflow-scroll-scrolled.html TBR=wangxianzhu@chromium.org Bug: 1047176 Change-Id: If4522d945a8e5d2d269bd7e8eedf8b070a81cc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298277Reviewed-by:
-
Sven Zheng authored
Bug: 1104291 Change-Id: Ib783a1d26f96c16042178c232a41477a9f0fc6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293479Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788490}
-
Yue Zhang authored
http://crrev.com/c/2123991 makes TAB_CLOSED_LISTENER a common property for all types of tab lists. However, TAB_CLOSED_LISTENER should not be set for UiType.SELECTABLE. This CL fixes this issue by not setting up TAB_CLOSED_LISTENER for UiType.SELECTABLE. Bug: 1105439 Change-Id: I3999463f1cb574fd16904fef83fe4ef1a5418c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298521Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788489}
-
Yuki Shiino authored
Creates the returned V8 wrapper in the appropriate context when [CheckSecurity=ReturnValue] is specified for the new bindings generator. Bug: 839389 Change-Id: Iccc59a2dca63d146b4f06413672778627bb7a1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297000Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#788488}
-
Jeremy Roman authored
We know exactly what the final size and type is, so we can write directly into the final buffer instead of using a builder first. Change-Id: Ia8fcbc2ae6ae7adc0eedc9d3cac7938a6ccb3291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297684 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#788487}
-
Kent Tamura authored
SELECT: The last selected OPTION should be selected when multiple selected OPTIONs are added by jQuery append(). HTMLOptionElement::SetWasOptionInsertedCalled() had a silly bug. Bug: 1105672 Change-Id: Ic70572f297969d44bbe8f3d55fe05af796397f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298882 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This enables VaapiVEA to produce temporal layer bitstream. The temporal layer bitstream structure is defined in VP9TemporalLayer class. It now supports two and three temporal layer structures. VA-API encoder driver works in CQP mode only if temporal layer encoding because VA-API driver on gen 9 devices doesn't support bitrate control of each bitrate layer in CBR mode. Design doc: go/vaapi-vp9-TL Bug: 1030199 Test: vp9_encoder_unittest Test: appr.tc/?debug=loopback&vsc=vp9&vrc=vp9 with --force-fieldtrials=WebRTC-SupportVP9SVC/EnabledByFlag_1SL3TL/ --enable-features=VaapiVP9Encoder Change-Id: Ie46b4b52730c59684ea00c27bdf1afaaf07bf991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150525 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#788485}
-
Lingqi Chi authored
|WebLocalFrameImpl::FromFrame()| will return nullptr if the given frame does not have a valid |WebLocalFrameClient|, using the returned null pointer leads to a null dereference crash. This CL adds a check on the returned WebLocalFrameImpl. Bug: 1069289 Change-Id: Ifa009f974a1bb25add08bb6f155b02a4c797c423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275818 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Nate Chapin authored
* Add an execution_context_ pointer to SecurityContext (which will be null for RemoteSecurityContext). Use execution_context_ state in lieu of context_type_for_asserts_, and add a way for ExecutionContext to report if it has an insecure ancestor. This gives SecurityContext all the state it needs to update the SecureContextMode when the SecurityOrigin changes. * Now that SecureContextMode is set automatically, ensure all tests that depend on the SecureContextMode set a suitable SecurityOrigin, and remove SetSecureContextModeForTesting(). Change-Id: I881593fc3e3dbeef589c87f4e40b1037200037b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295792 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Glen Robertson authored
Web App Manifest spec term was updated recently: https://github.com/w3c/manifest/pull/833 Bug: 1096388 Fixes: 1096388 Change-Id: I6fe6da6abb8d4e06391c46d4054a746bc49e6e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291512Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#788482}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4f8011aef19..9421094d01b1 2020-07-15 herb@google.com Revert "rename MakePath to Make" 2020-07-15 herb@google.com rename MakePath to Make 2020-07-15 reed@google.com Revert "remove support for serialized pictures before aug 2019" 2020-07-14 adlai@google.com Add a direct context arg to makeColorTypeAndColorSpace 2020-07-14 johnstiles@google.com Update SkTQSort to use half-open ranges. 2020-07-14 brianosman@google.com Runtime effects: Allow null children 2020-07-14 jcgregorio@google.com Add one R preview bot. 2020-07-14 herb@google.com subclass GrPathSubRun from GrSubRun 2020-07-14 bsalomon@google.com Remove under used IsACopyNeededForMips helper. 2020-07-14 bsalomon@google.com Make GrTextureProducer take optional subset and domain rects 2020-07-14 herb@google.com make GrAtlasSubRun a subclass of GrSubRun 2020-07-14 egdaniel@google.com Update GrDawnBuffer to handle mappable xfer buffers. 2020-07-14 robertphillips@google.com Set up to use new GrDirectContext factories in Chrome 2020-07-14 herb@google.com extract and rename SubRun to GrSubRun 2020-07-14 johnstiles@google.com Replace various one-liner sorting functor adapters with lambdas. 2020-07-14 bungeman@google.com Move makeFontData to SkTypeface_FreeType. 2020-07-14 senorblanco@chromium.org Roll Dawn, and update to new TextureDataLayout API. 2020-07-14 jvanverth@google.com Add Direct3D compressed texture support. 2020-07-14 bsalomon@google.com Remove GrTextureProducer::DetermineDomainMode. 2020-07-14 reed@google.com Create mipmaps when creating images 2020-07-14 brianosman@google.com In FPs, store pointers for all child slots, even nullptr 2020-07-14 egdaniel@google.com Revert "Add GrContext api to update compressed backend textures." 2020-07-14 johnstiles@google.com Include the SkTSort header only where it is used. 2020-07-14 egdaniel@google.com Add GrContextOption to limit the number of cached secondary command buffers. 2020-07-14 reed@google.com remove support for serialized pictures before aug 2019 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1099255 Tbr: nifong@google.com Change-Id: I26f0c3bea8ed278c552c66c48328ecb22c2e7289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298470Reviewed-by:
-
