- 21 Nov, 2019 40 commits
-
-
Mohamed Amir Yosef authored
This CL introduces a new class that encapsulate the save/update logic. 1- This makes the password form manager smaller and more maintainable. 2- The save/update logic is now better testable. 3- This will allow introducing the multi-store password save manager which will be needed for Butter for Passwords without touching the PasswordFormManager class. TBR=vasilii@chromium.org Change-Id: Ib2c3d134ba5e94975610d263da6bece3bb5c3302 Bug: 1012203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865158Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#717584}
-
tby authored
This crash looks to be caused by accessing a null base::Value, and there's only one unchecked access in the EnforceLoggingPolicy. This CL adds a null check there too. Logic change: The code block checks whether an arc app is syncable and, if so, whitelists it for logging. Otherwise it whitelists a generic 'some app' for logging. This change means that, if we can't establish whether an arc app is syncable, we assume it is *not*, and add the generic app. As far as I understand, this complies with logging policy. Bug: 1026967 Change-Id: I2b33e81d847a82fdceea97e75acf8bd9a7acee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928457Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#717583}
-
Yuki Shiino authored
It's invalid that DOMString / USVString have default value of IDL null. Removed such use cases. https://crrev.com/c/1920018 will prevent writing this sort of mistakes in future. Bug: 1024695 Change-Id: I9d21bfda685ba54bce3d0e32aa0a2fd111b621d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926094 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#717582}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 1023677 Change-Id: If25fcb12308719437e56883f20cff1c83d435b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924962 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#717581}
-
Colin Blundell authored
This CL paves the way for reusing //chrome's SSLBlockingPage(Base) in WebLayer by componentizing them. We do not componentize ssl_blocking_page_unittest.cc at this time as it fundamentally relies on //chrome-level mechanisms. We are going to investigate whether the test really is conceptually //chrome-level (in which case we'll rename it to something like chrome_ssl_blocking_page_unittest.cc) or whether the mechanisms that it relies on for validating its tests can be converted to mechanisms available in //components. We also do not put the moved files in the security_interstitials namespace at this time to avoid churn with further moves that will occur. TBR=mkwst@chromium.org Bug: 1025059 Change-Id: I4c594c3b4d53f804847919bb5c3be86444767730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924252 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#717580}
-
Sergey Poromov authored
The code is used only in Drive and can be simplified to just: if (base::CommandLine::ForCurrentProcess()->HasSwitch( chromeos::switches::kDisableGaiaServices)) { return false; } const user_manager::User* user = chromeos::ProfileHelper::Get()->GetUserByProfile(profile); if (!user || !user->HasGaiaAccount()) return false; BUG=chromium:942937 TEST=tryjobs Change-Id: I34ad06406a2eb1c439456caa71be583f24d32797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926146Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#717579}
-
Shelley Vohr authored
These files had an include-what-you-use issue leading to release build failures in Electron, as it was unable to find max in the std namespace. This fixes those errors. Change-Id: I393891debf575893eecd7ba9ec468520e2608d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904823Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717578}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 517a971c. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." 88c90ec1 "MediaCapabilities: Update EME robustness interface" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic84a1f84403836d4e9e1eccb0b3c767ca72a8663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928871Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717577}
-
Eric Willigers authored
When an app is opened as a window in RTL, the title text is no longer shifted far to the left (where it could overlap with the web app three dot menu). Bug: 1026521 Change-Id: I76644f944d7657aa3bf7cce826be47b4a0193f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928107Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#717576}
-
Roman Sorokin authored
Bug: none Change-Id: Ifd08d0ccc25463a0502f935b5c1c13eb8a1120bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924521 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#717575}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.24-1574075354-benchmark-80.0.3964.0-r1 to 80-3945.24-1574075354-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I75452283f29e867899db35e9d703f817c4f0289f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717574}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=bsep@chromium.org Bug: 1023677 Change-Id: I30c7f70cc734aacd530ee5993d86863f8b05eddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927022 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b8e748be6b94..fdbc1acec72f git log b8e748be6b94..fdbc1acec72f --date=short --no-merges --format='%ad %ae %s' 2019-11-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 2ee9aaa288d9..45dde9ad6dde (1 commits) Created with: gclient setdep -r src/third_party/angle@fdbc1acec72f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: Ie4fe3c1b8a2502c9667a122d6e46c81aa7089663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928229Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2ee9aaa288d9..45dde9ad6dde git log 2ee9aaa288d9..45dde9ad6dde --date=short --no-merges --format='%ad %ae %s' 2019-11-20 rharrison@google.com Add missing dealloc (#3061) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@45dde9ad6dde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,courtneygo@google.com Bug: None Change-Id: If0ef6b5c5bc964aa87d91ad178b3fa133d807177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928225Reviewed-by:
-
Jared Saul authored
Change-Id: I9f081babb7ea7da9a8d9ea9ec4ceba9d42272940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926673 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#717570}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3945.24-1574073272-benchmark-80.0.3964.0-r1 to 80-3945.24-1574073272-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ic176da4704202607e5f2c3faebde5be7ae68b1da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928230Reviewed-by:
-
Gauthier Ambard authored
To be inline with other icons. See bug for screenshot. This CL also removes the x1 icon as it is no longer needed. Bug: 1026303 Change-Id: I83cf6f7dafb7a8da23684dd72700906947a0b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924524Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#717568}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2843e0643c5..8ae8320dd326 Created with: gclient setdep -r src-internal@8ae8320dd326 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5752ebe2190418b9943e4a869ad7f01190642de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928227Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717567}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 1023677 Change-Id: Iac3ccdf9370a1e31677b2aba1e159c20e7f3a7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926873 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#717566}
-
Hajime Hoshi authored
|disabled_reasons_| should live as long as the frame lives. This CL lets a render frame have |disabled_reasons_|, and record them when frames are swapped or eviction happens. Bug: 1004676 Change-Id: I57b8738df3889846d892ba72900a0d046ebe04f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849612 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717565}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kolos@chromium.org Bug: 1023677 Change-Id: I3c0c4c0da9cd006dea3c80fe0c5bde12dc3e5caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927006 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#717564}
-
Koji Ishii authored
Following bot results are included. 325 327 329 330 331 333 334 340 342 343 344 346 348 352 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I0355b2e2db2e003b2a204aef0db8d496c9316206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923779Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#717563}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Id95f207e11baf222b809a9806b2caeb77f97bcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928371Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#717562}
-
Kenichi Ishibashi authored
This is a preparation for moving ServiceWorkerDatabase into the storage service. ServiceWorkerDatabase depends on some simple structs, enums and constants. These don't have complex dependencies but are defined in mojom files which also contain other interfaces which have complex dependencies. Put direct dependencies of ServiceWorkerDatabase in separate mojom files to make it easier to move ServiceWorkerDatabase into the storage service. The plan is similar to crrev.com/c/1920008. In follow-up CLs, we would add a separate mojom target which contains direct dependencies of ServiceWorkerDatabase (in general, storage serivice). Bug: 1016064 Tbr: lazyboy@chromium.org Change-Id: Ifba7a5e10b81a8607b28754c237ab4266455fd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928092 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#717561}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=rsorokin@chromium.org Bug: 1023677 Change-Id: I1ea6defcfd6a41ebdb3a89e3078a8b6448aae321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927016 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717560}
-
Fredrik Söderquist authored
The |id_| field is always set to 0 (zero) and never accessed. |image_url_| is only used in the constructor and then never accessed. Change-Id: If80d39d3a4318df14ddccb9c16d56bc23642d49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926135Reviewed-by:
-
sandromaggi authored
Make the touch target 48x48 for a11y. Make the icon and poodle 32x32 to fit the Assistant design spec. Change alignment of elements in header. Before: https://screenshot.googleplex.com/PpW7rjVyNz5 After: https://screenshot.googleplex.com/O8yg4ZTjth1 These changes have been viewed and accepted by UX. Note that the poodle change is not in this CL but has to be done in a different CL. State without poodle change: https://screenshot.googleplex.com/6ys5nL8Jdja Bug: b/144332468 Change-Id: I0324bdb9054d1518ffd9ba9c00b8e0021bbc0e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911749 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#717558}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1023677 Change-Id: I45cdc2bf680f2afd0ea5dfc8b2411bb20593b831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924801 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=grt@chromium.org Bug: 1023677 Change-Id: Iecb73bedae1c12c720687ff4bdd43cad7787409b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926910 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717556}
-
Rune Lillesveen authored
When checking if we were outside the flat tree for the style recalc root update, we checked the computed style of the common ancestor instead of the parent element. That lead to a recalc root outside the flat tree which in turn left us with a dirty tree after the lifecycle update. Bug: 1023205 Change-Id: I8687adb6740bf988e4466b783b87b3b8ba3b4ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927811Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#717555}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: If43685ed5d417243b6fd014f25811da574d703b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926850 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#717554}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: I5e541cfbd7d200e7e57b9391f2ce1bd13a211e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927047 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: I742a5ba4d7aad3ad9b654c1f1a1179b890cabebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926819 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Ia88b463a8685014a22d65c9e0132cb528e4242bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921603Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#717551}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: I1ea903063c171fc143ad483696cfaaaef473d03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927007 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL makes ServiceWorkerProviderHost take running hosted service worker version as a constructor argument, and calculate |url_|, |site_for_cookies_|, and |top_frame_origin_| in the constructor. This change simplifies getters of these fields, and makes it easier to move them to ServiceWorkerContainerHost. Bug: 931087 Change-Id: Ic14d2af2f57a54344f9998245ae530331532be67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928109Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 1023677 Change-Id: Ibaace0daf144250455ce45975cf508a8ad7c4b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926946 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#717548}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=grt@chromium.org Bug: 1023677 Change-Id: I878aae6b13b99aa85f1c10a96822273b8b4f5fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926912 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 1023677 Change-Id: I7b369565a3b50f81e329c8ef8adb8df727991a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926875 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Marcin authored
CL is providing necessary changes to scripts to allow them installing necessary libs for building Android version. Change-Id: If93bc950fa5a2c51bc2668cd59f5d12af23cf872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924468Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#717545}
-
