GitLab

Bug: 1070494
Change-Id: I0c828ed291c53dfeb238fce1de47c7d7aa76602a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146289
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759088}

Prior to this CL, the setsize and selected attributes were incorrectly
linked. There are now two separate attributes with their own reflected
properties.

Bug: 914469
Change-Id: I73c26e3685fc758537cbe0eb9e3bb98becc75bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148112
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759087}

Bug: 1066029
Change-Id: Iaecc6e60782b686e3bd4d0f3ae76f320939bc659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145555Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759086}

This controller and its model are needing to be exposed to the new
AssistantSearchProvider. This will be used to provide a chip from
conversation starters in the launcher.

With the addition of this new interface, we no longer need to expose
the controller model through the AssistantViewDelegate.

Moving forward, this pattern can be used for other Assistant
sub-controllers as well.

Bug: b:146074655, b:153165835
Change-Id: I7016bd9ae8d6cbe07dc9afe3ee01b99588127fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135838
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759085}

ChromeOS related APIs are still actively updated. This is especially
because those APIs (e.g. autotestPrivate) are heavily used by
Tast tests.

Due to the role changes of some of the current owners, I guess
it would be better to have new owners who have experience of
Tast tests.

Bug: none
Test: none
Change-Id: I3b14bc26a38dfb739cbd0cd56bcd0acc96ef1ebc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142955Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759084}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08f4d59e0b17..e0950f3cd2c6

git log 08f4d59e0b17..e0950f3cd2c6 --date=short --first-parent --format='%ad %ae %s'
2020-04-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@e0950f3cd2c6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I3b85b91cb4d8a4c0712715acd757d191a0dc3ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149816Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759083}

This change removes the unneeded function GetCurrentExecutablePath
from the PWA launcher executable.

Previously, this function got the current executable's path and then
called base::NormalizeFilePath to preserve its capitalization.
Preserving the file path's capitalization was left over from when the
PWA launcher updated itself in-place, and therefore needed its
filename exactly as displayed in order to create an updated file with
that filename.

With the removal of this unneeded call to base::NormalizeFilePath, the
whole function is trivial and can be extracted into the rest of the
code.

This change also fixes LaunchResult::kMaxValue, which was incorrectly
set to an enum value that was not the highest.

Bug: 960245
Change-Id: If7d737d14f6cc56e0aab10a83fde8cd379e05ce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149945
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759082}

This CL adds a histogram that records whether touch event in site
permission dialog is blocked because the dialog was obscured by overlay
window.

This diagram helps to assess how often users experience issues
interacting with permission dialogs.

BUG=1014477
R=tedchoc@chromium.org

Change-Id: I8c606ab0f0f2ef8128c35d4f57028469942d2796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148161Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759081}

Bug: 1067057
Change-Id: I1c4f6691d701770fc8f06bc4640312214b2e6c46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143857
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759080}

For M84.
Launch bug: https://crbug.com/1042109

Change-Id: I0a4f2533e9794b3190de9e0e360b2559d49212ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148916Reviewed-by: dstockwell <dstockwell@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Cr-Commit-Position: refs/heads/master@{#759079}

Previously, on ChromeOS, Breakpad would only be installed if
(a) the device owner had already consented to stats collection at the
time the browser process started up or
(b) the user consented to stats collection in the OOBE flow.

Extend this to install Breakpad if the user consents to metrics
collection in the settings menu. Or if a tast test changes consent via
the autotest private functions.

Consistent with previous behavior, Breakpad is not uninstalled if the
user revokes consent. Rather, we rely on crash_reporter to discard the
report in that case.

This change only affects Breakpad. Crashpad is always installed and
relies on crash_reporter discarding reports if crash collection consent
is not given.

This only affects ChromeOS.

This change isn't perfect. It only installs Breakpad in the main browser
process when the user gives consent in the setting screen. Trying to
install Breakpad in all running processes seems like it would be very
complex, and Breakpad is being deprecated in favor of Crashpad soon, so
I'm just fixing the main browser process here.

BUGS=chromium:1058261, chromium:1058258

TEST=Disabled consent in OOBE, logged in, enabled consent on settings
screen, crashed browser and saw crash files written out.
TEST=Enabled consent in OOBE, crashed browser before logging in, ensured
crash files written out
TEST=tast ... ui.ChromeCrashLoggedIn.browser_breakpad

Fixed: chromium:1058261, chromium:1058258
Change-Id: I8d2ac65b690790f0396d8a67ce9a0c3af114d69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145676
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759078}

Bug: 1068326
Change-Id: Ibec216845b7fef3a0fd7f8d780c5cb47ed24d430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149633Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759077}

Set async=false on all three scripts instead of the first repeatedly.
The current typos are causing a test to be flaky (AdTaggingBrowserTest.
ChildrenOfFrameWithWindowStopAbortedLoad_StillCorrectlyTagged).

Bug: 1069346
Change-Id: Ib5c7f4994d25ebf4eedcc6d23ef2110c321bb454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148846
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759076}

Also performing several other small cleanups
 1) Eliminate usage of CallJavascriptFunctionUnsafe()
 2) Eliminate global setSaveDumpMessage in favor of a WebUI event.
 3) Eliminate global returnProcessList in favor of a Promise.
 4) Remove bad calls to AllowJavascript(). This method should not
    be called within async C++ callbacks.
 5) Add JS type checking.
 6) Move "Refresh" and "Save" button creation in HTML, no need to
    do this in JS.
 7) Remove unnecessary flattenhtml="true" in grd file.

Bug: 1028829
Change-Id: I7841982bef7957b7178171ab50211f93deb1d672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956446
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759075}

Converting String URLs to GURL also required moving some tests from
junit to native java unittests, as GURL requires the native library to
be loaded.

Bug: 783819
Change-Id: Id574a15715effe1845d2cfa50f698461b83bb5b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071376Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759074}

This CL updates the unmask dialog on Desktop&Clank (in the window title)
and iOS (in the instruction).

Bug: 1059087
Change-Id: Ia33fab4eaa7cc35dcb08e7d1c5fe87e33556fb2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144738
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759073}

This CL makes the matches in the popup show and hide in response to the
group toggling.

Bug: 1052522
Change-Id: Ifdc5684fed01d84a05663cbe3093417392a4a88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149508
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759072}

Build a standard promo card component that could be used in different
area.

Bug: 1068831
Change-Id: I8f557c602109abfbe5736e82afad7bfea262d236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141136
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759071}

We want to get rid of the single argument AddHeader() method as the two
argument AddHeader() and SetHeader() methods are safer and more flexible.

Bug: 1068194
Change-Id: Ia94f58be1f09887d858df8c107843c683da1560a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148023
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759070}

Both //content/common and //chromeos/system are including
core_sceduling.cc source rules resulting in two object files
with the same symbols when both dependencies are included.

The reason those source files were added in content/common was
because //chromeos/system was not exporting its symbols. The
correct fix is to let //chromeos/system when using
//chromeos:chromeos_export to also properly set the visibility,
the other alternative would have been to create a separate chromeos
system export rule but that seems unnecessary.

Bug: 1070488
Change-Id: I6287388e42ab652c951ee10eb5f96ede74b1c625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149277Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759069}

When the Assistant response's first UI element is a card, the card is
given an empty top border for spacing. When this occurs, DCHECK fails
because we were previously expecting local bounds when we should be
expecting contents bounds.

Bug: b:153904177
Change-Id: I7f28149cb6317836c76f566827526c8220f0e5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148221Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#759068}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54e96aa9dd24..69510cd61f1a


Created with:
  gclient setdep -r src-internal@69510cd61f1a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1046880
Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com
Change-Id: I502adb49e2d5c4fea8f509a81f34d6eaa72fcee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149808Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759067}

Bug: 1044139
Change-Id: Id5d490f24f8fa8adad5821e4f2be0188a95c2fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149475
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759066}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ifb83ad15153e7b00c072ddb82576c9f5a7bab9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149815Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759065}

Remove chrome/test/chromedriver/chrome/version.h, which has been
made obsolete by https://crrev.com/758971.

Change-Id: Id0de8a194e856dad2499902ba3287ef936a16a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149293
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: John Chen <johnchen@chromium.org>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#759064}

The tests now use FakeCrostiniFeatures to set all things enabled.

Bug: 1067487
Change-Id: I8e797002be93a830eb2ce1e425b4bd91cf8bffb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147165
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759063}

Enhance the GetMediaFeeds API to sort results
by audio+video watchtime percentile as well as
limiting the number of results and having a
minimum watchtime.

This will be used for getting feeds to fetch
and for display.

BUG=1053599

Change-Id: If6015f57ba93a39ec07288fe8a3d1244c3bdb7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145760Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759062}

This CL adds an OfflineIndicatorControllerV2 class that controls the
status indicator widget for offline indicator specific purposes. This
new class is owned by TabbedRootUiCoordinator like the status indicator
widget itself. The old offline indicator snackbar is also disabled when
V2 is enabled.

Bug: 1068725
Change-Id: Ifa34779309f1229ca82d4a9ea7b1b9b49a43f4d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148217
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759061}

Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking
result.value (which has a base::Optional type, convertible to bool).

The error_code enum is really a private implementation detail. Callers
don't care about it (other than it being an error or no error). Removing
references (outside of //base/json) to that enum will let us more easily
modify the //base/json implementation.

Bug: 1070409
Change-Id: I54b8e787b5c1469efff77fda48d72a4d7251f7f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147401Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759060}

Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking
result.value (which has a base::Optional type, convertible to bool).

The error_code enum is really a private implementation detail. Callers
don't care about it (other than it being an error or no error). Removing
references (outside of //base/json) to that enum will let us more easily
modify the //base/json implementation.

Bug: 1070409
Change-Id: I2e67c7815fa8ce3e9ad784e85e236cf33558e8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147440Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759059}

Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking
result.value (which has a base::Optional type, convertible to bool).

The error_code enum is really a private implementation detail. Callers
don't care about it (other than it being an error or no error). Removing
references (outside of //base/json) to that enum will let us more easily
modify the //base/json implementation.

Bug: 1070409
Change-Id: I0fe1f6d5debb837b6e7abab6fdfa0fd6a8a22e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143190Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759058}

Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking
result.value (which has a base::Optional type, convertible to bool).

The error_code enum is really a private implementation detail. Callers
don't care about it (other than it being an error or no error). Removing
references (outside of //base/json) to that enum will let us more easily
modify the //base/json implementation.

Bug: 1070409
Change-Id: Ifffa60fa05d5dd2f52fabe0a2d6794db187e0f1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147400Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Vincent Boisselle <vincb@google.com>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759057}

Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking
result.value (which has a base::Optional type, convertible to bool).

The error_code enum is really a private implementation detail. Callers
don't care about it (other than it being an error or no error). Removing
references (outside of //base/json) to that enum will let us more easily
modify the //base/json implementation.

Bug: 1070409
Change-Id: I1e026b4b8e1544823b07ce2c6da9f5bd56f6c708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145750Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759056}

Selector specificity due to selector lengths for files-ng caused the
selector for check-select 'Open' button color to be overridden.

Change the non files-ng selector 'Open' button color case to not be
applied when check-select mode is active.

Bug: 1068556
Change-Id: I5fd36169941bcb4a1fad111d090b6ef728761aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147138
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759055}

This obviates the need for the work described in
go/chrome-nonpredictive-tabstrip-animations.

One known issue: with stacked tabs enabled, resize a window to trigger
a transition into the stacked layout. The tabs will animate into the
new layout, and while this is taking place, they will ignore any
further changes to the tabstrip's bounds.

Further work: Continue removing now-dead code from the new animation
system.

Bug: 958173
Change-Id: I977b3836ad87647fa17e431a1215ebd1ce81727c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055544Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759054}

This CL creates a NotificationSettingsClient in site_settings that
contains embedder-specific logic needed to render the Site Settings UI.
These 4 methods are mostly needed to support TrustedWebActivities,
which are a Chrome-specific feature. They were put into their own
client interface to keep SiteSettingsClient more organized.

Bug: 1058597
Change-Id: Iceeeabc1476c39d079f8eb8aeade142dd5d4e05e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146141
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759053}

Per the style guide, we should use proper test assertions to report
failures gracefully.

Bug: None
Change-Id: I84be462364d6f310c08c591785d7f781a92251b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149376Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759052}

Clusterfuzz found that using EventSender::DoDragDrop from a remote frame
causes a crash. EventSender doesn't support remote frames in this case
and this is a crash in test-only code so not severe but this CL will
silence the fuzzer.

Bug: 1070137
Change-Id: Ib64b677a792af2311cd7ace745755c2b9055219e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149282
Auto-Submit: David Bokan <bokan@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759051}

The Assistant search provider will be used to provide a single search
result from its internal cache of conversation starters. This will be
surfaced as a suggestion chip in the launcher.

This CL simply stubs in the provider (along with a single hardcoded
result) so as to unblock development of the logic which will allocate
Assistant a dedicated chip slot.

Changes are gated behind a new feature flag:
  AssistantLauncherChipIntegration

Bug: b:146673437, b:153165833
Change-Id: I54159c3ee17110c8fad46bbb3cea4a88b3250df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134651
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759050}

This method decides for a given user and username, whether moving
to the account store should be offerred or not.

Bug: 1032992
Change-Id: Ie57a2d4f4bafe309ac114f2060270ca3d85c0a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135612
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759049}