- 03 Oct, 2018 40 commits
-
-
Aldo Culquicondor authored
These methods don't affect the BrowserRenderer. The task posting is done in VrGLThread instead. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie43b046c71b7293d33316f4029f0fd7710c19869 Reviewed-on: https://chromium-review.googlesource.com/c/1258283 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#596219}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I3173492480955a562415bd8885b6b92fb6cbf5a6 Reviewed-on: https://chromium-review.googlesource.com/c/1256782Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#596218}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/607f907d47b0..c3bef3e7b028 git log 607f907d47b0..c3bef3e7b028 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jmadill@chromium.org Allow 'defined' in define in non-WebGL. Created with: gclient setdep -r src/third_party/angle@c3bef3e7b028 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9a293a9b4379033c32c047031d5700c7897d31ec Reviewed-on: https://chromium-review.googlesource.com/c/1258874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596217}
-
Bailey Berro authored
- Fixes a nullptr dereference crash when SetupKerberos times out. Bug: chromium:891517 Change-Id: Ie9394ec31d1f1c640c313a829bd0d99c9f02e48f Reviewed-on: https://chromium-review.googlesource.com/c/1258216 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596216}
-
Stephen McGruer authored
Test appears to be heavily timeout-flaky, unclear as to why it suddenly became flaky at this time. Bug: 891530 Change-Id: I1d097662b7a9f6fbb35999d5553224ac4a24a2b5 TBR=bokan@chromium.org Change-Id: I1d097662b7a9f6fbb35999d5553224ac4a24a2b5 Reviewed-on: https://chromium-review.googlesource.com/c/1258620Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596215}
-
stkhapugin@chromium.org authored
Deletes all the legacy code that is not used in UI Refresh. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I99f1ee75475187951b96a037e7874c735e459996 Reviewed-on: https://chromium-review.googlesource.com/c/1235717 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596214}
-
Andrew Grieve authored
Bug: 860531 Change-Id: I03983ef066185bfc5aa40a34c9ced4fbfd2c97e2 Reviewed-on: https://chromium-review.googlesource.com/c/1258055 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#596213}
-
Guido Urdaneta authored
When the last track from a source is removed, the source is asynchronously stopped. Between the request to stop and the reception of a notification about actual stop it is possible that a new track is added to the source (e.g., by cloning the track being removed). There was a DCHECK asserting that there could be no tracks when the stop notification is received, but as the example above shows, this is not necessarily the case. No further changes are required since the newly added track will start out ended due to being connected to a stopped source. A test that fails with the old DCHECK is added to prevent similar regressions. Drive-by: Replace the |webkit_| prefix with |web_| on the test. Bug: 770908 Change-Id: I7ce01d3f0a2a5f77e161c88eb58c5334fad0aa3b Reviewed-on: https://chromium-review.googlesource.com/c/1258002Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#596212}
-
Justin Cohen authored
Bug: 883770 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2b7a57e57047677304ba572b9648e998563a8d39 Reviewed-on: https://chromium-review.googlesource.com/c/1256442 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#596211}
-
Ehsan Chiniforooshan authored
We would like to deprecate smoothness metrics and replace them with equivalent TBMv2 rendering metrics. To prevent those changes from breaking benchmarks that use legacy smoothness metrics, this CL chanes those benchmarks to compute both legacy and equivalent TBMv2 metrics. After the transition is complete, we can just compute TBMv2 ones. Bug: 890757 Change-Id: I95203ec76a09be2273e4f71fe3e372e1ff04cc6d Reviewed-on: https://chromium-review.googlesource.com/c/1258213Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596210}
-
Mythri Alle authored
V8 API will deprecate the non maybe versions of v8::Object::Has and v8::Object::Delete. Updated extensions/ to use maybe versions. Bug: v8:7284 Change-Id: I966abdec0226c5999cacd5bf5daf993747179287 Reviewed-on: https://chromium-review.googlesource.com/c/1254208 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596209}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: Ic2eec59581223c897b76675a2d7b1fb47a1327da Reviewed-on: https://chromium-review.googlesource.com/c/1257681 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596208}
-
Steve Anton authored
TBR=hta@chromium.org,haraken@chromium.org Bug: 864871 Change-Id: I6a2e0dc98efc58e22b33066ee3d37ded3c9b021a Reviewed-on: https://chromium-review.googlesource.com/c/1258503 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596207}
-
Hugo Holgersson authored
With snav-testharness.js, the flakiness seen in Issue 836275 will most probably be gone. Bug: 803086, 836275 Change-Id: If44b1ca5c88af3c0fcc045061cdce50dcc91a276 Reviewed-on: https://chromium-review.googlesource.com/c/1257919Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#596206}
-
Tim Volodine authored
This patch provides an initial implementation of the URLLoaderFactory for Android WebView and hooks it up for usage when the Network Service feature is enabled. At this stage the implementation is pass-through, i.e. it simply forwards requests further to the target factory and eventually the network. Further functionality will be added in subsequent patches such as the ability to intercept/block, error callbacks etc.. BUG=841556 Change-Id: I079b21d4d17b064b2e013f7c5692dea3b02e1a04 Reviewed-on: https://chromium-review.googlesource.com/c/1244458 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596205}
-
Nico Weber authored
Bug: 845389 Change-Id: Ifd303cb366e6d2ed3750651463b8de0d931e49f4 Reviewed-on: https://chromium-review.googlesource.com/c/1258293Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596204}
-
Justin Cohen authored
Also note that -correctMissingSafeArea in content suggestions VC can be bypassed when the BrowserContainerFullscreen feature is enabled. BUG: 849206, 836730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id876a66b1509cdec64a645b59c296186c31fa8e1 Reviewed-on: https://chromium-review.googlesource.com/c/1255984Reviewed-by:
-
Fredrik Söderquist authored
Hoist call to ResolveTargetElement() out of HasCycleUseReferencing(), leaving the latter only checking for cycles. Drop the InUseShadowTree() check from BuildShadowAndInstanceTree since its single caller checks it already. Use ToSVGElementOrNull to simplify the code a bit. Bug: 397525 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idb6cbd9e155d6217db77ef97299e77fa57cd0d8d Reviewed-on: https://chromium-review.googlesource.com/c/1257918Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#596202}
-
Aldo Culquicondor authored
Bug: 891495 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6b4aa77dc0c81b79afe681c31ed2b4a06f19dc37 Reviewed-on: https://chromium-review.googlesource.com/c/1257816Reviewed-by:
-
Fabio Tirelo authored
This was requested during UI review for the feature that split the Autofill Settings page into Profiles and Payment methods, so that they will be consistent with the user menu. Screenshots can be found in the bug. Bug: 891454 Change-Id: I2a436d08d2e6bbb9c1f4730cbf43351100006bd2 Reviewed-on: https://chromium-review.googlesource.com/c/1258050Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596200}
-
Eric Seckler authored
The linux jumbo bot is flaking on content nocompile tests due to the nocompilation tests timing out. This patch increases the timeout to twice what it was before. Bug: 882852 Change-Id: Ib2bc0023acd8d677ea77eb2769a5f83da39ed0da Reviewed-on: https://chromium-review.googlesource.com/c/1248601Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#596199}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e44e847c70ac..416018d455bf git log e44e847c70ac..416018d455bf --date=short --no-merges --format='%ad %ae %s' 2018-10-03 kthelgason@webrtc.org Remove deprecated protocol alias RTCEAGLVideoViewRenderer. 2018-10-03 kwiberg@webrtc.org audio_coding_module_unittest: Don't rely on the ACM to create encoders Created with: gclient setdep -r src/third_party/webrtc@416018d455bf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I20c0b24ec78710eadb94a950dfcea4eedd255b84 Reviewed-on: https://chromium-review.googlesource.com/c/1258869Reviewed-by:
-
Stephane Zermatten authored
Before this patch, the script executor checked element existence in parallel and the script tracker checked script preconditions in parallel. This doesn't work: element existence checks only work when run one at a time. This meant that precondition on elements were never met, because there were always multiple scripts to check, while WaitForDomProto worked, as it's typically running a check on a single element. With this patch, checking for elements from preconditions works, even when there are more than one script or elements to check. Bug: 806868 Change-Id: Ib5e97a36a7aff5df5eab183da9461375df4f1ec3 Reviewed-on: https://chromium-review.googlesource.com/c/1256794Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#596197}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b627af80e3a4..5b2bc879189c git log b627af80e3a4..5b2bc879189c --date=short --no-merges --format='%ad %ae %s' 2018-10-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@5b2bc879189c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Id71ceca29b2521f923bc49c32a66706e1a98fbcb Reviewed-on: https://chromium-review.googlesource.com/c/1258870Reviewed-by:
-
Bence Béky authored
This CL lands the third_party/spdy portion of server change 211551817 by bnc. BUG=488484 Change-Id: I7090d3fcc9ec885114ff5674fd0bba531258130c Reviewed-on: https://chromium-review.googlesource.com/c/1252086 Commit-Queue: Yang Song <yasong@chromium.org> Reviewed-by:
Yang Song <yasong@chromium.org> Cr-Commit-Position: refs/heads/master@{#596195}
-
Hiroki Nakagawa authored
For evolution of worklet thread management there're some dead or duplicate functions in worklet codebase. This CL removes them for cleanup. Bug: n/a Change-Id: I744146854e7f1cbcbb1a48cc60bac6cae34cad35 Reviewed-on: https://chromium-review.googlesource.com/c/1257475Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596194}
-
Sylvain Defresne authored
The script was incorrect as no args.root_dir was defined, thus causing the script to fail if invoked directly (went unnoticed as the code is usually loaded as a python module). Also fix some minor style issues. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia92f2596d1cb30e7bbd6de3aa8f0911a70c97205 Reviewed-on: https://chromium-review.googlesource.com/c/1255732Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596193}
-
Fredrik Söderquist authored
This can save a conversion to UTF-8 (and copy to CString) for ASCII-only URLs. Bug: 889183 Change-Id: Ie5edad4a95da70bac0acd27b01d6e03cd1315bbd Reviewed-on: https://chromium-review.googlesource.com/c/1257926 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/extensions/api/mdns. This CL was uploaded by git cl split. TBR=vitalybuka@chromium.org Bug: 809610 Change-Id: I8796684bd7f2948bcf7463a804698aa148a2cfcb Reviewed-on: https://chromium-review.googlesource.com/c/1246171Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596191}
-
Nico Weber authored
We ship this code, it should have a test. It almost still builds, and it still passes, so there's no reason to keep it disabled. Bug: 845389 Change-Id: I15066058d3189276edade9f6f4448add94ba2814 Reviewed-on: https://chromium-review.googlesource.com/c/1255983Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82dac3df06b9..cd9050823b91 git log 82dac3df06b9..cd9050823b91 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 fmayer@google.com Merge "profiling: Add ClientConfiguration for sampling rate." Created with: gclient setdep -r src/third_party/perfetto@cd9050823b91 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I21ac3efea583a9df835cb5d89ba46ad2c92a2d52 Reviewed-on: https://chromium-review.googlesource.com/c/1258867Reviewed-by:
-
Greg Thompson authored
BUG=none R=pastarmovj@chromium.org Change-Id: If47183f4d79d9aa1a91f193d8bebc123c260eafb Reviewed-on: https://chromium-review.googlesource.com/c/1233495 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#596188}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be8193c9313a..b627af80e3a4 git log be8193c9313a..b627af80e3a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 borenet@google.com [infra] Try another workaround for go_deps asset creation Created with: gclient setdep -r src/third_party/skia@b627af80e3a4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I14eebb488107e526c01bff25e0e057affdf42268 Reviewed-on: https://chromium-review.googlesource.com/c/1258868Reviewed-by:
-
Fergal Daly authored
This reverts commit 6592bd30. Reason for revert: OK checking owners took a long time: 1813ms Traceback (most recent call last): File "/home/bratell/src/google/depot_tools/metrics.py", line 225, in print_notice_and_exit yield File "/home/bratell/src/google/depot_tools/git_cl.py", line 6110, in <module> sys.exit(main(sys.argv[1:])) File "/home/bratell/src/google/depot_tools/git_cl.py", line 6092, in main return dispatcher.execute(OptionParser(), argv) File "/home/bratell/src/google/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/home/bratell/src/google/depot_tools/git_cl.py", line 5086, in CMDupload return cl.CMDUpload(options, args, orig_args) File "/home/bratell/src/google/depot_tools/git_cl.py", line 1551, in CMDUpload change=change, parallel=options.parallel) File "/home/bratell/src/google/depot_tools/git_cl.py", line 1485, in RunHook parallel=parallel) File "/home/bratell/src/google/depot_tools/presubmit_support.py", line 1547, in DoPresubmitChecks results += executer.ExecPresubmitScript(presubmit_script, filename) File "/home/bratell/src/google/depot_tools/presubmit_support.py", line 1454, in ExecPresubmitScript result = eval(function_name + '(*__args)', context) File "<string>", line 1, in <module> File "<string>", line 182, in CheckChangeOnUpload File "<string>", line 164, in _CheckForForbiddenChromiumCode File "tools/audit_non_blink_usage.py", line 604, in check if not _check_entries_for_identifier(entries, identifier): File "tools/audit_non_blink_usage.py", line 548, in _check_entries_for_identifier if entry['disallowed'].match(identifier): AttributeError: 'list' object has no attribute 'match' Original change's description: > Add the ability to give advice on forbidden identifiers. > > Add addvice for base::Bind* > > Currently we are told not to use something, but it's not always clear what > we should use instead. This allows adding advice for the correct alternative > to the forbidden identifies. > > Change-Id: Iaadab609452d2413fdd39a31c80e3924467c42d3 > Reviewed-on: https://chromium-review.googlesource.com/c/1253526 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596178} TBR=tkent@chromium.org,tzik@chromium.org,fergal@chromium.org Change-Id: I16684eee34a7e547cb6d923f38ee669e13394223 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1258812Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#596186}
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/favicon. This CL was uploaded by git cl split. R=caitkp@chromium.org Bug: 809610 Change-Id: I050d6189e8eb2f2f80a6670ab3649218fabcd1ae Reviewed-on: https://chromium-review.googlesource.com/c/1246170Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596185}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/23eba224241c..e44e847c70ac git log 23eba224241c..e44e847c70ac --date=short --no-merges --format='%ad %ae %s' 2018-10-03 buildbot@webrtc.org Roll chromium_revision 601c715f..14de2307 (596047:596155) 2018-10-03 nisse@webrtc.org Delete pre_decode_image_callback 2018-10-03 ssilkin@webrtc.org Add number of freezes per minute metric. 2018-10-03 saza@webrtc.org Reland "Remove APM-internal usage of EchoControlMobile" Created with: gclient setdep -r src/third_party/webrtc@e44e847c70ac The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib17b9714246a56e84c066613cd4ecb48f9e017cf Reviewed-on: https://chromium-review.googlesource.com/c/1258866Reviewed-by:
-
Noel Gordon authored
Untrusted content (HTML here) is rendered in Quick View in a <webview> element. Its parent <file-safe-media> sets the background color of the rendered HTML and that color must be solid white. Test that. Bug: 891150 Change-Id: I10975df3e862b4d8746c97adc43aaf18b248dd4b Reviewed-on: https://chromium-review.googlesource.com/c/1258670Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596183}
-
Findit authored
This reverts commit 051435e2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596148 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDUxNDM1ZTI3MTBiNzk1OGI5ZmE0YTI1NjgyZGEzYTFmOTNiMTI5MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/3840 Sample Failed Step: network_service_browser_tests on Ubuntu-16.04 Sample Flaky Test: StartupIncognitoBrowserCreatorTest.IncognitoStartupThenNormalStartup Original change's description: > The session restore logic is improved. > > The session restore logic looked at the command line of the main browser > process, which resulted in session loss if the browser is first launched > as incognito and then another window is opened with some normal profile. > > This change introduces passing the command line of the new process to > the session restore point so it decides whether to restore the session > according to settings and command line both relevant to the profile that > is to be loaded. > > R=sky@chromium.org > > Change-Id: I69de884b4d270da4d4cc358fe225255b3d4cb3b5 > Reviewed-on: https://chromium-review.googlesource.com/c/1245368 > Commit-Queue: Alexander Dunaev <voodoo@yandex-team.ru> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596148} Change-Id: I543e0412a0960c0a540d8c1dd6dd870dbdc62fa5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891660 Reviewed-on: https://chromium-review.googlesource.com/c/1258387 Cr-Commit-Position: refs/heads/master@{#596182}
-
Sam McNally authored
This is a reland of 0780e76b. The tests in folder_shortcuts.js are flaky with DriveFS, so continue to not run them as before. Original change's description: > Run more FilesApp tests with DriveFS enabled. > > Run with DriveFS enabled: > - Drive-related context_menu.js tests. > - Drive-related metadata.js tests. > - folder_shortcuts.js tests. > - fileDisplayDrive in tablet mode with DriveFS enabled. > > In order to make those tests pass: > - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return > it in GetMetadata(). > - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching > metadata, trying to get a value for it. > - Remove two unused and incomplete tests in context_menu.js. > - Only perform early-init for the downloads volume for the "user" > profile. > > Bug: 891197 > Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70 > Reviewed-on: https://chromium-review.googlesource.com/c/1255086 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596048} Bug: 891197 Tbr: noel@chromium.org Change-Id: Ib85e05c0d940f5a748ef5207b3ff4c3d4e0e7df6 Reviewed-on: https://chromium-review.googlesource.com/c/1257474Reviewed-by:
-
Harald Alvestrand authored
Moved the scheduling of subsequent tones from the webrtc layer to the blink layer. Revised the tests to remove the chance to sneak in extra tonechange events when overriding a remaining tone buffer. Also change "approximate timing" to "at least this long". Bug: chromium:816475 Change-Id: Id91011600b61f43152c8fb896d72433ccb871c61 Reviewed-on: https://chromium-review.googlesource.com/c/1236337 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
