GitLab

Move `Account` serializes and deserializers from `AccountManagerAsh` to
//components/account_manager_core, where it can be depended on by ash
and lacros both.

Bug: 1117466
Change-Id: I4927e89be2e909888f5ccf9ac19ad00b9f007ea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510055
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825450}

Still seeing likely OOMs in the utility process, trying another fix.

This CL
- Prevents starting the compositor if the device is already under
  moderate pressure before loading it.
- Stops requesting out-of-viewport bitmaps when under moderate memory
  pressure or worse.
- Adds a listener to the compositor process to stop when it detects it
  is under memory pressure. This works in harmony with the browser side
  equivalent, but since there is a monitor per-process, this should
  catch more cases.

Bug: 1144768
Change-Id: I08d38f55cfe90eabb364efa85839861028b9cc99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526165Reviewed-by: Fred Mello <fredmello@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825449}

This CL fixes an issue that was causing the screen
reader to unnecessarily re-focus when a node with
scopes route flag was found without any descendant
names route node.  This caused the scopes route node
to be added to the cache but then immediately removed
by the check for empty scopes route.  That causes
a refocus.

Bug: None
Test: Manual w/ display assistant, unit tests
Change-Id: Idbafc1cff79150d8be7f790612d342cd674d16e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525771Reviewed-by: Ryan Daum <rdaum@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825448}

This adds evidence_locker_filepath in ContentAnalysisResponse::Result
and a corresponding reporting field.

This should be removed once a better propagation for this info is
agreed upon.

Bug: 1147036
Change-Id: I496d13a80fd7f06a83f534afa0b6d673184a6bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526929
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825447}

Bug: 1144767
Change-Id: I8e4b613fbed55cc7336a0bf4ac144d7dd4834dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521572
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825446}

Add a standalone account_manager::AccountType enum that can be depended
on by Lacros and Ash, both.
The existing proto chromeos::account_manager::AccountType will be
visible only to Chrome OS Account Manager.

Bug: 1117466
Change-Id: I952bf0d1a81577609103e3f7d9467cc2c0631431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505833
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825445}

https://chromium.googlesource.com/openscreen.git/+log/9abc1e30cfe5..1030c88a4bb8

2020-11-09 mfoltz@chromium.org [Open Screen] Fix two unitialized reads dicovered by MSAN.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1143946
Tbr: jophba@chromium.org
Change-Id: I0d26a74f836cf24b1b60eaf6d607e6a42d1b91db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526606Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825444}

This completes the H265Decoder by adding picture output flags, picture
order counts, ref pic list calculations and DPB management operations.

The unit tests were updated for this and a fuzzer was also added for
the decoder.

BUG=chromium:1141237,b:153111783
TEST=media_unittests, media_h265_decoder_fuzzer

Change-Id: Ieaa1da24d1e93ea017e1d5d68e67e07596347879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521113
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825443}

Change-Id: Ia023f30e7ebc952da99e0390082d61fb5174da18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521448Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#825442}

Bug: None
Change-Id: Ie57dec47c4467bbdaa44ad0bc38d27b1d55fbb6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526484
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825441}

In some cases a crash is happening when building the BVC view hierarchy
(see the linked bug); this is due to UIKit throwing an exception when
a constraint is created between views that aren't in the same view tree.

This CL just adds an explicit CHECK for the views that were triggering
this crash, so that we can get more information about the state of these
views when this occurs.

Bug: 1136765
Change-Id: I9d9c0431663aaa26df38bac1b66c476938320d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510213
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825440}

This is a reland of ddb531f7

There is a fix in media_session_service.cc to allow the tests to pass
when ash-chrome is not running.

Original change's description:
> [Media Session] Fix for Lacros
>
> At the moment in Lacros there are two instances of the
> Media Session Service (MSS) one hosted in ash-chrome and
> the other in lacros-chrome. This means that sessions in
> either browser process cannot see sessions from the other.
>
> This changes it so when a client asks for lacros-chrome
> MSS instead of providing a locally hosted MSS it binds
> the MSS in ash-chrome.
>
> BUG=1140215
>
> Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825016}

Bug: 1140215
Change-Id: I64834d9be778998b42bf3447444a6955265215ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825439}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.
This CL was uploaded by git cl split.

R=msramek@chromium.org

Change-Id: I118ba2a88ecbbbe731ff98061c4e11c6255abcb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525764
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825438}

Previously, rtcLogTransfer and webrtcIceSdpRestartAction were appended
to the host capability set in me2me_desktop_environment.cc and
it2me_desktop_environment.cc, but not in desktop_session_proxy.cc. The
latter omission prevented the associated functionality from working with
me2me on Windows hosts. Rather than setting the capabilities in yet
another location, this change moves setting them to client_session.cc,
which applies to all hosts, and is also where the associated
functionality is hooked up.

Change-Id: Ib534a52016b30382f40e6cbbee0c7376b684514d
Bug: 1147147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525239
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825437}

This change adds setup for a client-driven experiment that buckets
users on First Run into 3 groups, two experiment and one control.

This reland removes the setup in Create() so that the final
hookup can be landed separately.

Bug: 1138603, 1146408
Change-Id: I0f3c73c11a07a966cf7ba7cae7bc7feaa85daad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523247
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825436}

This fixes a few different issues with our HLG support:
- Windows was missing the DXGI define for HLG.
- Windows was not excluding HLG content from the brightness slider.
- HLG AV1 was not decoding to P010 where available.

To avoid having HLG content scaled by the brightness slider the
unused |f| parameter in the skcms_TransferFunction for HLG is
used to store the SDR white level. Skia will need to be updated
to use this scaling factor to fix HLG based HDR images.

gfx::ColorTransform has been updated to use the SDR white level
information in its HLG transforms.

Bug: 1144260
Test: Manual + updated unittests.
Change-Id: Iedd5d4b1ae0e67de685300306384e8a4e6edf086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511269
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825435}

This change reduces the latency between when a byte is received and when
it is available to script by configuring the COMMTIMEOUTS structure so
that ReadFile() return immediately rather than either waiting for the
buffer to be full or a timeout to be exceeded.

The previous timeout of 1ms was insufficient because on Windows the
minimum timing interval is frequently 16ms and so this introduced a
sizable amount of latency.

Bug: 1142799
Change-Id: Ie02cb64162dcf7ee178ab9dfcca614d63f79c13e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522196
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: James Hollyer <jameshollyer@chromium.org>
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825434}

Bug: 1129654
Change-Id: Ie2092143272e93ac9e06a7fc9ae29b4c2f98ad36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523068Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825433}

Remove FrameTreeNodeIdRegistry which is no longer needed now that networking callbacks are on the UI thread.

Change-Id: Ic66af3c207262aac8b955cb15a2f4a4922e0d898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524281
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825432}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011090600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/E4D0gMpEOK-9ZjBkcQ2WWgNdHFGpHjbbbc5Y1U0IVywC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/172781941
Tbr: media-app@grotations.appspotmail.com
Change-Id: I4e3581447c592897a9c3ca81d41970c9ffe5230e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525862Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825431}

All the histograms with expiry date of M85 are removed, along with the
corresponding code.

Bug: 1088659
Change-Id: I49af6e8a30ae2ed688a36d34d74eb8c817c4e78d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519726Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825430}

Created a skeleton for the Long Screenshots service. This will eventually
be used to call Freeze-Dried Tabs and generate the bitmaps needed for the
screenshot.

Bug: 1142520
Change-Id: Ia9e9ff5cc79d316ea6048e127c83f70a55c54996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518090Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825429}

Adds several unit tests for the ReportSchedulerIOS class. The test cases
ensure an enterprise report is triggered at the correct times, that the
report can be generated successfully, and that error handling is done
correctly, including retrying.

Bug: 1114853
Change-Id: I8e1ca4019067b40b9df40b0cb008983dec4bd9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517620
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825428}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I5aba8ef4c7e7ffe29b8840a0828c2d4d0cdec74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525745Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825427}

The context menu will only show when the content forward entry point is
enabled and will eventually be used to allow the user to enable/disable
holding space item previews in the tray.

This CL adds and shows the context menu but does not wire it up to
perform its intended action. That will be done in the next CL.

Bug: 1142572
Change-Id: Ic81bf57b84467d28757b311e73aeacf0eef401b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523905Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#825426}

Second CL in a series that introduces the Tab Groups extension API.

This CL adds the implementation and tests for all Tab Groups API functions except for Move, which was complex enough to split out.

It does not include events yet.

Skipping translation screenshots because there isn't a good way to bring up the permissions prompt that I can see. This might be easier to circle back on once the API is out there and at least one extension that uses it exists.

Bug: 1106846
Change-Id: I56b9f24ac7323676073855977c381449f49300d1
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419971Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825425}

The ActiveMatch may be null when make a FindRequest with options that kWrapAround is
false, while the active_rect in |FindRequestManager| will not update when it is
empty then we will show a incorrect tickmark(active_rect of last FindRequest)
on Android. so We should reset the active_rect in |FindRequestManager| when there
is a new FindRequest.

Bug: 1141374

Change-Id: Ieac210a2b72f4f92649e68e1b2e2969fd707dbf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491726Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825424}

The previous code used to activate all existing keyboard layouts one
by one, then retrieve activated keyboard layout name and compare it
to US keyboard layout identifier.  The comparison failed since on
modern Windows keyboard layout name includes keyboard device identifier
(like Dvorak keyboard, etc) in the high word and this caused the last
checked keyboard layout to be left active. That layout is rarely
a US layout, which caused character to virtual key conversion API
::VkKeyScan() to fail on ASCII character keys.

The new code uses LoadKeyboardLayout() API that loads and activates
the specified keyboard layout (US English) or leaves system default
language of the system, if US English layout does not exist.

Bug: 783703
Change-Id: I2cdc1d4984131e455d30a16dbbd9c66c209e686e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521836
Commit-Queue: Shengfa Lin <shengfa@google.com>
Reviewed-by: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#825423}

Nearby Connections invokes ::OnEndpointLost() and ::OnEndpointFound()
back-to-back. Without this change, these back-to-back calls cause a
crash in Mojo's message passing logic, within the Nearby utility
process.

Bug: 1145818
Change-Id: Iee297ccb4aadebb71072d6155a1eb6f7ddd63cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523738
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#825422}

This is the parent the system uses when creating ClassLoaders, so it
makes sense to match that:
https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/app/ApplicationLoaders.java

Startup time improvements:
8% on android-go: https://pinpoint-dot-chromeperf.appspot.com/job/10079579520000
9% on Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/16c9aec6520000

3.4% improvement in first contentful paint: https://pinpoint-dot-chromeperf.appspot.com/job/13b83f01520000

Bug: 1146438
Change-Id: I157fb0d69ac8e2e9a4f14887d6530d02e2748090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521936
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825421}

Previously, any time an AXObject updated its list of children it would
compute the set of owned nodes due to aria-owns. This could result in
"stealing" a node that was previously the child of a different parent
and edge cases or bugs in the tree serializer (because it would encounter
the same node twice with different parents).

With this new patch, when we encounter a node that might need to
change its list of owned children (either due to the aria-owns
attribute changing or due to an id previously referenced by aria-owns
appearing), the update is queued until later, and then all updates are
processed together as part of the kInAccessibility lifecycle phase.

During serialization, the aria-owned relationships are thus kept consistent
and these problematic scenarios are avoided.

All existing aria-owns tests pass and one new regression test is added.
One aria-owns test has different expectations because the tree serializer
no longer encounters reparenting; this is a good thing!

Bug: 1143572, 11397833
Change-Id: If5ded18c76eac3ad5c4f9125c8649a4bcd888628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516258
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/master@{#825420}

In LocationBarLayout#onFinishNativeInitialization,
LocationBarPhone#setShowIconsWhenUrlFocused() is called to update the
|mFirstVisibleFocusedView| from UrlBar to StatusView. This means the
LocationBarPhone doesn't populate extra fade animation in
populateFadeAnimations(). However, when Instant Start is enabled, the
ToolbarPhone#triggerUrlFocusAnimation() will populate the URL focusing
animation before the LocationBarPhone is initialized. Thus,
unnecessary animation is created and results in the missing of page
info icon. To fix it, ToolbarPhone#triggerUrlFocusAnimation() will early
exit before native initialization.

Bug: 1137973
Change-Id: I5ce8031df2d0d618495e34cf8badc779e5d639dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521199
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825419}

This CL adds a Finch feature to show a "Suspicious site" Safety Tip
when there is a Safe Browsing delayed warning, i.e. when a page is
known to be malicious but Chrome is delaying the Safe Browsing warning
until user interaction.

This will allow us to measure 2 things:
- How a Safety Tip influences user behavior on known-bad sites
- How omnibox UI treatments influence user behavior when there is
  something (a Safety Tip) drawing their attention to the omnibox

This is implemented by checking if a delayed warning is present (and
the relevant Finch feature is enabled) inside
ReputationService::GetReputationStatusWithEngagedSites().

There's a bit of trickiness with the Finch features. Delayed warning
Safety Tips are controlled with their own separate Finch feature, so
that they can be controlled independently of the regular Safety Tips
feature. This is so that we can have simultaneous experiments where
one enables regular Safety Tips and another enables delayed warning
Safety Tips. (We aren't allowed to run multiple simultaneous
experiments that both enable the same feature.) Running simultaneous
experiments like this could mean that we end up with some users in
both experiments, but this should be rare, and even rarer still that a
user encounters both different types of Safety Tips (regular and
delayed warnings), so this shouldn't affect our metrics.

For convenience, I've reused the suspicious sites Safety Tips variant
-- both the UI and the SafetyTipStatus -- rather than introduce a new
type of Safety Tip. This seemed okay to me because we're not really
actively using/studying the suspicious site variant, so I figured we
can reuse it for this purpose. This does mean that we'll want to make
sure to turn off any existing Finch config for the suspicious site
Safety Tip before we run delayed warnings Safety Tip experiments.

Bug: 1146471
Change-Id: Ie98a12d0f95b1e4313493697d218385edb58212a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523674Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825418}

Use the chrome_orderfile_config config for libwebviewchromium (as is
already done for the WebView-only variants of libmonochrome) so that we
get the same benefit from orderfile optimisation in this build variant.

Bug: 1101454
Change-Id: I7accacb50b988065060517e7ec67eba9107a03b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486120Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825417}

https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..0bec1380d03d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Id50eb4b541244f3f593636d301571731cadb999d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525847Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825416}

Re-enable SinkAPI-integration on blink_web_tests.
A patch was made in https://crrev.com/c/2519885, and sample swarming
tasks show that blink_web_tests with the SinkAPI integration ran
acceptably fast enough, compared to it without the integration..

R=bsheedy@chromium.org, chanli@chromium.org,dpranke@google.com
CC=robertma@chromium.org,bpastene@chromium.org,nodir@chromium.org

Bug: 1141606
Change-Id: Ibb45d081f8d2fd869f2632da066fb461c641b21f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523747Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825415}

It seems to be flaky.

TBR=marq@chromium.org

BUG=1146303

Change-Id: Ibaa9ea626a6179af72a1b98d5660f990b3390f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526608Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825414}

NearbyConnectionsManagerImpl holds a raw ptr to the PayloadTracker and
it was not being cleaned up in all cases when the PayloadTracker was
destroyed.

Fixed: 1145726
Change-Id: I62321c6f9316b4af504d2db01dfa55c871d4c0fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523917
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825413}

Previously the Privacy Budget project added a tool to generate a list of
APIs along with enough information to keep track of which ones have been
marked with `HighEntropy`. This CL replaces that tool with one which
captures a bit more detail about APIs.

Bug: 1144960
Change-Id: I281b713839bf22e38d1963a54290f891dcd624ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515283Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Alex Turner <alexmt@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825412}

Also add render test.

Bug: 1146983
Change-Id: I3c411741e9043ff780708bed3a49e07b4a197453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526443
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825411}