- 29 Jun, 2018 40 commits
-
-
Morten Stenshorne authored
Change-Id: I0220951586c580689caa4a5a1b9c0451e83c5069 Reviewed-on: https://chromium-review.googlesource.com/1118177 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#571633}
-
Xiaocheng Hu authored
When parent and child inline elements have different font metrics, they may have different vertical locations and/or heights, in which case we should preserve the parent box fragment, since we can't reconstruct the parent rect as a simple union of its child rects. This patch fixes failures due to such incorrect reconstruction. Note: this is a sibling patch of crrev.com/c/1108509, where we preserved inline box fragment if there are atomic inline children. Note 2: legacy handles different font metrics case with ComputeItemTopHeight in layout_inline.cc, which looks hacky and reduces code readability. Hence, we don't replicate it to NG. Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7d99e01afd0842b03163c16d0ab57bc0ef9fcc4c Reviewed-on: https://chromium-review.googlesource.com/1117716 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571632}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7ec4a3ef. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20357 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=kereliuk No-Export: true Change-Id: Ica3db82437f23f0a92da020e108d652b9e42b09e Reviewed-on: https://chromium-review.googlesource.com/1120854 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571631}
-
Xiaocheng Hu authored
NG Hit test code currently uses variable names with unclear meanings, e.g. |accumulated_offset|, |adjusted_location|, ...., like legacy. This patch changes them into clear terms like |physical_offset|, and adds comments for clarification. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c189b7e7001db8abb66241500b97d5df0c9c5b0 Reviewed-on: https://chromium-review.googlesource.com/1121052 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c91fe3ab1c5d..184d408b646b git log c91fe3ab1c5d..184d408b646b --date=short --no-merges --format='%ad %ae %s' 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-29 ruiqimao@google.com skeletal animation support added to API and software backend 2018-06-29 mtklein@chromium.org update and skip accepts check in lexers 2018-06-29 brianosman@google.com Update ImGui to v1.62 (June 22, 2018) 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-29 mtklein@google.com Revert "GrTessellator: handle three consecutive collinear edges." 2018-06-29 enne@chromium.org Fix chrome memory dump crashes using out of process strike caches 2018-06-29 senorblanco@chromium.org GrTessellator: handle three consecutive collinear edges. 2018-06-29 fmalita@chromium.org [skottie] Fix 'subtract' masks 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@184d408b646b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851409.,chromium:851409. TBR=jcgregorio@chromium.org Change-Id: I6c4ed70c86826c5e2077314c243d352d238a02bb Reviewed-on: https://chromium-review.googlesource.com/1121049Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571629}
-
Scott Graham authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/aec56e26079f..0dd5c6f980d2 $ git log aec56e260..0dd5c6f98 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 scottmg Revert "Remove libcpp_is_static" 2018-06-29 scottmg Re-add .gitignore for GN 2018-06-28 thomasanderson Remove libcpp_is_static Created with: roll-dep src/buildtools TBR: dpranke@chromium.org Bug: 858852, v8:7900 Change-Id: Ie887a2a54932703505369516ca42bf44c19242db Reviewed-on: https://chromium-review.googlesource.com/1121046Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#571628}
-
liberato@chromium.org authored
This is a reland of 7baa2dc1 Original change's description: > Convert various gpu video decoders to use AbstractTexture. > > Previously, VDAVideoDecoder, MCVD and D3D11VideoDecoder used > the validating GLES decoder's TextureRef (possibly indirectly, via > GLES2DecoderHelper and CommandBufferHelper) to retain textures. > > This CL moves them all over to use AbstractTexture, in preparation > for supporting the passthrough GLES decoder. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I13985223443b8e0897c1508f052d0f35d77746fe > Reviewed-on: https://chromium-review.googlesource.com/1091649 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571223} Change-Id: I69b842f2c08cbac9e9a1dfa12ea08133fff56c75 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1120470Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#571627}
-
Charlie Reis authored
We should track down the cause, but the intent of the restriction is to prevent web processes from committing extension URLs, so make an exception for now. BUG=840857 Change-Id: I5259f870140896400eb076b870981750a9ff73cd Reviewed-on: https://chromium-review.googlesource.com/1120840 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571626}
-
Alex Moshchuk authored
After r550769, cross-process postMessages are scheduled with PostTask, so that the actual postMessage IPC goes out on next iteration of the event loop. This is problematic when postMessage is executed from an unload handler that is triggered on a local-to-remote frame swap in RenderFrameImpl::OnSwapOut: the SwapOut ACK ends up being sent before any postMessage IPCs, and if this was the last active frame in the process, the browser process, upon receiving the SwapOut ACK, might destroy proxies that a postMessage was targeting. To prevent this, schedule the SwapOut ACK to ensure that it gets sent after any postMessage IPCs. Bug: 857274 Change-Id: I9e7339c0abc409fd201e7f73927e871c0f0d3b95 Reviewed-on: https://chromium-review.googlesource.com/1119391Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#571625}
-
Tessa Nijssen authored
Currently, the SuggestedTextTouchBarController generates text suggestions based only text being selected and doesn't take any surrounding text into account. The goal is to generate text suggestions from all the text present in the textfield and the current cursor position, which results in behavior more similar to Safari's text suggestions. First, WebContents::DidChangeTextSelection() and WebContentsObserver::DidChangeTextSelection() were modified to pass in the whole text in the textfield and the current selection range instead of the selected text. The method requestSuggestionsForText: was modified to requestSuggestionsForText:inRange: so that it may receive the full text in the textfield along with the range of the current selection. The WebContentsTextObserver was edited to also observe when a webpage finishes loading. This way, the controller can check whether the cursor is in a textfield before the text selection changes. This is necessary for websites in which a textfield is autofocused. This currently does not account for text that may be in the autofocused textfield, which will be addressed in a later CL. The browser tests for SuggestedTextTouchBarController were updated to reflect the new behavior. TouchBarTest now only checks if a touch bar is created based on whether or not a textfield is focused, as that is the only condition required for the creation of a touch bar. Text selection test now passes a range to -webContentsTextSelectionChanged: and tests that the range is stored properly afterwards. Unnecessary asserts were removed from both tests. The way that tests access the SuggestedTextTouchBarController was also modified to reduce the amount of memory used and make the code cleaner. Now, tests access one global controller rather than creating a new one for every test. Bug: 717553 Change-Id: Ia9a62a1b802976cbc76e2243d60d0a41cd1844cd Reviewed-on: https://chromium-review.googlesource.com/1119363Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#571624}
-
Alexander Semashko authored
This is a prerequisite for switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner. This CL is split out from https://crrev.com/c/982612. This CL was uploaded by git cl split. R=avi@chromium.org Bug: 668707 Change-Id: I890f55395c05eebbe390b1401dea3a0f4d21b19c Reviewed-on: https://chromium-review.googlesource.com/1120495Reviewed-by:
-
Yuly Novikov authored
Bug: 839893 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I04433ae8f98448817a86f882fa70342c055a4633 Reviewed-on: https://chromium-review.googlesource.com/1121039Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571622}
-
chrome://safe-browsingDaniel Rubery authored
Rename "resued_password_type" to "reused_password_type". Render: https://screenshot.googleplex.com/rRa1W6cEQqr Bug: 84935, 857503 Change-Id: I13a2724548ce317788b49eb48e7ec345b98385eb Reviewed-on: https://chromium-review.googlesource.com/1120872Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#571621}
-
Alexander Semashko authored
This is a prerequisite for switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner. This CL is split out from https://crrev.com/c/982612. This CL was uploaded by git cl split. R=dpapad@chromium.org Bug: 668707 Change-Id: I723a927eadbb422cff9165e159bfcb72412f6c5a Reviewed-on: https://chromium-review.googlesource.com/1120499Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#571620}
-
Alexander Semashko authored
This is a prerequisite for switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner. This CL is split out from https://crrev.com/c/982612. This CL was uploaded by git cl split. R=bsep@chromium.org Bug: 668707 Change-Id: I5e19527ac309235112faed7a250bf344c2376242 Reviewed-on: https://chromium-review.googlesource.com/1120498Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#571619}
-
Ned Nguyen authored
THis would help prevent issues like https://chromium-review.googlesource.com/c/chromium/src/+/1107213 Bug: 713357 Change-Id: Id43c20d5c232120232faf9568b5691721ccdbe47 Reviewed-on: https://chromium-review.googlesource.com/1107302 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#571618}
-
Brandon Wylie authored
Bug: 858943 Change-Id: Ibb5847c879db96157ead688ec38720140ea16216 Reviewed-on: https://chromium-review.googlesource.com/1121051Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571617}
-
Nick Burris authored
Per discussion at the bottom of go/cct-extensions-chrome, we want to list extension IDs even if we can't get their name. This string format makes this more friendly than just showing an extension ID. Bug: 853339 Change-Id: Ib58ce929077a36effe73eaa63fdf59197db8eb33 Reviewed-on: https://chromium-review.googlesource.com/1120163Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Nick Burris <nburris@google.com> Cr-Commit-Position: refs/heads/master@{#571616}
-
Oriol Brufau authored
These properties provide the author with the ability to control borders through logical, rather than physical, direction and dimension mappings. The patch only adds 'border-block-start', 'border-block-end', 'border-inline-start' and 'border-inline-end'. The other flow-relative border shorthands will be implemented behind a flag in another patch. Intent to Implement and Ship: CSS flow-relative margins, paddings and borders https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc Spec: https://drafts.csswg.org/css-logical/#border-shorthands BUG=850000 TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html The test still has some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: If186e1bd9826a24bce2d7ca5a4a58b0051cd5ece Reviewed-on: https://chromium-review.googlesource.com/1117185 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#571615}
-
Xianzhu Wang authored
Previously raster invalidations for changed display items were generated by PaintController during painting and recorded in PaintChunksAndRasterInvalidations. Now RasterInvalidator checks for changed paint chunks first, and if a paint chunk is not fully invalidated, call DisplayItemRasterInvalidator:: Generate() to generate raster invalidations for changed display items in the chunk. Some other changes are needed to achieve that: - We no longer need to save raster invalidations for display items along with paint artifact; - Let RasterInvalidator own the previous paint artifact shared with PaintController) so that DisplayItemRasterInvalidator can compare old and new display items; - Some updates of client and display item status previously done by PaintController::CommitNewDisplayItems() are now done after RasterInvalidator::Generate() in PaintController::FinishCycle(). Bug: 843606 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I06a9845aa10974252ea0590d91b32a81444684ae Reviewed-on: https://chromium-review.googlesource.com/1104885 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571614}
-
Sky Malice authored
Also fixed lint errors in modified files. Bug: 714018 Change-Id: I1a5347e8adab28edabebb386e5e5ef20b6ebe938 Reviewed-on: https://chromium-review.googlesource.com/1117374Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571613}
-
Peter Boström authored
This code was previously excluded as AvatarToolbarButton wasn't compiled on CrOS. When the code for badging Guest and Incognito on CrOS was put back an UpdateIcon() call was missed. Bug: chromium:834522 Change-Id: Iee5989cea8fcdbdea5fc3e03717d3476b68d8d11 Reviewed-on: https://chromium-review.googlesource.com/1120954 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic79f6d4a525d3b492f2e01e19fb08c77ba26db76 Reviewed-on: https://chromium-review.googlesource.com/1120847 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571611}
-
Yi Gu authored
TBR=bokan@chromium.org NOTRY=true Bug: 859169 Change-Id: I36dfab32c886820aa2a5416c9e4984b9fce0f110 Reviewed-on: https://chromium-review.googlesource.com/1121080Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571610}
-
Eric Roman authored
The approach taken is to generate the certificate chain from C++, and have any URLs point at an instance of the EmbeddedTestServer. Using live URLs for the certificate has the advantage of working for platform verifiers, for which we can't directly mock network responses. Bug: 845652 Change-Id: Id38df93b81b4380256dbc11e9a46345c37c99c90 Reviewed-on: https://chromium-review.googlesource.com/1093736 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#571609}
-
Xiaocheng Hu authored
In LayoutNGMixin::NodeAtPoint(), parameter |accumulated_offset| satisfies that, |accumulated_offset + Location()| equals the physical offset of the current LayoutBox in the paint layer, regardless of writing mode or whether the box was placed by NG or legacy. This patches fixes the physical offset calculation utilizing the above invariant. It also renames variable |adjusted_location| into |physical_offset| to be more accurate. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I73311ad17c56cf1f300e627966904fac3430a5d9 Reviewed-on: https://chromium-review.googlesource.com/1117881 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571608}
-
Peter Kasting authored
Bug: 855729, 856667, 846430 Change-Id: Id2c9da22f671c94ffce1995477cab0899217ea2b Reviewed-on: https://chromium-review.googlesource.com/1119538 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Katie D authored
Also refactors a common helper class into test_utils. Bug: 840576 Change-Id: Ia6ca2d6af641864ef1a508f6121f9aa1cd523117 Reviewed-on: https://chromium-review.googlesource.com/1106999 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#571606}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a19649b86b3d..a4dec94a1aa3 git log a19649b86b3d..a4dec94a1aa3 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 iannucci@chromium.org Add download_archive to gitiles module. 2018-06-29 sergiyb@chromium.org Prune VirtualEnv's python from environment before running GN Created with: gclient setdep -r src/third_party/depot_tools@a4dec94a1aa3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790650,chromium:793687 TBR=agable@chromium.org Change-Id: I5d633dd5be22cb2f5ab1ea4de1d6a9c7332359d2 Reviewed-on: https://chromium-review.googlesource.com/1120946Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571605}
-
Scott Chen authored
Changing tabindex=-1 for a readonly field that is not intended to be focused. Screen-readers can still navigate to it, so it will still read the value if there's any. This essentially turns the input into a <div> that may contain text, except you can drag to the right to see more text if the value is very long and overflows. Bug: 856994 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id210c48c7b63182bd6369d5bc1c87c72742cb193 Reviewed-on: https://chromium-review.googlesource.com/1117310Reviewed-by:
-
Orin Jaworski authored
Omnibox entity suggestions with two lines of text will layout as before, but now if the second line description is absent, the primary content text line will be vertically centered. This CL is identical to 1118788 but with const string moved from anonymous namespace to within function using it. Bug: 856703 Change-Id: Ib3b7127b3bc91b7d1caa175e49da45dc7f299f13 Reviewed-on: https://chromium-review.googlesource.com/1119225Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#571603}
-
Min Qin authored
The newly created in-progress download can get removed by user. In this case, DownloadItem::OnDownloadUpdated() is never called, and DownloadDBCache will never be informed of the removal. This causes DownloadDBCache to store the download info forever. This CL fixes that behavior by allowing DownloadDBCache to listen to all the events once the DownloadItem is created. BUG=842245 Change-Id: I560071a32ec376ae2c6ebe8f72f62a9527bb3362 Reviewed-on: https://chromium-review.googlesource.com/1119504 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571602}
-
Jochen Eisinger authored
BUG=809433,857494 R=blundell@chromium.org,khorimoto@chromium.org Change-Id: I934a03314db1d998eb64adb443d1c2f1eac3cdb3 Reviewed-on: https://chromium-review.googlesource.com/1113180Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571601}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a29426142dd..deee55b3d522 git log 7a29426142dd..deee55b3d522 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 xz4215@gmail.com Calculate all audio samples in AudioMixerCalculateEnergy. 2018-06-29 kwiberg@webrtc.org Turn rtc::{Make,Wrap}Unique into aliases for their Abseil counterparts 2018-06-29 terelius@webrtc.org Revert "Unit test for case where the number of active and configured spatial" Created with: gclient setdep -r src/third_party/webrtc@deee55b3d522 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd9adc6d6de3e6c4e87fb06067437cb139d922c9 Reviewed-on: https://chromium-review.googlesource.com/1120877Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571600}
-
Fady Samuel authored
This test appears to be running fine locally now. I suspect the hang was caused by the incorrect flag being checked that was fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1119191 Bug: 855920, 672962 Change-Id: Ic9b27c80b3070011e5a06c3ba9153a7d464108e4 Reviewed-on: https://chromium-review.googlesource.com/1120147Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#571599}
-
Stefan Zager authored
BUG=823365 R=skobes@chromium.org,pdr@chromium.org Change-Id: I7b47fe3b3ac33b93c9b1a8fc118b154169d48c3a Reviewed-on: https://chromium-review.googlesource.com/1119770Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
-
Yi Gu authored
TBR=wez@chromium.org NOTRY=true Bug: 859151 Change-Id: I5ed4767890dc5da367564a393521f24c0fcf3e3c Reviewed-on: https://chromium-review.googlesource.com/1121040Reviewed-by:
-
Stefan Zager authored
Miscellaneous fixes to tests that still used LocalFrameView as a ScrollableArea. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I10e5a2d6c3519a127cb315ffee80d5bfe05dfaca Reviewed-on: https://chromium-review.googlesource.com/1119769Reviewed-by:
-
Bill Orr authored
Devices are converted over to XrRuntime. Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibd50a6eb6b5e971ceba260dc46852157222b3228 Reviewed-on: https://chromium-review.googlesource.com/1093386 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#571595}
-
wutao authored
This cl fixes a logic in OnBlur in MdTab. If it is not kHighlight, the focus ring should be cleared. Bug: 858951 Test: manual. Change-Id: I0799ad506ce71e1a77de6be0332523cffad5959d Reviewed-on: https://chromium-review.googlesource.com/1120682Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571594}
-
