- 06 Nov, 2020 40 commits
-
-
Xing Liu authored
Adds an observer method to notify update for reading list backend. Bug: 1139133 Change-Id: Ic5483e075086d48334a9e347125048b5699c2560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519151Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825086}
-
Ossama Mahmoud authored
Currently, in the fingerprint enrollment flow we instruct the users to place their fingers either on the power button or on the fingerprint sensor without specifying the exact location of the fingerprint sensor In this CL, the aria_labels are updated to provide the users with the exact location of the fingerprint sensor on their devices. Bug: 1146413 Change-Id: Ibbf8bb23485380a0be17fbe29f03c3f69df2bb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523323 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825085}
-
Michael Checo authored
- Provides "customSort" function to scanning select elements that use the select behavior. "customSort" should cover all custom sorting needs by allowing callers to provide their own comparison function and an optional conversion function that can be used to sort on any field. Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I8bed8c9b2c70f066ac219fcd2c10f17063c9489d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518237 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825084}
-
Becca Hughes authored
It is not used anymore since the test refactor. Change-Id: Ic8a5d95665f15f5d3498e4c29d8ffd7af6d82c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481684 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#825083}
-
Gabriel Charette authored
The trace event will be called "ThreadController active" and be in the "base" tracing category. It will be activated for each active nested loop ThreadController is involved in (i.e. all loops but purely native nested loops -- undetectable). The implementation uses a stack of active run-levels (replacing some existing run-levels counters). This is is simpler than the alternatives as the amount of conditions to enter/exit a run-level are too many to hope to get manual accounting right: Enter: - DoWork() coming from Run() - DoWork() coming from native HandleWorkMessage - BeforeDoInternalWork() coming from Run() or native as well - DoIdleWork coming from a native nested loop (this one is surprising but happens on Mac because the |idle_work_source_| gets invoked first when the |work_source_| isn't signaled and a native nested loop starts..!) Exit: - DoIdleWork() - Quit() (was it already idle or not?) - Exit nested loop (was it already idle or not?) - Exit native task (was there a native nested loop within that native task that we need to "end" now?) Two tricky cases: Nested native task : Native task => native nested loop => native task vs Subsequent native tasks: Native task A (returns), Native task B BeforeDoInternalWork() was refactored as a scoped object because we need to be able to observe when a native task is done to capture Native Task => Nested native loop => End native task (needs to end the native loop, we aren't otherwise notified about it). We need to capture begin/end to be able to differentiate nested native tasks from subsequent native tasks (e.g. in a nested RunLoop without application tasks). The stack-based approach + scoped native work handles all of these cases across both ThreadController impls. R=altimin@chromium.org, fdoray@chromium.org and regular runtime. Example trace @ goto.google.com/oasrn Test: Locally with startup trace, nested loops (tab drag-out-of-window), Bug: 899897, 1074019 Change-Id: I68831ce92a66da8b91a523d931846262182b5de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226216 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825082}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e9cf1a8e1bd..31623e15a8a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I288055f3d4bd7752ac44c4848a68c66545f3e85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825081}
-
Jesse Schettler authored
Update the string for the color mode dropdown label to match the UI spec. Bug: 1059779 Change-Id: Ia5d2e97e12b7913387e7400fe4816bef8a2802bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522900 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Theresa Wellington authored
This test was only failing on tablets, so conditionally disable to retain some coverage. TBR=jinsukkim@chromium.org Bug: 1145195 Change-Id: I12cd015f6c370b177402b6f2f30d00f22dda362a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522903Reviewed-by:
-
Jesse Schettler authored
Add a new ScanJobObserver to receive updates for in-progress scan jobs. The observer is implemented by and passed from the scan app to the browser in calls to ScanService::StartScan(). Bug: 1059779 Change-Id: Ic9e73d688f7639cf8a892e8f5d269840d1b981c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508435 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
John Delaney authored
This web feature's enum was marked obsolete on https://crrev.com/c/2518106, but the corresponding mojo entry was not updated causing the following presubmit warning to trigger: ** Presubmit Warnings ** FeatureObserver enum has been updated and the UMA mapping needs to be regenerated. Please run update_use_counter_feature_enum.py in src/tools/metrics/histograms/ to update the mapping. Change-Id: I6b5aaa40b3c2f5da293bcd54f8cb65fdc222ec9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522960Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825077}
-
Theresa Wellington authored
Disable this test on M emulator due to flakiness TBR=siashah@chromium.org Bug: 1146477 Change-Id: If8bc27db6b1ff252a782657da11199da53d67612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523558Reviewed-by:
-
Roland Bock authored
Returning an optional struct which is only filled in case the call is successful does not require an extra bool to indicate success. The change removes said bool. This is a documentation-only change. Change-Id: If7406703e0cbd91a77c590383ea3430978d1c9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523174Reviewed-by:
-
rbpotter authored
The scenario the test is checking is very uncommon (requires PDF printer to be disabled, and no printers connected). Flakes are likely related to the new temporary dom-if added around the user manager. Disable the test for now, until the timing issue can be resolved or the dom-if can be removed. Bug: 1146513 Change-Id: I613557e4fe877e0f4bb2fff5c160a65692cc0eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523248 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#825074}
-
Thomas Lukaszewicz authored
This CL adds support for the feedback button on non ChromeOS desktop platforms Windows, Mac and Linux. See below for details on new feedback bucket. https://docs.google.com/document/d/1vepB7t_cYatX_-jNkVbkv49WSVPCk80ueHlg7oW6TIA/edit Bug: 1099917 Change-Id: I795ac19fe9e4fb5b8655c721ca9bf62b9728f992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523489Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#825073}
-
Krzysztof Olczyk authored
Add [Stable] to: * mojo_base.mojom.File * mojo_base.mojom.ProcessId * mojo_base.mojom.UnguessableToken These are fundamental types that are unlikely to require any non-compatible changes. Making them stable is required for their use in stable versioned interfaces. Change-Id: I6f21e248dc995f790024e86ae5afe312d51b584c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521117 Auto-Submit: Krzysztof Olczyk <kolczyk@vewd.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/31623e15a8a0..7abf802320ca 2020-11-06 primiano@google.com Merge "native-heap-profiler.md: fix Target processes anchor" 2020-11-06 treehugger-gerrit@google.com Merge "metrics: Tweak RAILMode interpretation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd6d33382491fa36d5f85db432438bd0476ed9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522965Reviewed-by:
-
Taylor Bergquist authored
Previously, with tab scrolling on and stacked tabs both on, the tabstrip was being put into the ScrollView, but stacked tabs never let the tabstrip width grow beyond the available width, so it never became scrollable. Now, tab scrolling prevents stacked tabs layout from being enabled. Bug: 1145746 Change-Id: I1e2196138566e3998a59639baeb6dfe9e3742065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522509Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#825070}
-
Filip Gorski authored
Bug: 1075602 Change-Id: I4f053a11ad6dcb564e9fa766daa3abd30de516cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522924Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#825069}
-
Sam Maier authored
Change-Id: I1285b1d76184bec795025a4157a5770275a8300f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523438 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#825068}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/91bb7506bd20..b674f8a27725 2020-11-06 qyearsley@chromium.org Edit depot_tools recipe_modules docstrings for consistency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I289c4420d798bca18b8916d4e1d53118ee113416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523375Reviewed-by:
-
Justin Donnelly authored
Bug: 1000444 Change-Id: I9a4261f503999c89e5f53da7110b15deecbe3cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523239 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825066}
-
Pavel Yatsuk authored
Icon resource id will be set from native feature code. ResourceMapper::MapToJavaDrawableId() will be used for mapping from native constant to Android resource id. This CL adds logic to porpagate the icon resource id to MessageBannerView. BUG=1123947 R=twellington@chromium.org Change-Id: I6c57d9ddd180f229bedffdae3c677fd2c8efc32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523472 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This class uses NearbyConnector to request a connection, then send/receive messages when the connection has been completed. Also removes some "const" qualifiers in WireMessage so that operator=() works correctly. Bug: 1106937 Change-Id: I8925a48a65e2706b694d585d551f790691a03071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512515 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#825064}
-
cfredric authored
This CL also adds a PrintTo(SchemefulSite, ostream) function overload, to allow tests to produce better error messages. Bug: 1143756 Change-Id: I90e594eb5c355deb28344f75c1aa5e91402b2044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519753 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#825063}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8b6cf636df1..4ed9d3498dcf 2020-11-06 vhau@google.com Modify gralloc0 implementation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I805f368d9e4922bd94f9acfa1b8a42361709e4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522608Reviewed-by:
-
Reilly Grant authored
This change simplifies feature detection for developers by only exposing the BarcodeDetector interface on platforms where it is possible for BarcodeDetector.getSupportedFormats() to return a non-empty list. Bug: 1137825 Change-Id: Ib52b6aef476decec48b1696509d44135f2b92caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508448 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#825061}
-
Akihiro Ota authored
UXR reported that users were confused by the automatic reading behavior for tutorial lessons that allowed them to move freely. This is because they would hear the lesson read automatically, but hear the same content again when navigating. Instead of reading the entire lesson, we now give a hint for navigating when these types of lessons are shown. Fixed: 1142041 AX-Relnotes: N/A Change-Id: I35ccb209d7ad542df965d99b92b2e3921abe38b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519038Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#825060}
-
Theresa Wellington authored
TBR=sandromaggi@google.com Bug: 1146555 Change-Id: Id356193a13606dc956e98e4af8dbaf1a1a6f8a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523557Reviewed-by:
-
Jimmy Gong authored
Phonehub will disconnect upon a power suspend state and reconnect when suspend is done. Bug: 1139415, 1106937 Test: chromeos_components_unittest Change-Id: I12e58c47eb2c6c75204ede6160181305f3939b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520416 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825058}
-
Chong Gu authored
Bug: 1080853 Change-Id: Ia0e24f70cfc2a3a0d4e2ddf7a18c939cfeb5a13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523475 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825057}
-
Yulun Wu authored
Spec: https://www.figma.com/file/rQFGy3iAMfNdDnydTGkvHr/Style-%7C-Semantic-color-system-surface-theming?node-id=522%3A28 Bug: 1134432 Change-Id: I92ba9d50bdef74d1bff52db34019f7ca7f58ca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508363Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825056}
-
ssid authored
Reduces one of the hot spots in early startup. Change-Id: I0fbf412a14cf1e31bbfe601d523fb8169fb73a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523241 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0512ce9c848a0e0924bf26649d42740a3c18a783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522897Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#825054}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I2b1ebe5bbc25ac716cb7b44c469d9f7dd880ffc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503320Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825053}
-
Kramer Ge authored
When exiting picture-in-picture view, the associated wl_surface is not destroyed, but attaches a nil wl_buffer. When restarting picture-in-picture mode, skia_output_device_buffer_queue does not know it has to reschedule the background image, resulting in picture-in-picture being unresponsive. Save the background buffer and re-attach it in wayland_window s.t. the buffer queue does not need to schedule/damage background every frame. Change-Id: I882e73cecd083d56e360ba61662db9eae566d199 Bug: 1142825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519607 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#825052}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ccc9dd2835f5..434681c2378b 2020-11-06 rohpavone@chromium.org Reland "[Telemetry] Adds telemetry support to Fuchsia for memory benchmarks." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I6ebf03df325982f3e89400bd78b4639d74716b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521215Reviewed-by:
-
Aleks Totic authored
Move table-specific node to NGTableNode. This is good for code health: * ng_block_node header no longer includes table-specific headers, and compiles faster. * it is easier for developers to find out where table-specific methods are. Bug: 958381 Change-Id: I975e59aabbbbcd06892a746a918825da4336a6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522113 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#825050}
-
Martin Kreichgauer authored
Also switch the default in WPTs back to CTAP 2.0 and have LargeBlob tests enable 2.1 explicitly, since they were relying on it. Bug: 1117630 Change-Id: Ib3e0fbfe1c1a5532f2246b98b3abfd6f2fcc7d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509030 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#825049}
-
John Delaney authored
What: New UseCounter to tracker % of page loads that have an ad. Why: This metric is useful for knowing how many pageloads are applicable for ad interventions, such as the heavy ad intervention. Bug: 1139434 Change-Id: I8e6e1b9b6aa60afcd4d58c331c00a3b9bcf6523e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480967 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#825048}
-
Kyle Horimoto authored
This function allows clients to set a NearbyConnector to be used when attempting a Nearby Connection. Within the SecureChannel implementation, connection requests are rejected with the newly-added MISSING_NEARBY_CONNECTOR failure reason if a connection is requested when a NearbyConnector has not been set. A future CL will use the provided NearbyConnector when initiating a connection. On the client side, NearbyConnectorFactory now sets the NearbyConnector instance when it is created. PhoneHubManagerFactory adds a dependency on NearbyConnectorFactory to ensure that the NearbyConnector is set before Phone Hub starts up. Bug: 1106937 Change-Id: I6f25aa9be817c0bb15c19045d2c4e9494b674368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513748 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#825047}
-
