- 31 Jul, 2019 40 commits
-
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLAreaElement> and DynamicTo<HTMLAreaElement> as new downcast helper. 2. Use IsA<HTMLAreaElement>(element) in place of IsHTMLAreaElement(element) Bug: 891908 Change-Id: I519218d8b82066eb21edd362c2c230ab31b3ae91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725541Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#682604}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6980c4e0aef8..a13c7744f154 git log 6980c4e0aef8..a13c7744f154 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e6092f3bc901..324bdfed0692 (6 commits) Created with: gclient setdep -r src/third_party/skia@a13c7744f154 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Ieab2de11abf058c0e95097a823e949d36da17365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682603}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I57bb051a81907515ccfcc8d9e938a343203fc9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725538Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#682602}
-
Joel Hockey authored
Since files_xf_elements.html doesn't contain any reference to chrome://resources or other part which would need to be rewritten, there is no need to modify it for UI tests. Change-Id: I1b3fa6cb97d436b865eebf8939ac795a8bd966a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725133 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#682601}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLAudioElement> and DynamicTo<HTMLAudioElement> as new downcast helper. 2. Use IsA<HTMLAudioElement>(element) in place of IsHTMLAudioElement(element) Bug: 891908 Change-Id: I787075e911bdbd7371b1827a017f5dcdc1abf0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726430Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46e8be7b481d..aa48b9720588 Created with: gclient setdep -r src-internal@aa48b9720588 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I000318a6c0ab44d6dfe425b7dc0213326b485393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727757Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682599}
-
Bartek Nowierski authored
They are old and superseded by Memory.Renderer.* & Memory.Experimental.Renderer2.* Bug: 916761 Change-Id: Ie99a6e37d5f7fe016f71cc713562c468efaf2bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722536Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#682598}
-
Takashi Sakamoto authored
This reverts commit 6720f8ec. Reason for revert: suspect causing content_browsertests failure on Windows bots: E.g. https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/39015 deterministic failures AXPlatformNodeTextRangeProviderWinBrowserTest.OutOfProcessIFrameTraversal AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitFormat AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitParagraph AXPlatformNodeTextRangeProviderWinBrowserTest.EntireMarkupSuccessiveMoveByWord AXPlatformNodeTextRangeProviderWinBrowserTest.IFrameTraversal AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitFormatAllFormats AXPlatformNodeTextRangeProviderWinBrowserTest.MoveEndpointByUnitParagraphCollapseTrailingLineBreakingObjects AXPlatformNodeTextRangeProviderWinBrowserTest.ExpandToEnclosingFormat AXPlatformNodeTextRangeProviderWinBrowserTest.GetBoundingRectangles https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906448482404732176/+/steps/content_browsertests_on_Windows-10-15063/0/logs/Deterministic_failure:_AXPlatformNodeTextRangeProviderWinBrowserTest.EntireMarkupSuccessiveMoveByWord__status_FAILURE_/0 [ RUN ] AXPlatformNodeTextRangeProviderWinBrowserTest.EntireMarkupSuccessiveMoveByWord ... ../../content/browser/accessibility/ax_platform_node_textrangeprovider_win_browsertest.cc(360): error: Expected: (nullptr) != (text_range), actual: (nullptr) vs 8-byte object <00-00 00-00 00-00 00-00> Original change's description: > Add trailing whitespace and punctuation to UIA Move(TextUnit_Word) > > 1. Changing the behavior of `ITextRangeProvider` methods `Move` and > `ExpandToEnclosingUnit` with `TextUnit_Word`. > > Previously we relied on both, word start and end offsets, computed > from Blink, but such approach didn't matched every AT's expectations. > > Updated logic makes use of start offsets only, this forces movement > by word to include whitespace and punctuation characters before the > next word start; the only special case being the last word, whose end > offset will be located after the last character on the document. > > 2. Removing `AXPosition`'s methods `AsLeafTextPositionBeforeCharacter` > and `AsLeafTextPositionAfterCharacter` in favor of refactoring > `AsPositionBeforeCharacter` and `AsPositionAfterCharacter`. > > This is a follow-up optimization since the former methods called > their `AsLeafTextPosition` equivalents, but reverted the result if > the position was not adjusted to another anchor. > > 3. Adding a new browser test to cover some AT's expectations. > > Rebaselining `AXPlatformNodeTextRangeProviderWin` unit and browser > tests to account for the new word movement behavior. > > Bug: 928948 > Change-Id: Iab689fde2a2ea973e86f7cdb10c1c22cf1af1704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718064 > Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682564} TBR=nektar@chromium.org,kschmi@microsoft.com,ethavar@microsoft.com Change-Id: I855ecf6dbb5769c591d35bd6134164e5aeec37b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728130Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#682597}
-
Shuo-Peng Liao authored
For some platform specific format, e.g. V4L2_PIX_FMT_MT21C, it does not have corresponding VideoPixelFormat mapping. As the format is only used between video decoder accelerator (VDA) and image processor, we shall add an optional field, fourcc, in PortConfig so that VDA can tell image processor which input format it should be used. BUG=985683, b:132589320 TEST=Run VDA_unittest and media_unittest on elm Change-Id: I1362a6805b64bab03db254010e7b62b0cc4fd68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724269 Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#682596}
-
Eric Willigers authored
The file handling tests are now run with both WebAppBrowserController and HostedAppBrowserController. Bug: 966290 Change-Id: I3ec4abf6883dfb132a294c3707439607e3cb6233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727849 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#682595}
-
Takashi Sakamoto authored
E.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/40811 Unexpected Failures: * fast/borders/border-radius-mask-canvas-all.html * fast/borders/border-radius-mask-canvas-border.html * fast/borders/border-radius-mask-canvas-padding.html * fast/borders/border-radius-mask-canvas-with-mask.html * fast/borders/border-radius-mask-canvas-with-shadow.html * fast/borders/border-radius-mask-canvas.html * fast/borders/border-radius-mask-video-ratio.html * fast/borders/border-radius-mask-video-shadow.html * fast/borders/border-radius-mask-video.html Bug: 979422 Change-Id: I77650a186cf4dcb029b58b0d839aab07ee40688a TBR: chrishtr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727096Reviewed-by:
-
Koji Ishii authored
This patch adds: NGFragmentItem NGFragmentItems NGFragmentItemsBuilder Still in early phase, not used in the regular code path, but this patch shows the ownership of these objects. |NGFragmentItems| is owned by |NGPhysicalBoxFragment|. |NGFragmentItemsBuilder| is owned by |NGBoxFragmentBuilder|, instantiated when needed. |NGInlineLayoutAlgorithm| can refer it through |NGInlineChildLayoutContext|. Bug: 982194 Change-Id: I236b5523b0d98b715ab62089c48ce17ddea91b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666832 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#682593}
-
Yuki Shiino authored
As a preparation to introduce identity operator to ExtendedAttributes, refactors ExtendedAttributes giving it immutability. Bug: 839389 Change-Id: Ia985e9fc09ec0647ea819fe373a2482bd5473dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724434 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
We actually do same tasks in |merge_partial_interfaces| and |merge_interface_mixins|, so this CL factors out |merge_partials| defined in |_merge_partial_interfaces|. Bug: 839389 Change-Id: I1382d05df60fd8ac833fd1645e3ebcec62dcbf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720121Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#682591}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e08ca23ec9fe..8e967dfdfc37 git log e08ca23ec9fe..8e967dfdfc37 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 steveanton@webrtc.org Use unique_ptr in JsepCandidateCollection Created with: gclient setdep -r src/third_party/webrtc@8e967dfdfc37 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iaa4528ab7e409def7515e5d54e746de9a447d5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727755Reviewed-by:
-
Kuo Jen Wei authored
Bug: 988898 Change-Id: Ib8808652383e7f1680d2f14cf4ca202686c3e471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727524 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#682589}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 98ccf8be. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I36665cc1d0dc262bd34e8b73f826dfd9546712ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727211Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682588}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b38939a8..62077a99 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia83880bae5183bd09fc7875053df6278f7ce931b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726993Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682587}
-
Leo Zhang authored
Replace unused build flag with sanity test flag, which is used to enable sanity tests. Bug: 837156 Change-Id: I66d5dae07cf02b0e8a8e139358f3f0d427acd90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723571 Auto-Submit: Leo Zhang <googleo@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#682586}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9c76515a890..46e8be7b481d Created with: gclient setdep -r src-internal@46e8be7b481d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie8dafce76a01376ac75681ef0d68d573ea6776e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727754Reviewed-by:
-
Ryan Sleevi authored
On Windows and macOS, when a CRLSet is used to revoke a certificate, the chain originally constructed by the OS verifier is made available, as well as having the hashes for that chain computed in CertVerifyResult.public_key_hashes. For Linux/ChromeOS, due to a bug in NSS's libpkix's memoization of certificate paths during the chain building process, combined with how Chromium implemented CRLSets using an application-verifier callback, the constructed chain was forgotten and not placed into the CertVerifyResult. Align the platforms to ensure that the CertVerifyResult is populated with the (revoked) chain information. This can be used with the ssl_error_assistant in //chrome to provide additional error messaging for entries in CRLSets. Bug: 989220 Change-Id: If4bf73d3548b0dec60980070ea7fa4c28edb0f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727446 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#682584}
-
Yuki Shiino authored
Stops (ab)use of __str__. Bug: 839389 Change-Id: I428b5fe95b93c4abe8285896c1116bbf5dd01844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724410Reviewed-by:
-
John Abd-El-Malek authored
Bug: 934009, 967698 Change-Id: I9cb7023ed6899cd035fda7424b07989c3fdb599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727521 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f04f1f93a70f..eea340047eca git log f04f1f93a70f..eea340047eca --date=short --no-merges --format='%ad %ae %s' 2019-07-31 johnkslang@users.noreply.github.com Merge pull request #1859 from zoddicus/fixNoRTTIForWindows Created with: gclient setdep -r src/third_party/glslang/src@eea340047eca The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I4b4fc028971538265c46e6e4f03403883d4df51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727753Reviewed-by:
-
Dominic Battre authored
This CL introduces a Value::FindStringKey implementation that returns a mutable string which can be modified inline. This reduces the number of temporary copies needed for the LogBuffer. Bug: 928595 Change-Id: Ic09b0bd029805b983a888b691420a9d3b32f4ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724516 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#682580}
-
Kuo Jen Wei authored
This reverts commit 02ad8296. Reason for revert: Feature re-enabled on M78. Original change's description: > [CCA] Remove fps selection icon > > BUG: 976602 > TEST: On device with constant 30/60 fps capability, the icon is not > shown in video mode. > > Change-Id: I400144e25105a619ea3aff88ddfea0731d9128cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717502 > Auto-Submit: Kuo Jen Wei <inker@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Commit-Queue: Kuo Jen Wei <inker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680746} TBR=shik@chromium.org,shenghao@chromium.org,inker@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Icff3a1b6e7933374a9df8d05d185597d7de62fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727830 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#682579}
-
Noel Gordon authored
Austin continues to make valuable contributions to FilesApp. He has a very good grasp of the FilesApp code base, good testing focus, and is asked to review more changes given his knowledge of FilesApp. Time to make him an OWNER. No-try: true Bug: None Change-Id: Id7a55dda4034de8e4a4b6c1f2cf60e4648ffff5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726801Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#682578}
-
Nigel Tao authored
Also simplify the internal AppIsDefaultForExtensionService() function to pass the Profile directly, instead of passing an extensions::ExtensionService to get its Profile. AppIsDefault() was added here: https://codereview.chromium.org/118463002/diff/530001/chrome/browser/ui/app_list/app_list_syncable_service.cc At that point in time, we didn't have ExtensionPrefs::Get(profile), we used ExtensionService::extension_prefs(). But AppListSyncableServiceFactory (and the other constructor call sites) guarantees that the profile is the same: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc?type=cs&sq=package:chromium&g=0&l=50 Change-Id: Iea2be8ce14ffb08679fdb6bbbb74bee1b5fcf3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715969 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682577}
-
Hirokazu Honda authored
GAVEA formerly computes the mapped size of video frame and addresses of planes from format and coded size. We recently changed code in Android to use minigbm stack to allocate video frame buffer. It is infeasible to compute them only from format and coded size. We have to use offset and stride that is provided by Android. Bug: b:118544836 Test: CtsVideoTestCases and CtsMediaTestCases Change-Id: Ic2dca4c3fcbc9116ef6890c3802c1ac8afb97a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676941 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#682576}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I1b15bdb8e1303276c1c3fe22722c92f500e04714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700925Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#682575}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I286a9626dba28aae156556c48d02838309a58d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727655Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682574}
-
Antonio Gomes authored
This is the first of 'n' CLs that dismantle both MediaStreamCenter classes in content and blink. It is part of phase 4.7 in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ As a first step, this CL starts by embedding the blink::MediaStreamCenter methods used by other blink/renderer/platform/mediastream classes into their respective callsides. This steps makes further work easier, since the remaining users of the blink::MediaStreamCenter APIs are in blink/renderer/modules/. The methods being moved here are: - MediaStreamCenter::SetContentHint - MediaStreamCenter::GetSourceSettings BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I75a8487c4fca0838f49b92311f5d80ec4e929435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726569 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#682573}
-
Glenn Hartmann authored
TBR=loonybear@chromium.org Change-Id: Iaa0e65037f861eb7c78bccfff44204cde5de77ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727523Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#682572}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5ae853a163e7..e08ca23ec9fe git log 5ae853a163e7..e08ca23ec9fe --date=short --no-merges --format='%ad %ae %s' 2019-07-30 bryanf@microsoft.com Include overlapping dialogs when capturing a window via screen cropping Created with: gclient setdep -r src/third_party/webrtc@e08ca23ec9fe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I391e2320570c9e18b049870a4f3889b9cc414e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727716Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ffff6c5fcc92..7264bc930f9b git log ffff6c5fcc92..7264bc930f9b --date=short --no-merges --format='%ad %ae %s' 2019-07-30 tsepez@chromium.org Remove last circular include between fpdfapi/page and fpdfapi/render. Created with: gclient setdep -r src/third_party/pdfium@7264bc930f9b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I8593e5c9c6aa203808270fd0043e1f715204f124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727589Reviewed-by:
-
Alexey Baskakov authored
Now we can distinguish kUserInstallDeclined case. Bug: 789381 Change-Id: I3ae8a8c04a9615940e8aa7aaa3e024c0f90e2be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725531 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#682569}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b7089ee5024..b9c76515a890 Created with: gclient setdep -r src-internal@b9c76515a890 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4055a01f0da1be4b691b9973f9937bd4d39dcc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727715Reviewed-by:
-
Rob Schonberger authored
Do so by creating a Factory for PalmDetectionFilter, controlled by flags and feature parameters, called PalmDetectionFilterFactory. Thoroughly unit test this factory. Add an instance of SharedPalmDetectionFilterState to InputDeviceFactoryEvdev, and pipe it through to instances of TouchEventConverterEvdev so that all PalmDetectionFilter get the same shared instance, as intended. Bug: 982118 Change-Id: I5878bc126a9e4bf809b9d5869520bef814aace8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716000 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682567}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79a5354d..b38939a8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I555a583e41c9ffe8b866e75e16473be1b8a7cae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726860Reviewed-by:
-
Rob Schonberger authored
Add tests for these metrics. Bug: 982118 Change-Id: I0626727ea968e3fbd970bfa32df0a35d2ae5d285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720117 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
