GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4333faa..992f946

TBR=

Review URL: https://codereview.chromium.org/1102223003

Cr-Commit-Position: refs/heads/master@{#327019}

Revert of ozone: Add ability to set clinet capabilities which we will need for atomic (patchset #2 id:20001 of https://codereview.chromium.org/1100803004/)

Reason for revert:
Speculative revert - Linux ChromiumOS Ozone Tests is broken.
http://goo.gl/vykWsG

Original issue's description:
> ozone: Add ability to set client capabilities which we will need for atomic
>
> Committed: https://crrev.com/e5983b7fde9d576bd514490106564e2238eb0713
> Cr-Commit-Position: refs/heads/master@{#326860}

TBR=dnicoara@chromium.org,achaulk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1104013002

Cr-Commit-Position: refs/heads/master@{#327018}

When these tests fail, they time out after a long preriod of time instead of stopping when there's an error.

The specific error case I was hitting was that my camera didn't support the highest resolution. The error is to be expected given my configuration, but there's no need to wait for a timeout.

R=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1061473002

Cr-Commit-Position: refs/heads/master@{#327017}

Revert of ozone: Add sync flag for atomic commit (patchset #2 id:20001 of https://codereview.chromium.org/1099713005/)

Reason for revert:
Speculative revert - Linux ChromiumOS Ozone Tests is broken.
http://goo.gl/vykWsG

Related to https://codereview.chromium.org/1100803004/

Original issue's description:
> ozone: Add sync flag for atomic commit and page flip event handling
>
> Committed: https://crrev.com/f7553583492a8ea9a54d75cd6b2d3dd83c94512c
> Cr-Commit-Position: refs/heads/master@{#326863}

TBR=dnicoara@chromium.org,achaulk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1098093005

Cr-Commit-Position: refs/heads/master@{#327016}

Removed LOAD_FROM_CACHE_IF_OFFLINE flag and related test cases.

BUG=426442

Review URL: https://codereview.chromium.org/1080673004

Cr-Commit-Position: refs/heads/master@{#327015}

Remove dependency on //chrome/browser/history/history_utils.h by
injecting the CanAddURLToHistory function (via a base::Callback)
into TopSitesImpl.

BUG=479174

Review URL: https://codereview.chromium.org/1100763002

Cr-Commit-Position: refs/heads/master@{#327014}

The --auto-select-desktop-capture-source flag is quite useful for
testing since tools like Selenium generally can't interact with dialogs
we pop up in the browser. It is implemented for aura-using platforms
like Linux, CrOS and Windows and this patch adds it for Mac too.

BUG=475372

Review URL: https://codereview.chromium.org/1084913002

Cr-Commit-Position: refs/heads/master@{#327013}

Revert of Evict Service Worker when reading it from disk cache fails. (patchset #2 id:20001 of https://codereview.chromium.org/1098083003/)

Reason for revert:
Broke Win 8 Aura content_browsertests

[ RUN      ] ServiceWorkerVersionBrowserTest.ReadResourceFailure
...
[2420:2792:0426/232049:1965296:FATAL:service_worker_registration.cc(44)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO). Must be called on Chrome_IOThread; actually called on Unknown Thread.
Backtrace:
	base::debug::StackTrace::StackTrace [0x07FB1081+33]
	logging::LogMessage::~LogMessage [0x07FFD9FF+63]
	content::ServiceWorkerRegistration::~ServiceWorkerRegistration [0x045639F5+293]
	content::ServiceWorkerRegistration::`scalar deleting destructor' [0x006A087A+26]
	base::RefCounted\u003Ccontent::ServiceWorkerRegistration>::Release [0x0372C3D2+114]
	scoped_refptr\u003Ccontent::ServiceWorkerRegistration>::Release [0x03D8F94E+14]

http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/29227/steps/content_browsertests/logs/ServiceWorkerVersionBrowserTest.ReadResourceFailure

Original issue's description:
> Evict Service Worker when reading it from disk cache fails.
>
> If reading the SW resources from the disk cache fails, we should evict
> the worker or else we will keep getting the same failure.
>
> This patch unsets the worker from the live registration, and then
> deletes the registration if the SW was the stored version.
>
> BUG=448003
>
> Committed: https://crrev.com/64e3ffb1c6b85c7d21e63afcbffe85c5a1112eb7
> Cr-Commit-Position: refs/heads/master@{#327000}

TBR=nhiroki@chromium.org,kinuko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448003

Review URL: https://codereview.chromium.org/1056913010

Cr-Commit-Position: refs/heads/master@{#327012}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5d23c38..1899651

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1102223002

Cr-Commit-Position: refs/heads/master@{#327011}

This ensures that the PDF title will be truncated with ellipses if it is
too long, rather than pushing out the other controls to the right. Also
URL decode the title to remove ugly encoded characters.

BUG=439114

Review URL: https://codereview.chromium.org/1090313003

Cr-Commit-Position: refs/heads/master@{#327010}

TBR=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/1103113002

Cr-Commit-Position: refs/heads/master@{#327009}

Same as NativeAppWindowCocoa. This behavior is only for app windows.

BUG=459877

Review URL: https://codereview.chromium.org/1105663004

Cr-Commit-Position: refs/heads/master@{#327008}

BUG=459882

Review URL: https://codereview.chromium.org/1109693003

Cr-Commit-Position: refs/heads/master@{#327007}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3071d11..4333faa

TBR=

Review URL: https://codereview.chromium.org/1099813008

Cr-Commit-Position: refs/heads/master@{#327006}

Revert of Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted (patchset #1 id:1 of https://codereview.chromium.org/1093923004/)

Reason for revert:
It still times out:
http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/builds/615/steps/service_worker.service_worker/logs/stdio

Original issue's description:
> Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted
>
> ServiceWorkerPerfTest was failing on Android One, due to timeouts of
> VideoRecorder.IsStarted(). This patch attempts to fix this by increasing
> the timeout from 5 seconds to 10 seconds, and re-enable the test.
>
> BUG=469841
> TEST=tools/perf/run_benchmark --browser=trybot-all-android service_worker.service_worker
>
> Committed: https://crrev.com/42ce01867659573b37b46df12a3db18ba26674b9
> Cr-Commit-Position: refs/heads/master@{#326820}

TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469841

Review URL: https://codereview.chromium.org/1099033005

Cr-Commit-Position: refs/heads/master@{#327005}

BUG=423248
TEST=out/Release/browser_tests --gtest_filter=WebUIResourceBrowserTest.ContextMenuHandlerTest

Review URL: https://codereview.chromium.org/647483006

Cr-Commit-Position: refs/heads/master@{#327004}

Let InMemoryURLIndex use SequencedTaskRunner instead of FILE thread to perform file tasks.
Post WritePrivateDataToCacheFileTask() in dtor.

BUG=480822

Review URL: https://codereview.chromium.org/1101253002

Cr-Commit-Position: refs/heads/master@{#327003}

White space only change from https://codereview.appspot.com/229420043

TBR=rmcilroy@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1102673008

Cr-Commit-Position: refs/heads/master@{#327002}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2f6785b..3071d11

TBR=

Review URL: https://codereview.chromium.org/1104953002

Cr-Commit-Position: refs/heads/master@{#327001}

If reading the SW resources from the disk cache fails, we should evict
the worker or else we will keep getting the same failure.

This patch unsets the worker from the live registration, and then
deletes the registration if the SW was the stored version.

BUG=448003

Review URL: https://codereview.chromium.org/1098083003

Cr-Commit-Position: refs/heads/master@{#327000}

This patch fixes the regression which is caused by the following CL.
https://chromium.googlesource.com/chromium/src/+/3315eb5fe7bcb9300995dae3326de2d2c5f3c44a

Since the Styx URLs are updated in that CL, we need to use DriveApiUrlGenerator::GenerateDownloadFileURL to create a download URL to pass a cast device.

BUG=477733
TEST=can cast a video

Review URL: https://codereview.chromium.org/1055403004

Cr-Commit-Position: refs/heads/master@{#326999}

BUG=

Review URL: https://codereview.chromium.org/1096203008

Cr-Commit-Position: refs/heads/master@{#326998}

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/1088903011

Cr-Commit-Position: refs/heads/master@{#326997}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9de7917..2f6785b

TBR=

Review URL: https://codereview.chromium.org/1066873004

Cr-Commit-Position: refs/heads/master@{#326996}

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/596/steps/compile/logs/stdio

..\..\base/win/shortcut.h(51,3) :  warning(clang): [chromium-style] Complex constructor has an inlined body.
ShortcutProperties() : icon_index(-1), dual_mode(false), options(0U) {}
                      ^
..\..\base/win/shortcut.h(32,1) :  warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
struct ShortcutProperties {
    ^
2 warnings generated.

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1100403003

Cr-Commit-Position: refs/heads/master@{#326995}

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/1077323003

Cr-Commit-Position: refs/heads/master@{#326994}

Now that we have added PrefRegistry registration functions that do not need to
accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is
redundant and we can remove it altogether.

Ran the following command:
for x in $(git ls-files | grep -E "\.(cc|h|mm)$") ; do perl -0777 -i -pe 's/,[ \n]*(user_prefs::)+PrefRegistrySyncable::UNSYNCABLE_PREF//igs' $x ; done && git cl format

There are still some occurences that need to be manually fixed.

BUG=476800

Review URL: https://codereview.chromium.org/1102733002

Cr-Commit-Position: refs/heads/master@{#326993}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8daf7c3..9de7917

TBR=

Review URL: https://codereview.chromium.org/1108743002

Cr-Commit-Position: refs/heads/master@{#326992}

This moves all pref registration functions from PrefRegistrySyncable
into PrefRegistrySimple and changes PrefRegistrySyncable to derive
from PrefRegistrySyncable. This is done to consolidate the registration
functions in a single place that can be used by syncable and unsyncable
prefs.

BUG=476800

Review URL: https://codereview.chromium.org/1095673003

Cr-Commit-Position: refs/heads/master@{#326991}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dccf813..8daf7c3

TBR=

Review URL: https://codereview.chromium.org/1083673006

Cr-Commit-Position: refs/heads/master@{#326990}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6682798..dccf813

TBR=

Review URL: https://codereview.chromium.org/1104863004

Cr-Commit-Position: refs/heads/master@{#326989}

Blink rebaselines for SK_SUPPORT_LEGACY_COLOR32_MATH have landed.

BUG=480013
TBR=reed@google.com,mtklein@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/1088083004

Cr-Commit-Position: refs/heads/master@{#326988}

BUG=466848

Review URL: https://codereview.chromium.org/1097083004

Cr-Commit-Position: refs/heads/master@{#326987}

BUG=480013
TBR=mtklein@google.com,reed@google.com

Review URL: https://codereview.chromium.org/1095513004

Cr-Commit-Position: refs/heads/master@{#326986}

  since browsing_data/ is now under components/

BUG=471287
Test=None, internal only change without visible side effects.

Review URL: https://codereview.chromium.org/1056793002

Cr-Commit-Position: refs/heads/master@{#326985}

renderer and test do not need to depend on it and
compositor_impl_android.cc does not use content_provider_in_process.h
either.

BUG=338338
R=avi@chromium.org

Review URL: https://codereview.chromium.org/1101403002

Cr-Commit-Position: refs/heads/master@{#326984}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/283b587..5d23c38

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1103973003

Cr-Commit-Position: refs/heads/master@{#326983}

BUG=

Review URL: https://codereview.chromium.org/1067583004

Cr-Commit-Position: refs/heads/master@{#326982}

It contains information of how the user closed the "Save password?" bubble in the past. Basing on this data two different algorithms are to be implemented so the bubble isn't so annoying for the users.

BUG=431739

Review URL: https://codereview.chromium.org/1083293004

Cr-Commit-Position: refs/heads/master@{#326981}

This CL uses the MockConnection for bump scrolling browser test.
This will make the test more resilient to network failures.

BUG=478331

Review URL: https://codereview.chromium.org/1086563005

Cr-Commit-Position: refs/heads/master@{#326980}