GitLab

It doesn't check that the integer version was actually added
to leveldb though, which is unfortunate.  It ensures that
opening a v0 database doesn't fail an assert, which is what
would happen if you opened an unmigrated database with code
that expects to find a stored integer version.

BUG=108223

Review URL: https://chromiumcodereview.appspot.com/10826159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125043
TEST=Manuall check a snapshot is sent in appropriate size.


Review URL: https://chromiumcodereview.appspot.com/10831186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150457 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a class of single client sync integration tests whose primary
purpose is to be run on the Chrome on iOS buildbots as part of cross platform
sync integration tests.

All tests in this class are disabled by default so that they don't run as part
of normal chromium buildbot runs. The DISABLED_ annotation will be overridden
when the tests are run on the Chrome on iOS buildbots.

TBR=thakis@chromium.org
BUG=b/6942067
TEST=Run cross platform tests on Chrome on iOS buildbots

Review URL: https://chromiumcodereview.appspot.com/10829227

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117168

Review URL: https://chromiumcodereview.appspot.com/9959079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141231
TEST=none
TRY=false


Review URL: https://chromiumcodereview.appspot.com/10854033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150454 0039d316-1c4b-4281-b951-d872f2087c98

so that ExtensionDispatcher knows what Extension is active, not just its ID.


BUG=139869


Review URL: https://chromiumcodereview.appspot.com/10824188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150453 0039d316-1c4b-4281-b951-d872f2087c98

notice's year.


Review URL: https://chromiumcodereview.appspot.com/10825231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150452 0039d316-1c4b-4281-b951-d872f2087c98

This change depends on http://codereview.chromium.org/10835047/ .

BUG=136816
TEST=try

Review URL: https://chromiumcodereview.appspot.com/10834097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150451 0039d316-1c4b-4281-b951-d872f2087c98

This broke Google Chrome Linux builders which are still looking for theme_resources_100_percent.pak.

BUG=139803
TEST=Chrome runs with ui and theme resources correctly loaded.

Review URL: https://chromiumcodereview.appspot.com/10825111

TBR=flackr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150450 0039d316-1c4b-4281-b951-d872f2087c98

AsyncPolicyLoader is freed via DeleteSoon() via the FILE thread, but in some tests it happens too late (after the BrowserProcessImpl destructor has been called).

TBR=oshima@chromium.org
BUG=141255

Review URL: https://chromiumcodereview.appspot.com/10830205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150449 0039d316-1c4b-4281-b951-d872f2087c98

In addition, RemoveEntry and RemoveChild now return void.

BUG=137725
TEST=unit tests.
Review URL: https://chromiumcodereview.appspot.com/10825218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150448 0039d316-1c4b-4281-b951-d872f2087c98

We use ulocdata_getPaperSize to get the preferred paper size for
a region.  The error handling for the call assumed that a value other
than U_ZERO_ERROR was an error.  This is incorrect.  The function sometimes
returns a warning (negative value).  When that happens, the error handling
code defaulted to 8.5x11 pages.

This CL changes the error handling to no longer treat a warning as an error.

BUG=140821
TEST=Set display language to English(UK).  Print a web page and choose to save as PDF.  Verify that the saved PDF is A4.


Review URL: https://chromiumcodereview.appspot.com/10834217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150447 0039d316-1c4b-4281-b951-d872f2087c98

Linux: Add more selective plugin blacklisting code. Blacklist a plugin that fails to check for SSE2 on platforms without SSE2 support.

BUG=140086
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10823132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150446 0039d316-1c4b-4281-b951-d872f2087c98

R=bauerb@chromium.org
BUG=139028


Review URL: https://chromiumcodereview.appspot.com/10821114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150445 0039d316-1c4b-4281-b951-d872f2087c98

This requires the --no-sandbox flag to work properly.

BUG=130508

Review URL: https://chromiumcodereview.appspot.com/10850005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132846
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10534174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150443 0039d316-1c4b-4281-b951-d872f2087c98

|phantom_widget_| used to be a scoped_ptr, and it used to .reset() itself here.
But it is a raw pointer now, so it needs to be null-checked.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10827205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150442 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150440 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10834210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150439 0039d316-1c4b-4281-b951-d872f2087c98

Upstreaming the chrome_browser_main_android and its immediate dependencies. This code is used to override the default chromium initialization with android specific initialization. Android uses custom MessageLoop.

BUG=138184
TEST=Compile unit_tests_apk target


Review URL: https://chromiumcodereview.appspot.com/10819003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150438 0039d316-1c4b-4281-b951-d872f2087c98

browser.app_panel_browser_frame_view.obj : error LNK2001: unresolved external symbol "public: virtual int __thiscall AppPanelBrowserFrameView::GetThemeBackgroundXInset(void)const " (?GetThemeBackgroundXInset@AppPanelBrowserFrameView@@UBEHXZ)
initial\chrome.dll : fatal error LNK1120: 1 unresolved externals
ninja: build stopped: subcommand failed.

See https://chromiumcodereview.appspot.com/10816004

Maybe only failing on component build? Not sure.

R=pkotwicz@chromium.org,sky@chromium.org
BUG=137090
TEST=

Review URL: https://chromiumcodereview.appspot.com/10832193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150437 0039d316-1c4b-4281-b951-d872f2087c98

Background: We plan to Add ReadDirectoryByPath() to GDataDirectoryService
and use the same ReadDirectoryCallback, and hide_hosted_documents  turned
out to be an obstacle. It's cleaner to check the setting in the caller,
where this setting matters anyway.

BUG=141147
TEST=confirm that the "show hosted documents" setting works as before

Review URL: https://chromiumcodereview.appspot.com/10836137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140964


Review URL: https://chromiumcodereview.appspot.com/10828199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132789, 132794
TEST=PyAuto CONTINUOUS suite


Review URL: https://chromiumcodereview.appspot.com/10830193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141184

Review URL: https://chromiumcodereview.appspot.com/10854032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=builds,manual

With this change, the IPC-based PPAPI proxy builds all code needed for 3d and OpenGL ES.
Review URL: https://chromiumcodereview.appspot.com/10837145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111465

Review URL: https://chromiumcodereview.appspot.com/10834214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140323
TEST=Chrome not crashing after opening and closing the website settings popup for an internal chrome page (e.g. chrome://settings)

Review URL: https://chromiumcodereview.appspot.com/10826185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6944
TEST=sbox_integration_tests
Review URL: https://chromiumcodereview.appspot.com/10831160

TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10831200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150429 0039d316-1c4b-4281-b951-d872f2087c98

There was a bug where X32 syscalls were included in x86_64_linux_syscalls.h.

Thankfully, the "#if defined" guard prevented those lines from actually
doing anything.

BUG=
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10826190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150427 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10810062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127323
TEST=New test


Review URL: https://chromiumcodereview.appspot.com/10825210

TBR=jianli@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Gab is not an OWNER.
TEST=Gab is an OWNER.


Review URL: https://chromiumcodereview.appspot.com/10855032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6944
TEST=sbox_integration_tests
Review URL: https://chromiumcodereview.appspot.com/10831160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150423 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10831199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112155

Review URL: https://chromiumcodereview.appspot.com/10825212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127323
TEST=New test


Review URL: https://chromiumcodereview.appspot.com/10825210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150420 0039d316-1c4b-4281-b951-d872f2087c98

This allows dead code stripping to be turned back on for the main executables
and for the NXArgc and NXArgv symbols to be stripped.

BUG=139902

Review URL: https://chromiumcodereview.appspot.com/10837149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135185

Review URL: https://chromiumcodereview.appspot.com/10827192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150416 0039d316-1c4b-4281-b951-d872f2087c98