- 26 Sep, 2017 40 commits
-
-
Takashi Toyoshima authored
Since I ensure that the assumption is correct, I will replace one existing SECURITY_CHECK with DCHECK as I planned. Bug: 768325 Change-Id: I1a653d8d3d3a7e62df537e9e4d3017798078a108 Reviewed-on: https://chromium-review.googlesource.com/681394Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#504294}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ccb28b4fd165..ae4cc909a3bb $ git log ccb28b4fd..ae4cc909a --date=short --no-merges --format='%ad %ae %s' 2017-09-25 dmazzoni Add metric for accessibility. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I50f86ee290e7cc9464f68c881d5f091f573b063a Reviewed-on: https://chromium-review.googlesource.com/683800 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504293}
-
Will Harris authored
These leaks could occur under certain conditions such as when a policy evaluation in the broker has denied access but the request has still been made from the target. The leaked data is only visible in the shared memory, and never passed to the caller. This CL also fixes an inconsistency in behavior between the Open and Create functions for file and registry keys. BUG=765846 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I8fabbb8431cd2205d18b8cbe9553efd482d9b40f Reviewed-on: https://chromium-review.googlesource.com/673714 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504292}
-
Kyle Horimoto authored
There are race conditions in Bluetooth which can cause errors when starting and stopping discovery sessions too close to one another. In the worst case, these issues can cause a crash. This CL rate-limits BLE advertisements and scans to at most one per 200ms. This reduces the possibility of race conditions in the kernel. Bug: 768523, 672263 Change-Id: I985aec16b6f9cd80c385ab9af199daff4fb50ced Reviewed-on: https://chromium-review.googlesource.com/683756Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#504291}
-
Khushal authored
The animation can be reset to start from the beginning in blink. Plumb this to cc to replicate this behaviour if image animations are being ticked by the compositor. This uses a counter sequence incremented on the main thread each time the animation is reset to act as a synchronization point, which is necessary since recordings can be cached and resued by blink. Bug: 735743 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ff6fe22b1c5179a1ea8ec893f5d239895a4d2a4 Reviewed-on: https://chromium-review.googlesource.com/664245 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504290}
-
Colin Blundell authored
https://codereview.chromium.org/2673443002 introduced a bug in the Identity extension API implementation: it assumed that there would be only one IdentityGetAuthToken instance that needed to listen for IdentityAPI shutdown at a given time, but in fact, there can be many. An example is if the user has multiple tabs open that each call the getAuthToken() function with interactive set to true, so that they end up hanging waiting for the user to authenticate. The result of this bug is that if the browser shuts down with multiple getAuthToken() calls active, only the last call will receive notice of IdentityAPI shutdown. Other calls can then end up calling back into Profile during its shutdown process, e.g. if they get notified by OAuth2TokenService as part of *its* shutdown process that it has failed their token requests. These calls can result in CHECKs (see crash reports linked from crbug.com/720073). This CL fixes the bug while maintaining the property that IdentityGetAuthToken does not require an interface dependence on IdentityAPI (i.e., the property that was the motivation of the original CL). To do so, it changes IdentityAPI to maintain a CallbackList that gets invoked on its shutdown. This CL also introduces a browsertest that fails without this change. Bug: 720073 Change-Id: I44daaa0c0bbc27e54da9ab826e256c70f3d5a2a8 Reviewed-on: https://chromium-review.googlesource.com/680974Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#504289}
-
Wei Li authored
Change windows sandbox policy to allow ppapi utility process to access font directory in file system. Also set pdf compositor service's sandboxing type as ppapi so it can access font system on various platforms. BUG=455764 Change-Id: I356ddfe57e172e90a6d6deaf4bcf6d39dc1b5b97 Reviewed-on: https://chromium-review.googlesource.com/682767Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#504288}
-
Xianzhu Wang authored
Bug: 637313 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icad7f9354b7cb92ddfe8caa5224e3ba2540f7440 Reviewed-on: https://chromium-review.googlesource.com/667756 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504287}
-
Lei Zhang authored
Change-Id: I2bbe2154f8be8e727b7adad8ff809ff1668c55df Reviewed-on: https://chromium-review.googlesource.com/683235 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#504286}
-
Rune Lillesveen authored
The comparison of ComputedStyle does not take additional flags into account. For instance, the AffectedBy* flags used for updating pseudo classes like :hover. We used to call SetStyleInternal, but this was removed because the previous comment said it was because of style sharing which is now removed. The display:contents case (768406) never worked because the code path for StoreNonLayoutObjectComputedStyle() was always skipped when computed style compared to be equal. Bug: 768406, 767832 Change-Id: Iac4708e3cd3a6451d99c1bb2bb69efb74289b8eb Reviewed-on: https://chromium-review.googlesource.com/681755Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#504285}
-
Walter Korman authored
Will be useful for folks working on font support in out-of-process raster. For more see: https: //docs.google.com/document/d/1vsJsk1zGSagxxBggd8j5G9u0rMzD1NTaQWgEbUabEvY/preview#heading=h.xzi2kl5b59mm Change-Id: I77797cb295495b9adcef1a620754d71882dee79f Reviewed-on: https://chromium-review.googlesource.com/683463 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#504284}
-
Andrew Grieve authored
Expected to save ~700kb of .text on Android Bug: 738155 Change-Id: I58886003c259a65cd2e66baa71e38bfa962a2b3d Reviewed-on: https://chromium-review.googlesource.com/682647 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#504283}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fb921410. With Chromium commits locally applied on WPT: 4d3c601c "Refactor wpt/2dcontext/drawing-images-to-the-canvas/ layout tests:" f493473b "[Media Router] Update Cast Presentation URL logic - tests only" 9d3055f4 "Moving URL bar fires visualViewport resize event" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2431 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes-1 tyoshino@chromium.org: external/wpt/navigation-timing TBR=qyearsley@chromium.org No-Export: true Change-Id: Ife6cf23dc57834a100f46260f97802664323c291 Reviewed-on: https://chromium-review.googlesource.com/683535 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504282}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/712fe73cafb8..6bba6de94461 $ git log 712fe73ca..6bba6de94 --date=short --no-merges --format='%ad %ae %s' 2017-09-25 angle-deps-roller Roll skia/third_party/externals/angle2/ f0fd87d82..457ded9b4 (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I5dc14c99d9e3bba55c85af29ef827052e8613542 Reviewed-on: https://chromium-review.googlesource.com/683676Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504281}
-
Matt Menke authored
This CL adds a way to set both of these using NetworkContextParams, and updates Chrome to set both through the new path for both the system and main profile URLRequestContexts. Bug: 715695 Change-Id: I514bf9ae6923f380bcf550046c9f0b0e9952f270 Reviewed-on: https://chromium-review.googlesource.com/629136 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#504280}
-
David Grogan authored
When an element is selected as scroll anchor, we need to get its bounding box. But when a table has unlaid out table parts, we DCHECK that its borders aren't being queried. When a table with unlaid out table parts is the scroll anchor, the DCHECK was triggered. The "fix" in this CL is to use the old border widths when scroll anchoring code is looking for an anchor. Bug: 746570 Change-Id: I424e3807c2ed7a7a20f02617e2e0586dba83e708 Reviewed-on: https://chromium-review.googlesource.com/679994Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504279}
-
Yafei Duan authored
Implementing the MarkPageAccessedTask which is responsible for updating the database entry when a page is loaded. Also added a utility method to get all pages for testing. Bug: 753595 Change-Id: I0f0ba0f150928b7e245eb357893067c6863d420f Reviewed-on: https://chromium-review.googlesource.com/677026 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#504278}
-
Hiroki Nakagawa authored
These tests were disabled by [1] because [2] introduced a stricter check for ServiceWorkerVersion::status_ (status_ == NEW) and failed them. We found this check is wrong because ServiceWorkerScriptURLLoader is also used for importScripts() that can be called during the Install event (status_ == INSTALLING). This CL makes ServiceWorkerScriptURLLoaderFactory determines whether to use ServiceWorkerScriptURLLoader more precisely, and changes the check in the ctor of ServiceWorkerScriptURLLoader based on that. This CL also corrects the timings to update the service worker status in the browser tests to avoid the check failure. [1] https://chromium-review.googlesource.com/c/664845/ [2] https://chromium-review.googlesource.com/c/662957/ Bug: 748415, 765064, 767916 Change-Id: Id7786510170129514058e6f5c5d4bd1860b4be1b Reviewed-on: https://chromium-review.googlesource.com/674143 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#504277}
-
Xida Chen authored
This is the follow-up CL after this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/667323 Bug: 725651 Change-Id: I083a826e12ec2ef2b7fa1f2132c66cc92eb282e8 Reviewed-on: https://chromium-review.googlesource.com/680060Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504276}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/852ba7672ce0..ccb28b4fd165 $ git log 852ba7672..ccb28b4fd --date=short --no-merges --format='%ad %ae %s' 2017-09-25 dtu [pinpoint] Retry requests on socket.error. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I6b45d07dd00452008afe6fe0f9f2f7bff30856f1 Reviewed-on: https://chromium-review.googlesource.com/683460 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504275}
-
Scott Chen authored
Bug: 760308 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0dac06f45fdfaff49c9376746a95b46b93ccbea1 Reviewed-on: https://chromium-review.googlesource.com/683250Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504274}
-
Kouhei Ueno authored
This CL also fixes propagate-nonce-inline-module.html, which was actually testing classic scripts to test inline module scripts. Bug: 711706 Change-Id: I4d7b16aed2710a6508dc3403518b320727eba504 Reviewed-on: https://chromium-review.googlesource.com/674844 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#504273}
-
Tetsui Ohkubo authored
Message center is required to not resize after returning to settings panel. Previously, the height was sometimes shrinking, while sometimes not, depending on event timing. TEST=manual BUG=767805 Change-Id: Ic1594f142f8dc9e4f88a69bfddd1f2598c2a0ab1 Reviewed-on: https://chromium-review.googlesource.com/681095Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#504272}
-
Jamie Madill authored
The command line flag "--one-frame-only" will force the ANGLE perf tests to stop execution after one iteration. This will help test correctness while giving a much faster run time. Currently they take about ten minutes on the bots, this should hopefully give a 10x improvement for correctness-only testing. Requires http://crrev.com/c/677306 to land first. BUG=725308,765321 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9bbbe3a2c3100fd4d43759382cd62ec2f45ab33b Reviewed-on: https://chromium-review.googlesource.com/677307Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#504271}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: Ieae97c173aa6c6cae95df4df484c4d6b660e4c85 Reviewed-on: https://chromium-review.googlesource.com/683515Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#504270}
-
Shuhei Takahashi authored
This change adds MetadataModel.setUseModificationByMeTime() to ask it to override modificationDate field in MetadataItem with modificationByMeDate. This function is called on changing the current directory, and set to true when Recent root is being opened. Bug: 758677 Test: Last modified column in Recent is replaced Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I838e7ab5b46d4a4962becea60a2225531ba67363 Reviewed-on: https://chromium-review.googlesource.com/676506Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#504269}
-
Shuhei Takahashi authored
Recent root is not watchable but there is no refresh button today. In order to refresh, the user needs to change the current directory to another file system, and then go back to Recent root, which is not awesome. This change lets Recent root to silently refresh when Files app window gets focus. Bug: 758622 Test: Manually test the contents refresh on focusing Files app window Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie36c8ec8885567f555d273c3b6d876450a8eb492 Reviewed-on: https://chromium-review.googlesource.com/680678Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#504268}
-
rbpotter authored
Print preview currently sends preview requests as soon as the user selects a printer instead of waiting for the backend to report the printer's capabilities first. It then sends more requests after the capabilities are reported. This results in superfluous requests and will make moving capabilities fetch to a utility process less useful. Eliminate these extra requests. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic700e0feb374f8289edc9515e347b2e679097199 Reviewed-on: https://chromium-review.googlesource.com/646500Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#504267}
-
Marc-Antoine Courteau authored
Video of the fix in action: https://drive.google.com/file/d/0B4g_WskzVRJdVUtMdjJqVlliQ0U/view?usp=sharing This is a third attempt at fixing this issue. The first one was reverted due to failures in ios_showcase_egtests on smaller devices. Those failures were caused by the fact that some elements were off-screen, and EarlGrey was unable to select them. The second one was also reverted due to failures on iPhone 5s with iOS 9.0. Bug: 767154 Change-Id: Ia5cb29dd719ab58311db9122ef7e41c0771200d2 Reviewed-on: https://chromium-review.googlesource.com/678020Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503771} Reviewed-on: https://chromium-review.googlesource.com/682395 Cr-Commit-Position: refs/heads/master@{#504266}
-
Lisa Suzuki authored
This CL is a 1st step of supporting "namespace" definition in WebIDL. In order to check if ASTs are made correctly, I made pattern matching tests. Bug: 727971 Change-Id: I033e9bab2623675f40a9b941cc53cdecef0c186d Reviewed-on: https://chromium-review.googlesource.com/676692Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Lisa Suzuki <lisabelle@google.com> Cr-Commit-Position: refs/heads/master@{#504265}
-
Christopher Cameron authored
This needs to be updated due to bt709 interpretation change in crbug.com/763260 Bug: 768608 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9321869000d10f79f82f9dd4ca778e6517ed7ef7 Reviewed-on: https://chromium-review.googlesource.com/683078Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#504264}
-
Steven Bennetts authored
This generalizes EAP support for Ethernet and WiMAX. Bug: 380937 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I39e5c92f648e35822a85e95d8cbd3c128d649258 Reviewed-on: https://chromium-review.googlesource.com/677131 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#504263}
-
Tommy Steimel authored
Bug: 698737 Change-Id: I954b7c6e2aa1b56a742a4a2787093fa413b5f47c Reviewed-on: https://chromium-review.googlesource.com/676202Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#504262}
-
Justin DeWitt authored
This will ensure that the notification is only shown if there actually is fresh content in the system. If not, we will not show the notification and stop scheduling the background task until there is fresh content. Bug: 701939 Change-Id: Ief7f659254e80faf08e94e752eb34d0c5bb8e6ab Reviewed-on: https://chromium-review.googlesource.com/682769 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#504261}
-
Kent Tamura authored
Only event_factory.cc and event_modules_factory.cc need to depend on each of event_*headers.h. So we don't need to generate header files, and can fold them into *.cc. Change-Id: I38b1c4a646045d66f8c4fbf49f12de93724c9ec0 Reviewed-on: https://chromium-review.googlesource.com/681094Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#504260}
-
Yuki Awano authored
- Add support for elements inside android notification via chrome.automation. ChromeVox. Bug: 763318 Test: Confirm that user can navigate elements on android notification by Change-Id: Iee057986596202f2e95c3db6b313cc21939e98bc Reviewed-on: https://chromium-review.googlesource.com/656751 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#504259}
-
Nathan Bruer authored
Per spec protocol should forward the response status code as an int instead of numbers. See: https://github.com/ChromeDevTools/devtools-protocol/issues/58 R=pfeldman BUG=767274 Change-Id: I450278a2889352d077373e7c1d2ea0d80367b7cd Reviewed-on: https://chromium-review.googlesource.com/676504 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504258}
-
Andrew Grieve authored
The rename will help to call out that multiple build targets exist on Android. Bug: 731186 Change-Id: I1dbe2ffe932b25ab8739f53c2cd05c2ee3d8b2b6 Reviewed-on: https://chromium-review.googlesource.com/682770 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#504257}
-
Stephen Martinis authored
Switches to new bots for the linux perf builder. Bug: 732463 Change-Id: Ied8d923448f40b8295ddfb2fde1adde481666075 Reviewed-on: https://chromium-review.googlesource.com/676725 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#504256}
-
Nico Weber authored
Bug: 756607 Change-Id: I78e1fdf2411c067efd5423987ab9812f14b93736 Reviewed-on: https://chromium-review.googlesource.com/680041Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#504255}
-