GitLab

The DCHECKs don't trigger in release, and in any case it's a bit rude to have
the renderer crash on a plugin that did the wrong thing, so send an error
instead.

BUG=None
TEST=Pepper Flash


Review URL: http://codereview.chromium.org/7628025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92231
TEST=Second remoting connection from the same browser works.

Review URL: http://codereview.chromium.org/7633036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19775,32624,89304,92571
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7648003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91620
TEST=Host doesn't crash when shutting down.

Review URL: http://codereview.chromium.org/7635005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96645 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17469
TEST=Click battery icon, confirm it meets spec

Review URL: http://codereview.chromium.org/7491083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96643 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96641 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tree green
Review URL: http://codereview.chromium.org/7637025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96640 0039d316-1c4b-4281-b951-d872f2087c98

Whitespace change: http://codereview.chromium.org/7633020

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7633030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96639 0039d316-1c4b-4281-b951-d872f2087c98

For a detailed description see part #1, http://codereview.chromium.org/6478005/

This CL fixes the bug fully on Linux. More platforms will follow.

BUG=61062
TEST=unit_tests, possibly more

Review URL: http://codereview.chromium.org/7628006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96638 0039d316-1c4b-4281-b951-d872f2087c98

This makes WebUILoginView not a drag-n-drop target as TabContents::ShouldAcceptDragAndDrop would return false now. Besides, WebUILoginView is popup in some sense.

BUG=chromium-os:18781
TEST=Verify crash no longer happens for chromium-os:18781.


Review URL: http://codereview.chromium.org/7640023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96636 0039d316-1c4b-4281-b951-d872f2087c98

On both Lucid and Natty, cups-config --libs includes cflags and other
unneeded output.  Parse the cups-config output to emit only the relevant
subsets of flags.

Review URL: http://codereview.chromium.org/7633022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96635 0039d316-1c4b-4281-b951-d872f2087c98

Now that pending preview requests are being canceled when a new request is issued, the event listeners of the printing controls should not check for |hasPendingPreviewRequest| before issuing new requests, instead they should immediately request a new preview so that the previous one is canceled.

Also all functions that are associated with a specific print request should get the requestID as a parameter, in order to ignore obsolete responses.

I found out that when the print preview tab is reloaded, responses from requests before the reload are reaching the ui code. If reloading the preview tab repeatedly all these request have id=0 and are not being ignored as they should. Therefore I changed the id of the initial request to have a random variable.

BUG=91556, 91769
TEST=See bug description

Review URL: http://codereview.chromium.org/7550022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96634 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91619
TEST=Set up a remoting sesssion and make sure it works.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96327

Review URL: http://codereview.chromium.org/7491070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96632 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7638002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96631 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7637026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92521
TEST=as in bug

Review URL: http://codereview.chromium.org/7639022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96629 0039d316-1c4b-4281-b951-d872f2087c98

1. set a proper minWidth on tileGrid, this is so that if you shrink the browser a lot you can still see the tiles (they don't start disappearing behind a white sheet on the right side)
2. fix coordinate calculation during drag destination calculation (this was already wrong but became more apparently so when I increased the margins).

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7461148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96628 0039d316-1c4b-4281-b951-d872f2087c98

with RESULT_CODE_MISSING_DATA.  We used to just CHECK() crash.

BUG=69194


Review URL: http://codereview.chromium.org/7610009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96627 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7639009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96625 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96624 0039d316-1c4b-4281-b951-d872f2087c98

Enable prefs.PrefsTest.testGeolocationPref on linux and mac, keeping test disabled for win as the test fails on win xp bot only

BUG=89000
TEST=NONE

Review URL: http://codereview.chromium.org/7516003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96623 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7640022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96621 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91737
R=mmenke@chromium.org,dtseng@chromium.org
TEST=browser_tests --gtest_filter=WebUIBrowserAsyncTest.*

Review URL: http://codereview.chromium.org/7576024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96620 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7637018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96619 0039d316-1c4b-4281-b951-d872f2087c98

https://bugs.webkit.org/show_bug.cgi?id=66037 upstream.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7637002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96618 0039d316-1c4b-4281-b951-d872f2087c98

Convenience methods for WindowedNotificationObserver.

R=phajdan.jr@chromium.org
BUG=various
TEST=none


Review URL: http://codereview.chromium.org/7489019

TBR=gbillock@chromium.org
Review URL: http://codereview.chromium.org/7633032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96617 0039d316-1c4b-4281-b951-d872f2087c98

R=apatrick@chromium.org
BUG=none
TEST=everything still compiles

Review URL: http://codereview.chromium.org/7634014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96616 0039d316-1c4b-4281-b951-d872f2087c98

Previously we'd crash (DCHECK in Debug, SEGV in Release) if the client (plugin)
requested more than 10 concurrent Decode()s, because that's how many input
buffers the OMX component would have.  Now we just queue extra Decode()s and
drain them as we get buffers back from the decoder.
Added test coverage.

BUG=none
TEST=ovdatest, gles2

Review URL: http://codereview.chromium.org/7461154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96615 0039d316-1c4b-4281-b951-d872f2087c98

So instead of:

base::Value::ValueType

We write a nice:

base::Value::Type

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7634018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96614 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96613 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: http://codereview.chromium.org/7640024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96612 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7587011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51716,92717
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7633028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68657
TEST=CookieMonsterTest.InitializeFromCookieMonster

Moving here from http://codereview.chromium.org/7541021/

TBR=rdsmith
TBR=zel

Review URL: http://codereview.chromium.org/7599025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96607 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a corner case bug in the HexStringToInt conversion function which caused the string "0x" to be treated as a valid hexadecimal number.
Although the parsed result was 0, the boolean flag returned indicated that the hex number was in proper format

The IteratorRangeToNumber class's Invoke function increments the string pointer by 2 if the string starts with "0x" or "0X" and the length is greater than *or equal* to 2
If the length of the string is 2, i.e "0x", after the pointer increment, the string would be empty and the function returns true as the parse result

Changed the condition from "greater than or equal to" to "greater than"

Added another test cases which now properly treats "0x" as an invalid hex string

Contributed by ali.akbar@gmail.com

BUG=92054

Review URL: http://codereview.chromium.org/7584031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17755
TEST=manual
Review URL: http://codereview.chromium.org/7635027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96604 0039d316-1c4b-4281-b951-d872f2087c98

Fixes the test break on ChromeOS.

TEST=none
BUG=none

modified:   chrome/browser/ui/panels/panel_browsertest.cc

Review URL: http://codereview.chromium.org/7629023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96603 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96601 0039d316-1c4b-4281-b951-d872f2087c98