- 09 Sep, 2020 40 commits
-
-
Andre Le authored
BUG=1106937,1126208 Change-Id: I7d54f5c4aeb9c6aa3243567e83dbd022e651c4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388168 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#805431}
-
Adithya Srinivasan authored
Bug: 1120501 Change-Id: Ica8546b86353d86a5001b3d7bad161d8ee0e68f5 Tbr: calamity@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401850Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805430}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc9083e4831f..6acdaf066c12 2020-09-09 mheikal@chromium.org Improve AdbWrapper#is_emulator to use device codename vs serial If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:11249650 Tbr: rmhasan@google.com Change-Id: Ib5d527ddf3bb1c29201d05410e5247a9d6369c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805429}
-
Mehran Mahmoudi authored
On Android M and prior versions, a white rect appears on the bottom of the player. This is seemingly caused by using the canvas#setMatrix method. This CL removes this call for identity matrix which fixes this problem for the default scale factor. However, for non-identity matrices, the white rect will still appear. Fixing that requires further investigation. Bug: 1126541 Change-Id: I9c48b3dc90e6fecf450f99059ff8cdf788d94420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401840Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805428}
-
ckitagawa authored
This CL fixes a low-volume crash in paint preview code. Where the tab might be null when checking if shown and needs badge. This CL was uploaded by git cl split. Change-Id: I69c03fb298c1d70b13368d6f9056d744231caee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401321 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805427}
-
Nate Fischer authored
This renames "repack_whitelist" to "repack_allowlist" and swaps out related code (ex. variables in chrome/ layer). The new term is consistent with "enable_resource_allowlist_generation" and avoids non-inclusive terminology. Bug: 1097644 Test: autoninja -C out/Official monochrome_public_apk (official build) Change-Id: I3e319c8b8bec9ab9df081b0b61ec02683d665af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399453Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805426}
-
Saurabh Nijhara authored
The browser tests only require a single requirement in the policy value and the code to create such policy value is getting repeated in all tests. Now, extracting the code to create policy value into a function. Bug: 1126163 Change-Id: I3e7c35ffc629e2b85ef5cf8bd19f6a429382cbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401619 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805425}
-
Marijn Kruisselbrink authored
Change-Id: I9d6a18bf62aa8ba445dba472d068a7d748bf7e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401500 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805424}
-
David Black authored
Previously thumbnails were fetched at a constant size and exhibited heavy pixelation when rendering in holding space UI. Now, we'll request the appropriate thumbnail size for each holding space type which will ensure consistency with what we intend to render. Known issue: The image loader we use to fetch thumbnails only supports cropping of square images. To prevent image distortion for non-square image requests, we'll ensure that we always request square images and perform an additional crop on our end. Bug: 1113772 Change-Id: I43e86b37e31d1dc94fd737bc29021dc68658c8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399438 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805423}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /headless to source.chromium.org equivalent. This CL was uploaded by git cl split. R=eseckler@chromium.org Change-Id: I27b31f841ee3bd0b5b06f950a56707c92aca4414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392707 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805422}
-
Josh Nohle authored
Enforce that each ListPublicCertificates RPC call takes no longer than 30s to complete. If this limit is exceeded, fail the task and rely on the scheduler to retry the attempt later. Fixed: b/166114040, 1116910 Change-Id: I9904a1d8c9da2d9a921f528dfbaf432213717d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401498 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805421}
-
Yuke Liao authored
Ash-chrome occasionally fail to start even after 20s, which causes infrastructure failures on linux-lacros-rel. This CL mitigates the issue by adding a retry logic so that the test runner script attempts to start ash-chrome up to 3 times. Bug: 1126185 Change-Id: Ibf80b6dbee51645db600e2804a53ca4d5320ca0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399618 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805420}
-
Alexander Surkov authored
ax_dump_tree tool sets siltently include-all filter if the filter file path is relative or mistyped, and ignores silently unrecognized filters, which makes harder to figure out why your filters don't work Bug: None Change-Id: I871350d67c9dc945ef4543eb11bb51c680aa025f AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399123 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805419}
-
Marc Treib authored
...and wire them into the respective SyncClient implementations. The feature flag for this service is still disabled, so this causes no behavior change yet. Bug: 1102314 Change-Id: I3a06470b2faf0cc9941e90024cf7ba672a70a99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397736 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805418}
-
Mark Mentovai authored
Update Crashpad to fc97e5cbb21dc7f4d4679b86792dd2717818bd80 7547d0aa874f android: Remove orderfile configs from handler trampoline b4724081350e fuchsia: Remove run_tests.py functionality ebab28f30d33 Remove a variable-length array* to enable compiling with -Wvla 1509aadd6364 Remove a variable-length array to enable compiling with -Wvla 45ca490687af Build with -Wvla, forbidding stack-allocated variable- length arrays 59e8120e7ada [Wconversion] Suppress warnings on Fuchsia 71695216f9bb ios: Fix Xcode project buildgen dc9f3a58aabb fuchsia: Fix Wconversion on Mac/iOS builds 364fdd65a01e fuchsia: Fix Wconversion on Mac/iOS builds (take two) bdf94713241b mac: Switch from <AvailabilityMacros.h> to <Availability.h> 56937e1df569 mac: 11.0 SDK support b3d84e0d0571 mac: System libraries are no longer found on disk on macOS 11 df3bc64246ab mac: Be more positive c4acae9f961a fuchsia: fix configs clobbering in GN template 3965bc7d7894 Refactor OS_LINUX usage for coming LaCrOs update 5412beb63386 mac: Replace MacOSXMinorVersion with MacOSVersionNumber e0d8a0aa01ac mac-arm64: Cope with signal handling quirks abfc89bb9b70 mac-arm64: Set expectations for tests that crash via __builtin_trap ca83774eea9c mac-arm64: Make MacModelAndBoard use target-type instead of board-id f8563cb8626a mac-arm64: Omit the cl_kernels workaround on this platform 0bc3826129d5 mac-arm64: Allow target_cpu = "mac_universal" to create universal builds df12d57e97b4 mac: Don’t build 32-bit ProcessReaderMac support where it’s unusable ca88ff1edb8e mac-arm64: Don’t attempt to determine the CPU frequency fc97e5cbb21d mac: Work around broken {CTL_KERN, KERN_PROCARGS2} sysctl in 11.0db6 Bug: crashpad:345,crashpad:347,crashpad:352,crashpad:355,chromium:1103944 Change-Id: I3c1f59d3c5bd2886916ea80228be765aafb4f63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399518 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805417}
-
Lin XInan authored
Bug:1056387 TEST=main.star Change-Id: Ia6b598fc8f906fcea73cb36b5c03f22fbb7be053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401940 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#805416}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/21bebc68fda6..215d2b0fa42d 2020-09-09 mtklein@google.com impl SkMulDiv255Round with SkMul16ShiftRound 2020-09-09 bsalomon@google.com Revert "Perf bot experiment, disable GLSL integers on ANGLE ES3" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I45d336ed69a11c8f2306a0b7e5c4a5dece6a34a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401858Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805415}
-
Etienne Bergeron authored
This CL is making const the function that are not modifying the state of the resource bundle. This step is required to make the transition to a Reader/Writer lock. Bug: 1123115 Change-Id: I764a8657fe358ce8cc5097d7ca7140a48682afd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401324Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805414}
-
Mark Pearson authored
Largely the change is to make it more acceptable to emit impressions and other events that are not user triggered if it's useful/necessary for analysis. Change-Id: Ic9215981dd71846c3eb3db4ef3af87f40d1ca1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392712 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805413}
-
Ahmed Mehfooz authored
Bug: 1110760 Change-Id: I713b6810aa6d6f21da35e01bf12513df44a3ce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398988Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805412}
-
Palak Agarwal authored
Bug: 1117534 Change-Id: I34823045b6e3364edbab94fd3eb74b8b1ef02d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397619Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#805411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8b9262d7426..9b74c18d1728 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: davidvc@google.com,adithyas@google.com Change-Id: I89b86a9d4b1e89bf30305960800f6e8bbaab5af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401613Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805410}
-
Ryan Hansberry authored
The prior implementation of this function assumed that the provided |size| would match the number of bytes read. In reality, |size| is generally a very large value and number of bytes read may be smaller than it. Manually verified by successfully sending a 7KB file from Chrome OS to Android. Bug: 1124992 Change-Id: I781a2c1f69aee374a18c10641ed14f31eb7348f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393616Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805409}
-
Daniel Rubery authored
This is a reland of a4418459. The original CL was causing crashes due to UaF on the Scorer object. This CL fixes that issue by performing the thread hop within Scorer. Since the returning callback on the PhishingClassifier is guarded by a WeakPtr, this should be more safe. Original change's description: > Move visual feature scoring to helper thread > > This CL calls the GetMatchingVisualTargets in a worker thread, since > the process of scoring visual features takes longer than expected > and was blocking interaction. > > Fixed: 1121375 > Change-Id: I8f3e33d20f812645a72adfc16fe33241b49a6ff4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372869 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801907} BUG=1121375,1122534 Change-Id: Ifedb94ad8b613a2ba7377bb5bc7795e657a94512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386380Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#805408}
-
David Black authored
New HoldingSpaceClient APIs will be accessed from //ash to: - Copy an item to clipboard (stubbed) - Open an item in its folder (implemented) - Pin an item (stubbed) - Unpin an item (stubbed) Stubbed APIs will be implemented in a follow up CL. Bug: 1126274 Change-Id: Ie6790e935272d90064f278d8d916fd3b33445752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399764Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#805407}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/214971471446..5fc363ed10fc 2020-09-09 chrche@microsoft.com [Loc] Presubmit#3: LocV2 Checking the shape of localization API calls 2020-09-09 aerotwist@chromium.org Migrates theme patching to top-level ThemeSupport 2020-09-09 chrche@microsoft.com [Loc] Presubmit#2: prevent using of LocV1 APIs in migrated files 2020-09-09 jacktfranklin@chromium.org Persist the network filter text input. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I043e8f75d9b1f4e0beece1876c8a8b604adaa3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805406}
-
Joanmarie Diggs authored
This is a follow-up change to http://crrev.com/c/2346329 to address a missed comment. AXPosition::IsValid will check if the positions are valid, so update AXSelection to account for any triggered DOM mutations, and then call AXSelection::IsValid, which will check the validity of the AXPosition instances associated with the selection. Bug: 1113650 AX-Relnotes: N/A Change-Id: Ic7d72111b2172784bbd199b6fe7767b5badefa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396156 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805405}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599630228-06e78b920e92149bcb86488690cdbb2bed08546f.profdata to chrome-win64-master-1599651808-28c874736fb144e9b48a72308f081ee03ad277c7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icab2c0aaab9ac3ced0a254eff33e62f3e84284c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401603Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805404}
-
Ian Struiksma authored
Add win-1909 to os enum, update mb config. Bug: 990885,1125612 Change-Id: I419a4ebf018d70841ec62b8bdf2e9dfd26e21cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399721Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#805403}
-
Mark Pearson authored
Change-Id: Ifedf9d66171961cf4435c2714848ba49afc1b263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391512Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805402}
-
Xi Han authored
This is caused by passing a null TabContentManager in Instant Start: LayoutManagerChrome#setTabModelSelector(). As a result, StartSurfaceStackLayout isn't registered as ThumbnailChangeListener of the TabContentManager. Thus, it misses the event of the tab's thumbnails get fetched. Besides, a refactoring is done in this CL: 1) A Supplier of TabContentManager is passed to LayoutManager in the constructor. 2) Add separate API in Layout.java, i.e. setTabContentManager(). Bug: 1116449 Change-Id: Id220248d4ca3cfc832fc1506dfe9e41b32a5efd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355052Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805401}
-
Victor Costan authored
Bug: 1001838 Change-Id: I43735057f98c6041e852318126fbe5f46e4bee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400242 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805400}
-
Ahmed Mehfooz authored
Change in UX requirement to match check mark colors used in menu bubbles to match active pods. Bug: 1115873 Change-Id: I9629a763aae9388442dcb7588532df39d4aeff75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400238Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805399}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/447e7a69ecdd..21205c372020 2020-09-09 treehugger-gerrit@google.com Merge "Ensure unique entries in power_profile" 2020-09-09 hjd@google.com ui: Hack minimum screensize to fix heap profiles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:168048193 Tbr: perfetto-bugs@google.com Change-Id: I97cee88669380792a3cda63352b57342d6ef3726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805398}
-
Gavin Williams authored
Change enum values to camel case to match style guidance for enum class members. Bug: 1059607 Change-Id: Icf5884449d1ad71b761dba7d14a64a7e478b801c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399566Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#805397}
-
Shimi Zhang authored
There is no states shared between tests, so we can easily apply @Batch(Batch.PER_CLASS) to this test file. I also migrated the EmbeddedTestServer to use EmbeddedTestServerRule, so we could reuse the EmbeddedTestServer between tests. Bug: 989569 Change-Id: I1ff0b5dc04a576a41e49c9d0ed9371ac1360e928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399903 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#805396}
-
Ossama Mahmoud authored
Previously, on the login screen in kiosk mode, the shutdown button is to the left of the Apps button. But when DeviceRebootOnShutdown policy is turned on, the restart button is to the right of the Apps button. To make the order more consistent, now both shutdown and restart buttons are to the left of the Apps button. R=antrim@chromium.org, rsorokin@chromium.org Bug: 1113244 Change-Id: I410f8122cd5c5024d2f8f558d842fdf5124a97e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387055 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#805395}
-
Jan Wilken Dörrie authored
This change removes the stale kGooglePasswordManager base::Feature from both Desktop and Android code. In addition, it also removes the corresponding chrome://flag and associated navigation to settings logic. Bug: 903249, 904821, 1126051 Change-Id: I8a77293fc61b4a721b2bae3c197dcade2cc5ea14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401338Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#805394}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/168986591cc1..d281ff186273 2020-09-09 vyshu@google.com paygen: Stop adding unused attributes to update payload 2020-09-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-09 vapier@chromium.org cros_portage_upgrade: rename blacklist->ignore 2020-09-09 ahassani@chromium.org Reland "cros_update: Delete it." 2020-09-09 saklein@chromium.org commandline: Remove build-target type. 2020-09-09 vapier@chromium.org git: trim unused project methods 2020-09-09 bpastene@chromium.org cache: Handle trailing garbage when untarring via pbzip2. 2020-09-08 tcwang@google.com afdo: Only check milestone and timestamp for CWP profiles. 2020-09-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-08 manojgupta@chromium.org cbuildbot: Enable goma even with latest toolchain 2020-09-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-04 vapier@chromium.org gs_unittest: simplify stub tarball creation 2020-09-04 vapier@chromium.org gs: rm: add -- before path 2020-09-04 vapier@chromium.org image_test: ban tcl & update java packages 2020-09-04 saklein@chromium.org sysroot_controller: Ignore package versions in InstallPackages. 2020-09-03 moragues@google.com trogdor: add factory builder for factory-trogdor-13443.B 2020-09-03 vyshu@google.com remote_access: fix style 2020-09-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-03 morg@google.com Skip unit tests for grunt-arc-r board builders 2020-09-03 seanabraham@chromium.org config_lib: borealis is a special suffix to remove for HW testing 2020-09-02 mmortensen@google.com BuildAPI: Use optional packages in Packages.GetTargetVersions. 2020-09-02 gredelston@google.com test_that: Rename whitelist-chrome-crashes 2020-09-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-02 bpastene@chromium.org cache: Use 'pixz' when extracting .xz tarballs if it's installed. 2020-09-02 yichengli@chromium.org artifacts: Exclude private fingerprint libraries If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I9e2c4dd0273665b09311bd32cc43a1ce6c3f5b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805393}
-
Sergei Glazunov authored
With this patch, PartitionAlloc holds the reference count (i.e. the number of associated CheckedPtrs) for every non-direct-mapped allocation. On free(), if the count doesn't equal zero, the allocation is poisoned and quarantined until there are no references left; therefore, use-after-free issues affecting CheckedPtr-protected pointers become unexploitable. This is a highly experimental feature, which is disabled by default. Bug: 1073933 Change-Id: Icda4b6e0c303e472df4222e1418bf0fdfe9aeef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385456 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805392}
-