- 26 Nov, 2019 40 commits
-
-
Jared Saul authored
Change-Id: Id13b46e08df385dc3e3107671259d9330ad79153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931758 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#719350}
-
Alex Newcomer authored
The old animation has a lot going on, it is hard for it to do well on slower devices. In order to make these transitions look good on all devices, change them a bit. The new animation: - Shelf background snaps away for the duration of the animation. - Animating background animates up/down to be in its final position. Bug: 1027751 Change-Id: If02f7a3f9d5f9ef9af59cf73747a9b7fab582042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930693 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#719349}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 17307335. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I60c2acc3d5d47e68a6604917c08ef549acb238f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936853Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719348}
-
Matthew Denton authored
Fix breakpad crash key deserialization if the crashing process sends strings without the null terminator. Bug: 984778 Change-Id: Ib77e584467c54413caaaef80ee8ef6e91a6b176e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935168Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#719347}
-
Brian Salomon authored
This reverts commit afc005c8. Reason for revert: prefer https://chromium-review.googlesource.com/c/chromium/src/+/1937657 Original change's description: > Compile Skia .mm files with C++17 support > > Change-Id: Ied5a58752c15cee95ba053e39e1c31e06d09f361 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937649 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> > Cr-Commit-Position: refs/heads/master@{#719342} TBR=bsalomon@google.com,brianosman@google.com Change-Id: Iab3e82c4e3df4c4f52767a983cce234c794217fb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937970Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#719346}
-
Elly Fong-Jones authored
These tests check that window positions and sizes are restored properly. Unfortunately they put their test windows at (10,10) which the window server helpfully adjusts to (10,23) to keep them from overlapping the title bar, which confuses the tests. Have them put their windows at (50,50) instead to avoid that. Bug: 1028239 Change-Id: Id69fc6d841878b35c74f0ebe51e8edc127057d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937770 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Yue Zhang authored
Add Duet-TabStrip integration flag. Originated from http://crrev.com/c/1915462. Bug: 1022827 Change-Id: I3a47b151573357dbdad45184ae72a83e706f7dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935439Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719344}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/data_reduction_proxy This CL was uploaded by git cl split. Bug: 1018667 Change-Id: I9685de8a0463ad7645e27d21474511ed8a030e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916468Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719343}
-
Brian Salomon authored
Change-Id: Ied5a58752c15cee95ba053e39e1c31e06d09f361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937649Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#719342}
-
John Abd-El-Malek authored
TBR=svaldez@chromium.org Bug: 1028371 Change-Id: I0f084e3263c756bfe59502e359d2dac979efbcee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937658Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719341}
-
haozhe authored
Both Chrome and Firefox pass The original test is kept because it's in the smoke test Bug: 900581 Change-Id: Iaa581f78cdde875f25a0accfbd953ba54277e9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937513Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#719340}
-
Ben Kelly authored
Approximately 0.02% of cache.put() calls fail due to a file existing on disk in the desired location already. This can possibly happen if a previous deletion is prevented due to virus scanning or some other application holding the file open. This CL allows us to recover by use the disk_cache OpenOrCreateEntry() method. This will open the existing file if it exists. The put operation will then proceed to truncate it and store the new response in the file. Bug: 968444 Change-Id: I57f6ce119d83cedb6e98467813262a8ed3037552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929522 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#719339}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f06a1962beff..24536bdd3cff git log f06a1962beff..24536bdd3cff --date=short --first-parent --format='%ad %ae %s' 2019-11-26 rharrison@google.com Disable shaderc library target in BUILD.gn (#910) Created with: gclient setdep -r src/third_party/shaderc/src@24536bdd3cff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ic8eef1ab83d7536967859eef488ef5575515694b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719338}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6a4a14635e70..44d7ec06830e git log 6a4a14635e70..44d7ec06830e --date=short --first-parent --format='%ad %ae %s' 2019-11-26 kwiberg@webrtc.org Add Opus-only audio codec factories 2019-11-26 sprang@webrtc.org Revert "Fixes dynamic mode pacing issues." Created with: gclient setdep -r src/third_party/webrtc@44d7ec06830e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3bb9a6be095ec2fab1fb982f37e5d19f16c8b878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937448Reviewed-by:
-
Daniel Murphy authored
This change adds sequence checkers to all method calls in * IndexedDBBackingStore * IndexedDBBackingStore::Transaction * IndexedDBBackingStore::Transaction::ChainedBlobWriterImpl * LocalWriteClosure * IndexedDBBackingStore::Cursor * ObjectStoreKeyCursorImpl * ObjectStoreCursorImpl * IndexKeyCursorImpl * IndexCursorImpl R=enne@chromium.org Bug: 1024966 Change-Id: I3c5912a73839a03ddb53aa058c694ec45d318cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935028 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719336}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f1240d519b7..e4df91c4a821 Created with: gclient setdep -r src-internal@e4df91c4a821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I219f037ea1a07077481a3c9ae0d06b7036422e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719335}
-
zhaoyangli authored
Moved ensureAppLaunchedWithFeaturesEnabled from -setUp to overriding launchAppForTestMethod method of BaseEarlGreyTestCase. This will reduce unnecessary relaunches of app, which will make tests suites run faster. Bug: 1009017 Change-Id: I6f39404ae54e5a057ddba37867e08c45f27a9495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928587Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#719334}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c92a0fa4..0f1fce1f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2d3519f6612f0aea1cbcac77a243a9400e4e1410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936852Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719333}
-
Xiaohui Chen authored
Bug: None Test: None Change-Id: I8e227f866625d1d9c85ad4ea6b8d000d5a1360a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937515Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719332}
-
Egor Pasko authored
Remove these obsolete flags and associated functionality: --branch --netrc --new-commit-flow --jobs --max-load This depends on the internal recipe to stop using these flags (the change for that is landing). Bug: 1028600 Change-Id: Ideea791f06afabd1ae1674220eb458b10de5fd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937367 Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719331}
-
Ayu Ishii authored
Bug: 1007730 Change-Id: I6e812d7d7a1e37824a9d34194a822212f1ce2291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935157Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#719330}
-
Javier Ernesto Flores Robles authored
This changes might over update the switch and therefore the on/off animation is being killed. To be fixed in a follow up for a later release. Bug: 1028095 Change-Id: Id9e28eeecde05f230c34d1b4f00fdb3df650f73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937172 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719329}
-
Robert Sesek authored
Change-Id: I26f2de5ac35310127b503e1c41ab444a563a1d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937587 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719328}
-
Yue Li authored
Record the number of eligible users that enabled/disabled the Assistant screen context ('Related info') toggle in their Assistant settings. Bug: b/145025524 Test: Manual Test Change-Id: Icaa8203660b82571266e2dcce561016aecfde10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934263Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#719327}
-
Brian White authored
Bug: 766909 Change-Id: Ib220095f8830f04e7b28476af3b6c1e0a493425b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935047 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#719326}
-
Brandon Wylie authored
Bug: 1016424 Change-Id: I62c22f920be14cdd1eeca65f226bd2dabfcff00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935330 Auto-Submit: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#719325}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c92898569764..ca29ecd5c79b git log c92898569764..ca29ecd5c79b --date=short --first-parent --format='%ad %ae %s' 2019-11-26 primiano@google.com Merge "Reduce entropy in tools/trace_to_text" Created with: gclient setdep -r src/third_party/perfetto@ca29ecd5c79b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I360adc666dc66c067219f1dd1e15030b599e64eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937628Reviewed-by:
-
Caleb Rouleau authored
In order to support abridging benchmarks, switch to use BenchmarkConfig objects instead of straight dictionaries. Bug: 965158 Change-Id: I73cd1d3d34531a1e18d1d97debad645d65f80c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935751 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719323}
-
Ted Meyer authored
check all floats and doubles to make sure they are finite - report 'NaN' otherwise. Bug: 1027412 Change-Id: I3c424f82e66434e89fc7268d65a980a6bd86fd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935887 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719322}
-
Yao Xiao authored
Only support it when socket pools are also split by the NIK, because the key is grabbed from the session key and will be empty when socket pools are not partitioned. Bug: 1021617 Change-Id: Ib0f601b8b20deb2c4bb85ddb4e212eb71380d086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900556Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#719321}
-
Chris Lu authored
This change adds targets for the remaining buttons to their appropriate InfobarTranslateModalDelegate methods. Bug: 1014959 Change-Id: I6d665d708a424559c9e406e9b67b4af554787a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936287 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#719320}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/83aafc979fa6..74e43a9f7fd6 git log 83aafc979fa6..74e43a9f7fd6 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@74e43a9f7fd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I04a9e2db2913fcacfef7ee8c513206fd2b30f2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936531Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Idc995920f08746ab0cf4b84c5c662437ec4f50c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930896 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#719318}
-
Pavel Feldman authored
Since input.files can be set in the user land, there is no need to handle file chooser dialog natively for the automation scenarios. This change removes the browser-side dialog interception and moves the event to the blink side for simplicity. As a side effect, there is no need to grant file access to the renderer every time dialog is handled - blobs are constructed on the renderer side and there is no need to pass file names around. This removes `page.handleFileChooser` from the CDP, and instead exposes `frameId` and `backendNodeId` parameters when emitting the `fileChooserOpened` event. Change-Id: I738b1e5f2f0804eb9e22ad771f234a727a914aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935410 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719317}
-
Sam Fortiner authored
The last remaining use of GraphicsLayer's position, including side-effects such as non-UI code reads of cc Layer::position which is set via GraphicsLayer::SetPosition, is UpdateMainGraphicsLayerGeometry where it is used to determine if the position changed and a call to SetPosition is needed. Since there are no other readers of this data, this callsite can be removed along with all other SetPosition callsites and supporting (now unused) code. This has no functional impact on Blink composition as layer position has already moved over to using BGPT. Bug: 999336 Change-Id: I7937c601269bafb515ad1ce16231dbacf70b8efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935499 Commit-Queue: Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719316}
-
Yngve N. Pettersen authored
If a generate_embedded_i18n target is specified with multiple grd_files_info entries each of the entries can have different xtb_locales configurations. However, unless the xtb_locales variable is reset to [] before it's updated, then the GN generation will fail. Change-Id: I40d89b5e4da66570c61e03971d534518e5a4873d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932800 Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#719315}
-
Joe Downing authored
The Chrome app has been deprecated and replaced by a website. I am now cleaning up references to it throughout Chromium with the eventual goal of removing the code. Change-Id: If74d7f578b1c308f799bd30c9848b7d3a1d83b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926539 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719314}
-
Wez authored
Change-Id: I47bff3b02a23a3749473ff363d164ea3f5c1b545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929916 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#719313}
-
Bill Budge authored
- Reworks tests to use PerformanceTestRunner to run code with timeline. - Performs tests in iframe, and uses postMessage to coordinate. Bug: chromium:1018029 Change-Id: Ie315516ddd90abe7538b485fd395d993a7a3e980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924712 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719312}
-
John Abd-El-Malek authored
This isn't flaking locally on the same build (Windows 10 Debug 64 bit) or on the same trybot as that waterfall bot. Trying to reland to see if it still flakes on that one bot. TBR=loyso@chromium.org Bug: 1026523 Change-Id: I69f346e74454904f629958c6f5006c9a66da9bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935158 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
