GitLab

[telemetry] Make default flags passed to WebPageRelay overridable via --extra-wpr-args by placing them earlier on the command line.

Review URL: https://chromiumcodereview.appspot.com/23523017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281244

Review URL: https://chromiumcodereview.appspot.com/23875002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221536 0039d316-1c4b-4281-b951-d872f2087c98

See bug for details.

BUG=285389

Review URL: https://chromiumcodereview.appspot.com/23706006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284835

Review URL: https://chromiumcodereview.appspot.com/23653015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221534 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221533 0039d316-1c4b-4281-b951-d872f2087c98

The blink roll was causing ContentShell to crash on startup, and thus
causing tons of tests to fail. Reverting until a real fix lands in
blink.

This reverts commit 292464e4.

BUG=285973
R=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/24010002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221532 0039d316-1c4b-4281-b951-d872f2087c98

This adds test coverage for the bug fixed by http://crrev.com/218391.

BUG=275810

Review URL: https://chromiumcodereview.appspot.com/23702023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280562

Review URL: https://chromiumcodereview.appspot.com/23926004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285339,285364

Review URL: https://chromiumcodereview.appspot.com/23874013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285995
R=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/23890006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221528 0039d316-1c4b-4281-b951-d872f2087c98

Add Error Console UI for install warnings to the chrome:extensions page (hidden behind the error console switch).

Snazzy Images: http://imgur.com/a/7QnMo#0 (updated 9/3)

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/22938005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221527 0039d316-1c4b-4281-b951-d872f2087c98

Looks like this doesn't have to be a window property.
Changed to use a plain global flag.

BUG=272460
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/23625007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221526 0039d316-1c4b-4281-b951-d872f2087c98

Pexe files with the cache-control:no-store header should not be cached.
Add a field to the PnaclCacheInfo struct, plumb the value all the way
from the plugin to the browser, and treat it basically the same way we
currently treat incognito translations (since we currently don't have an
off-the-record cache for those).
R=jvoung@chromium.org
BUG=none, noticed this was missing when doing cleanup

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221275
Reverted due to iterator use-after-erase in patchset 4. fixed in 5. No idea why it passed the CQ so cleanly but blew up the buildbots so completely.

Review URL: https://chromiumcodereview.appspot.com/23458015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221525 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes the following bugs in the cellular APN setting UI.:

  1. The first time the user brings up the custom APN UI, the APN input field
     contents were being set to "undefined". Fixed this.
  2. After setting a custom APN, if the user ever reverted to the default APN,
     and if the default APN did not contain a username/password field, the
     username and password fields of the Cellular.APN property were being set
     to "undefined" and this was getting stored in the profile.
  3. The JS now caches the APN fields set by the user so that the user can now
     switch back and forth between the default and the selected APNs. Before,
     trying to select the user APN via the drop-down menu resulted in the wrong
     APN to be set.

BUG=282711
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/23629010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221524 0039d316-1c4b-4281-b951-d872f2087c98

This cl removes a temporary Android-specific if-defined to force scrollbars to be solid-color, used while waiting for corresponding Blink changes that landed in r157254.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23653017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/23566018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221521 0039d316-1c4b-4281-b951-d872f2087c98

As preparation of migrating Drive disabling setting into Drive File System's
mounting state, this replaces GetForProfile, since it will return the
instance always (regardless of Drive disabling setting).

BUG=284972
TEST=Ran unit_tests

Review URL: https://chromiumcodereview.appspot.com/23638007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221520 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221519 0039d316-1c4b-4281-b951-d872f2087c98

It doesn't require PNaCl-specific changes per se, but I updated it to use the
new formatting (and created placeholder pages for links) and also simplified it
a bit to be less version-dependent.

BUG=None
R=binji@chromium.org

Review URL: https://codereview.chromium.org/23538006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221517 0039d316-1c4b-4281-b951-d872f2087c98

The CountingPolicyTest.CapReturns and FullStreamUIPolicyTest.CapReturns tests are occasionally flaking because the IO is slow and we have a low timeout of 5s set. This raises the timeout to 8s and makes sure the flush happens before our timeout starts.

Shoutout to mvrable for figuring out what was going on.

BUG=285823
NOTRY=true
R=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23991002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no

Review URL: https://chromiumcodereview.appspot.com/23442007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221515 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23530042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221514 0039d316-1c4b-4281-b951-d872f2087c98

Also removed unnecessary calls to updateNavBar_().

This fix is based on http://crrev.com/219018, which had to be reverted
because it introduced a regression.

BUG=263870
TEST=See repro steps in bug.
R=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/23464026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221512 0039d316-1c4b-4281-b951-d872f2087c98

This updates the Native Client technical overview to the new bright world of PNaCl. As discussed in the team meeting, I'm still focusing on Native Client as the umbrella name for the technology, but trying to present PNaCl as the default toolchain.

This update also removes some duplication from the document (with itself and with other documents), and introduces new, consistent diagrams. The other documents touched are just adding placeholders for links to look nicely in rendering.

It's still rough along the edges and has some TODOs, but I think it's ready for an initial review.

BUG=None
R=binji@chromium.org

Review URL: https://codereview.chromium.org/23629023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221511 0039d316-1c4b-4281-b951-d872f2087c98

No one have interests LauncherItemChanged().

R=skuhne@chromium.org
BUG=NONE
TEST=Compiles

Review URL: https://chromiumcodereview.appspot.com/23530020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221510 0039d316-1c4b-4281-b951-d872f2087c98

If we don't cancel the starvation callback, ProcessPendingEvents will get executed later when the callback fires.
Because we use a BarrierClosure in ProcessPendingEvents() and the count is 0 as both audio and video decoders are released, OnPrefetchDone() will be immediately called.
And this will cause ProcessPendingEvents() to get called again and again, thus crashing chrome.

An alternative to this fix is to check count before creating the barrier.
Logically starvation callback should not get called after Release().

BUG=285573

Review URL: https://chromiumcodereview.appspot.com/23672025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221509 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280668

Review URL: https://chromiumcodereview.appspot.com/23571007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221508 0039d316-1c4b-4281-b951-d872f2087c98

include it rather than ui_export.h

TBR=sky@chromium.org
http://crbug.com/285385

Review URL: https://codereview.chromium.org/23486010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267667
TEST=unit_tests --gtest_filter=NetworkingPrivateCryptoTest.*

Review URL: https://chromiumcodereview.appspot.com/23710003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221505 0039d316-1c4b-4281-b951-d872f2087c98

This makes OutputConfigurator::GetModeInfo() not print an
"Unable to find info" warning when passed mode 0.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23619015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23971004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221502 0039d316-1c4b-4281-b951-d872f2087c98

CacheControl takes pylib/android_commands.py.
Broken at https://chromiumcodereview.appspot.com/20766003

BUG=
TBR=simonjam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23601016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23591028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282582

Review URL: https://chromiumcodereview.appspot.com/23494022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221497 0039d316-1c4b-4281-b951-d872f2087c98

The histograms were added to Chrome in:
https://codereview.chromium.org/23181006/

Review URL: https://chromiumcodereview.appspot.com/23983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221496 0039d316-1c4b-4281-b951-d872f2087c98

When raising a set of windows in response to a dock icon click, only raise the
ones on the currently active space. We currently raise all of them and switch
spaces haphazardly.

Also tidy up the applicationShouldHandleReopen:hasVisibileWindows: callback. We
should return NO since we've reacted and don't need AppKit to deminiaturize for
us. (Although it seems to not make much difference, probably because we've
already picked a window to deminiaturize, so AppKit won't pick a second.) Also
remove the tabbed/popup check. As of r192264, those are the only browser window
types.

BUG=281674
TEST=Open a browser window in Desktop 1 and one in Desktop 2.
Switch to Desktop 2.
Open another application in Desktop 2 and make it foreground.
Click the dock icon for Chrome. Should remain on Desktop 2.

Review URL: https://chromiumcodereview.appspot.com/23737003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221495 0039d316-1c4b-4281-b951-d872f2087c98

Looks like it was originally a copy/paste error.

BUG=284895

Review URL: https://chromiumcodereview.appspot.com/23654010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221494 0039d316-1c4b-4281-b951-d872f2087c98

When the LayerTreeHostImpl drops RenderPasses from its output, it does
not also drop the RenderPassDrawQuads that point to them. The direct
renderers ignore these quads, so this has never been a problem. However
the DelegatedRendererLayerImpl was not able to deal with this correctly
and would crash. More problematic is that a compromised renderer could
send invalid RenderPassDrawQuads, which the DelegatedRendererLayerImpl
must be able to handle gracefully.

So, for both cases, we here make the DelegatedRendererLayerImpl ignore
invalid RenderPassDrawQuads, and just drop the from its own output.

Tests:
DelegatedRendererLayerImplTest.InvalidRenderPassDrawQuad

R=piman
BUG=283630

Review URL: https://chromiumcodereview.appspot.com/23891003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221493 0039d316-1c4b-4281-b951-d872f2087c98

This *reverts* the parts of high-res timing that was moved out from simple cache
in attempt to have it in base/, here:
http://src.chromium.org/viewvc/chrome?view=revision&revision=216478

The changes in base/ are untouched today. This partial revert should be safe
because this change just adds (un-removes) a different implementation and
switches simple cache to using it.

The bug being blocked by this deficiency is in the BUG field, we do not have a
specific bug for the problem, it would have required age restriction on the
audience.

BUG=261618

Review URL: https://chromiumcodereview.appspot.com/23819025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221492 0039d316-1c4b-4281-b951-d872f2087c98

Shill does not send the passphrase to Chrome for security reasons, so
show ****** in the passphrase field when configuring wifi if the service
is Connectable. (Sometimes when a connection fails we do not know why
it failed and so we show the configure dialog in case it is an error in
the configuration).

BUG=264819

Review URL: https://chromiumcodereview.appspot.com/23522013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221491 0039d316-1c4b-4281-b951-d872f2087c98