GitLab

The feature is now behind --enable-in-browser-thumbnailing flag.

The in-browser thumbnailing works as follows:

- The scroll offset is sent from the renderer to the browser.
- The thumbnail is taken when the page info is sent from the renderer process.
- Since thumbnails are generated in the browser, we can avoid the generation when unnecessary (ex. off-the-record mode, or New Tab Page).
- The quality of thumbnails is as good as before, as the patch doesn't change timing heuristics.
- The drawback is that we cannot take thumbnails from background tabs.

New functions are added to ThumbnailGenerator for clipping thumbnails, with tests.

BUG=65936
TEST=add unit tests for thumbnail_generator. confirmed that the thumbnails are updated with and without --enable-in-browser-thumbnailing

Review URL: http://codereview.chromium.org/6246007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72115 0039d316-1c4b-4281-b951-d872f2087c98

The CL ifdef'ed out for some parts of HTML, but it did not touch the corresponding JS code that modifies the part.

BUG=chromium-os:11142
TEST=manually open chrome://settings

Review URL: http://codereview.chromium.org/6342013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72114 0039d316-1c4b-4281-b951-d872f2087c98

This is based on GTK implementation. Please see the header file for features that are not implemented yet.

Textfield changes (files under views/controls/textfield) are being reviewed by Ben in separate CL (http://codereview.chromium.org/6314012/), so you don't have to review them (but you're welcome to do so).

* Updated factory method in AutocompleteEditViewGtk to return views-implementation when TextfieldViews is enabled.
* Added new option to FillLayout so that it lays out its child inside border.
* Added missing GD_PK_Delete to keycode conversion.
* Enabled tests in autodomplete_edit_view_browsertests for views-implementation as well. I moved the test body to the class and then called them from each test class to avoid having another test configuration on bots. Let me know if there is better way.

BUG=none
TEST=Enabled autocomplete_edit_view_browsertest for views-implementation.

Review URL: http://codereview.chromium.org/6245003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72113 0039d316-1c4b-4281-b951-d872f2087c98

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6346011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72112 0039d316-1c4b-4281-b951-d872f2087c98

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6265018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72111 0039d316-1c4b-4281-b951-d872f2087c98

return value as a bool

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6346010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72110 0039d316-1c4b-4281-b951-d872f2087c98

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6360010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72109 0039d316-1c4b-4281-b951-d872f2087c98

TEST=it compiles BUG=none
Review URL: http://codereview.chromium.org/6336010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72108 0039d316-1c4b-4281-b951-d872f2087c98

few annoying cases where someone has been monitoring Chrome under windbg,
which can skip over __debugbreak() and then show them a scary-looking
access violation.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/6372008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72107 0039d316-1c4b-4281-b951-d872f2087c98

the base namespace. Fix several files including lock.h unnecessarily.

BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47955,69883
TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72095

Review URL: http://codereview.chromium.org/6383002
Patch from James Weatherall <wez@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69755
TEST=Throbber works properly when settings page is scaled.

Review URL: http://codereview.chromium.org/6378006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72104 0039d316-1c4b-4281-b951-d872f2087c98

preparation for experimenting with them to gpu-accelerate various aspects of
chrome's drawing. In this initial patch, the files will be built, but not
called.

Now with dependency on gpu lib for sharedlib build on linux

TEST=be sure that page rendering, and <canvas> rendering, look the same as before

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71998

Review URL: http://codereview.chromium.org/6357006
Patch from Mike Reed <reed@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72103 0039d316-1c4b-4281-b951-d872f2087c98

a NaCl page reload / surf-away regression.
BUG=NaCl ppapi audio proxy
TEST=native_client/tests/ppapi_example_audio

Review URL: http://codereview.chromium.org/6300011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70327
TEST=none

Review URL: http://codereview.chromium.org/6268009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47955,69883
TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total.

Review URL: http://codereview.chromium.org/6383002
Patch from James Weatherall <wez@chromium.org>.

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6341006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47955,69883
TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total.

Review URL: http://codereview.chromium.org/6383002
Patch from James Weatherall <wez@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72095 0039d316-1c4b-4281-b951-d872f2087c98

A NULL |result| should DCHECK, but not crash.  This is a short term solution to the top-crasher, will still DCHECK for devs while a longer term fix is determined.

BUG=68783, 69833
TEST=none

Review URL: http://codereview.chromium.org/6275011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6352003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72093 0039d316-1c4b-4281-b951-d872f2087c98

being notified after the object has been destroyed.

BUG=69441
TEST=none

Review URL: http://codereview.chromium.org/6299014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72092 0039d316-1c4b-4281-b951-d872f2087c98

  grep --include="*.gyp*" -nr -F "ppapi_egl" .

However this library causes NaCl to require third_party/mesa which relative to NaCl is large.

This CL moves the definition of this static library from ppapi to the lib/gl directory under ppapi so that PPAPI users are not forced to DEPS in mesa.

Review URL: http://codereview.chromium.org/6342012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64800
TEST=Verify that the checkbox for the Mac address book appears in autofill options.
Review URL: http://codereview.chromium.org/6278012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72089 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6264007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6354010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=run out/Debug/views_examples, it should work as before.

Review URL: http://codereview.chromium.org/6377004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=56415,43716
TEST=Verify language & settings panel functionality on dom-ui settings window.
Review URL: http://codereview.chromium.org/6296017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72085 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash in PluginService if the keys are null.  It's still unclear why this is happening now as opposed to before.  This change just fixes the crash in the meantime.

BUG=70317
Review URL: http://codereview.chromium.org/6313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72083 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72079 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r72069.

The ARM build gave this compiler warning:
cc1plus: warnings being treated as errors
third_party/WebKit/Source/WebCore/platform/graphics/FontCache.cpp: In function 'const WTF::AtomicString& WebCore::alternateFamilyName(const WTF::AtomicString&)':
third_party/WebKit/Source/WebCore/platform/graphics/FontCache.cpp:139: error: 'timesNewRoman.unstatic.3258' may be used uninitialized in this function
make: *** [out/Release/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/graphics/FontCache.o] Error 1

TBR=jorlow

Review URL: http://codereview.chromium.org/6248012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72078 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72076 0039d316-1c4b-4281-b951-d872f2087c98

1) Change style to match style guide.
2) Use "git svn info" so we can use the same parsing code for
   both git and svn.

TEST=ran manually

Review URL: http://codereview.chromium.org/6263009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72074 0039d316-1c4b-4281-b951-d872f2087c98

It is returning Unicode so it should be a string16.
The callers want a string16 anyway.

TEST=compiles

Review URL: http://codereview.chromium.org/6306006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72073 0039d316-1c4b-4281-b951-d872f2087c98

can happen if we try to edit a profile that is in the process of being removed,
but for which we haven't been notified that it's removed yet.

BUG=69327
TEST=none

Review URL: http://codereview.chromium.org/6323012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72071 0039d316-1c4b-4281-b951-d872f2087c98

fails flakily.

TBR=isherman
BUG=70323
TEST=none

Review URL: http://codereview.chromium.org/6351012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72070 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow

Review URL: http://codereview.chromium.org/6300010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72069 0039d316-1c4b-4281-b951-d872f2087c98

As of today, we have dedicated chromium trybots that can run the sync
integration tests, but it requires developers to explicitly send try
jobs to these bots via the --bot switch.

Now that the sync trybots are stable, it is time to make this process
automatic by adding a PRESUBMIT.py file to chrome/browser/sync, that
adds the sync trybots in addition to win, mac and linux to the list of
preferred trybots.

This patch adds such a PRESUBMIT.py file, that includes
win_sync, mac_sync and linux_sync to the list of preferred trybots.

BUG=70311
TEST=modify something under chrome/browser/sync and do a "git try" or "gcl try"

Review URL: http://codereview.chromium.org/6275010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72067 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69135
TEST=none
TBR=gavinp


Review URL: http://codereview.chromium.org/6300009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6380006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70149
TEST=None

Review URL: http://codereview.chromium.org/6349007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72061 0039d316-1c4b-4281-b951-d872f2087c98