- 01 Aug, 2017 40 commits
-
-
Takeshi Yoshino authored
- Remove an unused include - Access root_ directly than via Root() Bug: Change-Id: I2b9abe974dd7c3bcfc4921a1bd86833dc0b2efe4 Reviewed-on: https://chromium-review.googlesource.com/586212 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#490972}
-
Emilio Cobos Álvarez authored
Not doing it results in incorrect behavior when there are multiple adjacent text nodes, either script-generated ones or because of display: contents. BUG=746437,657748 Change-Id: If5aa9209d16d5532629a0f0e2f1730d18a193ebf Reviewed-on: https://chromium-review.googlesource.com/575982Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Emilio Cobos Álvarez <ecobos@igalia.com> Cr-Commit-Position: refs/heads/master@{#490971}
-
Julian Pastarmov authored
The value could change during startup when delivered through policy but the backend can not be switched on the fly. So make sure the first seen value is preserved. BUG=736408 Change-Id: Ie608e9735b6009df3cd7070338412bd5b83376f4 Reviewed-on: https://chromium-review.googlesource.com/586688Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#490970}
-
Koji Ishii authored
Change-Id: I8a26eda72944a0c4d043275ffcde814bb6630f4c Reviewed-on: https://chromium-review.googlesource.com/594757Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490969}
-
Andrew Grieve authored
Deletes google_play_services_library GN variable. This should reduce compile times a bit, but mostly is just a good idea in general. Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f Reviewed-on: https://chromium-review.googlesource.com/585450 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Michael Case <mikecase@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490968}
-
gaschler authored
Add FakeContextualSuggestionsFetcher, MockFetchContextualSuggestionsCallback and a unittest for ContextualSuggestionsSource suggestion fetching. Bug: 749988 Change-Id: I958744e74fa54204d5dd764da49fc2ca45d6b9b3 Reviewed-on: https://chromium-review.googlesource.com/593656 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490967}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ab3909796cf2..de7c9620c374 $ git log ab3909796..de7c9620c --date=short --no-merges --format='%ad %ae %s' 2017-08-01 art-snake Prevent use of null pFileRead in CPDF_DataAvail. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifbf8ecee9c19109874bb2d0758e547bd4195f9f2 Reviewed-on: https://chromium-review.googlesource.com/595867 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490966}
-
Roman Sorokin authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/542963a5cdc8..3eac6aef29eb $ git log 542963a5c..3eac6aef2 --date=short --no-merges --format='%ad %ae %s' 2017-06-29 ljusten authpolicy: Add proto for Kerberos files Created with: roll-dep src/third_party/cros_system_api Bug: 737960 Change-Id: I84ac71002f0427e01e8a4f576dc8536237d1b330 Reviewed-on: https://chromium-review.googlesource.com/594050 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490965}
-
Raphael Kubo da Costa authored
Using wpt-import in Chromium 208c0175. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dom-dev@chromium.org: external/wpt/html domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams TBR=qyearsley@chromium.org No-Export: true Change-Id: I946fd58c943f2535ecbb3229ac94ab8563e38fd9 Reviewed-on: https://chromium-review.googlesource.com/595648 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#490964}
-
Vitalii Iarko authored
Previously, the suggestions were sorted by score. However, pushed suggestions must stay on top independetly of their score. This CL stores suggestion order in the database by recording suggestion position as its rank and then sorting by rank. Score is used as a fallback. Bug: 750100 Change-Id: Ic799f9a2e72d79908435b48185f7c6d74fa2d297 Reviewed-on: https://chromium-review.googlesource.com/593318 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#490963}
-
Patti authored
Site Details shows a 'Usage' section, which describes the amount of storage used by a website. Only show this when #enable-site-settings is on, since it's not in scope for the first version of Site Details. Manual test - With #enable-site-details on and #enable-site-settings off, navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fpermission.site. It should not show the 'Usage' heading, nor the 'Permissions' heading. With both flags on, navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fpermission.site and verify 'Usage' and 'Permissions' headings are both there, most likely with 'No usage data' under 'Usage'. Then navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fwww.google.com and again verify both headings are there, probably with a non-zero storage number under 'Usage'. Bug: 656758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2a5dd7de7fcd6f4c3270dce2bb51e22ab6e1cec0 Reviewed-on: https://chromium-review.googlesource.com/587516 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#490962}
-
Xida Chen authored
Right now in ScrollingCoordinator::SetTouchEventTargetRects, we always send TouchAction::kTouchActionNone when we pass the rect to cc. This CL change the kTouchActionNone to the real value associated with that rect. TBR=flackr@chromium.org Bug: 716668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I92c450fac165c59ba01ae1ef9f037c3001d56403 Reviewed-on: https://chromium-review.googlesource.com/581907 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490961}
-
Xida Chen authored
In the current implementation of MailboxInfo, we keep a RefPtr to Canvas2DLayerBridge, and when the MailboxReleased function gets called, we do a self_ref to keep the Canvas2DLayerBridge alive. Now that the MailboxReleased function is called through a WTF::Bind to a WeakPtr of Canvas2DLayerBridge, we don't need the self_ref anymore. Also, we can remove the mailboxes_ that is kept in this class, we just need to remove the associated resources. Bug: None Change-Id: I7f087a23a7fca32272d0ad05efb66f92d9eabba8 Reviewed-on: https://chromium-review.googlesource.com/579690 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#490960}
-
Hajime Hoshi authored
The test is now timed out on the flakiness dashboard because idle tasks are never called on tests until testRunner.runIdleTasks explcitly (crbug.com/595152). This doesn't leak now. This CL also fixes a comment regarding crbug.com/726218. Bug: 595152, 662477 Change-Id: I757bd5e72063933b28d92dc69cb4a3e42e9e4c56 Reviewed-on: https://chromium-review.googlesource.com/595792Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#490959}
-
Rune Lillesveen authored
After style sharing code was removed, this mode is no longer in use. Bug: 721517 Change-Id: Ia0997792f5641b722d86922f40d631613552c137 Reviewed-on: https://chromium-review.googlesource.com/595728Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#490958}
-
Yutaka Hirano authored
Supporting <link rel="preload" as="fetch" crossorigin> was considered to be hard because we have two CORS handling logic. CORS for preload is checked in ResourceLoader and CORS for xhr is checked in DocumentThreadableLoader. Resource::CanReuse is a function that determines whether we can reuse a resource for a request, and it returns false in such a case. On the other hand, it should be safe to run the CORS check twice. If the CORS check for the existing resource is run in ResourceLoader, we can reuse it for an XHR request. This CL changes Resource::CanReuse in that sense. Bug: 702845 Change-Id: Ifa5580c4465ff683e65455256266cbeeecde3d92 Reviewed-on: https://chromium-review.googlesource.com/582063 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#490957}
-
gambard authored
When rotating the device, the omnibox width should be set to the new width. This width computation needs to take into account the y offset of the collection and its new size. So the calculation needs to be started from the collection. Bug: 750637 Change-Id: I14dc8f878b815f7f32bd33f88691e9b39782e0d4 Reviewed-on: https://chromium-review.googlesource.com/595741Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490956}
-
Hitoshi Yoshida authored
This CL does two things. 1. In compile time, creates a snapshot file, which consists of V8 contexts. 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext(). We expect this speeds up context creation for 3 times faster on Android. Detailed information is described in the design doc [1]. [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30 This CL is a re-land of https://codereview.chromium.org/2841443005 (and the 1st patch is same with it) Test expectations are changed due to http://crbug.com/705364 BUG=588893, 617892, 705364 TBR=rkc, jochen, dchen, kinuko, eroman, thakis Change-Id: If85e68a6498f7d35a0c59f4af9323ba72fc36d5f Reviewed-on: https://chromium-review.googlesource.com/594608Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#490955}
-
Marc Treib authored
It's not always safe to use cached data for the OneGoogleBar. For now, always wait for the network request to come back before serving the OGB. This is similar to the behavior of the remote NTP. This also allows us to simplify the observer interface a bit. Note that if the network request fails due to a transient error, the cached data is still used. Bug: 742937 Change-Id: Iadd2e72bfe06265d006629719c4792b2aefd15ec Reviewed-on: https://chromium-review.googlesource.com/593909Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#490954}
-
stkhapugin@chromium.org authored
Create OminboxPopupViewSuggestionsDelegate to abstract out OmniboxViewIOS API from OmniboxPopupViewIOS. PopupView now does not directly receive a pointer to OmniboxView, getting a browser state and a delegate instead. OmniboxViewIOS implements the delegate methods. Bug: Change-Id: I42bf3a2ca0d88f1215181981a3f66d8089be385a Reviewed-on: https://chromium-review.googlesource.com/579727 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#490953}
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: I4fcee351c4fe8f639ad7c65abc83563f3afb13df Reviewed-on: https://chromium-review.googlesource.com/590394 Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#490952}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b50fdbf..1e8730d2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Icd290ff0834593d1714f2a6bdabb49d482770f3d Reviewed-on: https://chromium-review.googlesource.com/595847Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#490951}
-
Jérôme Lebel authored
The struct returned by protocol_copyMethodDescriptionList() should be freed after being used. Bug introduced with crrev.com/2785153002 Bug: 751066 Change-Id: I869ddfb4e6e3d9a489fa756ed48074a3f63175d8 Reviewed-on: https://chromium-review.googlesource.com/595739Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#490950}
-
Dominik Röttsches authored
At the same time change computed style to a number type according to CSS Fonts Level 4 [1]. [1] https://drafts.csswg.org/css-fonts-4/#font-stretch-prop Bug: 739139 Change-Id: I30db184559e7f047efcca999ae1b63aaa18b5eab Reviewed-on: https://chromium-review.googlesource.com/574590 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#490949}
-
Takeshi Yoshino authored
WebDataSource is an interface to expose DocumentLoader to outside of Blink together with ExtraData. Naming this class WebDocumentLoader makes it easier to understand correspondence between this interface and DocumentLoader. This patch also - adds Get.* prefix to the getters using this opportunity. - just removes unused includes and forward declarations from some files Bug: Change-Id: I6c9c0e49b4eeac94cae349439f85c3163d35f04a Reviewed-on: https://chromium-review.googlesource.com/590840 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#490948}
-
Helen Li authored
Bug: 730036 Change-Id: I2f7f64619276df1ab75c2514507dd6c0581dc045 Reviewed-on: https://chromium-review.googlesource.com/590413Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#490947}
-
Helen Li authored
This CL converts DCHECKs to CHECKs to see if |active_jobs_| and |job_requests_map_| can go out of sync. If that's the case, OnJobComplete() can be called when there's no longer a server_id entry in |job_requests_map_| and |requests_iter| is invalid in OnJobComplete(). Bug: 750271 Change-Id: I06fde6921668acb33456c2f65e102136ef0aae10 Reviewed-on: https://chromium-review.googlesource.com/594189Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#490946}
-
gaschler authored
Split ContextualSuggestionsFetcher into interface and implementation to prepare for testing with mocks. Bug: 749988 Change-Id: I6a141354781743551244be9d247958f3bc38e1e5 Reviewed-on: https://chromium-review.googlesource.com/593618 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490945}
-
Balazs Engedy authored
The test used to schedule a call to window.close() in the main frame of a WebContents to close itself after it calls window.open(). However, the CreateNewWindow sync IPC could still have been dispatched *before* ViewHostMsg_Close in the browser process in the unfortunate scenario where the browser process happened to be waiting for a reply to another sync IPC on the UI thread, in which case incoming sync IPCs to this thread are dispatched, but the message loop is not pumped, so proxied non-sync IPCs such as ViewHostMsg_Close are not delivered. This CL remedies the problem by triggering window.open() just before the FrameMsg_Delete messages would be sent to the frame. Bug: 728171, 729021 Change-Id: Ia2d53447d58e4038d2ceafdf8b2d70ed8c7d494d Reviewed-on: https://chromium-review.googlesource.com/589273 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#490944}
-
Alexander Shalamov authored
Windows Sensor COM API does not provide linear acceleration sensor type, therefore, it needs to be implemented using SW fusion algorithm. This PR adds simple linear acceleration fusion algorithm that is based on low-pass filter. Same algorithm can be used on CrOS, Mac and Linux platforms. Bug: 741315 Change-Id: I2c4fa7fc1b7e5d3bc45ecc18cb44e4d8e2b055e9 Reviewed-on: https://chromium-review.googlesource.com/591467 Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#490943}
-
yoshiki iguchi authored
Double adding and removing of an observer hits DCHECK. This patch prevents that. Bug: none Change-Id: I289cadc8356783abdfac3fee6d2e3a57d620cc21 Change-Id: I384ea7ee20a98ac03f1661f48cc599d6f8acb8c4 Reviewed-on: https://chromium-review.googlesource.com/583958 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490942}
-
gaschler authored
Adds a virtual default destructor to RemoteSuggestionsScheduler. Annotates override to its implementation. Bug: n/a Change-Id: Ic95ce5534572100d0456f91e7a66099d4bf16b47 Reviewed-on: https://chromium-review.googlesource.com/593910Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Andre Gaschler <gaschler@chromium.org> Cr-Commit-Position: refs/heads/master@{#490941}
-
gambard authored
Bug: none Change-Id: If9a779ee684cbbd991236d590f52a18c00ed53ae Reviewed-on: https://chromium-review.googlesource.com/591149 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#490940}
-
Ramya Sharma authored
Change-Id: Iac8368f6a25931ad8f759a9655ba7a99d99f9e34 Reviewed-on: https://chromium-review.googlesource.com/595367Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#490939}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/78567f11..2b50fdbf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ibdde9a420525f836dd0870a2b385955b8cabc2a2 Reviewed-on: https://chromium-review.googlesource.com/594686Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#490938}
-
tzik authored
This CL convert WTF::Function from pass-by-unique_ptr to pass-by-value semantics. After this, WTF::Bind returns a WTF::Function object rather than an std::unique_ptr of it, and WTF::Function becomes a move-only type rather than a noncopyable type. The pass-by-value semantics reduces an allocation and indirection for each WTF::Function usage, and is a preparation to make WTF::Function closer to base::Callback. Bug: 554299 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib7758f269d120b1fb017b984c0e7a52ed5bf4bfd Reviewed-on: https://chromium-review.googlesource.com/577472 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#490937}
-
Robert Hogan authored
Bug: 636053 Change-Id: I9ed72d459d43f2a0113e4c46a496f6ecf65665d6 Reviewed-on: https://chromium-review.googlesource.com/593308Reviewed-by:
Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#490936}
-
Matt Falkenhagen authored
Also teach it to handle the case where there is no response body. This test class will evolve as more cases are added. Currently it just tests the simple case where a service worker handles the request, with no response body. Bug: 748416 Change-Id: Ifda79696eff766e725e6ee28fc27ca3d9ef9cf84 Reviewed-on: https://chromium-review.googlesource.com/590836 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490935}
-
Friedrich Horschig authored
This reverts commit 12af7241. Reason for revert: Please realnd without NOTRY as it caused compile failure. Compile log: test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test-gen.cc python ../../tools/gypv8sh.py ./v8_shell ../../chrome/third_party/mock4js/mock4js.js ../../chrome/test/data/webui/test_api.js ../../chrome/test/base/js2gtest.js extension --external=y ../../chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test-gen.cc test_data/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs undefined:68: SyntaxError: Invalid or unexpected token #if defined(OS_CHROMEOS) ^ SyntaxError: Invalid or unexpected token at ../../chrome/test/base/js2gtest.js:462:6 Original change's description: > [Sheriff] Disabling PanelTest.* on ChromiumOS > > The tests are flaky on ChromiumOS. > > TBR=dtseng@chromium.org, yutak@chromium.org > NOTRY=true > > Bug: 751046 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Id28f1ba7cb1c42c617b041c74a3698937d21eed5 > Reviewed-on: https://chromium-review.googlesource.com/595589 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490929} TBR=dtseng@chromium.org,yutak@chromium.org,jkrcal@chromium.org Change-Id: I0e62ca5b253292bd0ae4ef5e4f12e065589494db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/595687Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#490934}
-
Tatiana Gornak authored
As per latest decision all users should use native password manager setting page instead of being redirected to the passwords.google.com BUG=619868 Change-Id: I668722d4be34b605517bd846e071779e56f61346 Reviewed-on: https://chromium-review.googlesource.com/587187Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#490933}
-