GitLab

I recently introduced a change which caused SQLitePersistentCookieStore to load
the cookies for one eTLD every 200ms, instead of every 0ms. That change
appeared to cause a hang during shutdown.

This CL changes the delay from 200ms back to 0ms while I investigate the hang.

BUG=436152, 448910

Review URL: https://codereview.chromium.org/844533005

Cr-Commit-Position: refs/heads/master@{#312903}

Once we support multiple DRM devices we'll want to share the helper
thread between the different wrappers.

BUG=427959
NOTRY=true

Review URL: https://codereview.chromium.org/856423002

Cr-Commit-Position: refs/heads/master@{#312902}

Anything relying on the filter being added would not be initialized
otherwise.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/872473002

Cr-Commit-Position: refs/heads/master@{#312901}

Note: This doesn't occur under normal circumstances, but if a DBus crash
(or something else) causes an immediate shutdown, we sometimes crash in
NetworkPortalDetector::Get() which obscures the actual problem.

This also updates the portal detector logging to use device_event_log.h.

BUG=none

Review URL: https://codereview.chromium.org/865813005

Cr-Commit-Position: refs/heads/master@{#312900}

Do not discard symbols which aren't present in the uninstrumented build (for
example if they were inlined).  This should make the orderfile more robust
against minor changes in compiler decisions.

From local testing, I expect this to fix the out-of-order symbol error that is
keeping the bot red.

Review URL: https://codereview.chromium.org/871043002

Cr-Commit-Position: refs/heads/master@{#312899}

Once the problem in PPB_VideoDecode API implementation that causing
plugin crash is fixed PepperVideoRenderer3D can be enabled. This CL
enables it for Chrome 42 and above.

BUG=447403

Review URL: https://codereview.chromium.org/855553003

Cr-Commit-Position: refs/heads/master@{#312898}

BUG=451476
NOTRY=True

Review URL: https://codereview.chromium.org/861033004

Cr-Commit-Position: refs/heads/master@{#312897}

BUG=

Review URL: https://codereview.chromium.org/868123003

Cr-Commit-Position: refs/heads/master@{#312896}

This should be removed once the compile time error in ffmpeg is fixed.

BUG=450771,371125

Review URL: https://codereview.chromium.org/867333003

Cr-Commit-Position: refs/heads/master@{#312895}

- Makes Plugin Power Saver posters (using LoadablePluginPlaceholder) generate correct metrics.
- Makes the PluginInstanceThrottler report the NEVER unthrottle method correctly.

BUG=449251,403800

Review URL: https://codereview.chromium.org/863813002

Cr-Commit-Position: refs/heads/master@{#312894}

Adds a fake video encode accelerator (hardware encoder) implementation that can be used for testing (on devices without hardware encoder or missing implementation) and testing the efficiency of an existing hardware encoder.

BUG=440843

Review URL: https://codereview.chromium.org/760963003

Cr-Commit-Position: refs/heads/master@{#312893}

BUG=

Review URL: https://codereview.chromium.org/802523004

Cr-Commit-Position: refs/heads/master@{#312892}

the '*_eh_a' outputs doesn't seem to be generated anymore, because of this you get the following log if you compile the pnacl_support_extension target twice:

[master]E:\src\chrome\src>ninja -C out\Release pnacl_support_extension -d explain
ninja: Entering directory `out\Release'
ninja explain: output pnacl/pnacl_public_x86_32_libgcc_eh_a doesn't exist
ninja explain: pnacl/pnacl_public_pnacl_json is dirty
ninja explain: pnacl/pnacl_public_x86_32_crtbegin_o is dirty
ninja explain: pnacl/pnacl_public_x86_32_ld_nexe is dirty
ninja explain: pnacl/pnacl_public_x86_32_libcrt_platform_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_libgcc_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_libgcc_eh_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_libpnacl_irt_shim_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_pnacl_llc_nexe is dirty
ninja explain: pnacl/pnacl_public_x86_64_crtbegin_o is dirty
ninja explain: pnacl/pnacl_public_x86_64_ld_nexe is dirty
ninja explain: pnacl/pnacl_public_x86_64_libcrt_platform_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_libgcc_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_libgcc_eh_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_libpnacl_irt_shim_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_pnacl_llc_nexe is dirty
ninja explain: obj/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.actions_rules_copies.stamp is dirty
[2/2] STAMP obj\ppapi\native_client\src\untrusted\pnacl_support_extension\pnacl_support_extension.actions_rules_copies.stamp

BUG=439228

Review URL: https://codereview.chromium.org/873773002

Cr-Commit-Position: refs/heads/master@{#312891}

Now remoting_webapp_v2 doesn't use PNaCl. Also added new target
remoting_webapp_v2_pnacl that does use PNaCl.

BUG=451184

Review URL: https://codereview.chromium.org/865363002

Cr-Commit-Position: refs/heads/master@{#312890}

Revert of Roll Web Page Replay to pick-up HTTPS certificate fixes. (patchset #1 id:1 of https://codereview.chromium.org/855603002/)

Reason for revert:
This CL might cause the android perf bot redness
crbug.com/449889

Reverting it for now see if the perf bot recovers.

Original issue's description:
> Roll Web Page Replay to pick-up HTTPS certificate fixes.
>
> Includes fixes for:
>
> Generated certificates use different common name than original.
> https://github.com/chromium/web-page-replay/issues/37
>
> Replay uses wrong root CA during replay.
> https://github.com/chromium/web-page-replay/issues/38
>
> Android: Error installing cert from Mac host
> https://code.google.com/p/chromium/issues/detail?id=431686
>
> BUG=431686
>
> Committed: https://crrev.com/aa498cbeed50f119e76f08d2681b136325f191df
> Cr-Commit-Position: refs/heads/master@{#311829}

TBR=wuhu@google.com,tonyg@chromium.org,vmiura@chromium.org,sullivan@chromium.org,slamm@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=431686

Review URL: https://codereview.chromium.org/874483004

Cr-Commit-Position: refs/heads/master@{#312889}

Revert of Run task queue manager work in batches (patchset #9 id:160001 of https://codereview.chromium.org/845543004/)

Reason for revert:
Trying to see if this is the cause of MediaTest.Yuv* failures on Mac:

http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/2373
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/3274

Original issue's description:
> Run task queue manager work in batches
>
> This patch lets the task queue manager run more than one posted task
> per invocation. This helps reduce the overhead of yielding to and from
> the main message loop and can speed up cases where tasks are posted
> very frequently. One example is indexeddb, where some operations such as
> index building can result in 2500 posted tasks/s (Nexus 7).
>
> This patch also adds accounting for the desired run time of the next
> pending delayed task. This information is used to break out of a work
> batch if a delayed task should be run instead. Doing this avoids adding
> extra delay to delayed tasks.
>
> A potential downside of this change is that it can penalize work that
> runs on the message loop without going through the task queue manager.
> Based on performance tests[1], almost all tasks on the renderer main
> thread are already getting executed by the task queue manager, so I
> believe this change shouldn't cause a regression.
>
> [1] https://docs.google.com/a/chromium.org/spreadsheets/d/1IJZpBabW1pr4fb2T8BlkleHcOvHYrjvmCx_dLesxfMA/edit#gid=1492760051
>
> BUG=444764
>
> Committed: https://crrev.com/d9684457b5349dfc1cc19e8a2d98a69ba00ed058
> Cr-Commit-Position: refs/heads/master@{#312839}

TBR=rmcilroy@chromium.org,alexclarke@chromium.org,picksi@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444764

Review URL: https://codereview.chromium.org/867353002

Cr-Commit-Position: refs/heads/master@{#312888}

Old <incremental>-only number is preserved in CAST_BUILD_INCREMENTAL.

BUG=

Review URL: https://codereview.chromium.org/866843004

Cr-Commit-Position: refs/heads/master@{#312887}

- Makes components_browsertests swarmable.
- Adds components_browsertests to the main waterfall for linux, mac and
  win bots.
- Updates the chromium tryserver to run components_browsertests as
  swarmable.

BUG=311270

Review URL: https://codereview.chromium.org/863023003

Cr-Commit-Position: refs/heads/master@{#312886}

The entries were all found by the following command line:

$ g grep -nE '\bscoped_ptr<.*?>\(\)' ui/

BUG=None
TEST=app_list_unittests, aura_unittests, events_unittests,
message_center_unittests,views_unittests, ...
R=sky@chromium.org

Review URL: https://codereview.chromium.org/855023003

Cr-Commit-Position: refs/heads/master@{#312885}

R=sievers@chromium.org, vmiura@chromium.org
BUG=None
TEST=trybots

Review URL: https://codereview.chromium.org/866593002

Cr-Commit-Position: refs/heads/master@{#312884}

Other tweaks:
"Manage individual plug-ins..." for about:plugins link
"Always allowed to run" within about:plugins

BUG=403800

Review URL: https://codereview.chromium.org/852383002

Cr-Commit-Position: refs/heads/master@{#312883}

directly in the platform_backend

When the needs_browser_restart_after_each_page flag is set to true in the page
test, we initialize the browser_backend twice and call SetRndisForwarder()
twice. Instead, we can make this call for the platform once.

Additionally, I added a simple unittest for the case when this flag is set.

BUG=450331

Review URL: https://codereview.chromium.org/860913003

Cr-Commit-Position: refs/heads/master@{#312882}

Unhandled keyboard events should not use the guest as source. In the case of
the OOP PDF viewer, if devtools for the guest was open, unhandled keyboard
events would go there and would be applied to the guest by devtools instead
of to the embedder. The solution is to use the embedder WebContents as the source
for the unhandled keyboard event.

BUG=450929

Review URL: https://codereview.chromium.org/872843002

Cr-Commit-Position: refs/heads/master@{#312881}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2c097f3..f492958

TBR=kochi@chromium.org,pilgrim@chromium.org

Review URL: https://codereview.chromium.org/868143002

Cr-Commit-Position: refs/heads/master@{#312880}

Currently we trigger network connect failure notifications when a call
from ui::NetworkConnect::ConnectToNetwork() fails.

The problem with this approach is that connect calls from elsewhere
(e.g. through the networkingPrivate API) will not trigger notifications.

This CL makes NetworkStateNotifier a NetworkConnectionObserver and
triggers the failure notification on ConnectFailed events instead of the
NetworkConnect failure callback so that other failures will also
generate notifications.

This does not affect spawining of new UI (e.g. network configuration UI)
on failure (when appropriate) since that is expected to be handled by any
new UI that uses the networkingPrivate API.

BUG=434112

Review URL: https://codereview.chromium.org/762633002

Cr-Commit-Position: refs/heads/master@{#312879}

Jankiness of "422516 QuicStreamFactory::CreateSession57" is 35 jph.
Instrumenting further.

BUG=422516

Review URL: https://codereview.chromium.org/870053002

Cr-Commit-Position: refs/heads/master@{#312878}

This has been on everywhere for m39 and m40. People should not be
turning it off by this point, it will start to break soon.

BUG=169282

Review URL: https://codereview.chromium.org/830273003

Cr-Commit-Position: refs/heads/master@{#312877}

In particular, checkstyle shouldn't run on third-party code.

Review URL: https://codereview.chromium.org/866273002

Cr-Commit-Position: refs/heads/master@{#312876}

It hasn't worked from the beginning and it blocks ChannelMojo from
being enabled.

BUG=451221
R=jcivelli@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/866973004

Cr-Commit-Position: refs/heads/master@{#312875}

Previously VideoDecoderShim was assuming that the decoder calls output
callback only after decode is finished. That was a correct assumption
for VpxVideoDecoder, but not for FFmpegVideoDecoder. As result
PPB_VideoDecoder wasn't returning correct decode_id for decoded frames.
Now software decoders (i.e. VpxVideoDecoder and FFmpegVideoDecoder)
guarantee that they output all decoded frame before Decode() call
completes, which allows to return correct decode_id from
VideoDecoderShim.

BUG=448983
R=bbudge@chromium.org, xhwang@chromium.org

Review URL: https://codereview.chromium.org/805193006

Cr-Commit-Position: refs/heads/master@{#312874}

BUG=none

Review URL: https://codereview.chromium.org/847353003

Cr-Commit-Position: refs/heads/master@{#312873}

BUG=451107
R=kelvinp@chromium.org

Review URL: https://codereview.chromium.org/870823002

Cr-Commit-Position: refs/heads/master@{#312872}

This patch splits raster tile priority queue into two: required and all.
The required queue is used when the only tiles that we need are
required. When we need all of the tiles in priority order, we use the
all queue. The reason for the split is that the required tiles can
be much simpler to get.

R=reveman, danakj

Review URL: https://codereview.chromium.org/863013004

Cr-Commit-Position: refs/heads/master@{#312871}

BUG=

Review URL: https://codereview.chromium.org/870873002

Cr-Commit-Position: refs/heads/master@{#312870}

cast_shell creates aura::WindowTreeHost during main loop, and when running with
ozone-platform=egltest this causes a thread_restriction I/O FATAL.

BUG=448802

Review URL: https://codereview.chromium.org/853073003

Cr-Commit-Position: refs/heads/master@{#312869}

BUG=318948

Review URL: https://codereview.chromium.org/800183005

Cr-Commit-Position: refs/heads/master@{#312868}

Follow up for http://crrev.com/868853002.

BUG=430617
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/866983002

Cr-Commit-Position: refs/heads/master@{#312867}

A guest can now be explicitly resized (in addition to autosizing) from guest_view.js, using the new |setSize| function. This new function combines autosizing and normal resizing, as described in: https://docs.google.com/document/d/1EJfmJSK0JJsxKptSRhepnsOOwvXJNv5nnJ1pZdjGDRQ

BUG=434226

Review URL: https://codereview.chromium.org/857093003

Cr-Commit-Position: refs/heads/master@{#312866}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/918aba1..2c097f3

TBR=kochi@chromium.org,pilgrim@chromium.org

Review URL: https://codereview.chromium.org/872823002

Cr-Commit-Position: refs/heads/master@{#312865}

And allow callers of sendRequest to set a stack trace.

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/865083003

Cr-Commit-Position: refs/heads/master@{#312864}