- 01 Nov, 2018 40 commits
-
-
Alexandre Frechette authored
To increase visibility of the translate button on smaller screen device, we put it above the share button. See discussion in PRD: go/chrome-translate-manual-trigger. SCREENSHOT: https://screenshot.googleplex.com/NWuZVLCYSPn.png Bug: 883456 Change-Id: I7d334995e9cf7d15c312d23027c99ea52937d27e Reviewed-on: https://chromium-review.googlesource.com/c/1287093Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#604644}
-
Ryan Sturm authored
This adds tests to verify that opt outs are actually recorded and tracked appropriately for Previews. Bug: 900724,778793 Change-Id: Ib927645256eeeb7df08092eeb80f5652f295edbc Reviewed-on: https://chromium-review.googlesource.com/c/1311375 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#604643}
-
Luke Zielinski authored
The legacy SBER pref has been completely replaced by the Scout pref. This change removes the legacy SBER string and removes the checkbox from the unified and un-unified UIs. Bug: 662944 Change-Id: Icae674d21de1782dfaef5cc125a9bc79cbf4fa1a Reviewed-on: https://chromium-review.googlesource.com/c/1312624Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4ede5cbd079..f6fd71fba4d7 Created with: gclient setdep -r src-internal@f6fd71fba4d7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: Ieda6abbeb66e9c2beed6f216d0d3c7e74071f710 Reviewed-on: https://chromium-review.googlesource.com/c/1313008Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604641}
-
Becca Hughes authored
Debug information that is common across all media session types should be populated by media internals instead of the sessions themselves. This removes the need for duplicating logic across session types. Test: MediaInternalsAudioFocusTest BUG=875004 Change-Id: I0395e49423593d255973464658dbe41a3aa15b66 Reviewed-on: https://chromium-review.googlesource.com/c/1300103Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#604640}
-
Sergey Ulanov authored
FuchsiaVideoDecoder needs to be able to return frames with stride != width. Previously VideoFrameLayout::Wrap*() functions didn't allow to wrap such frames. This CL adds VideoFrame::WrapExternalDataWithLayout() which allows to pass frame layout explicitly. FuchsiaVideoDecoder uses the new function to create VideoFrame instances it returns. Bug: 876519 Change-Id: I2deaa15e5311dafd1c30a80a525530e2d70ee8e9 Reviewed-on: https://chromium-review.googlesource.com/c/1303965 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#604639}
-
Paul Meyer authored
This test is meant to crash the render process intentionally, and so should not be run on ASan bots. Bug: 900926 Change-Id: I0399dcbccf7974684837ab43c5f00892cce07b0b Reviewed-on: https://chromium-review.googlesource.com/c/1312979Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#604638}
-
Erik Luo authored
Clients will need to render a generic object/DOMNode, and be able to call `select()` to select the first child in the resulting TreeOutline. This CL: - Turns Common.Renderer > UI.Renderer - Returns a tree, so interested clients can use it Bug: 865674 Change-Id: Id877537a3c8713b99d34e6a4558037e0c8b3a111 Reviewed-on: https://chromium-review.googlesource.com/c/1298023Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#604637}
-
Peter Wen authored
Commands used: - `rm -rf third_party/android_deps/libs/[!O]*` - `tools/android/roll/android_deps/fetch_all.py --update-all` Added text license for GNU v2 with classpath exception since one dep was downloading a full html page for it. Bug: 900912 Change-Id: Ib3213d41259da0921e9d66cea2d08af2f29d383c Reviewed-on: https://chromium-review.googlesource.com/c/1312563Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604636}
-
Rayan Kanso authored
This was previously submitted as cl/1160848 This is the first step in supporting uploads for Background Fetch Bug: 774054 Change-Id: I325302b77313b38f211cb035522f80308cc83e14 Reviewed-on: https://chromium-review.googlesource.com/c/1297973 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604635}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a6b8b8078371..5d27da308ea5 git log a6b8b8078371..5d27da308ea5 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 fmayer@google.com Merge "profiling: Add proto for heapprofd." Created with: gclient setdep -r src/third_party/perfetto@5d27da308ea5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibf2e80a90dd73c5b913511b45666b0a1c7f9a6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1313028Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604634}
-
Jordan Demeulenaere authored
Change-Id: I6eedb76b32a2ea78b7779daab37785bff0e00174 Reviewed-on: https://chromium-review.googlesource.com/c/1312478Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#604633}
-
David Quiroz Marin authored
Deprecate histogram and remove all references. Bug: 894043 Change-Id: I101f75fc0882a7844a58507a194eb1a5efde207e Reviewed-on: https://chromium-review.googlesource.com/c/1308755 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604632}
-
James Hawkins authored
The get*Enabled method is no longer called in release. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I91261c61ae5f666cf45c14e6c71512f3a7c70a42 Reviewed-on: https://chromium-review.googlesource.com/c/1312094Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#604631}
-
Andrew Comminos authored
If a BaseAudioContext is uninitialized, its render thread will no longer clear associated orphaned render nodes (as it is stopped). Instead of checking whether or not the context has reported itself as being closed (which is independent of the initialization state), simply check the initialization state itself. R=hongchan@chromium.org Bug: 858834 Change-Id: I5b088d17122b0c86270ff8ca75b13ab1487a2131 Reviewed-on: https://chromium-review.googlesource.com/c/1284697 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604630}
-
Ned Nguyen authored
These days, perf bots are managed by swarming service. If needed, it's better to address keychain issues with swarming infra instead. Removing the keychain metrics help clean the code of speedometer benchmark. Bug: 714231 Change-Id: I3d18bc8da20f904cb254d3d1b2b016a4de05b203 Reviewed-on: https://chromium-review.googlesource.com/c/1312968Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#604629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ccf17e9..17a4d822 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9470694b01f764e707a7f40d3f5986d870810379 Reviewed-on: https://chromium-review.googlesource.com/c/1312932Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604628}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2256c2786cc8..ab688385cfbd git log 2256c2786cc8..ab688385cfbd --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Roll third_party/skia/ b547579d0..ffbcc3fad (556 commits; 56 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 53956d9bf..b547579d0 (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 449624811..53956d9bf (842 commits; 71 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 9d080a1d5..449624811 (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 0917fad2c..9d080a1d5 (87 commits; 5 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 386d9cf40..0917fad2c (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 91e260f4d..386d9cf40 (7 commits) Created with: gclient setdep -r src/third_party/pdfium@ab688385cfbd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I82b88b8c7ffea8aafc1c617f662623d30b362429 Reviewed-on: https://chromium-review.googlesource.com/c/1313010Reviewed-by:
-
Mustaq Ahmed authored
Change-Id: I4b30c9adb106e85e2e713af0d931f900123885be Bug: 900198 Reviewed-on: https://chromium-review.googlesource.com/c/1307845Reviewed-by:
-
James Hawkins authored
This method did nothing given that no event listener was registered for the auth attempt listener in the WebUI. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I4f46d553ee95538a468b05a434f609ab60c7ca52 Reviewed-on: https://chromium-review.googlesource.com/c/1312300Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Kevin Bailey authored
In a RTL UI, we'd like the arrow keys to behave intuitively which means they must be reversed from in LTR mode. Also, it makes a slight behavior change: To handle the case of not being able to unfocus the button if the cursor is moved away from the end, we now unfocus the button as soon as the Omnibox is clicked (which makes sense in terms of moving the "focus".) Bug: 894788 Change-Id: I3323a5b2575bdbaad45853799044f21efa65ac63 Reviewed-on: https://chromium-review.googlesource.com/c/1280847 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#604624}
-
Tom McKee authored
Rename step_queueing_times_ to sliding_window_ to better clarity. Bug: 883487 Change-Id: I778db437b734a8e498efb69eb3aeff20aeb7cc47 Reviewed-on: https://chromium-review.googlesource.com/c/1299548 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604623}
-
Hazem Ashmawy authored
Add Finch Experiments info aka variations crash keys to Webview minidump. The keys are "variations" and "num-experiments". Bug: 758450 Change-Id: Ib3bc7b872c0ff88eb404595496a9084f1d123ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1305953 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#604622}
-
mark a. foltz authored
This patch removes the Presentation API from insecure contexts. The number of presentations started on insecure contexts is 0.0001% of page views on desktop and 0.0004 on Android. In addition it updates layout tests and WPT to use https: for presentation URLs. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion chromestatus.com feature entry: https://www.chromestatus.com/feature/5766218384408576 Bug: 733381 Change-Id: I9ae3025160b0e0bcf987fda0068a0e6bd92c24fd Reviewed-on: https://chromium-review.googlesource.com/c/1306336Reviewed-by:
-
Mikhail Lopatkin authored
Prior to this CL removal of grit output file in BUILD.gn wasn't triggering a re-run of grit if all other files are up-to-date. This may cause a suprising output list verification failure later, during clean build. R=agrieve@chromium.org Change-Id: I881992c174d5d3a2433759e2622929c4e84b3845 Reviewed-on: https://chromium-review.googlesource.com/c/1310274Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#604620}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be837ac3bc79..fe45da4f047e git log be837ac3bc79..fe45da4f047e --date=short --no-merges --format='%ad %ae %s' 2018-11-01 philipel@webrtc.org Remove WebRTC-VP8-GfBoost field trial. 2018-11-01 srte@webrtc.org Makes send time information in feedback non-optional. Created with: gclient setdep -r src/third_party/webrtc@fe45da4f047e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2c942fdd256766b3f2d64dba8f980b275dd78626 Reviewed-on: https://chromium-review.googlesource.com/c/1312340Reviewed-by:
-
David Bienvenu authored
This is a reland of 03b56190 Original change's description: > Native window occlusion tracking for windows. > > This implements native window occlusion tracking on windows, under flag/experiment control. It uses WinEvent event hooks and EnumWindows to track and calculate occlusion. > > It is not yet hooked up to the code that treats occluded windows differently. > > Bug: 813093 > Change-Id: Ic9b473b8cad38e7b1653566f28917164bc92e21c > Reviewed-on: https://chromium-review.googlesource.com/c/1140752 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603619} Bug: 813093 Change-Id: I78fa7b04a7efc0c392100b852e1a1a5f04421132 Reviewed-on: https://chromium-review.googlesource.com/c/1308264 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4dda60c7111..fa7df23d8b0c git log e4dda60c7111..fa7df23d8b0c --date=short --no-merges --format='%ad %ae %s' 2018-11-01 mtklein@chromium.org more SkBlitter::Choose refactoring 2018-11-01 brianosman@google.com Remove unused GrCubicEffect 2018-11-01 herb@google.com Revert "Move from a functional to object based interface between Painter and SkDraw" 2018-11-01 caryclark@skia.org refactor bookmaker 2018-11-01 caryclark@skia.org simplify default bookmaker command line Created with: gclient setdep -r src/third_party/skia@fa7df23d8b0c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I1a97bf90b7224b87335d02b2cd90c48f0668fb82 Reviewed-on: https://chromium-review.googlesource.com/c/1312337Reviewed-by:
-
Theresa authored
Use a hairline border for Zine cards and sign in promo cards. In this v1, the Zine thumbnails sit on top of the hairline border. A future update will move the thumbnails inside the hairline border. BUG=872080 Change-Id: Ie416d2107c0e8b4e6d7a058f7026a5d2765664e8 Reviewed-on: https://chromium-review.googlesource.com/c/1311804 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604616}
-
Eric Aleshire authored
This was configured in my scheme when testing locally, so I forgot it even existed. Found when doing a full repro of the bot testing flow while trying to debug unrelated issues with ios-wpr-simulator. This line is very long as both of these flags should be part of "-c" so that iossim passes it properly. Is that fine? Bug: 892381 Change-Id: I5d7def3f138d10033914718429307b76a8d71d8a Reviewed-on: https://chromium-review.googlesource.com/c/1311809 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604615}
-
Ted Choc authored
BUG=898522 Change-Id: Id9ef47429b19582982480ff0dcd5af78ab21b99e Reviewed-on: https://chromium-review.googlesource.com/c/1311496 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#604614}
-
mrefaat authored
- Create TabUtil file that will contain methods that give tab information from a given webState but are not considered a tab state property. - Delete -title from tab.h/mm and create GetTabTitle function in TabUtil - Create Unit tests for GetTabTitle / Add SetTitle to TestWebState Bug: 898655, 898652 Change-Id: I9e30eb163d45f008e3a755cba7121526c41d5eee Reviewed-on: https://chromium-review.googlesource.com/c/1306782Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#604613}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/61791eae36b8..2960ec33667a $ git log 61791eae3..2960ec336 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 cwallez Add support for all of Chromium's CPU architectures. 2018-11-01 senorblanco D3D12 fix for register binding offsets. Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org BUG=870747 Change-Id: I6942e2e387f367be3aee7f707152375e6d6c0254 Reviewed-on: https://chromium-review.googlesource.com/c/1311932Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#604612}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5cb84f85868b..a6b8b8078371 git log 5cb84f85868b..a6b8b8078371 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 primiano@google.com Merge "Minor ui improvements" 2018-11-01 primiano@google.com Minor fixes to SQL controller and UI overview timeline Created with: gclient setdep -r src/third_party/perfetto@a6b8b8078371 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibbac7a5b813ef0d9b4faab5520b4beadd854b2b2 Reviewed-on: https://chromium-review.googlesource.com/c/1312334Reviewed-by:
-
manuk hovanesian authored
Revert "[Omnibox] Use GURL::possibly_invalid_spec instead of GURL::spec when sorting and deduping matches." This reverts commit 61d1146d. Reason for revert: per review comments, there may be a larger underlying reason as to why we we're generating invalid GURL's that should be addressed. Original change's description: > [Omnibox] Use GURL::possibly_invalid_spec instead of GURL::spec when sorting and deduping matches. > > Certain omnibox inputs, such as `http:www.` produce matches with invalid urls. Invoking GURL::spec on these invalid GURL's caused a DCHECK to evaluate false and crash the browser. The crash only affects debug builds as the DCHECK is inactive for non-debug builds. > > Bug: 898554 > Change-Id: I89a27f902b77bf6b221c321ab396787e9249a4e6 > Reviewed-on: https://chromium-review.googlesource.com/c/1308260 > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604012} TBR=krb@chromium.org,tommycli@chromium.org,manukh@chromium.org Change-Id: I3e2dddb8dd218bce805dc93d842f83b7366cf1bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898554 Reviewed-on: https://chromium-review.googlesource.com/c/1308603Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604610}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f2f7c2a92321..2256c2786cc8 git log f2f7c2a92321..2256c2786cc8 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Roll third_party/skia/ c994a93b3..91e260f4d (1 commit) Created with: gclient setdep -r src/third_party/pdfium@2256c2786cc8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I91ba830c004978c463dc26627d71fd4c54510af9 Reviewed-on: https://chromium-review.googlesource.com/c/1312335Reviewed-by:
-
Weidong Guo authored
Enable auto-hide shelf. Drag from bottom bezel to show home launcher and, meanwhile, use second finger to drag on home launcher, the launcher freezes. It happens because shelf is hidden when dragging with second finger which prevents the drag end event reaching home gesture handler. Changes: 1. Remove shelf visibility check for drag end event. 2. Avoid processing drag event when animation is running. Bug: 899554 Change-Id: I18262f813ab4acaab9266b7fba1c7790275d8fbc Reviewed-on: https://chromium-review.googlesource.com/c/1311840Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604608}
-
Anders Hartvoll Ruud authored
Due to how initial values of registered custom properties used to be handled, the style diff function for custom paint could not discover that the computed value for some property changed due to a new property registration. This meant that, if you used the property '--x' in your paint worklet (without applying '--x' on any element in the document), and _then_ registered the property '--x' (giving it an initial value), the worklet would not repaint even though the computed value of --x changed from "nothing" to the registered initial value. Now that initial values are returned from ::GetRegisteredVariable, simply compare those values when diffing for custom paint invalidation. Note that the second test in this CL is already passing before this CL, but I'm including it anyway since that case is also mentioned in the bug. R=ikilpatrick@chromium.org Bug: 657706 Change-Id: I2b7707d48d73693a70b100fe1121bd7f977b4db1 Reviewed-on: https://chromium-review.googlesource.com/c/1309788 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604607}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83a7a95315fa..f4ede5cbd079 Created with: gclient setdep -r src-internal@f4ede5cbd079 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3cc2e7330281c1321ddafbd8914c99aad4495e9c Reviewed-on: https://chromium-review.googlesource.com/c/1312339Reviewed-by:
-
Dmitry Gozman authored
We don't actually need these - we can use model observers instead. Bug: 882467 Change-Id: If847fcf4f2968430821de316e3b346a25a2a3592 Reviewed-on: https://chromium-review.googlesource.com/c/1311916 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
