- 22 Sep, 2020 40 commits
-
-
Johan Bay authored
This command takes a DOM node and a name and/or role to search for. It searches the accessibility subtree of the given node for the name and role. The command also includes ignored nodes in its result. The command is the underlying primitive for a new aria-based querying mechanism in Puppeteer. This CL is a follow-up to crrev.com/c/2366896. The feedback given there has been addressed in this CL. Doc: https://docs.google.com/document/d/1-BUEUgqAZlh26fv9oLfy1QRr0MF3ifnxGh7-NDucg9s/ Change-Id: Ibdcdb230b5d1287ab009f2dd9d25a53932072d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398547 Commit-Queue: Johan Bay <jobay@google.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#809251}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80297a032922..4d0f8b8c9cc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rsorokin@google.com Change-Id: Ia57a05337c199438b2a9e6e08c29cd7b310a6f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423523Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809250}
-
Alice Wang authored
This CL adds three more metrics for the web sign-in flow. Bug: 1120334 Change-Id: Ie28d1046289b7221f3075e2b7cecf0b57252539d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418380 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809249}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ee96f113769..82f83e6cda76 2020-09-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd0d8648992763112a210f8e5db68dfa3f958876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423524Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809248}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600732621-efcb2b5a6f18794514e083516aa5205975064ad2.profdata to chrome-mac-master-1600754349-f2bf1ecbd6b189476a5e50362abd5d7f8ec183c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia9461fa9bf9c1462ad7962c7b2b314e97008881f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423526Reviewed-by:
-
Wei Lee authored
We should show a message to users to let them know we have changed the default camera folder from "MyFiles/Downloads" to "MyFiles/Camera". Bug: 1127587 Test: Launch CCA and the dialog show up Change-Id: I2dc78e839dfb4bc54a42da2627eb89d491689016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407734 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#809246}
-
Dana Fried authored
This changes long-standing problems with FlexLayout that were not problems with BoxLayout. Specifically: - Flex weights now dictate deviation from a view's preferred size (which may now be zero), so that when a view with a FlexLayout shrinks, its flex children shrink proportionately, just as they grow proportionately when the host view enlarges. - When a child view hits its minimum size or drops out, remaining space is correctly allocated across other child views, even at the same flex priority. This solves a number of weird corner cases and rounding issues at the result of a bit more complexity. However, the code is more heavily documented and broken into steps so the net effect is that it should be relatively maintainable. Bug: 1012134, 1012113 Change-Id: Idc3059d572b3d165866b44c077c38d483d862596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100026 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#809245}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1d6daec3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: If505c3a247f5ac630c18da834a7a4e3732978d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422864Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809244}
-
Soumadeep Mazumdar authored
Issue: Pen/Touch selection handles persist even on refresh. On refresh, the active client is invalidated before handles are dismissed. Selection handles in PDF created in touch selection controller currently had no way of being destroyed on a tab refresh before the actual parent was destroyed. This is not the case in HTML where there is an explicit call made to HideAndDisalllowShowingAutomatically to remove the handles from aura observer depending on window focus lost. Fix: Added call to Hide and not show handles automatically on destruction. Following similarly from HTML, this call is made from PDFWebContentsHelper destructor which takes care of removing the selection handles before destroying the controller. Since this is tied to the client, it does not remove existing handles in other active clients. Bug: 1110815 Change-Id: I9818f06ac8fe7fac3223472a58088544f2bc462a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359652 Commit-Queue: Soumadeep Mazumdar <somazu@microsoft.com> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809243}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I2e2ab47f24ea29929a38a1d4ca406d15f2845ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414279Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#809242}
-
Daniel Libby authored
This will give us more insight into how frequently this happens as well as give us more accurate sites via HTTP Archive. The current data just shows when zoom not equal to one is parsed. R=ikilpatrick@chromium.org Bug: 1067747 Change-Id: Idfcc600b802e35955dc85705b7248b29f89863fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422355Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809241}
-
Olivier Yiptong authored
This cleans up the per-platform build configuration preprocessor directives. With this change, the platform build configurations are consolidated in one place. Bug: 1043306 Change-Id: Id9e2da3bf156e245b510ce7b32346df285fd6f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422811 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809240}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4a6338f2de7331e19b8dab18403bcb70e29eb22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423261Reviewed-by:
-
Dan Elphick authored
Move RAILMode from Info to Default so it's not disabled by default. Change-Id: Ib302aa70bb4f87e579d8c925eebfc43744f8bd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397719 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#809238}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600711078-15e6465f6b9c8d99add6c7e09aa1cb16b33babfa.profdata to chrome-linux-master-1600754349-bb0b36845adda8f601cf43d9095b0eb5c5334e61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I7cbff8884062ad5363f8d76b075956a050a2bc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423525Reviewed-by:
-
Julie Jeongeun Kim authored
This CL checks the case that |document_page_count| is bigger than |kMaxPageCount| at PrintJobWorker::GetSettingsWithUI() to fix the fuzzer issue from the ipc_fuzzer_replay and the ipcdump. On the normal flow, the renderer doesn't call GetPrintSettingsFromUser() if |expected_page_count| is bigger than |kMaxPageCount| at PrintRenderFrameHelper::Print(). Bug: 1130456 Change-Id: Ic1c91399eba2c794240744320b8d8a3ce5eaeb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421849 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
sandromaggi authored
This adds a new helper structure to support executing chains of callbacks from the |ActionDelegate|. With this, the |OnXForY| functions can be eliminated and the execution streamlined. This does not support callbacks with return values (like |GetElementTag|). This CL also changes the signature of |ActionDelegate| methods to stick to [arg1, .., argN, ElementFinder::Result, base::OnceCallback] to get rid of "argument shuffling helpers". Bug: b/168107066 Change-Id: If79fe0683b347ddfc8c8555739f79ca827e02217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410073 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809235}
-
Benoit Lize authored
Each PartitionRoot has a precomputed ~size -> Bucket* lookup table (where ~size is the order and sub-order of the allocation request). However since the sentinel bucket is now per-PartitionRoot, the pointers are all offsets from PartitionRoot::buckets. In addition, in some paths we only need the offset, not the pointer. To avoid duplication and wasted effort, make the mapping a static member of PartitionRoot. The size of this mapping is not trivial, since it is (kBitsPerSizeT + 1) * kNumBucketsPerOrder * sizeof(void*), that is 65 * 8 * 8 = 4160 on 64 bit architectures. Since we have several roots (2 + 4 for PartitionAlloc-Everywhere builds in renderers) and the mapping is on the critical path for allocations, reducing its size may be good for performance. It is now 65 * 8 * 2 = 1040 globally. Bug: 998048 Change-Id: Iaef1f62c599e196540f0c0544a856fa67f9fdf3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421513Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#809234}
-
Josh Simmons authored
Extending this flag until M90 to give us time to clean up the old smbprovider code and fully remove flag references. Bug: 1130910 Change-Id: Id2b0c883bc8334619a8fc36592c473614271ad8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423444Reviewed-by:
Anand K Mistry <amistry@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#809233}
-
Omar Morsi authored
Bug: 1130594 Change-Id: I815675d485a40f7131e48908cd1f25d8f20c74d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421459Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#809232}
-
Shakti Sahu authored
This CL adds a network fetcher for fetching the video tutorial metadata. Bug: 1130417 Change-Id: I272a7a040e83c48e542ddd7241b4129713696ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421094Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809231}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a49a5334c36..7a1f241c0134 2020-09-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 688a0b34 to 1d6daec3 (400 revisions) 2020-09-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 48588bd1810d to f39e0f01aa1f (25 revisions) 2020-09-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fe878dedd5ad to 6aadd31a5f98 (1 revision) 2020-09-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from dcd37fa4f476 to 52a588f3c9ba (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1032721 Tbr: csmartdalton@google.com Test: Test: Test: DrawCallPerfBenchmark.Run/vulkan_attrib_changeTest: Test: tested with trigger.py Change-Id: Iddfbfa046dd9c86cbc1e3ee1a488b85f6c5baf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423256Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/242419022dde..0ee96f113769 2020-09-22 changhaohan@chromium.org Clean up legacy set-like objects in Runtime.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I736fd60fad608b9b4d448ffddcb2a9f2e1c8096d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423255Reviewed-by:
-
Meredith Lane authored
Tests have been failing flakily but often, starting from: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/2384 TBR=beccahughes@chromium.org Bug: 1124983 Change-Id: I68ed910d8072b5d0298e8e6a84e8b1c60dcc5dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421851Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#809228}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/092f3bde17d7..80297a032922 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: meredithl@google.com Change-Id: I22609ec5fe86aaf433b003ce5d27fb0aaf4d9a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423253Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Remove native dependency of ReturnToChromeExperimentsUtil.shouldShowStartSurfaceAsTheHomePage() and PseudoTab.readAllPseudoTabsFromStateFile() so that they can be called without leading to native initialization. Benchmarking results using http://crrev.com/c/2373287: 100 samples on Nexus 5X Median Diff with control p-value FirstDrawCompletedTime 414.0ms -29.0ms (-7.00%) 0.000000 SingleTabTitleAvailableTime 287.0ms -31.5ms (-10.98%) 0.000000 FeedStreamCreatedTime 836.5ms -39.5ms (-4.72%) 0.000030 FeedContentFirstLoadedTime 1898.5ms -0.5ms (-0.03%) 0.534189 FeedsLoadingPlaceholderShown 234.0ms -2.0ms (-0.85%) 0.629761 100 samples on Pixel 2 XL Median Diff with control p-value FirstDrawCompletedTime 176.0ms -18.0ms (-10.23%) 0.000000 SingleTabTitleAvailableTime 131.0ms -14.0ms (-10.69%) 0.000000 FeedStreamCreatedTime 424.0ms -31.0ms (-7.31%) 0.000180 FeedContentFirstLoadedTime 1137.0ms -18.5ms (-1.63%) 0.075061 FeedsLoadingPlaceholderShown 107.0ms -1.0ms (-0.93%) 0.718766 100 samples on Pixel 3 XL Median Diff with control p-value FirstDrawCompletedTime 155.0ms -13.5ms (-8.71%) 0.000000 SingleTabTitleAvailableTime 117.0ms -13.0ms (-11.11%) 0.000000 FeedStreamCreatedTime 356.0ms -35.5ms (-9.97%) 0.000001 FeedsLoadingPlaceholderShown 94.5ms -2.0ms (-2.12%) 0.007312 FeedContentFirstLoadedTime 924.0ms -6.5ms (-0.70%) 0.034100 Bug: 1041865 Change-Id: I640aaeb6f2dae64b9152fd94d0cd354a487f5bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372900Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809226}
-
Melissa Zhang authored
This CL adds a condition that hides the "More Apps" section when there are more than 1 but less than 8 targets. Bug: 1130406 Change-Id: Id94069d3e6b3c13d313c52fe8516085da493e2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420172 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809225}
-
dpapad authored
Enums can be declared as standalone constants within their containing JS module. Previously they were augmented as static variables on some other class, which is unnecessary and makes the code more verbose. Specifically cleaned up: - BrowserApi.ZoomBehavior - PdfNavigator.WindowOpenDisposition - PDFMetrics.UserAction - Viewport.PinchPhase Bug: None Change-Id: I63227460ec44a5472bfc9d2b6b16f889e912e38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421609 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809224}
-
Dominic Mazzoni authored
Previously ChromeVox handled in-page links if you force-click on them. This change makes it so that it also handles it if the user presses Enter or mouse-clicks on a link, by responding to the scrolledToAnchor event. Testing this required enabling the test server because the browser doesn't follow same-page links in data urls. Some of the work to make use of the test server in ChromeVox tests was already done for portals, but I had to fix a tiny bug in js2gtest. how they're activated. Bug: 1130786 AX-Relnotes: ChromeVox now properly handles in-page links no matter Change-Id: I9e56f6c88fdbce35c14e692411cb7bb4a2e46db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422704 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809223}
-
George Burgess IV authored
this statement does nothing; remove it. Bug: 1130379 Change-Id: I3eb01bfdef76b9613a17893a9651970eff736ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420915 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#809222}
-
Wei Lee authored
As mentioned in go/cros-camera:dd:cca-default-saved-folder, we should display i18n name for camera folder and also makes it nonmodifiable. Bug: 1127587 Test: Manually tested with chained CLs. Files app works as expectation. Change-Id: Id4157bd02c130676a9c01949e37838e36a95b303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409743 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#809221}
-
Bo Majewski authored
Part 1 of n: Addresses comments that do not require rewriting any code: - using png_data->bytes without casting - renaming variable kMaxPdfSize => kMaxPdfSizeInBytes - using std::move on base::FilePath path - matching header and .cc parameter names - checking if a valid shared memory region was allocated. Bug: 1129607 Change-Id: Ib339b2b05b0e89003e21dff4ceac1a0647f74be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423065 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#809220}
-
Ilya Nikolaevskiy authored
Bug: webrtc:11956 Change-Id: Icf421840203e826a87b0db8fb69365160a6c0c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418671 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#809219}
-
Yury Khmel authored
Main motivation of this CL was to restore access to ArcAuth.CheckinTime and ArcAuth.SigninTime. crrev.com/c/2412780 introduced suffix separation however this indirectly made access to legacy data unavailable. Initial attempt was adding empty suffix that would probably restore access to legacy data in UMA dashboard. However it possible to refactor names to align it with common ARC metrics naming. For example we frequently use TimeDelta so ArcAuth.SigninTime.unmanaged would be renamed to Arc.Auth.Signin.TimeDelta.unmanaged. This also explicitly removes intermediate names introduced CL above. That CL was landed few days ago and we don't have data that would be consumed by anybody. BUG=b:155123746 TEST=To verify in UMA dashboard. tast.arc.Optin and confirms new metrics are in chrome://histograms. Change-Id: Ic29ea01b8fb82ca538bb6444d5ee35581288a0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418849Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#809218}
-
Will Cassella authored
Bug: 1128657 Change-Id: I9548e1f3bfe5693871a56e23c3373f45147e52e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422091Reviewed-by:
-
Melissa Zhang authored
Adds expansion from default view to expanded view with apps list. This CL also moves Sharesheet UI classes into their own folder. Bug:1130406 Change-Id: I17824948bdb20a5e3cfa6b7ac93b0216ee43cf61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409480 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#809216}
-
Ian Kilpatrick authored
Per: crbug.com/1119873 It was possible to mutate the work queue while iterating over it. Using this it was possible to trigger a UAF. This patch converts CustomLayoutWorkTask to oilpan (not strictly required as a copy of the CustomLayoutWorkTask would have also sufficed), and now copies the Member<CustomLayoutWorkTask> before using it. Bug: 1119873 Change-Id: I3c66859af8c9a0f33fe8c7df7c30efd2913c2985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380135Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#809215}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/44dff4f2012d..1a49a5334c36 2020-09-21 johnstiles@google.com Restructure blend functions to allow for smarter inlining. 2020-09-21 johnstiles@google.com Rename 'DefaultSettings' golden outputs to 'StandaloneSettings'. 2020-09-21 jvanverth@google.com Revert "Reland "Use Microsoft's ComPtr to wrap D3D12 objects."" 2020-09-21 johnstiles@google.com Create golden outputs for SkSL blend functions. 2020-09-21 johnstiles@google.com Add convenience methods to CFG builder. 2020-09-21 egdaniel@google.com Allow client to pass in VK_IMAGE_LAYOUT_UNDEFINED into mutable state change requests. 2020-09-21 egdaniel@google.com Make GrStencilAttachment derive from GrSurface. 2020-09-21 johnstiles@google.com Remove needless do-while(false) block from inlined blend methods. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I94683c5bcdc3c981c7337329d9b69e30437eb05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422828 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Wei Lee authored
This CL replaces pwa.html and manifest.json by CameraSystemWebAppInfo to reduce the flakiness and slowness of SWA installation. Bug: 980846, 1085274 Test: Launch CCA (SWA) successfully Change-Id: I72d350077d8e8a7328572e27a16a97e4863516a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422927Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c946ee14364..242419022dde 2020-09-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I59d4a0406ee749df6fdc650a25db5f2bd4214117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423245Reviewed-by:
-
